Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1515/ --- Review request for Plasma. Summary --- Hi! With commit #1019443 to kdebase

Re: Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

at handler. Just, that won't help for the webpage and email cases. - Friedrich W. H. On 2009-09-03 18:23:03, Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:/

Re: Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

.g. Amarok? No idea now. - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1515/#review2242 --- On 2009-09-03 18:2

Re: Tokamak4 Attendance, LAST CALL

Hi, Mardi, le 5 janvier 2010, à 14:02, John Layt a écrit: > On Tuesday 05 January 2010 11:26:27 Sebastian Kügler wrote: > > Please everybody who's planning to attend Tokamak4, to be held from 19th > > - 26th February at the openSuse premises in Nuremberg, Germany, do the > > following: Finally u

Bookmarks plasmoid moved to kdereview

Hi all, I've just moved the Bookmarks plasmoid* from playground to kdereview. It's a simple one-button plasmoid which on a click (or activation) shows the standard bookmarks menu and calls KRun for the selected bookmark. It can be configured to just show a subtree of the whole bookmarks tree, a

Re: Bookmarks plasmoid moved to kdereview

Hi Chani, Mardi, le 12 janvier 2010, à 04:03, Chani a écrit: > On January 11, 2010 18:21:11 Aaron J. Seigo wrote: > > On January 11, 2010, Friedrich W. H. Kossebau wrote: > > > I've just moved the Bookmarks plasmoid* from playground to kdereview. > > > > cool; i

Re: Bookmarks plasmoid moved to kdereview

Hi Aaron, Mardi, le 12 janvier 2010, à 03:21, Aaron J. Seigo a écrit: > On January 11, 2010, Friedrich W. H. Kossebau wrote: > > I've just moved the Bookmarks plasmoid* from playground to kdereview. > > cool; i may not have much time between now and 4.4.0 to look at it, bu

Re: Bookmarks plasmoid moved to kdereview

Hi, Mardi, le 12 janvier 2010, à 02:14, Friedrich W. H. Kossebau a écrit: > Hi all, > > I've just moved the Bookmarks plasmoid* from playground to kdereview. > > It's a simple one-button plasmoid which on a click (or activation) shows > the standard bookmarks

Re: Bookmarks plasmoid moved to kdereview

Mardi, le 26 janvier 2010, à 00:00, Aaron J. Seigo a écrit: > On January 24, 2010, Friedrich W. H. Kossebau wrote: > > Upcoming Tuesday two weeks have passed since the move into kdereview. > > Thanks to Albert, Burkhard and Laurent some i18n problems have been > > fixed. Did

Re: Bookmarks plasmoid moved to kdereview

Mercredi, le 27 janvier 2010, à 19:23, Aaron J. Seigo a écrit: > On January 27, 2010, Friedrich W. H. Kossebau wrote: > > Mardi, le 26 janvier 2010, à 00:00, Aaron J. Seigo a écrit: > > > On January 24, 2010, Friedrich W. H. Kossebau wrote: > > > > Upcoming Tuesday t

Re: Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1515/ --- (Updated 2010-01-29 16:23:40.126653) Review request for Plasma. Changes --

Restoring weather applet in kdeplasma-addons

Hi, I am missing the weather applet in my Plasma5 workspace. I found the sources in kdeplasma-addons/applets/weather, but it seems not yet ported and is disabled from the build. So I would see to port it over now myself. A few questions I have: Q1: Is anyone already looking into it? Any gener

Re: Restoring weather applet in kdeplasma-addons

Hi Martin, Am Freitag, 5. Februar 2016, 17:05:43 CET schrieb Marco Martin: > On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I am missing the weather applet in my Plasma5 workspace. I found the > > sources in kdeplasma-addons/applet

Re: Restoring weather applet in kdeplasma-addons

Am Freitag, 5. Februar 2016, 19:15:29 CET schrieb Marco Martin: > On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote: > > I see. And found it now, plasma-workspace/dataengines/weather. Seems it > > was started in 2014, but then lost focus of developers. Some "

Re: Restoring weather applet in kdeplasma-addons

Am Montag, 8. Februar 2016, 10:41:00 CET schrieb Marco Martin: > On Monday 08 February 2016, Friedrich W. H. Kossebau wrote: > > No config support yet, are QWidget-based config dialogs that even still > > supported API-wise? > > eh, unfortunately no,because mixing qwidget

Re: Restoring weather applet in kdeplasma-addons

rieb Marco Martin: > On Tuesday 09 February 2016 01:07:14 Friedrich W. H. Kossebau wrote: > > the > > > > > config key > > > > You meant "main.xml" here where you wrote "config.xml", right? > > (would match files I found elsewhere in the

Review Request 127193: Revival of Weather applet (for Plasma 5.6)

d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

plasmaweather/weatherpopupapplet.h ce95a5a libs/plasmaweather/weatherpopupapplet.cpp 4533619 libs/plasmaweather/weathervalidator.h eb33558 libs/plasmaweather/weathervalidator.cpp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kosseb

Theming issues noted while porting Weather applet

Hi, happy to have the weather applet almost revived and good enough to have your eyes on it (hopefully in time for 5.6), see parallel emails for https:// git.reviewboard.kde.org/r/127193/ Some issues I noticed which seem unrelated to the weather applet code, are these known or should be filed a

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

property fetch currently, so even a lambda will not help :) In general that might be a useful API addition, but here, for the Weather applet, not needed, so cannot back the addition with a usecase (yet). - Friedrich W. H. --- This is an auto

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

d should be revisited by UI experts. As said, for now concentrated on porting the existing applet and would like to postpone this to after the applet is ported as it is. Okay to drop this for this review? > On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > applets/weather/pack

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

libs/plasmaweather/weathervalidator.cpp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

text barely fits in > > there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and test

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

pp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Theming issues noted while porting Weather applet

Hi, Am Samstag, 27. Februar 2016, 18:13:28 CET schrieb Marco Martin: > On Saturday 27 February 2016, Friedrich W. H. Kossebau wrote: > > * PlasmaCore.FrameSvgItem seems to not update to changes of the Plasma > > color theme, stays with theme current on start > > that should

Re: Theming issues noted while porting Weather applet

Am Montag, 29. Februar 2016, 13:17:42 CET schrieb Kai Uwe Broulik: > ‎> If there one switches between dark and breeze meta themes, then for some > reason the updates of the FrameSvgItem items only happen delayed on the > next > > Yeah I've also seen the look and feel package kcm doesn't properly a

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

text barely fits in > > there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and test

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

iting on search. - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review92916 --- On Feb. 29, 2016, 2:23 a

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

text barely fits in > > there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and test

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

/weathervalidator.cpp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

e give this applet another test and consider getting it in for 5.6, I surely am not the only one missing it a lot :) - Friedrich W. H. Kossebau On March 1, 2016, 12:43 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an aut

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review93003 --- On March 1, 2016, 3:18 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an autom

Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

dataengines/weather/ions/envcan/CMakeLists.txt a3daa55 dataengines/weather/ions/envcan/ion_envcan.h 19407d6 dataengines/weather/ions/envcan/ion_envcan.cpp 56efc7a Diff: https://git.reviewboard.kde.org/r/127248/diff/ Testing --- Thanks, Friedrich W

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

visit: https://git.reviewboard.kde.org/r/127248/#review93038 ----------- On March 1, 2016, 8:10 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generate

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

iewboard.kde.org/r/127248/#review93038 --- On March 1, 2016, 8:10 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

.org/r/127248/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127252: Port all ion plugins away from KDELibs4Support

https://git.reviewboard.kde.org/r/127252/diff/ Testing --- Tested both noaa & wettercom station, still showed correct day numbers for me. Could not test with non-arabic number presentation locale (only assume it should work) Thanks, Friedrich W. H.

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

- On March 2, 2016, 12:54 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127252/ >

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

marked as submitted. Review request for Plasma and Marco Martin. Changes --- Submitted with commit 6801fa9c2475887f4ca993aba5ae091a181d901b by Friedrich W. H. Kossebau to branch master. Repository: plasma-workspace Description --- Porting `KLocalizedDate(date.date()).formatDate

Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

--- 10/10 times configuring a new weather station (also from different services) worked & did not result in an empty widget (but then before I also only seldomly saw that). Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-d

Re: Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

marked as submitted. Review request for Plasma, Kai Uwe Broulik and Marco Martin. Changes --- Submitted with commit d5b8faa0e07be47f6bc2177d6e7ae40df873c014 by Friedrich W. H. Kossebau to branch Plasma/5.6. Repository: kdeplasma-addons Description --- Possible root of the error

Use-cases for ASCII-art kwin backend (Re: Minutes Monday Plasma Meeting)

Am Montag, 4. April 2016, 12:42:39 CEST schrieb Sebastian Kügler: > * april-fool: https://phabricator.kde.org/D1283 - might work as easter egg, > opinions? Use-cases: * nice gimmick for Plasma demo points on fairs/events (as eye catcher or talk starter), if separate (virtual) machine is available

RFC: Enabling users to report issues with Plasma widgets

Hi, challenge: 1. take your favourite Plasma widget 2. find a bug or idea for an improvement with it 3. report it to the maintainer of the widget 1. & 2. are easy. But 3. is not easy at all. Question: Are endusers supposed to report issues with Plasma widgets and get in contact with its develop

Re: bbcukmet feature in bugfix branch?

Hi Harald, Am Mittwoch, 6. April 2016, 11:23:04 CEST schrieb Harald Sitter: > Not that I know what an ion is but I am pretty sure [1] is a feature > and not a bug fix, yet it is in the bug fix branch for 5.6 :-( thanks for speaking out when seeing possible rule breaking, very appreciated. This o

Re: RFC: Enabling users to report issues with Plasma widgets

Thanks for the feedback so far, everyone. Looks like this is something were consensus needs more work before moving on with whatever plan. Will look more into this end of April. Though also happy to have someone else pick up this topic meanwhile and do the lead. Until then still welcoming comm

Re: KDE/kdenetwork/kdnssd/ioslave

Hi again, Kevin, Jeudi, le 28 avril 2011, à 23:45, Friedrich W. H. Kossebau a écrit: > the network:/ kio-slave > (which btw already lists plasma remote widgets, but in a device-centric > way, not service- centric), the attached patch never made it to kdelibs/plasma (bitrotted

How to do a Plasma runner which only triggers once the query string is complete?

Hi, (cc:ing marble-devel for heads-up, please follow-ups only on plasma-devel) I would like to do a Plasma runner which reuses the runners that Marble, your favourite celestial body watcher, has. Yes, Marble has also runners: In the "Navigation" sidebar, in the edit field below "Search" the use

Re: How to do a Plasma runner which only triggers once the query string is complete?

Ping... so, noone any idea? On marble-devel Anders proposed to wait until user stops typing, but from what I could see there is no way to make use of that here, right? So is the only option really some kind of end-keyword? :( Lundi, le 17 octobre 2011, à 20:32, Friedrich W. H. Kossebau a écrit

Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop & co. runs fine Thanks, Friedrich W. H. Kossebau

Re: Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

a/desktop/applets/pager/CMakeLists.txt 056f9d4 plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop & co. runs fine Thanks

Re: Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

/CMakeLists.txt 375a0d6 plasma/desktop/applets/pager/CMakeLists.txt 056f9d4 plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop & co. runs

Re: Review Request 128108: update weather applet ui

smaComponents.Label applets/weather/package/contents/ui/main.qml (line 155) <https://git.reviewboard.kde.org/r/128108/#comment65088> Please do not delete "textFormat: Text.StyledText", just add "opacity: 0.6". - Friedrich W. H. Kossebau On J

Re: Review Request 128108: update weather applet ui

ently already (but only with a fixed version :) ). - Friedrich W. H. Kossebau On June 8, 2016, 10:25 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 128108: update weather applet ui

To reply, visit: > https://git.reviewboard.kde.org/r/128108/ > --- > > (Updated June 10, 2016, 10:37 p.m.) > > > Review request for Plasma and Friedrich W. H. Kossebau. > > > Repository: kdeplasma-addons > > > Descri

Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

nly tested `LC_ALL=C LANG=C msgfmt --statistics somefile.po -o /dev/null> 2>&1` on the commandline, worked as expected, no file created. Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.

Re: Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

marked as submitted. Review request for Plasma, Albert Astals Cid, Jonathan Riddell, Luigi Toscano, and Harald Sitter. Changes --- Submitted with commit 40e9146fba8fdfa1ca11abb34f371f5ce1ae7d05 by Friedrich W. H. Kossebau to branch master. Repository: releaseme Description

Review Request 128594: Add a kapptemplate for Plasma Wallpaper

675e71 Diff: https://git.reviewboard.kde.org/r/128594/diff/ Testing --- Installed the template, then created a new wallpaper plugin using kapptemplate and following the README, then selected in wallpaper config, incl. editing the plugin config by entering a new text. Thanks, Frie

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit d4f10cd67e8c4811d3a39fbd44e1f16655c9b2fc by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- This template should allow people to

Re: Review Request 128612: Add translation domain to wallpaper QML object

.DisplayText || i18n("") ``` - Friedrich W. H. Kossebau On Aug. 5, 2016, 1:56 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

et.desktop e142552 src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645 src/plasma/pluginloader.h 80cd1e9 Diff: https://git.reviewboard.kde.org/r/128616/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses at

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses at

Re: Review Request 128897: cursor model: look for cursors in correct place

tps://git.reviewboard.kde.org/r/128897/#comment66752> Should these includes not be conditional on whether X11 is found or not? - Friedrich W. H. Kossebau On Sept. 13, 2016, 12:44 p.m., Jason A. Donenfeld wrote: > > --- > This is a

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

/kfiledialog_unittest.cpp (line 106) <https://git.reviewboard.kde.org/r/129732/#comment68101> Please also add a comment why `QTest::qWaitForWindowExposed()` is not used as with similar tests, not obvious to me at least. - Friedrich W. H. Kossebau On Dec. 31, 2016, 1:20 a.m., Albert Astals Cid

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

discussed on irc). Though my POV is limited, file widgets being not my playing ground, so perhaps better have someone else ship-it, too. - Friedrich W. H. Kossebau On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid wrote: > > --- >

[Differential] [Commented On] D4120: add support for display_name in categories

kossebau added a comment. Sounds good. While touching this, have you considered localized display names? While content description might be still English as lingua-franca, having the display name localized might be another step into the direction of average users which are not fluent in

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. kossebau added a comment. @jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5127 To: jriddell, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Relicensing Plasma Browser Integration Host to GPLv3+

lf) touched that folder: > > David Edmundson > Fabian Vogt > Laurent Montel > Friedrich W. H. Kossebau > Matthijs Tijink > > Are you fine with this, or have any other comments? Fine with me. Only touched build system/cmake code though, which is rather trivial and, if actually properly licensed, should be some BSD one? Cheers Friedrich

Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

(cc: plasma-devel for heads-up, not subscribed there, please re: only to kfd) Am Samstag, 17. April 2021, 16:11:24 CEST schrieb Luigi Toscano: > Several "needs input" tasks are related to Plasma. > Maybe it would be better to focus on Plasma next time and involve Plasma > people, and find out whic

Developer setups for user D-Bus service files?

Hi, (plasma-devel as CC: for heads-up, please reply only to kde-devel to keep discussion in one place) at least with systemd controlled start (but possibly also before) of the session D-Bus (based on what I understood so far, please correct me) for a user is not possible just by editing their

plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

Hi, with plasma-framework, kactivities and kactivities entering the Plasma product bundle, I assume they also will adapt to Plasma versioning. Without any de-KF-ication though this will break things though for building consumers soonish. Example --- 8< --- find_package(KF6 ${KF_MIN_VERSION} RE

Move krunner also to plasma bundle? (was: Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now)

Am Sonntag, 5. November 2023, 15:32:21 CET schrieb christ...@cullmann.io: > On 2023-11-05 15:11, Nate Graham wrote: > > On 11/5/23 07:09, christ...@cullmann.io wrote: > >> if we are atm moving stuff, might it make sense to move Baloo, too, > >> given it only > >> is usable with the daemon inside Pl

D28142: Display PID & signal numbers unlocalized

kossebau created this revision. kossebau added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY These are less numbers, but more identifiers in the system. REPOSITORY R871 DrKonqi

D28142: Display PID & signal numbers unlocalized

kossebau added a comment. Not tested though, somehow my setup prevents my custom drkonqi to show up. So far I just know it tells and should work in theory. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28142 To: kossebau, #plasma, sitter Cc: plasma-devel, Orage, L

D28142: Display PID & signal numbers unlocalized

This revision was automatically updated to reflect the committed changes. Closed by commit R871:af4cd7a4cf5f: Display PID & signal numbers unlocalized (authored by kossebau). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28142?vs=78022&id=78116 REVISION DETA

D28262: [applets/analog-clock] Optional minute hand

kossebau resigned from this revision. kossebau added a comment. Resigning, due to currently not having time for Plasma development. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma Cc: ngraham, aloiseau, plasma-devel, Orage,

D28330: Color icons in titlebar if possible

kossebau added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPale

D28330: Color icons in titlebar if possible

kossebau added a comment. With cross-casting I meant the type of cast where the types involved are not in same inheritance branch INLINE COMMENTS > davidre wrote in breezebutton.cpp:148 > I don't think it can fail. decoration() is a QPointer > (https://api.kde.org/kdecoration/html/classKDec

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Can you tell which packagers missed that this is a required runtime dependency? Noting runtime dependencies as done so far here, by not having it required and tagging it as "RUNTIME" is a pattern everywhere else in KDE code, so the proposed patch or just settin

D28360: cmake: make xsettingsd check an option

kossebau added a comment. In D28360#636615 , @eszlari wrote: > In D28360#636610 , @kossebau wrote: > > > Can you tell which packagers missed that this is a required runtime dependency? > > > h

D28360: cmake: make xsettingsd check an option

kossebau added a comment. See how it is done across KDE repos here: https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=TYPE+RUNTIME&_casesensitive=1 There should be no reason the same works here as well. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Sadly Cmake does not have separate "RUNTIME-OPTIONAL" & "RUNTIME-REQUIRED" so far. Previously that was solved by noting the required vs. optional in the purpose text, so the info still arrived with packagers. Just "REQUIRED" means, it is required for the build. Cou

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Yes, I would just do a patch for the 'PURPOSE' text, mentioning "Required" or "Optional" (whatever you decide on), based on previously discussions with packagers on similar cases. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde

D28134: Add ColorUtils

kossebau added a comment. Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #p

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > Hi all, > > > > Please see below - any ideas as to why KHelpCenter no longer successfully > > builds? > > > > It doesn't look like KHelpCenter has changed... > > N

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > Hi all, > > Another breakage in Qt? Should be fixed now (restarted build now completed), with similar traps also removed for the future, thanks to David Faure for the work done and Ade for the root detecting investigations. Seem

D29144: [applets/weather] Improve UX for selecting a weather station

kossebau resigned from this revision. kossebau added a comment. No time left over for Plasma currently, sorry, REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblac

D12459: [Icon KCM] Port to new design

kossebau added inline comments. INLINE COMMENTS > main.cpp:393 > +for (int i = 0; i < KIconLoader::LastGroup; i++) { > +KIconLoader::emitChange(KIconLoader::Group(i)); > + Is KIconLoader::emitChange also for kde4 apps only? Asking as KIconLoader of KIconThemes seems to have

D22778: Restore option to create a Qt Designer plugin

kossebau abandoned this revision. kossebau added a comment. Rebased/Updated as https://invent.kde.org/plasma/libksysguard/-/merge_requests/10 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D22778 To: kossebau, #plasma, davidedmundson, mart Cc: plasma-devel

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > systemtray.h:100 > */ > -Q_INVOKABLE void reorderItemAfter(QQuickItem* after, QQuickItem* before); > - > -Q_INVOKABLE bool isSystemTrayApplet(const QString &appletId); > +Q_INVOKABLE Plasma::Service *serviceForSource(const QStrin

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > I don't know, this code was there before my changes, I've just done some > refactoring here. Thanks for your reply. Okay, so seems you did not hit anything related. Thing is, you added `` Q_INVOKABLE Plasma:

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > Oh, OK, now I remember, sorry for misinforming you... > > I haven't had any problems with this, it "Just Worked" :) Maybe it should > return just plain QObject*, I'm not experienced in this area, what do you

D13818: Port from KStandardDirs to QStandardPaths

kossebau created this revision. kossebau added a reviewer: jgrulich. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY --kdelibs4suupport TEST PLAN Tested importing a config fil

D13818: Port from KStandardDirs to QStandardPaths

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f327922e60fb: Port from KStandardDirs to QStandardPaths (authored by kossebau). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13818?vs=369

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

kossebau created this revision. kossebau added reviewers: dfaure, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With the movement to support running unittests pre-instal

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

kossebau added a comment. Initial draft version of the patch for principal review. Blocks should be indented surely. Perhaps the test methods should be also separated each into in-orocess and out-of-process , so the out-of-process ones could get a QSKIP at the begin, for improved lo

D13874: textplugin: Fix missing QTextStream include

kossebau added a comment. Not the maintainer, just did some commits recently :) Thanks for the patch. Seems this is needed with some newer version of Qt? Some >5.11.1? Can you commit yourself? Should go to Plasma/5.12 branch possibly, to make that one work as well with newer Qt. REPOSIT

D13927: autotests: Compare doubles to doubles

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:03aed13d9ff3: Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int (authored by kossebau). REPOSITORY

  1   2   3   4   5   6   >