Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2019/09/14 00:44, Kaashif Hymabaccus wrote:
> On Thu, Sep 05, 2019 at 10:05:30AM +0100, Stuart Henderson wrote:
> > On 2019/09/01 19:20, Kaashif Hymabaccus wrote:
> > > Hi ports@,
> > > 
> > > Here is the new release of rss2email. As before, it is a new port and
> > > not an update of rss2email since it is completely incompatible and I
> > > don't want to break users' perfectly fine configurations.
> > 
> > Let's just cut across and tell people in release notes to save
> > their config first. 2.x will not be seeing any updates and it's a one
> > time change. I've put an @ask-update in pkg/PLIST so that people know
> > to save feeds, and will write something for faq/current.html (to copy
> > to OpenBSD upgrade notes) telling people what to do.
> > 
> > Other changes compared to your version, remove HOMEPAGE (it's the default
> > for a MODPY_PI=Yes port), remove TEST_DEPENDS (RUN_DEPENDS is automatically
> > added, see "make show=TEST_DEPENDS"), rerun "make plist".
> > 
> > OK?
> 
> Thanks for the improvements to my update.
> 
> While I would like this committed, I am actually especially interested
> in whether someone has a feed that breaks 3.10 in some way. I get the
> feeling that maybe some OpenBSD devs are regular users of rss2email
> 2.71 (sthen@, maybe jca@?), so they might have some nontrivial feeds
> to test the config migration to 3.10 and all of the other new stuff.
> 
> Any testers (and bug reports, diffs) are welcome of course.
> 

It's already committed. Other than the problem which I ran into with georss
which I patched in feedparser, it has been happy with everything I've thrown
at it.

Re: NEW: mail/rss2email3

[Kaashif Hymabaccus]

On Thu, Sep 05, 2019 at 10:05:30AM +0100, Stuart Henderson wrote:
> On 2019/09/01 19:20, Kaashif Hymabaccus wrote:
> > Hi ports@,
> > 
> > Here is the new release of rss2email. As before, it is a new port and
> > not an update of rss2email since it is completely incompatible and I
> > don't want to break users' perfectly fine configurations.
> 
> Let's just cut across and tell people in release notes to save
> their config first. 2.x will not be seeing any updates and it's a one
> time change. I've put an @ask-update in pkg/PLIST so that people know
> to save feeds, and will write something for faq/current.html (to copy
> to OpenBSD upgrade notes) telling people what to do.
> 
> Other changes compared to your version, remove HOMEPAGE (it's the default
> for a MODPY_PI=Yes port), remove TEST_DEPENDS (RUN_DEPENDS is automatically
> added, see "make show=TEST_DEPENDS"), rerun "make plist".
> 
> OK?

Thanks for the improvements to my update.

While I would like this committed, I am actually especially interested
in whether someone has a feed that breaks 3.10 in some way. I get the
feeling that maybe some OpenBSD devs are regular users of rss2email
2.71 (sthen@, maybe jca@?), so they might have some nontrivial feeds
to test the config migration to 3.10 and all of the other new stuff.

Any testers (and bug reports, diffs) are welcome of course.

Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2019/09/01 19:20, Kaashif Hymabaccus wrote:
> Hi ports@,
> 
> Here is the new release of rss2email. As before, it is a new port and
> not an update of rss2email since it is completely incompatible and I
> don't want to break users' perfectly fine configurations.

Let's just cut across and tell people in release notes to save
their config first. 2.x will not be seeing any updates and it's a one
time change. I've put an @ask-update in pkg/PLIST so that people know
to save feeds, and will write something for faq/current.html (to copy
to OpenBSD upgrade notes) telling people what to do.

Other changes compared to your version, remove HOMEPAGE (it's the default
for a MODPY_PI=Yes port), remove TEST_DEPENDS (RUN_DEPENDS is automatically
added, see "make show=TEST_DEPENDS"), rerun "make plist".

OK?


Index: Makefile
===
RCS file: /cvs/ports/mail/rss2email/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- Makefile24 Aug 2019 20:14:06 -  1.4
+++ Makefile5 Sep 2019 09:03:42 -
@@ -1,39 +1,29 @@
-# $OpenBSD: Makefile,v 1.4 2019/08/24 20:14:06 sthen Exp $
+# $OpenBSD$
 
-COMMENT=   get news from RSS feeds in email
+COMMENT =  convert RSS/Atom newsfeeds to email
 
-DISTNAME=  rss2email-2.71
-FIX_EXTRACT_PERMISSIONS= Yes
+MODPY_EGG_VERSION = 3.10
+DISTNAME = rss2email-${MODPY_EGG_VERSION}
+CATEGORIES =   mail www
 
-CATEGORIES=mail textproc
+MAINTAINER =   Kaashif Hymabaccus 
 
-HOMEPAGE=  http://www.allthingsrss.com/rss2email/
-
-# GPLv2/v3
-PERMIT_PACKAGE=Yes
-
-MASTER_SITES=  ${HOMEPAGE}
-
-MODULES=   lang/python
-BUILD_DEPENDS= ${RUN_DEPENDS}
-RUN_DEPENDS=   converters/py-html2text \
-   textproc/py-feedparser
-SUBST_VARS+=   MODPY_SITEPKG
-
-NO_BUILD=  Yes
-NO_TEST=   Yes
-
-do-install:
-   ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/rss2email/ \
-   ${PREFIX}/share/doc/rss2email/ ${WRKINST}/${MODPY_SITEPKG}/
-   ${INSTALL_SCRIPT} ${WRKSRC}/rss2email.py ${WRKINST}/${MODPY_SITEPKG}/
-   ${INSTALL_DATA} ${WRKSRC}/readme.html ${PREFIX}/share/doc/rss2email/
-   ${INSTALL_DATA} ${WRKSRC}/config.py.example \
-   ${PREFIX}/share/examples/rss2email/
-   ${INSTALL_DATA} ${WRKSRC}/config.py.example \
-   ${PREFIX}/share/examples/rss2email/
-   ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
-   ${WRKINST}/${MODPY_SITEPKG}/rss2email.py
-   ${SUBST_PROGRAM} ${FILESDIR}/r2e ${PREFIX}/bin/r2e
+# GPLv2+
+PERMIT_PACKAGE =   Yes
+
+MODULES =  lang/python
+
+RUN_DEPENDS += converters/py-html2text${MODPY_FLAVOR} \
+   textproc/py-feedparser${MODPY_FLAVOR}
+
+MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
+MODPY_PI = Yes
+MODPY_SETUPTOOLS = Yes
+
+post-install:
+   ${INSTALL_MAN} ${WRKSRC}/r2e.1 ${PREFIX}/man/man1/
+
+do-test:
+   cd ${WRKSRC} && env PYTHONPATH=. ${MODPY_BIN} test/test.py
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/mail/rss2email/distinfo,v
retrieving revision 1.2
diff -u -p -r1.2 distinfo
--- distinfo24 Aug 2019 20:14:06 -  1.2
+++ distinfo5 Sep 2019 09:03:42 -
@@ -1,2 +1,2 @@
-SHA256 (rss2email-2.71.tar.gz) = 1SRRl6UDRBBAXx9XlGELhL8mwMQMjQX+CJURZ5epmzE=
-SIZE (rss2email-2.71.tar.gz) = 63268
+SHA256 (rss2email-3.10.tar.gz) = AcZbUrEO+E/2ZJLU5157uJ4p1qfEmsm5v1XKhO9bT/o=
+SIZE (rss2email-3.10.tar.gz) = 65388
Index: files/r2e
===
RCS file: files/r2e
diff -N files/r2e
--- files/r2e   26 Jun 2013 16:23:10 -  1.1.1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,4 +0,0 @@
-#!/bin/sh -e
-[ -d ~/.rss2email ] || mkdir ~/.rss2email
-cd ~/.rss2email
-exec ${MODPY_BIN} ${MODPY_SITEPKG}/rss2email.py feeds.dat $*
Index: pkg/DESCR
===
RCS file: /cvs/ports/mail/rss2email/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR   26 Jun 2013 16:23:10 -  1.1.1.1
+++ pkg/DESCR   5 Sep 2019 09:03:42 -
@@ -1,2 +1,6 @@
-rss2email is a free tool for delivering news from RSS feeds to your
-email program.
+rss2email is a simple program which you can run in your crontab. It
+watches RSS feeds and sends you nicely formatted email messages for
+each new item.
+
+rss2email was started by Aaron Swartz and is currently maintained by
+by the community at https://github.com/rss2email.
Index: pkg/PLIST
===
RCS file: /cvs/ports/mail/rss2email/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST   26 Jun 2013 16:23:10 -  1.1.1.1
+++ pkg/PLIST   5 Sep 2019 09:03:42 -
@@ -1,8 +1,43 @@
-@comment $OpenBSD: PLIST,v 1.1.1.1 2013/06/26 16:23:10 sthen Exp $
+@comment $OpenBSD: PLIST,v$
+@ask-update rss2email-<3 Make sure your 

NEW: mail/rss2email3

[Kaashif Hymabaccus]

Hi ports@,

Here is the new release of rss2email. As before, it is a new port and
not an update of rss2email since it is completely incompatible and I
don't want to break users' perfectly fine configurations.

Some concerns from last time have been addressed:

Q: Is the new upstream (https://github.com/rss2email/rss2email) the
   canonical upstream?

A: Yes, the old maintainer W. Trevor King has added the new
   maintainers to the PyPI package (https://pypi.org/project/rss2email/)
   and this is where we have released 3.10.

Q: Why is "3" embedded in the port name? What happens when version 4
   is released?

A: As one of the maintainers of the project, I can personally
   guarantee version 4 will never be released. We will never break
   compatibility (big statement I know) and there will never be a
   major version bump. If there are better naming ideas, I am open to
   them.

Q: Why would I use this instead of my already working rss2email-2.71
   setup?

A: We got all of the people who had forked rss2email under one roof
   and collected all of their previously bugfixes and new
   features. Like support for writing to maildir, working tests, some
   SSL fixes, some feed parsing fixes, etc. I think it works better
   than 3.9 (which is actually not even in ports, so maybe this is
   irrelevant). And not to mention, this is the only version with
   active maintainers who will respond to problems.

Q: Does it work on the undeadly.org RSS feed?

A: Yes! Or at least it does on my machine.

The only issue I have is that "make test" hangs but if you manually go
to WRKSRC and run the tests it works. Probably something to do with
the fact the tests start a web server?

I am really keen to get this in eventually since I've been using it
for an extremely long time.

Testing and suggestions are very welcome.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: Binary data

Re: NEW: mail/rss2email3

[Daniel Jakots]

On Fri, 11 May 2018 18:43:01 +0200, Jeremie Courreges-Anglas
 wrote:

> I get a warning using undeadly but no fatal crash:
> 
>   russell /usr/ports/mystuff/mail/rss2email3$ r2e3 run
>   sax parsing error: :104:121: undefined entity: undeadly
> (http://www.undeadly.org/cgi?action=rss -> j...@wxcvbn.org)
> 
> I received the mail below:
> --8<--
> From: "OpenBSD Journal: " 
> Subject: 
> To: j...@wxcvbn.org
> Date: Fri, 11 May 2018 16:11:23 - (11 minutes, 35 seconds ago)
> User-Agent: rss2email/3.9 (https://github.com/wking/rss2email)
> 
> 
> 
> URL: None
> -->8--  

That's because undeadly rss is broken.
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fundeadly.org%2Fcgi%3Faction%3Drss
says "This feed does not validate." and tt-rss says "LibXML error 26 at
line 104 (column 129): Entity 'ecirc' not defined"
(It's not the first time)

I'm not saying rss2email3 couldn't handle it in a better way though.

Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2018/05/11 18:43, Jeremie Courreges-Anglas wrote:
> This is at least the second unreleased fix I noticed for newer python3+
> versions.  This begs the question as to how this newer version is better
> than what we already have in ports...

Very good point. I've had zero problems with 2.70..

Re: NEW: mail/rss2email3

[Jeremie Courreges-Anglas]

On Fri, May 11 2018, Stuart Henderson  wrote:
> On 2018/05/11 13:54, Jeremie Courreges-Anglas wrote:
>> On Wed, May 09 2018, Stuart Henderson  wrote:
>> > On 2018/05/09 08:34, Jeremie Courreges-Anglas wrote:
>> >> On Sun, May 06 2018, Kaashif Hymabaccus  wrote:
>> >> > On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
>> >> >> 
>> >> >> a TEST_DEPENDS is needed here
>> >> >> 
>> >> >> 
>> >> >> A few changes are needed in pkg/PLIST too
>> >> >> 
>> >> >> - remove share/doc/rss2email3/README, because the README from 
>> >> >> pkg/README
>> >> >>   will be automatically put there-> 
>> >> >> share/doc/pkg-readmes/${FULLPKGNAME}
>> >> >> - ${MODPY_COMMENT} should be used for directories containing 
>> >> >> ${MODPY_PYCACHE}
>> >
>> > That's not really needed here, it's python3+ only.
>> >
>> >> >
>> >> > Made these changes. Tarball attached.
>> >> 
>> >> The port looks good to me, the transition path makes sense I guess...
>> >> 
>> >> Two questions:
>> >> 
>> >> 1. This proposal embeds "3" in the port directory name and the PKGNAME,
>> >>   what is supposed to happen with rss2email-4.0? A new mail/rss2email4
>> >>   port? :)
>> >
>> > Has anyone figured out the process needed to move from aaronsw (RIP)'s
>> > rss2email code that we have in ports now to this version? There was a
>> > comment earlier that having the two in tree together made this easier
>> > but no indication how. It would seem sensible to just have a one-time
>> > bump to move across and avoid complexity.
>> 
>> I would prefer this approach too.  I thought you were an rss2email user.
>> Did you try the instructions in pkg/README?
>
> Aargh I missed that :)
>
> So with a replacement, README is too late, but we can add to current.html
> and upgrade notes. Something like this should work..
>
> - Make a note of the default email address (r2e list | grep ^default)
> - Export the list of feeds (r2e opmlexport > r2e.opml)
> - Send any updates to feeds with the old version (r2e run)
> - Update the package
> - Create a new database (r2e new)
> - Set the default email (r2e email "em...@example.com")
> - Import the list of feeds (r2e opmlimport < r2e.opml)
> - Ignore old updates (r2e run --no-send), or if you don't mind duplicates
> and want to be sure you didn't miss any, re-send everything (r2e run).
>
> Then I hit a runtime problem though...
>
> $ r2e run
> sax parsing error: :104:121: undefined entity: feed-1 
> (http://www.undeadly.org/cgi?action=rss -> s...@spacehopper.org)
> Traceback (most recent call last):
>   File "/usr/local/bin/r2e", line 5, in 
> rss2email.main.run()
>   File "/usr/local/lib/python3.6/site-packages/rss2email/main.py", line 163, 
> in run
> args.func(feeds=feeds, args=args)
>   File "/usr/local/lib/python3.6/site-packages/rss2email/command.py", line 
> 62, in run
> feed.run(send=args.send)
>   File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 838, 
> in run
> for (guid, id_, sender, message) in self._process(parsed):
>   File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 357, 
> in _process
> processed = self._process_entry(parsed=parsed, entry=entry)
>   File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 470, 
> in _process_entry
> for k,v in extra_headers.items():  # remove empty tags, etc.
> RuntimeError: OrderedDict mutated during iteration

Patch from upstream attached to work around this.



patch-rss2email_feed_py
Description: Binary data

This is at least the second unreleased fix I noticed for newer python3+
versions.  This begs the question as to how this newer version is better
than what we already have in ports...

I get a warning using undeadly but no fatal crash:

  russell /usr/ports/mystuff/mail/rss2email3$ r2e3 run
  sax parsing error: :104:121: undefined entity: undeadly 
(http://www.undeadly.org/cgi?action=rss -> j...@wxcvbn.org)

I received the mail below:
--8<--
From: "OpenBSD Journal: " 
Subject: 
To: j...@wxcvbn.org
Date: Fri, 11 May 2018 16:11:23 - (11 minutes, 35 seconds ago)
User-Agent: rss2email/3.9 (https://github.com/wking/rss2email)



URL: None
-->8--

then mails for the p2k18 reports from landry@, naddy@, stsp@ and eric@
followed.  I get the same warnings, and the same mostly empty mail in
subsequent runs.

>> There's also
>> https://github.com/rss2email/rss2email/commit/375404478410e12fd497d4f11bf7c7050e4eb907
>> which I find "funny".  Probably not many users rely on SSL/TLS.
>
> Probably not for smtp..

Yep.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2018/05/11 13:54, Jeremie Courreges-Anglas wrote:
> On Wed, May 09 2018, Stuart Henderson  wrote:
> > On 2018/05/09 08:34, Jeremie Courreges-Anglas wrote:
> >> On Sun, May 06 2018, Kaashif Hymabaccus  wrote:
> >> > On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
> >> >> 
> >> >> a TEST_DEPENDS is needed here
> >> >> 
> >> >> 
> >> >> A few changes are needed in pkg/PLIST too
> >> >> 
> >> >> - remove share/doc/rss2email3/README, because the README from pkg/README
> >> >>   will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
> >> >> - ${MODPY_COMMENT} should be used for directories containing 
> >> >> ${MODPY_PYCACHE}
> >
> > That's not really needed here, it's python3+ only.
> >
> >> >
> >> > Made these changes. Tarball attached.
> >> 
> >> The port looks good to me, the transition path makes sense I guess...
> >> 
> >> Two questions:
> >> 
> >> 1. This proposal embeds "3" in the port directory name and the PKGNAME,
> >>   what is supposed to happen with rss2email-4.0? A new mail/rss2email4
> >>   port? :)
> >
> > Has anyone figured out the process needed to move from aaronsw (RIP)'s
> > rss2email code that we have in ports now to this version? There was a
> > comment earlier that having the two in tree together made this easier
> > but no indication how. It would seem sensible to just have a one-time
> > bump to move across and avoid complexity.
> 
> I would prefer this approach too.  I thought you were an rss2email user.
> Did you try the instructions in pkg/README?

Aargh I missed that :)

So with a replacement, README is too late, but we can add to current.html
and upgrade notes. Something like this should work..

- Make a note of the default email address (r2e list | grep ^default)
- Export the list of feeds (r2e opmlexport > r2e.opml)
- Send any updates to feeds with the old version (r2e run)
- Update the package
- Create a new database (r2e new)
- Set the default email (r2e email "em...@example.com")
- Import the list of feeds (r2e opmlimport < r2e.opml)
- Ignore old updates (r2e run --no-send), or if you don't mind duplicates
and want to be sure you didn't miss any, re-send everything (r2e run).

Then I hit a runtime problem though...

$ r2e run
sax parsing error: :104:121: undefined entity: feed-1 
(http://www.undeadly.org/cgi?action=rss -> s...@spacehopper.org)
Traceback (most recent call last):
  File "/usr/local/bin/r2e", line 5, in 
rss2email.main.run()
  File "/usr/local/lib/python3.6/site-packages/rss2email/main.py", line 163, in 
run
args.func(feeds=feeds, args=args)
  File "/usr/local/lib/python3.6/site-packages/rss2email/command.py", line 62, 
in run
feed.run(send=args.send)
  File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 838, in 
run
for (guid, id_, sender, message) in self._process(parsed):
  File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 357, in 
_process
processed = self._process_entry(parsed=parsed, entry=entry)
  File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 470, in 
_process_entry
for k,v in extra_headers.items():  # remove empty tags, etc.
RuntimeError: OrderedDict mutated during iteration

> There's also
> https://github.com/rss2email/rss2email/commit/375404478410e12fd497d4f11bf7c7050e4eb907
> which I find "funny".  Probably not many users rely on SSL/TLS.

Probably not for smtp..

Re: NEW: mail/rss2email3

[Jeremie Courreges-Anglas]

On Wed, May 09 2018, Stuart Henderson  wrote:
> On 2018/05/09 08:34, Jeremie Courreges-Anglas wrote:
>> On Sun, May 06 2018, Kaashif Hymabaccus  wrote:
>> > On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
>> >> 
>> >> a TEST_DEPENDS is needed here
>> >> 
>> >> 
>> >> A few changes are needed in pkg/PLIST too
>> >> 
>> >> - remove share/doc/rss2email3/README, because the README from pkg/README
>> >>   will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
>> >> - ${MODPY_COMMENT} should be used for directories containing 
>> >> ${MODPY_PYCACHE}
>
> That's not really needed here, it's python3+ only.
>
>> >
>> > Made these changes. Tarball attached.
>> 
>> The port looks good to me, the transition path makes sense I guess...
>> 
>> Two questions:
>> 
>> 1. This proposal embeds "3" in the port directory name and the PKGNAME,
>>   what is supposed to happen with rss2email-4.0? A new mail/rss2email4
>>   port? :)
>
> Has anyone figured out the process needed to move from aaronsw (RIP)'s
> rss2email code that we have in ports now to this version? There was a
> comment earlier that having the two in tree together made this easier
> but no indication how. It would seem sensible to just have a one-time
> bump to move across and avoid complexity.

I would prefer this approach too.  I thought you were an rss2email user.
Did you try the instructions in pkg/README?

>> 2. Right now it's not clear to me who is upstream,
>>   https://github.com/wking/rss2email or 
>> https://github.com/rss2email/rss2email ?
>> 
>>   https://github.com/wking/rss2email is mentioned as upstream in the 3.9
>>   release (2014) hosted on pypi.  https://github.com/rss2email/rss2email
>>   is mentioned as a possible new upstream in
>>   https://github.com/wking/rss2email/issues/105
>>   PR opened 9 days ago: https://github.com/rss2email/rss2email/issues/18
>>   All I know is that rss2email/rss2email has two more commits than
>>   wking/rss2email and transferred some PRs from it.
>> 
>>   I guess it would be nice to sort this out, especially a new release
>>   seems warranted, see for example the unreleased fix
>>   
>> https://github.com/wking/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3
>>   
>> https://github.com/rss2email/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3

There's also
https://github.com/rss2email/rss2email/commit/375404478410e12fd497d4f11bf7c7050e4eb907
which I find "funny".  Probably not many users rely on SSL/TLS.

>> Thoughts?
>
> There's more activity on the dev branch of rss2email/rss2email, though
> it's still not very lively. I'd probably go with whatever's on pypi plus
> patches for now but consider switching if the more-active upstream feels
> sufficiently confident to make a non-dev release.. But probably worth
> monitoring those recently opened issues for a bit first?

Probably. *shrug* :)

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2018/05/09 08:34, Jeremie Courreges-Anglas wrote:
> On Sun, May 06 2018, Kaashif Hymabaccus  wrote:
> > On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
> >> 
> >> a TEST_DEPENDS is needed here
> >> 
> >> 
> >> A few changes are needed in pkg/PLIST too
> >> 
> >> - remove share/doc/rss2email3/README, because the README from pkg/README
> >>   will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
> >> - ${MODPY_COMMENT} should be used for directories containing 
> >> ${MODPY_PYCACHE}

That's not really needed here, it's python3+ only.

> >
> > Made these changes. Tarball attached.
> 
> The port looks good to me, the transition path makes sense I guess...
> 
> Two questions:
> 
> 1. This proposal embeds "3" in the port directory name and the PKGNAME,
>   what is supposed to happen with rss2email-4.0? A new mail/rss2email4
>   port? :)

Has anyone figured out the process needed to move from aaronsw (RIP)'s
rss2email code that we have in ports now to this version? There was a
comment earlier that having the two in tree together made this easier
but no indication how. It would seem sensible to just have a one-time
bump to move across and avoid complexity.

> 2. Right now it's not clear to me who is upstream,
>   https://github.com/wking/rss2email or 
> https://github.com/rss2email/rss2email ?
> 
>   https://github.com/wking/rss2email is mentioned as upstream in the 3.9
>   release (2014) hosted on pypi.  https://github.com/rss2email/rss2email
>   is mentioned as a possible new upstream in
>   https://github.com/wking/rss2email/issues/105
>   PR opened 9 days ago: https://github.com/rss2email/rss2email/issues/18
>   All I know is that rss2email/rss2email has two more commits than
>   wking/rss2email and transferred some PRs from it.
> 
>   I guess it would be nice to sort this out, especially a new release
>   seems warranted, see for example the unreleased fix
>   
> https://github.com/wking/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3
>   
> https://github.com/rss2email/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3
> 
> Thoughts?

There's more activity on the dev branch of rss2email/rss2email, though
it's still not very lively. I'd probably go with whatever's on pypi plus
patches for now but consider switching if the more-active upstream feels
sufficiently confident to make a non-dev release.. But probably worth
monitoring those recently opened issues for a bit first?

Re: NEW: mail/rss2email3

[Jeremie Courreges-Anglas]

On Sun, May 06 2018, Kaashif Hymabaccus  wrote:
> On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
>> 
>> a TEST_DEPENDS is needed here
>> 
>> 
>> A few changes are needed in pkg/PLIST too
>> 
>> - remove share/doc/rss2email3/README, because the README from pkg/README
>>   will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
>> - ${MODPY_COMMENT} should be used for directories containing ${MODPY_PYCACHE}
>
> Made these changes. Tarball attached.

The port looks good to me, the transition path makes sense I guess...

Two questions:

1. This proposal embeds "3" in the port directory name and the PKGNAME,
  what is supposed to happen with rss2email-4.0? A new mail/rss2email4
  port? :)

2. Right now it's not clear to me who is upstream,
  https://github.com/wking/rss2email or https://github.com/rss2email/rss2email ?

  https://github.com/wking/rss2email is mentioned as upstream in the 3.9
  release (2014) hosted on pypi.  https://github.com/rss2email/rss2email
  is mentioned as a possible new upstream in
  https://github.com/wking/rss2email/issues/105
  PR opened 9 days ago: https://github.com/rss2email/rss2email/issues/18
  All I know is that rss2email/rss2email has two more commits than
  wking/rss2email and transferred some PRs from it.

  I guess it would be nice to sort this out, especially a new release
  seems warranted, see for example the unreleased fix
  
https://github.com/wking/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3
  
https://github.com/rss2email/rss2email/commit/354543d53e1b2716a416d23614b323d5c96aeee3

Thoughts?

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: NEW: mail/rss2email3

[Kaashif Hymabaccus]

On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote:
> 
> a TEST_DEPENDS is needed here
> 
> 
> A few changes are needed in pkg/PLIST too
> 
> - remove share/doc/rss2email3/README, because the README from pkg/README
>   will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
> - ${MODPY_COMMENT} should be used for directories containing ${MODPY_PYCACHE}

Made these changes. Tarball attached.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: Binary data

Re: NEW: mail/rss2email3

[Solene Rapenne]

Kaashif Hymabaccus writes:

> On Tue, Jan 16, 2018 at 12:14:10AM +, Kaashif Hymabaccus wrote:
>> Ping with a new tarball. The distinfo in the previous one is wrong.
>>
>> --
>> Kaashif Hymabaccus
>> GPG: 3E810B04
>
> Anyone interested in this? Tarball attached.

make test fails for me

Traceback (most recent call last):
  File "test/test.py", line 15, in 
import rss2email.feed as _rss2email_feed
  File "/home/ports/pobj/rss2email3-3.9/rss2email-3.9/rss2email/feed.py", line 
49, in 
import feedparser as _feedparser
ModuleNotFoundError: No module named 'feedparser'

a TEST_DEPENDS is needed here


A few changes are needed in pkg/PLIST too

- remove share/doc/rss2email3/README, because the README from pkg/README
  will be automatically put there-> share/doc/pkg-readmes/${FULLPKGNAME}
- ${MODPY_COMMENT} should be used for directories containing ${MODPY_PYCACHE}

--- pkg/PLIST.orig  Mon Apr 30 17:44:04 2018
+++ pkg/PLIST   Mon Apr 30 17:44:27 2018
@@ -3,7 +3,7 @@
 lib/python${MODPY_VERSION}/site-packages/rss2email/
 
lib/python${MODPY_VERSION}/site-packages/rss2email-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
 lib/python${MODPY_VERSION}/site-packages/rss2email/__init__.py
-lib/python${MODPY_VERSION}/site-packages/rss2email/${MODPY_PYCACHE}/
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/rss2email/${MODPY_PYCACHE}/
 
lib/python${MODPY_VERSION}/site-packages/rss2email/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/rss2email/${MODPY_PYCACHE}command.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/rss2email/${MODPY_PYCACHE}config.${MODPY_PYC_MAGIC_TAG}pyc
@@ -33,5 +33,3 @@
 lib/python${MODPY_VERSION}/site-packages/rss2email/version.py
 @man man/man1/r2e3.1
 share/doc/pkg-readmes/${FULLPKGNAME}
-share/doc/rss2email3/
-share/doc/rss2email3/README

Re: NEW: mail/rss2email3

[Kaashif Hymabaccus]

On Tue, Jan 16, 2018 at 12:14:10AM +, Kaashif Hymabaccus wrote:
> Ping with a new tarball. The distinfo in the previous one is wrong.
> 
> -- 
> Kaashif Hymabaccus
> GPG: 3E810B04

Anyone interested in this? Tarball attached.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: Binary data

Re: NEW: mail/rss2email3

[Kaashif Hymabaccus]

Ping with a new tarball. The distinfo in the previous one is wrong.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: Binary data

Re: NEW: mail/rss2email3

[Kaashif Hymabaccus]

On Sat, Dec 09, 2017 at 10:32:26PM +, Stuart Henderson wrote:
> 
> MODPY_EGG_VERSION = 3.9
> 
> - please move this up in the block with DISTNAME
> 
> ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/${DISTNAME}
> 
> - usually we don't use the full version number in such directories,
> ${PREFIX}/share/doc/rss2email3 would probably be the most appropriate
> 
> (pkg/MESSAGE) 
> 
> - please convert to a pkg-readme

Incorporated these suggestions. Tarball attached.

Also I moved everything around so it's in the same order as the
infrastructure Makefile template.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: application/tar-gz

Re: NEW: mail/rss2email3

[Stuart Henderson]

On 2017/12/09 19:40, Kaashif Hymabaccus wrote:
> Hello ports@
> 
> This is a port of the new version of rss2email, 3.9. Since it makes a
> number of breaking changes from the version of rss2email we have now,
> I'm making this an entirely new port.
> 
> This is heavily based on the port Thomas Levine submitted a while ago,
> most of the credit goes to him.
> 
> Note: I install the script as r2e3 (not r2e) so as to avoid conflict
> with rss2email-2.7. There were some ideas floating around about how to
> rename ports or scripts to avoid confusion, but I think the best thing
> to do is to avoid breaking people's scripts altogether and treat this
> as a new, unrelated program. It almost is, since we have different
> authors, a different version of Python and a different config file
> format.
> 
> Comments? I think this is a fairly inoffensive and non-disruptive way
> of handling this potential conflict.
> 
> -- 
> Kaashif Hymabaccus
> GPG: 3E810B04

I think that's the right way to handle it. Couple of comments,

MODPY_EGG_VERSION = 3.9

- please move this up in the block with DISTNAME

${INSTALL_DATA_DIR} ${PREFIX}/share/doc/${DISTNAME}

- usually we don't use the full version number in such directories,
${PREFIX}/share/doc/rss2email3 would probably be the most appropriate

(pkg/MESSAGE) 

- please convert to a pkg-readme

NEW: mail/rss2email3

[Kaashif Hymabaccus]

Hello ports@

This is a port of the new version of rss2email, 3.9. Since it makes a
number of breaking changes from the version of rss2email we have now,
I'm making this an entirely new port.

This is heavily based on the port Thomas Levine submitted a while ago,
most of the credit goes to him.

Note: I install the script as r2e3 (not r2e) so as to avoid conflict
with rss2email-2.7. There were some ideas floating around about how to
rename ports or scripts to avoid confusion, but I think the best thing
to do is to avoid breaking people's scripts altogether and treat this
as a new, unrelated program. It almost is, since we have different
authors, a different version of Python and a different config file
format.

Comments? I think this is a fairly inoffensive and non-disruptive way
of handling this potential conflict.

-- 
Kaashif Hymabaccus
GPG: 3E810B04


rss2email3.tgz
Description: application/tar-gz