Re: Protocol Buffers Compiler Maven Plug-In

2009-01-20 Thread Nat
So is this going anywhere? Bueller...? Bueller...? After my last post I was curious to build my first Maven2 plugin, and I also now have a working plugin that binds to the generate-sources phase like Tom's original post in this thread. I was just about to (ask to) put it on Codehaus but re-rea

Re: Protocol Buffers Compiler Maven Plug-In

2009-01-20 Thread Kenton Varda
[cc Greg to get his attention] On Tue, Jan 20, 2009 at 9:35 AM, Nat wrote: > > So is this going anywhere? Bueller...? Bueller...? > > After my last post I was curious to build my first Maven2 plugin, and > I also now have a working plugin that binds to the generate-sources > phase like Tom's o

Re: how to submit patches? (python performance enhancement)

2009-01-20 Thread Kenton Varda
I like to have patches sent using codereview.appspot.com to make it easy for us to review. Petar (pesho.pet...@gmail.com) is in charge of Python protobufs so you should send the review to him (and CC me). On Sat, Jan 17, 2009 at 8:09 AM, Will P wrote: > > Hi all, > I have a speed enhancement pa

Re: Generating subclasses of a protocol buffer serialized class

2009-01-20 Thread Kenton Varda
Sorry, but we don't allow subclassing of protocol buffer objects (in any language). Allowing this leads to too many "fragile base class" problems. If you want to expose all of the fields of your protocol message (which is what you'd get from subclassing), you can always add an accessor to your wra

Re: Protocol Buffers Compiler Maven Plug-In

2009-01-20 Thread Gregory Kick
I totally understand the frustration. This had slipped to the bottom of the priorities, but I'm actually working on this stuff today. Basically, my plan is to check in the plugin today. The plugin is more or less done, but I have no tests. (ack!) I would really, really, really appreciate it if

Re: Protocol Buffers Compiler Maven Plug-In

2009-01-20 Thread Nathaniel Harward
I don't really consider this slacking; anything going to the open source community is a public gift and should be treated as such. I mostly just want to avoid fragmentation and having three different plugins doing the same thing, so that it can be focused and as high-quality as possible. Even if

Re: Quick Hacky text_mode Parse in Python

2009-01-20 Thread Helder Suzuki
I sent a partial patch a while ago and I disappeared without completing the text_format in python, sorry about that. So far I've only implemented the tokenizer part (w/ test cases), but anyone is free to use it to implement the parser part (I'd be really glad), and for some reason I couldn't set up