[protobuf] Re: Issue 361 in protobuf: Fix warnings

2012-02-08 Thread protobuf
Comment #3 on issue 361 by van...@gmail.com: Fix warnings http://code.google.com/p/protobuf/issues/detail?id=361 There are also few warnings I don't know how to handle properly protobuf-2.4.1\src\google\protobuf\text_format.cc:126: warning: C4355: 'this' : used in base member initializer list

[protobuf] Re: Issue 361 in protobuf: Fix warnings

2012-02-08 Thread protobuf
Comment #4 on issue 361 by nn1436...@gmail.com: Fix warnings http://code.google.com/p/protobuf/issues/detail?id=361 C4800: 'google::protobuf::uint64' : forcing value to bool 'true' or 'false' This is simple write the correct expression. Generates warning: uint64 x = 1; bool a = x; No warning,

[protobuf] Issue 372 in protobuf: command(protoc.exe --version )returned 1

2012-02-08 Thread protobuf
Status: New Owner: liuj...@google.com Labels: Type-Defect Priority-Medium New issue 372 by m...@laiyonghao.com: command(protoc.exe --version )returned 1 http://code.google.com/p/protobuf/issues/detail?id=372 What steps will reproduce the problem? 1.run python code below: import subprocess fro

[protobuf] Re: Issue 361 in protobuf: Fix warnings

2012-02-08 Thread protobuf
Updates: Status: Accepted Comment #5 on issue 361 by liuj...@google.com: Fix warnings http://code.google.com/p/protobuf/issues/detail?id=361 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group.

[protobuf] Re: Issue 350 in protobuf: FAIL: testPrintAllExtensions while running for protobuf: python setup.py test

2012-02-08 Thread protobuf
Updates: Status: Accepted Comment #1 on issue 350 by liuj...@google.com: FAIL: testPrintAllExtensions while running for protobuf: python setup.py test http://code.google.com/p/protobuf/issues/detail?id=350 Looks like the \r\n problem. -- You received this message because you are subs

[protobuf] Re: Issue 355 in protobuf: SerializeToString question

2012-02-08 Thread protobuf
Updates: Cc: f...@google.com Comment #1 on issue 355 by liuj...@google.com: SerializeToString question http://code.google.com/p/protobuf/issues/detail?id=355 The cpp implementation is quite experimental and known to have various issues. Thanks for reporting this. -- You received this

[protobuf] Re: Issue 372 in protobuf: command(protoc.exe --version )returned 1

2012-02-08 Thread protobuf
Updates: Status: Accepted Comment #1 on issue 372 by liuj...@google.com: command(protoc.exe --version )returned 1 http://code.google.com/p/protobuf/issues/detail?id=372 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Gro

[protobuf] Re: Issue 371 in protobuf: GeneratedMessageTest.MergeFromSelf CHECK failed: (&from) != (this)

2012-02-08 Thread protobuf
Updates: Status: Accepted Comment #1 on issue 371 by liuj...@google.com: GeneratedMessageTest.MergeFromSelf CHECK failed: (&from) != (this) http://code.google.com/p/protobuf/issues/detail?id=371 gtest-1.6.0 have known issues working with protobuf tests. Since 2.4.1, protobuf changes

[protobuf] Re: Issue 361 in protobuf: Fix warnings

2012-02-08 Thread protobuf
Comment #6 on issue 361 by van...@gmail.com: Fix warnings http://code.google.com/p/protobuf/issues/detail?id=361 Thanks. What about this: src\google\protobuf\stubs\common_unittest.cc:75: warning: C4307: '+' : integral constant overflow EXPECT_EQ(0u, kuint32max + 1); Seems like this is done

[protobuf] Re: Issue 361 in protobuf: Fix warnings

2012-02-08 Thread protobuf
Comment #7 on issue 361 by tom.ritc...@gmail.com: Fix warnings http://code.google.com/p/protobuf/issues/detail?id=361 In my setup, at least, GCC doesn't complain about "forcing value to bool", or about "'this' : used in base member initializer list". I frankly think the "forcing value to boo

[protobuf] Issue 373 in protobuf: Tests hang/crash/don't pass without RTTI

2012-02-08 Thread protobuf
Status: New Owner: liuj...@google.com Labels: Type-Defect Priority-Medium New issue 373 by van...@gmail.com: Tests hang/crash/don't pass without RTTI http://code.google.com/p/protobuf/issues/detail?id=373 What steps will reproduce the problem? 1. Add -fno-rtti -DGOOGLE_PROTOBUF_NO_RTTI to src/Ma

[protobuf] Re: Issue 373 in protobuf: Tests hang/crash/don't pass without RTTI

2012-02-08 Thread protobuf
Comment #1 on issue 373 by van...@gmail.com: Tests hang/crash/don't pass without RTTI http://code.google.com/p/protobuf/issues/detail?id=373 In fact, tests didn't even compile: google/protobuf/extension_set_unittest.cc:618:67: error: "dynamic_cast" not permitted with -fno-rtti I made the

[protobuf] Re: Issue 351 in protobuf: Make protobuf_lite proto files not create any static initializers

2012-02-08 Thread protobuf
Comment #7 on issue 351 by pli...@google.com: Make protobuf_lite proto files not create any static initializers http://code.google.com/p/protobuf/issues/detail?id=351 I am taking over this issue. Here is a first CL: https://codereview.appspot.com/5643065/ -- You received this message beca

[protobuf] Re: Issue 373 in protobuf: Tests hang/crash/don't pass without RTTI

2012-02-08 Thread protobuf
Comment #2 on issue 373 by van...@gmail.com: Tests hang/crash/don't pass without RTTI http://code.google.com/p/protobuf/issues/detail?id=373 I've figured out that pthread_once() doesn't return. I have no idea what pthread_once has to do with no-rtti... Full stack attached. Attachments:

[protobuf] Re: Issue 373 in protobuf: Tests hang/crash/don't pass without RTTI

2012-02-08 Thread protobuf
Comment #3 on issue 373 by van...@gmail.com: Tests hang/crash/don't pass without RTTI http://code.google.com/p/protobuf/issues/detail?id=373 Oh, it's an old bug: https://groups.google.com/d/topic/protobuf/w6uwDA2PQH4/discussion Isn't it fixed yet? -- You received this message because you