[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf
Comment #8 on issue 607 by gli...@chromium.org: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 Niall, which Clang version are you using? Clang 3.5 must have this header (in fact we've just checked

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf
Comment #9 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 I would assume at the time of report I would be running 3.4 as 3.5 wasn't out yet. Actually, until that

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf
Updates: Owner: xiaof...@google.com Comment #10 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 Yes, I think we need to make the header work on Clang 3.4

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf
Comment #11 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 I can verify someone else's work after they have tested it themselves. I don't believe I am authorised by

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-07-07 Thread protobuf
Comment #5 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Can you revert this patch please? I don't have the header file sanitizer/tsan_interface_atomic.h on my

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-07-07 Thread protobuf
Comment #6 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Hi Niall, Do you mean the Clang version you installed supports ThreadSanitizer but without header file

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-07-07 Thread protobuf
Comment #7 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Correct, Ubuntu's clang supports ThreadSanitiser but without the header file mentioned. You can see the CI

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-03-24 Thread protobuf
Comment #3 on issue 607 by gli...@chromium.org: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Ping? -- You received this message because this project is configured to send all issue notifications

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-03-24 Thread protobuf
Updates: Status: Fixed Comment #4 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Committed as r521 -- You received this message because this project is

[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-02-18 Thread protobuf
Comment #1 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Where does this header file come from? Does it mean that users will need to install these header files