Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Rafael Schloming
On Mon, Sep 10, 2012 at 3:38 PM, Andrew Stitcher wrote: > On Mon, 2012-09-10 at 15:28 -0400, Rafael Schloming wrote: > > On Mon, Sep 10, 2012 at 3:23 PM, Andrew Stitcher >wrote: > > > > > On Mon, 2012-09-10 at 15:01 -0400, Rafael Schloming wrote: > > > > Can you comment on why you decided to inli

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Andrew Stitcher
On Mon, 2012-09-10 at 15:28 -0400, Rafael Schloming wrote: > On Mon, Sep 10, 2012 at 3:23 PM, Andrew Stitcher wrote: > > > On Mon, 2012-09-10 at 15:01 -0400, Rafael Schloming wrote: > > > Can you comment on why you decided to inline it directly into the C > > header > > > files as opposed to split

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Rafael Schloming
On Mon, Sep 10, 2012 at 3:23 PM, Andrew Stitcher wrote: > On Mon, 2012-09-10 at 15:01 -0400, Rafael Schloming wrote: > > Can you comment on why you decided to inline it directly into the C > header > > files as opposed to splitting it out somehow? Given William's comment on > > exceptions, it seem

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Andrew Stitcher
On Mon, 2012-09-10 at 15:01 -0400, Rafael Schloming wrote: > Can you comment on why you decided to inline it directly into the C header > files as opposed to splitting it out somehow? Given William's comment on > exceptions, it seems like it might well expand/evolve enough to make it > awkward to i

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread William Henry
- Original Message - > On Mon, 2012-09-10 at 14:16 -0400, William Henry wrote: > > It looks very attractive. Any plans to include exceptions? > > I was debating exceptions: On the one hand I wanted a very slim layer > with no hidden code - what is there now will pretty much compile > dir

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Rafael Schloming
Can you comment on why you decided to inline it directly into the C header files as opposed to splitting it out somehow? Given William's comment on exceptions, it seems like it might well expand/evolve enough to make it awkward to inline. --Rafael On Mon, Sep 10, 2012 at 2:47 PM, Andrew Stitcher

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Andrew Stitcher
On Mon, 2012-09-10 at 14:16 -0400, William Henry wrote: > It looks very attractive. Any plans to include exceptions? I was debating exceptions: On the one hand I wanted a very slim layer with no hidden code - what is there now will pretty much compile directly in to the same code as the equivalent

Re: First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread William Henry
It looks very attractive. Any plans to include exceptions? (I like the use of 'auto' keyword. Had not seen it in code like this before.) William - Original Message - > There is no proton group in reviewboard, so I'm forwarding this here > for > comment. > > Andrew > >

First cut at a C++ "binding" for proton comments please [Fwd: Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t]

2012-09-10 Thread Andrew Stitcher
There is no proton group in reviewboard, so I'm forwarding this here for comment. Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6929/ -