Re: ProtonJ compilation and test failures

2015-07-06 Thread Rafael Schloming
I just ran a maven-only clean build locally with no problems. You should have PN_MILLIS_MAX defined in proton-j/src/main/resources/ctypes.py, and this should be imported from proton-j/src/main/resources/cproton.py. Can you verify that this is as expected? --Rafael On Mon, Jul 6, 2015 at 5:50

ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
The recent changes on Proton-J seemed to have created some issues: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/1032/console The module currently requries Java 7 to compile, which is a slightly out of sync with the compiler source+target still being set to Java 6 (which the

Re: ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
Were you running it after having previously used the cmake build in the same terminal? I do indeed have the definition in ctypes, with the cproton file importing everything from ctypes. The maven build failed when I ran it directly in my git-clean'ed checkout. It then passed when run indirectly

Re: ProtonJ compilation and test failures

2015-07-06 Thread Rafael Schloming
Can you try doing an mvn clean and seeing if it is still an issue? A class entirely missing like that is usually due to mvn not recompiling everything that is impacted by a given change. --Rafael On Mon, Jul 6, 2015 at 8:11 AM, Gordon Sim g...@redhat.com wrote: All the ProtonJInterop tests

Re: ProtonJ compilation and test failures

2015-07-06 Thread Gordon Sim
All the ProtonJInterop tests fail for me, and the python-test then hangs. The error for each is something like: 2: proton_tests.reactor_interop.ReactorInteropTest. \ 2: Error: Could not find or load main class org.apache.qpid.proton.ProtonJInterop 2: test_protonc_to_protonj_1

Re: ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
That seemed to do the trick. Running the maven build in a clean checkout in clean terminal now works, so long as you use a version of Java able to build the recent source; the compilation issue is still there otherwise: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-c/

Re: ProtonJ compilation and test failures

2015-07-06 Thread Rafael Schloming
Can you do a git pull and give it another shot? I believe what is happening is that when maven launches the jython tests, it doesn't seem to include the jython shim in the class path. For some reason, this isn't an issue of the .class files that jython generates are hanging around in the source

Re: ProtonJ compilation and test failures

2015-07-06 Thread Gordon Sim
On 07/06/2015 01:24 PM, Rafael Schloming wrote: Can you try doing an mvn clean and seeing if it is still an issue? I see the same thing after mvn clean

Re: ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
On 6 July 2015 at 14:17, Gordon Sim g...@redhat.com wrote: On 07/06/2015 01:24 PM, Rafael Schloming wrote: Can you try doing an mvn clean and seeing if it is still an issue? I see the same thing after mvn clean Does cleaning the checkout as a whole make any difference? To preview what

Re: ProtonJ compilation and test failures

2015-07-06 Thread aconway
On Mon, 2015-07-06 at 16:48 +0100, Gordon Sim wrote: On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really should be a compile time exception, which I think means you must have stale class files *somewhere*. You could try doing a find checkout -name *.class

Re: ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
On 6 July 2015 at 16:48, Gordon Sim g...@redhat.com wrote: On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really should be a compile time exception, which I think means you must have stale class files *somewhere*. You could try doing a find checkout -name *.class

Re: ProtonJ compilation and test failures

2015-07-06 Thread aconway
On Mon, 2015-07-06 at 17:31 +0100, Gordon Sim wrote: On 07/06/2015 05:22 PM, aconway wrote: On Mon, 2015-07-06 at 16:48 +0100, Gordon Sim wrote: On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really should be a compile time exception, which I think

Re: ProtonJ compilation and test failures

2015-07-06 Thread Robbie Gemmell
On 6 July 2015 at 18:24, aconway acon...@redhat.com wrote: On Mon, 2015-07-06 at 17:31 +0100, Gordon Sim wrote: On 07/06/2015 05:22 PM, aconway wrote: On Mon, 2015-07-06 at 16:48 +0100, Gordon Sim wrote: On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really

Re: ProtonJ compilation and test failures

2015-07-06 Thread Gordon Sim
On 07/06/2015 05:22 PM, aconway wrote: On Mon, 2015-07-06 at 16:48 +0100, Gordon Sim wrote: On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really should be a compile time exception, which I think means you must have stale class files *somewhere*. You could try doing

Re: ProtonJ compilation and test failures

2015-07-06 Thread Gordon Sim
On 07/06/2015 04:08 PM, Rafael Schloming wrote: Any sort of missing class really should be a compile time exception, which I think means you must have stale class files *somewhere*. You could try doing a find checkout -name *.class just as a sanity check. I have deleted all the .class files

Re: ProtonJ compilation and test failures

2015-07-06 Thread Rafael Schloming
Any sort of missing class really should be a compile time exception, which I think means you must have stale class files *somewhere*. You could try doing a find checkout -name *.class just as a sanity check. Also, it's possible something in your local maven repo is somehow coming into play, maybe

Re: ProtonJ compilation and test failures

2015-07-06 Thread Gordon Sim
On 07/06/2015 02:23 PM, Robbie Gemmell wrote: On 6 July 2015 at 14:17, Gordon Sim g...@redhat.com wrote: On 07/06/2015 01:24 PM, Rafael Schloming wrote: Can you try doing an mvn clean and seeing if it is still an issue? I see the same thing after mvn clean Does cleaning the checkout as