Re: [VOTE] merge the proton mailing list into the users/dev lists

2016-03-30 Thread Rob Godfrey
+1 Additionally it might make sense to write a paragraph somewhere on suggestions for best practice on mailing the list (like including components / languages in use in the title or the body of the e-mail :-) ). -- Rob On 30 March 2016 at 11:25, Robbie Gemmell wrote: > Hello folks, > > Many mo

[jira] [Commented] (PROTON-1135) [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default

2016-03-28 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214500#comment-15214500 ] Rob Godfrey commented on PROTON-1135: - As a co-author of the AMQP specificatio

[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login

2016-02-17 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150836#comment-15150836 ] Rob Godfrey commented on PROTON-1136: - Fair enough then - having default to of

[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login

2016-02-17 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150817#comment-15150817 ] Rob Godfrey commented on PROTON-1136: - Yeah - I'd agree that it'd be

[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login

2016-02-17 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150790#comment-15150790 ] Rob Godfrey commented on PROTON-1136: - Presumably this issue is not restricte

Re: [VOTE] Release RC 3 as Qpid Proton 0.12.0

2016-02-10 Thread Rob Godfrey
To be pedantic, only PMC members votes are officially considered binding [1], and votes from committers who are not on the PMC are not... However in general as a community we would encourage anyone who has done any sort of validation of the release to provide their feedback via (non-binding) voting

Re: AMQP 1.0 session outgoing-window usage / meaning

2015-07-08 Thread Rob Godfrey
As far as I can recall/reconstruct the only utility given by the outgoing window was so that the sender (of transfer frames) can indicate to the receiver (of transfer frames) that it will require notification of which frames have been seen by the receiver within frames, otherwise the sender will p

[jira] [Updated] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?

2014-09-23 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-576: --- Attachment: PROTON-576.patch I've changed the test a bit (so that it covers other values and not

Re: improving cross language maintainability

2014-01-07 Thread Rob Godfrey
On 20 December 2013 19:49, Rafael Schloming wrote: > On Fri, Dec 20, 2013 at 11:43 AM, Fraser Adams < > fraser.ad...@blueyonder.co.uk> wrote: > > > I've been following this thread with interest and I guess that Rob's > > comment > > > > > > " > > > > However I think that would require us to be >

Re: improving cross language maintainability

2013-12-20 Thread Rob Godfrey
Since I have pretty much given up on trying to work on proton, I'm not sure that my opinion counts for much anymore... however I suppose I'm a little curious how the JNI binding differs in "extra work" vs. PHP or Ruby or such. Similarly why the API distinction is "hasty" when again it should (modul

Re: proton-j API factory simplification.

2013-08-02 Thread Rob Godfrey
Given the Proton class doesn't require the user to know which implementation they are using (but allows them to explicitly ask for a particular implementation type if they so desire) I'm a little confused how adding the requirement for the user to instantiate an implementation specific class actual

[jira] [Created] (PROTON-359) [Proton-j] Create a simple entry point for creating all Proton entities

2013-07-18 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-359: -- Summary: [Proton-j] Create a simple entry point for creating all Proton entities Key: PROTON-359 URL: https://issues.apache.org/jira/browse/PROTON-359 Project: Qpid

[jira] [Created] (PROTON-358) [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order

2013-07-18 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-358: -- Summary: [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order Key: PROTON-358 URL: https://issues.apache.org/jira/browse/PROTON

[jira] [Resolved] (PROTON-358) [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order

2013-07-18 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-358. Resolution: Fixed > [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due

Re: Qpid-specific logging facade(s) for Proton etc

2013-06-25 Thread Rob Godfrey
So, my main comment would be that I think the Factories should not be depending on the MessageLoggerSpi as you've defined it, but instead purely on EngineLogger. The MessageLogger stuff is a convenience but I don't think it should be mandatory to use it. My other comment would be that I don't thi

Re: Data interface in Proton-J

2013-06-18 Thread Rob Godfrey
067 <https://svn.apache.org/r1494067> >> [2] >> https://issues.apache.org/**jira/browse/PROTON-339<https://issues.apache.org/jira/browse/PROTON-339> >> >> >> On 14 June 2013 16:13, Rob Godfrey wrote: >> >> T >>> >> [...] >

Re: Data interface in Proton-J

2013-06-18 Thread Rob Godfrey
ttach comments/patch files to the JIRA [2]. Hope this helps, Rob [1] https://svn.apache.org/r1494067 [2] https://issues.apache.org/jira/browse/PROTON-339 On 14 June 2013 16:13, Rob Godfrey wrote: > That would be great! > > Let me have a dig around over the weekend and see if I can find it (

[jira] [Created] (PROTON-339) [Proton-J] Implement Data interface in pure Java

2013-06-18 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-339: -- Summary: [Proton-J] Implement Data interface in pure Java Key: PROTON-339 URL: https://issues.apache.org/jira/browse/PROTON-339 Project: Qpid Proton Issue Type

Re: Data interface in Proton-J

2013-06-14 Thread Rob Godfrey
That would be great! Let me have a dig around over the weekend and see if I can find it (I have *lots* of machines where it might be on :-( I should probably be more organised). Cheers, Rob On 14 June 2013 16:01, Leon Mlakar wrote: > > Hi Rob, > > thanks for reply. It got me thinking ... sin

Re: Data interface in Proton-J

2013-06-14 Thread Rob Godfrey
Hi Leon, As you have noticed a pure Java implementation of the Data interface is not yet available (I think I have a 30% complete implementation sitting somewhere on an old laptop, but I never got round to finishing it). It will get implemented eventually, but it's not currently being worked on a

[jira] [Resolved] (PROTON-60) Support configuring the max frame size.

2013-06-12 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-60. --- Resolution: Fixed Assignee: Rob Godfrey (was: Philip Harvey) > Support configuring the

Re: QPID Proton SASL header mismatch: 'AMQP\x01\x01\x00\x0a'

2013-05-27 Thread Rob Godfrey
Since this looks like an issue you are having with the Qpid C++ broker rather than Proton per se, it's probably worth cross-possting this to the Qpid User list -- Rob On 27 May 2013 18:11, Pablo Rodríguez Rey wrote: > Thanks Robbie Gemmel, that's what I suspected. > > I've found the problem th

Re: [VOTE] Subversion to JIRA integration

2013-05-24 Thread Rob Godfrey
QPID: Yes [ X ] No [ ] PROTON: Yes [ X ] No [ ] -- Rob On 24 May 2013 13:03, Robbie Gemmell wrote: > Hi all, > > As some of you will already know, a mail was sent to committers@a.oearlier > outlining some of the newer services ASF infra offer that we may not know > about. One in particular s

Re: Defining the behaviour of Proton Engine API under error conditions

2013-03-28 Thread Rob Godfrey
On 28 March 2013 02:45, Rafael Schloming wrote: > On Wed, Mar 27, 2013 at 6:34 PM, Rob Godfrey >wrote: > > > On 27 March 2013 21:16, Rafael Schloming wrote: > > > On Wed, Mar 27, 2013 at 11:53 AM, Keith W > wrote: > > > > > > > [..snip..] > &

Re: Defining the behaviour of Proton Engine API under error conditions

2013-03-27 Thread Rob Godfrey
On 27 March 2013 21:16, Rafael Schloming wrote: > On Wed, Mar 27, 2013 at 11:53 AM, Keith W wrote: > [..snip..] > >> 3. How will the application using top half API know an error has >> occured? What are the application's responsibilities when it learns of >> an error? >> > > The transport has a

[jira] [Commented] (PROTON-160) Allow open.hostname to be configured independently of network hostname

2013-03-10 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598301#comment-13598301 ] Rob Godfrey commented on PROTON-160: I'm somewhat late to this party,

[jira] [Created] (PROTON-269) Connect Redirect parsing incorrectly uses position in map rather than value of key

2013-03-10 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-269: -- Summary: Connect Redirect parsing incorrectly uses position in map rather than value of key Key: PROTON-269 URL: https://issues.apache.org/jira/browse/PROTON-269 Project

Re: put vs. send

2013-03-06 Thread Rob Godfrey
> > Whether that's reported as an error is really a choice of the bindings. In > C it's all just return codes. We could add a separate non-blocking flag > that causes the blocking operations to return distinct error codes, i.e. > the equivalent of EWOULDBLOCK, but I don't think this makes a whole l

Re: put vs. send

2013-03-06 Thread Rob Godfrey
On 6 March 2013 13:26, Rafael Schloming wrote: > On Wed, Mar 6, 2013 at 1:44 AM, Rob Godfrey wrote: > >> On 5 March 2013 21:10, Rafael Schloming wrote: >> > On Tue, Mar 5, 2013 at 11:24 AM, Ted Ross wrote: >> >> [.. snip ..] >> >> > >> >

[jira] [Commented] (PROTON-262) Fully implement (error) condtion API in Proton-J

2013-03-06 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594695#comment-13594695 ] Rob Godfrey commented on PROTON-262: 2) Whilst I see that http://docs.o

Re: put vs. send

2013-03-06 Thread Rob Godfrey
On 5 March 2013 21:10, Rafael Schloming wrote: > On Tue, Mar 5, 2013 at 11:24 AM, Ted Ross wrote: [.. snip ..] > > It isn't really possible to have "put" cause messages to be eventually sent > without a background thread, something we don't currently have. I think it's this that is what makes

Re: can't assign Jira

2013-03-05 Thread Rob Godfrey
You should be able to assign JIRAs to yourself now -- Rob On 5 March 2013 16:50, Michael Goulish wrote: > I created PROTON-260, but I can't seem to assign it to myself. > Do I need some new permissions to do this? >

[jira] [Assigned] (PROTON-262) Fully implement (error) condtion API in Proton-J

2013-03-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned PROTON-262: -- Assignee: Keith Wall (was: Rob Godfrey) > Fully implement (error) condtion API in Pro

[jira] [Created] (PROTON-262) Fully implement (error) condtion API in Proton-J

2013-03-05 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-262: -- Summary: Fully implement (error) condtion API in Proton-J Key: PROTON-262 URL: https://issues.apache.org/jira/browse/PROTON-262 Project: Qpid Proton Issue Type

Re: Need help Re: jenkins interop test failing due to PROTON-215 commits?

2013-02-27 Thread Rob Godfrey
On 27 February 2013 23:28, Alan Conway wrote: > On Wed, 2013-02-27 at 11:19 +, Phil Harvey wrote: >> Hi, >> >> I notice that proton-jni on Jenkins is failing [1] , probably due to the >> recent PROTON-215 commits. >> >> The failing test is: >> proton_tests.interop.InteropTest.test_message

Re: jenkins interop test failing due to PROTON-215 commits?

2013-02-27 Thread Rob Godfrey
notificati...@qpid.apache.org -- Rob On 27 February 2013 21:51, Alan Conway wrote: > On Wed, 2013-02-27 at 11:19 +, Phil Harvey wrote: >> Hi, >> >> I notice that proton-jni on Jenkins is failing [1] , probably due to the >> recent PROTON-215 commits. >> >> The failing test is: >> proton_test

[jira] [Updated] (PROTON-214) Test "proton_tests.messenger.MessengerTest.testSendBogus" failed

2013-02-27 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-214: --- Attachment: JNIMessenger.patch Attached a small patch for the JNIMessenger to throw a relevant

Re: [RESULT] [VOTE] 0.4 RC3

2013-02-26 Thread Rob Godfrey
+1 we should have a tag in the repo for each of our releases -- Rob On 26 February 2013 20:34, Rajith Attapattu wrote: > Rafi, > > I don't want to sound pedantic, but we should tag our releases as per > the guidelines provided by Apache. > The previous releases don't have tags either (at least t

Re: Testing types in a message

2013-02-15 Thread Rob Godfrey
On 15 February 2013 19:17, Alan Conway wrote: > On Fri, 2013-02-15 at 17:22 +0100, Rob Godfrey wrote: >> Of course, if you are using the Message class then there's really no >> reason to go to the codec directly. you can just use Java >> Maps/Lists/Arrays etc, along wi

Re: Testing types in a message

2013-02-15 Thread Rob Godfrey
ation. -- Rob On 15 February 2013 17:03, Rob Godfrey wrote: > Hi Alan, > > you can use the java Encoder/Decoders directly like this: > > import org.apache.qpid.proton.codec.EncoderImpl; > import org.apache.qpid.proton.codec.DeccoderImpl; > > ... > > > Byt

Re: Testing types in a message

2013-02-15 Thread Rob Godfrey
Hi Alan, you can use the java Encoder/Decoders directly like this: import org.apache.qpid.proton.codec.EncoderImpl; import org.apache.qpid.proton.codec.DeccoderImpl; ... ByteBuffer buf = ByteBuffer.allocate(2048); DecoderImpl decoder = new DecoderImpl(); EncoderImpl en

Re: Parallel Maven and CMake build systems for Proton

2013-02-15 Thread Rob Godfrey
On 15 February 2013 11:27, Rob Godfrey wrote: > > 2) The CMake system will not be required to perform dynamic dependency > resolution > > I should probably have phrased that one better... What I meant is that (unlike maven) we're not looking for the CMake build to go an

Re: Parallel Maven and CMake build systems for Proton

2013-02-15 Thread Rob Godfrey
A few of supplementary points: 1) The CMake system will not be required to generate pom files or deploy to maven repositories. 2) The CMake system will not be required to perform dynamic dependency resolution 3) The CMake system will not be required to integrate with other build/test tooling (cove

[jira] [Updated] (PROTON-61) Need a means of specifying and reading connection capabilities & properties

2013-02-14 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-61: -- Assignee: Rafael H. Schloming (was: Rob Godfrey) > Need a means of specifying and read

[jira] [Commented] (PROTON-61) Need a means of specifying and reading connection capabilities & properties

2013-02-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577489#comment-13577489 ] Rob Godfrey commented on PROTON-61: --- Access to connection capabilities has been adde

[jira] [Resolved] (PROTON-192) Implement Proton-JNI binding for proton-c

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-192. Resolution: Fixed > Implement Proton-JNI binding for proto

[jira] [Updated] (PROTON-184) [Proton-J] Separate API from Pure Java Implementation

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-184: --- Fix Version/s: 0.4 > [Proton-J] Separate API from Pure Java Implementat

[jira] [Resolved] (PROTON-184) [Proton-J] Separate API from Pure Java Implementation

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-184. Resolution: Fixed > [Proton-J] Separate API from Pure Java Implementat

[jira] [Commented] (PROTON-147) Don't send a Sender Disposition until the all the transfers for a delivery have been sent.

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575874#comment-13575874 ] Rob Godfrey commented on PROTON-147: IIRC after discussion I think we concluded

[jira] [Updated] (PROTON-110) java.lang.NullPointerException: the handle field is mandatory

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-110: --- Assignee: Keith Wall > java.lang.NullPointerException: the handle field is mandat

[jira] [Updated] (PROTON-99) Porting Issue -- pn_dtag macro does not compile with Visual Studio compiler

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-99: -- Fix Version/s: 0.4 > Porting Issue -- pn_dtag macro does not compile with Visual Studio compi

[jira] [Commented] (PROTON-109) Proton should handle inbound max-frame size violations.

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575846#comment-13575846 ] Rob Godfrey commented on PROTON-109: proton-j will also need this change impleme

[jira] [Updated] (PROTON-109) Proton should handle inbound max-frame size violations.

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-109: --- Component/s: proton-j > Proton should handle inbound max-frame size violati

[jira] [Updated] (PROTON-98) Porting Issue -- Visual Studio compiler requires explicit casts

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-98: -- Fix Version/s: 0.4 > Porting Issue -- Visual Studio compiler requires explicit ca

[jira] [Updated] (PROTON-68) Porting Issue -- dll imports and exports on Visual Studio

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-68: -- Fix Version/s: 0.4 > Porting Issue -- dll imports and exports on Visual Stu

[jira] [Updated] (PROTON-66) Driver implementation for proton-j

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-66: -- Assignee: Gordon Sim > Driver implementation for proto

[jira] [Updated] (PROTON-66) Driver implementation for proton-j

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-66: -- Fix Version/s: 0.4 > Driver implementation for proto

[jira] [Updated] (PROTON-61) Need a means of specifying and reading connection capabilities & properties

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-61: -- Fix Version/s: 0.4 > Need a means of specifying and reading connection capabilities & pro

[jira] [Updated] (PROTON-61) Need a means of specifying and reading connection capabilities & properties

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-61: -- Assignee: Rob Godfrey > Need a means of specifying and reading connection capabilities & pro

[jira] [Updated] (PROTON-58) NullPointerException on receiver.recv(...)

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-58: -- Assignee: Keith Wall > NullPointerException on receiver.r

[jira] [Updated] (PROTON-60) Support configuring the max frame size.

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-60: -- Assignee: Philip Harvey > Support configuring the max frame s

[jira] [Updated] (PROTON-60) Support configuring the max frame size.

2013-02-11 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-60: -- Fix Version/s: 0.4 > Support configuring the max frame s

[jira] [Reopened] (PROTON-219) Move Cmake modules to the tools directory

2013-02-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reopened PROTON-219: The cmake directory (and its sub-sirs) are still present see: svn.apache.org/repos/asf/qpid/proton

[jira] [Commented] (PROTON-192) Implement Proton-JNI binding for proton-c

2013-02-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571230#comment-13571230 ] Rob Godfrey commented on PROTON-192: Improved the implementation of JNIMessag

[jira] [Reopened] (PROTON-192) Implement Proton-JNI binding for proton-c

2013-02-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reopened PROTON-192: Assignee: Rob Godfrey (was: Keith Wall) > Implement Proton-JNI binding for proto

Re: svn commit: r1442155 - in /qpid/proton/trunk: cmake/Modules/ tools/ tools/cmake/ tools/cmake/Modules/

2013-02-04 Thread Rob Godfrey
This commit a) broke the build for Java using cmake (since the module files could no longer be found) b) should have been JIRAd (and perhaps reviewed / discussed before commiting) c) didn't even remove the "offensive" cmake directory at the root of proton, but just left it (and its subdirectory) e

Re: Changing the Proton build system to accommodate jni bindings

2013-01-25 Thread Rob Godfrey
No duplication of the proton-api code. >> > >> > - The source tarball will in the future be generated from the top >> > level, >> > rather than from the proton-c folder. This avoids the issues >> > previously >> > discussed whereby JNI

[jira] [Commented] (PROTON-156) [proton-j] Detach close field is not being set to true.

2013-01-25 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562791#comment-13562791 ] Rob Godfrey commented on PROTON-156: applied as revision 1438559

[jira] [Resolved] (PROTON-156) [proton-j] Detach close field is not being set to true.

2013-01-25 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-156. Resolution: Fixed Assignee: Rob Godfrey > [proton-j] Detach close field is not being

Re: Reducing the visibility of proton-j constructors

2013-01-25 Thread Rob Godfrey
Fri, Jan 25, 2013 at 9:39 AM, Rob Godfrey wrote: > >> In general dependency on implementation is bad, dependency on interface is >> better. One of the problems we've had with Qpid historically is it become >> hard to test as we have dependencies on implementation everywhere

Re: Reducing the visibility of proton-j constructors

2013-01-25 Thread Rob Godfrey
have a very clear way to get the implementation that provides these, without ever having to cast. -- Rob On 24 January 2013 20:03, Rafael Schloming wrote: > On Thu, Jan 24, 2013 at 5:06 AM, Rob Godfrey >wrote: > > > On 23 January 2013 17:36, Phil Harvey wrote: > > &g

Re: Changing the Proton build system to accommodate jni bindings

2013-01-24 Thread Rob Godfrey
On 24 January 2013 15:49, Rafael Schloming wrote: > On Wed, Jan 23, 2013 at 6:44 PM, Rob Godfrey wrote: > >> Firstly I think it would be helpful if you made clear the requirements you >> consider to be essential, nice to have, unimportant and/or detrimental. >> >

Re: Changing the Proton build system to accommodate jni bindings

2013-01-24 Thread Rob Godfrey
On 24 January 2013 14:43, Rafael Schloming wrote: > On Wed, Jan 23, 2013 at 6:10 PM, Rob Godfrey wrote: > >> On 23 January 2013 19:09, Rafael Schloming wrote: >> >> > I've added another wiki page that documents the proton release steps as >> > best I can

Re: Reducing the visibility of proton-j constructors

2013-01-24 Thread Rob Godfrey
On 23 January 2013 17:36, Phil Harvey wrote: > > As part of the Proton JNI work, I would like to remove all calls to > proton-j implementation constructors from "client code". I intend that > factories will be used instead [1], thereby abstracting away whether the > implementation is pure Java or

Re: Changing the Proton build system to accommodate jni bindings

2013-01-23 Thread Rob Godfrey
Firstly I think it would be helpful if you made clear the requirements you consider to be essential, nice to have, unimportant and/or detrimental. On 23 January 2013 20:17, Rafael Schloming wrote: > On Wed, Jan 23, 2013 at 8:01 AM, Keith W wrote: > > > Essential > > > > 3. To change proton-api

Re: Changing the Proton build system to accommodate jni bindings

2013-01-23 Thread Rob Godfrey
On 23 January 2013 19:09, Rafael Schloming wrote: > I've added another wiki page that documents the proton release steps as > best I can remember. I'll updated it more during the 0.4 release: > https://cwiki.apache.org/confluence/display/qpid/Proton+Release+Steps > > I think it's important to und

Re: Changing the Proton build system to accommodate jni bindings

2013-01-22 Thread Rob Godfrey
On 22 January 2013 13:47, Rafael Schloming wrote: > On Tue, Jan 22, 2013 at 4:22 AM, Rob Godfrey >wrote: > > > On 21 January 2013 18:05, Rafael Schloming wrote: > > > > > On Mon, Jan 21, 2013 at 9:33 AM, Rob Godfrey > > >wrote: > > > > >

Re: Changing the Proton build system to accommodate jni bindings

2013-01-22 Thread Rob Godfrey
On 21 January 2013 18:05, Rafael Schloming wrote: > On Mon, Jan 21, 2013 at 9:33 AM, Rob Godfrey >wrote: > > > Ummm... it's a dependency... you're familiar with those, yeah? > > > > The same way that the Qpid JMS clients depend on a JMS API jar, for whic

Re: Changing the Proton build system to accommodate jni bindings

2013-01-21 Thread Rob Godfrey
On 21 January 2013 15:11, Rafael Schloming wrote: > On Mon, Jan 21, 2013 at 7:10 AM, Rob Godfrey >wrote: > > > > > > > > > > This results in something that is quite awkward for the C build. For > > one > > > > thing I'

Re: mailing lists and fragmented communication

2013-01-21 Thread Rob Godfrey
On 21 January 2013 12:43, Robbie Gemmell wrote: > I'm happy enough with the idea of collapsing proton@ given that Protons > scope is in some ways wider than when it started out (where the very > specific protocol library made a good case for a separate list), but I > don't think that list being s

Re: Changing the Proton build system to accommodate jni bindings

2013-01-21 Thread Rob Godfrey
> > > This results in something that is quite awkward for the C build. For one > > thing I'm not sure an svn export of the proton-c directory would be > > considered releasable under this scheme as it would include the java > > binding, but not the source code necessary to build it, and apache pol

Re: inconsistent proton library names?

2013-01-07 Thread Rob Godfrey
I've not looked at the branch lately (only just back from vacation), but I would very much hope that there would be nothing preventing having both the JNI and native-Java libraries in the classpath, and allowing for explicit creation of the desired implementation of Connection / Messenger / whateve

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
On 14 December 2012 01:02, Weston M. Price wrote: > > On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: > > > A couple of comments... > > > > On 13 December 2012 23:37, Justin wrote: > > > >> API usability is important and deserves attention. >

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
A couple of comments... On 13 December 2012 23:37, Justin wrote: > API usability is important and deserves attention. > > > > pn_link_drain > > Existing C name:pn_link_drain > Proposed C name:pn_link_rescind_credit > Existing Java name: Receiver.drain > Proposed Java

[jira] [Resolved] (PROTON-127) Rename the org.apache.qpid.proton.type package for nicer Scala support

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-127. Resolution: Fixed Fix Version/s: 0.3 The type package has been removed. The public API

[jira] [Assigned] (PROTON-127) Rename the org.apache.qpid.proton.type package for nicer Scala support

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned PROTON-127: -- Assignee: Rob Godfrey > Rename the org.apache.qpid.proton.type package for nicer Sc

[jira] [Commented] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531400#comment-13531400 ] Rob Godfrey commented on PROTON-186: Patch applied (with modifications) to add

[jira] [Created] (PROTON-184) [Proton-J] Separate API from Pure Java Implementation

2012-12-12 Thread Rob Godfrey (JIRA)
Rob Godfrey created PROTON-184: -- Summary: [Proton-J] Separate API from Pure Java Implementation Key: PROTON-184 URL: https://issues.apache.org/jira/browse/PROTON-184 Project: Qpid Proton Issue

[jira] [Resolved] (PROTON-117) Consider replacing org.apache.qpid.proton.engine.Sequence with java.util.Iterator

2012-12-07 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-117. Resolution: Fixed Fix Version/s: 0.3 Assignee: Rob Godfrey > Consi

[jira] [Resolved] (PROTON-175) engine.Outcome and sub interfaces not used by proton-j, they should be deleted.

2012-12-07 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-175. Resolution: Fixed Fix Version/s: 0.3 Removed these as well as a few other unused interfaces

[jira] [Resolved] (PROTON-179) proton-j - replace system.out and system.err calls with java.util.logging

2012-12-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-179. Resolution: Fixed Patch applied in revision 1417602. > proton-j - repl

[jira] [Commented] (PROTON-172) Implement SSL within proton-j

2012-12-05 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510711#comment-13510711 ] Rob Godfrey commented on PROTON-172: Reviewed and applied 0001-PROTON-172-refact

Re: SSL related noise in tests? (was Re: Proton 0.3 ETA?)

2012-12-05 Thread Rob Godfrey
Yes - I'm sure Phil is working on a patch to remove this, the longer term solution being to add some sort of cross-platform logging support -- Rob On 5 December 2012 15:40, Gordon Sim wrote: > On 12/05/2012 01:56 PM, Gordon Sim wrote: > >> On 12/05/2012 01:09 PM, Hiram Chirino wrote: >> >>> We

[jira] [Commented] (PROTON-154) link attach, detach, attach sequence on single session does not result in a new link for the 2nd attach

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507406#comment-13507406 ] Rob Godfrey commented on PROTON-154: I've applied the patch for prot

[jira] [Resolved] (PROTON-173) Message annotations not properly encoded

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-173. Resolution: Fixed Fix Version/s: 0.3 Assignee: Rob Godfrey Patch applied

[jira] [Resolved] (PROTON-115) Expose API to access link name.

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-115. Resolution: Fixed > Expose API to access link n

[jira] [Resolved] (PROTON-145) 256K Messages do not get transfered properly with a 64k pump size

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-145. Resolution: Fixed Fix Version/s: 0.3 > 256K Messages do not get transfered prope

[jira] [Commented] (PROTON-81) Expose send/receive settle modes

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507224#comment-13507224 ] Rob Godfrey commented on PROTON-81: --- This was resolved in commits 1399329,1399330

[jira] [Updated] (PROTON-81) Expose send/receive settle modes

2012-11-30 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-81: -- Component/s: (was: proton-j) > Expose send/receive settle mo

[jira] [Resolved] (PROTON-155) [proton-j] Detach toString() does not include the handle field.

2012-11-21 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-155. Resolution: Fixed Fix Version/s: 0.3 > [proton-j] Detach toString() does not incl

  1   2   >