[jira] [Commented] (PROTON-560) Failing to transfer messages more than 4kB via AMQPS

2014-04-30 Thread Denis Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985262#comment-13985262 ] Denis Sokolov commented on PROTON-560: -- Sorry, didn't notice that. > Failing to tran

Re: simplified factory pattern for proton-j

2014-04-30 Thread Rafael Schloming
I forgot to mention, but another part of the reasoning here is that Java 8 is (finally!!!) allowing static methods in interfaces, so the "natural" pattern for this sort of thing would just be Interface.create(...), and while we won't be able to use that for a while, the Interface.Factory.create(...

[jira] [Commented] (PROTON-560) Failing to transfer messages more than 4kB via AMQPS

2014-04-30 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985403#comment-13985403 ] Ken Giusti commented on PROTON-560: --- Glad you reported the problem regardless - feedback

Re: simplified factory pattern for proton-j

2014-04-30 Thread Clebert Suconic
The only issue is that all the users using Proton-j would have to be at least Java8. For instance, I can have maybe my users using Java8 on the server, but they won't migrate all their clients. On Apr 30, 2014, at 6:48 AM, Rafael Schloming wrote: > I forgot to mention, but another part of the

Re: Optimizations on Proton-j

2014-04-30 Thread Clebert Suconic
@Rafi: I see there is a patch review process within Apache (based on your other thread on Java8) Should we make this through the patch process at some point? On Apr 29, 2014, at 4:04 PM, Clebert Suconic wrote: > > On Apr 29, 2014, at 4:00 PM, Rafael Schloming wrote: >>> >>> Notice that th

[jira] [Commented] (PROTON-560) Failing to transfer messages more than 4kB via AMQPS

2014-04-30 Thread Denis Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985424#comment-13985424 ] Denis Sokolov commented on PROTON-560: -- Ken, you will laugh, but it is me again. The

Re: simplified factory pattern for proton-j

2014-04-30 Thread Rafael Schloming
Right, I wasn't suggesting the proton codebase use Java 8 anytime soon (I would think not until Java 7 is EOLed), just that if a Java 8 codebase uses proton-j then the idioms will be a little bit closer to each other. --Rafael On Wed, Apr 30, 2014 at 8:33 AM, Clebert Suconic wrote: > The only i

Re: simplified factory pattern for proton-j

2014-04-30 Thread Clebert Suconic
Ah.. I see. I looked at the patch and I liked it. One thing I don't like on the current codebase is the implementations as inner classes on Interfaces.. (e.g. WriteableBuffer)... I would suggest making it a separate class. but on this case it makes a lot of sense I looked at the patch

Re: Optimizations on Proton-j

2014-04-30 Thread Rafael Schloming
On Wed, Apr 30, 2014 at 8:35 AM, Clebert Suconic wrote: > @Rafi: I see there is a patch review process within Apache (based on your > other thread on Java8) > > Should we make this through the patch process at some point? > I'm fine looking at it on your git branch, but if you'd like to play wit

Re: Optimizations on Proton-j

2014-04-30 Thread Robbie Gemmell
I think anyone can sign up for ReviewBoard themselves. It certainly didn't used to be linked to the ASF LDAP in the past, presumably for that reason. Its probably also worth noting you can initiate pull requests against the github mirrors. If it hasn't already been done for the proton mirror, we c

[jira] [Commented] (PROTON-407) [proton-c] Windows install does not install .lib nor .pdb files

2014-04-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985639#comment-13985639 ] ASF subversion and git services commented on PROTON-407: Commit 15

[jira] [Commented] (PROTON-560) Failing to transfer messages more than 4kB via AMQPS

2014-04-30 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985800#comment-13985800 ] Ken Giusti commented on PROTON-560: --- The code you're referencing is old. That data poin

Re: Optimizations on Proton-j

2014-04-30 Thread Clebert Suconic
I just submitted it as a git PR: https://github.com/apache/qpid-proton/pull/1 On Apr 30, 2014, at 10:47 AM, Robbie Gemmell wrote: > I think anyone can sign up for ReviewBoard themselves. It certainly didn't > used to be linked to the ASF LDAP in the past, presumably for that reason. > > Its

Re: Messenger.receive(1) causing sluggish behavior

2014-04-30 Thread Ken Giusti
I think this may be a bug in messenger. >From tracing the wire, I see that every time guru sends a reply using the >reply_to field in the message, a completely new session and link are created. >Over time this leads to a large number of sessions and links - one for each >reply message sent. T