I just submitted it as a git PR: https://github.com/apache/qpid-proton/pull/1
On Apr 30, 2014, at 10:47 AM, Robbie Gemmell <[email protected]> wrote: > I think anyone can sign up for ReviewBoard themselves. It certainly didn't > used to be linked to the ASF LDAP in the past, presumably for that reason. > > Its probably also worth noting you can initiate pull requests against the > github mirrors. If it hasn't already been done for the proton mirror, we > can have the emails that would generate be directed to this list (e.g. > http://mail-archives.apache.org/mod_mbox/qpid-dev/201401.mbox/%[email protected]%3E). > We obviously can't merge the pull request via github, but you can use > the reviewing tools etc and the resultant patch can be downloaded or > attached to a JIRA and then applied in the usual fashion (I believe there > is a commit message syntax that can be used to trigger closing the pull > request). > > Robbie > > On 30 April 2014 15:22, Rafael Schloming <[email protected]> wrote: > >> On Wed, Apr 30, 2014 at 8:35 AM, Clebert Suconic <[email protected] >>> wrote: >> >>> @Rafi: I see there is a patch review process within Apache (based on >> your >>> other thread on Java8) >>> >>> Should we make this through the patch process at some point? >>> >> >> I'm fine looking at it on your git branch, but if you'd like to play with >> the review tool then feel free. Just let me know if you need an account >> and I will try to remember how to set one up (or who to bug to get you >> one). ;-) >> >> --Rafael >>
