Re: [Python-Dev] We should be using a tool for code reviews

2010-10-01 Thread Andi Albrecht
Georg Brandl g.bra...@gmx.net writes: Am 30.09.2010 10:22, schrieb Dirkjan Ochtman: On Wed, Sep 29, 2010 at 20:32, Guido van Rossum gu...@python.org wrote: I would like to recommend that the Python core developers start using a code review tool such as Rietveld or Reviewboard. I don't really

Re: [Python-Dev] Celebrating issue #10000

2010-10-01 Thread Tarek Ziadé
On Fri, Oct 1, 2010 at 1:50 AM, Martin v. Löwis mar...@v.loewis.de wrote: Amaury just filed issue #1 yesterday; as counting started with 1000, we are now into 9000 roundup issues. Happy birthday, bugs ! :) ___ Python-Dev mailing list

Re: [Python-Dev] Branching without losing your build products [was: We should be using a tool for code reviews]

2010-10-01 Thread Barry Warsaw
On Oct 01, 2010, at 01:09 PM, Stephen J. Turnbull wrote: Barry Warsaw writes: I should note that I don't particularly like colocated/named branches. I personally much prefer separate directories for each feature or bug I'm working on. It helps me keep track of what I'm doing. I have a

Re: [Python-Dev] Celebrating issue #10000

2010-10-01 Thread Barry Warsaw
On Oct 01, 2010, at 01:50 AM, Martin v. Löwis wrote: Amaury just filed issue #1 yesterday; as counting started with 1000, we are now into 9000 roundup issues. I have become quite fond of roundup over the years, and would like to thank Ka-Ping Yee, Richard Jones, and Erik Forsberg for getting

[Python-Dev] Summary of Python tracker Issues

2010-10-01 Thread Python tracker
ACTIVITY SUMMARY (2010-09-24 - 2010-10-01) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues stats: open2548 (+45) closed 19241 (+50) total 21789 (+67) Open issues with patches:

Re: [Python-Dev] We should be using a tool for code reviews

2010-10-01 Thread Barry Warsaw
On Sep 30, 2010, at 01:46 PM, Brett Cannon wrote: Once we have a good workflow in place we would have to start shifting our development culture towards requiring a review of code no matter who the author is (which I support doing). I should note one other thing, in reference to my previous

Re: [Python-Dev] We should be using a tool for code reviews

2010-10-01 Thread Fred Drake
On Fri, Oct 1, 2010 at 12:31 PM, Barry Warsaw ba...@python.org wrote: I should note one other thing, in reference to my previous posting about reviews.  Launchpad does have a backdoor for getting changes in without formal review.  It's called rubber stamping and shows up in commit messages,

[Python-Dev] PPC Leopard build slave going down for an upgrade

2010-10-01 Thread Bill Janssen
I'm replacing the PPC Leopard build slave with a dual 2GHz G5 machine... Bill ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] Problems with hex-conversion functions

2010-10-01 Thread Arnon Yaari
Hello again. I submitted two patches to resolve the issues from my first post. Patch 9951 - implement bytes.hex (http://bugs.python.org/issue9951) Patch 9996 - fix input and output of binascii functions ( http://bugs.python.org/issue9996) Fix #1 - patch 9951 implements bytes.hex Fix #2 - this is

[Python-Dev] We should be using a tool for code reviews

2010-10-01 Thread Rafe Kaplan
Sorry I am not replying to the original thread with the same name. I've been working on an HG extension for helping with Rietveld code reviews. The main reason is so that Rietveld can remember state (what issue id is being used) and handle the uploading and downloading to Rietveld. The

Re: [Python-Dev] [Python-checkins] r85152 - tracker/instances/python-dev/config.ini.template

2010-10-01 Thread Benjamin Peterson
2010/10/1 martin.v.loewis python-check...@python.org: Author: martin.v.loewis Date: Sat Oct  2 00:57:26 2010 New Revision: 85152 Log: Add django settings to template. Modified:   tracker/instances/python-dev/config.ini.template Modified: tracker/instances/python-dev/config.ini.template

[Python-Dev] issue 9807 - a glitch in coexisting builds of different types

2010-10-01 Thread Barry Warsaw
I am continuing my quest to be able to install multiple versions and builds of Python simultaneously, so that they all nicely coexist. E.g. you could have a normal build of Python 3.2 and a --with-wide-unicode --with-pydebug build both installed and all packages with extensions would get built

Re: [Python-Dev] issue 9807 - a glitch in coexisting builds of different types

2010-10-01 Thread Antoine Pitrou
On Fri, 1 Oct 2010 20:06:57 -0400 Barry Warsaw ba...@python.org wrote: With my branch, you'll end up with this in /tmp/python: bin/python3.2m - the normal build binary bin/python3.2dmu - the wide+pydebug build binary bin/python3.2m-config bin/python3.2dmu-config Do

Re: [Python-Dev] issue 9807 - a glitch in coexisting builds of different types

2010-10-01 Thread Barry Warsaw
On Oct 02, 2010, at 02:24 AM, Antoine Pitrou wrote: On Fri, 1 Oct 2010 20:06:57 -0400 Barry Warsaw ba...@python.org wrote: With my branch, you'll end up with this in /tmp/python: bin/python3.2m - the normal build binary bin/python3.2dmu - the wide+pydebug build binary

Re: [Python-Dev] issue 9807 - a glitch in coexisting builds of different types

2010-10-01 Thread Benjamin Peterson
2010/10/1 Barry Warsaw ba...@python.org: I can think of a couple of ways out, none of which are totally satisfying. Probably the easiest out is to change the PEP 3149 naming so that the files don't end in .so.  E.g. use this instead:    foo.cpython-32dmu-so    foo.cpython-32m-so -1 Doesn't