Kristján Valur Jónsson writes:
> But again, it shows how useful assertions can be and why we ought
> not to disable them.
Note that just to be clear, I'm certainly not advocating the disabling
of CRT assertions - just the redirection of them so they don't prevent
unattended test runs from comple
"Martin v. Löwis" writes:
> Notice, however, that the feature was never present in the trunk.
Yep - would be nice if it were to get backported to trunk at some
point but that's a separate discussion ... presumably at some point
py3k will be the trunk anyway, and for better or worst (perhaps due
Kristján Valur Jónsson
Cc: Curt Hagenlocher; mhamm...@skippinet.com.au; David Bolen;
python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows?
Does it need to be backported? I wonder when that was introduced.
Also, what CL was it so I can review it?
2009/3/31 Kristján Valur Jónsso
I guess I'll stop asking after this note, but can anyone give a final
verdict on whether the older "-n" option can be restored to the
buildbot test.bat (from the revision history I'm not actually sure it
was intentionally removed in the first place)?
I have now restored it; it was removed by an
t; Sent: 31. mars 2009 21:31
> To: Kristján Valur Jónsson
> Cc: Curt Hagenlocher; mhamm...@skippinet.com.au; David Bolen;
> python-dev@python.org
> Subject: Re: [Python-Dev] Test failures under Windows?
>
> 2009/3/31 Kristján Valur Jónsson :
>> Right, my question to micros
submission to the py3k branch.
K
-Original Message-
From: Jesse Noller [mailto:jnol...@gmail.com]
Sent: 31. mars 2009 21:31
To: Kristján Valur Jónsson
Cc: Curt Hagenlocher; mhamm...@skippinet.com.au; David Bolen;
python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows
2009/3/31 Kristján Valur Jónsson :
> Right, my question to microsoft was more about making sure that a
> __crtMessageBox() actually does nothing, when running unattended as a service.
>
> Also, we should be seeing the same problem in non-debug versions, since the
> _set_invalid_parameter_handler(
On Tue, Mar 31, 2009 at 4:07 PM, David Bolen wrote:
> Kristján Valur Jónsson writes:
>
>> Btw, I am working on finding out the test suite failures for
>> test_multiprocessing.
>
> This is all well and good, but I still haven't seen any plausible
> reason for not preventing these popups (in favor
Kristján Valur Jónsson writes:
> Btw, I am working on finding out the test suite failures for
> test_multiprocessing.
This is all well and good, but I still haven't seen any plausible
reason for not preventing these popups (in favor of stderr failures)
during buildbot test runs? I don't get it
Kristján Valur Jónsson wrote:
Btw, I am working on finding out the test suite failures for
test_multiprocessing.
Some of those are caused by force builds on a branch, so make sure the
errors are still occurring before you put too much effort into this. We
made the branch before some recent f
es for
test_multiprocessing.
K
-Original Message-
From: Curt Hagenlocher [mailto:c...@hagenlocher.org]
Sent: 25. mars 2009 12:54
To: Kristján Valur Jónsson
Cc: mhamm...@skippinet.com.au; David Bolen; python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows?
2009/3/25 Kristján
Hirokazu Yamamoto writes:
> CRT Assertion was totally disabled before, but recently was enabled,
> and workarounds were patched for problematic functions. (ex: fdopen
> and dup) Probably this *patch* is not perfect. See
> http://bugs.python.org/issue4804
Ah - that ticket may explain why my build
David Bolen wrote:
I don't know why they are happening so frequently now when there was a
reasonable period when they weren't an issue (something about new I/O
support in 3.x perhaps?), but without preventing them it seems the
Windows build slaves are going to become (if not already) quite a bit
David Bolen writes:
>>From what I can see though, the tools/buildbot/test.bat file no longer
> adds the -n option that it used to, although I'm unclear on why it
> might have been removed. Perhaps this was just a regression that was
> accidentally missed, as it appears to have disappeared during
Curt Hagenlocher writes:
> The variation that goes through assert.c should write to stderr for a
> console-mode application, so it's reasonable to assume that we're
> hitting the other code path -- and that Mark's suggestion to use
> CrtSetReportMode would address the issue.
Which is pretty much
2009/3/25 Kristján Valur Jónsson :
>
> I'm going to poke my contacts at Microsoft and ask them if there is
> a way to disable popups like this for a process that runs unattended
> and/or is running as a windows service.
MSVC has shipped with runtime library source since the 16-bit days, so
the eas
I'm going to poke my contacts at Microsoft and ask them if there is a way to
disable popups like this for a process that runs unattended and/or is running
as a windows service.
There is, and Curt pointed out one strategy for achieving this without
losing the checks it provides...
> Curt's
On 25/03/2009 7:58 PM, David Bolen wrote:
Mark Hammond writes:
The issue was that Python unconditionally changed the behaviour of the
CRT, not only during the test suite.
Hmm... I was more or less referring to the state of the py3k tree as
of, say, r57823 back in 2007.
I was referring to t
ev-bounces+kristjan=ccpgames@python.org] On Behalf Of Mark
Hammond
Sent: 25. mars 2009 08:44
To: David Bolen
Cc: python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows?
On 25/03/2009 10:05 AM, David Bolen wrote:
> Kristján Valur Jónsson writes:
>
>> Now, I know that t
Mark Hammond writes:
> The issue was that Python unconditionally changed the behaviour of the
> CRT, not only during the test suite.
Hmm... I was more or less referring to the state of the py3k tree as
of, say, r57823 back in 2007. It appeared to just add access to the
necessary functions in th
On 25/03/2009 10:05 AM, David Bolen wrote:
Kristján Valur Jónsson writes:
Now, I know that this msvc behaviour can be disabled, but it was
decided that it was not appropriate to meddle with runtime flags of
the whole process for python.
I must have missed that discussion, but I can't see wha
Kristján Valur Jónsson writes:
> Now, I know that this msvc behaviour can be disabled, but it was
> decided that it was not appropriate to meddle with runtime flags of
> the whole process for python.
I must have missed that discussion, but I can't see what the problem
is if such an override only
> Note that I previously opened http://bugs.python.org/issue5116 with a
> patch to enable this to be controlled from Python via the msvcrt module.
> This would enable the test suite to disable assertions for its entire run.
This patch is fine with me. It might need some documentation, though.
Ho
On Tue, Mar 24, 2009 at 3:45 PM, Antoine Pitrou wrote:
> Mark Hammond gmail.com> writes:
>>
>> Note that I previously opened http://bugs.python.org/issue5116 with a
>> patch to enable this to be controlled from Python via the msvcrt module.
>> This would enable the test suite to disable asserti
Mark Hammond gmail.com> writes:
>
> Note that I previously opened http://bugs.python.org/issue5116 with a
> patch to enable this to be controlled from Python via the msvcrt module.
> This would enable the test suite to disable assertions for its entire run.
We certainly don't want to disable
On 25/03/2009 7:34 AM, "Martin v. Löwis" wrote:
I don't quite remember the -n flag, but I believe that Kristjan
just removed all that stuff, ie. there is now no way to block
CRT assertions anymore.
I
wasn't paying close attention, so maybe there's some other mechanism
in place at this point?
@python.org
[mailto:python-dev-bounces+kristjan=ccpgames@python.org] On Behalf Of Curt
Hagenlocher
Sent: 24. mars 2009 19:14
To: David Bolen
Cc: python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows?
On Tue, Mar 24, 2009 at 11:49 AM, David Bolen wrote:
>
> Kristján
> There was a discussion about this on the py3k mailing list back in
> mid-2007 ("buildbots" thread) and perhaps later as well, at which
> point I believe Martin added an "-n" option to regrtest and the
> buildbot test.bat file to disable the assertions. Is that the py3k
> branch piece you are ref
On Tue, Mar 24, 2009 at 11:49 AM, David Bolen wrote:
>
> Kristján Valur Jónsson writes:
>
>> These issues should be resolved in the py3k branch, but it will need
>> porting to 2.6. Dialogue boxes are annoying, but do they pop up if
>> you run your buildslave as a service without access to the co
Kristján Valur Jónsson writes:
> These issues should be resolved in the py3k branch, but it will need
> porting to 2.6. Dialogue boxes are annoying, but do they pop up if
> you run your buildslave as a service without access to the console?
Not sure what the MSVC++ runtime does with assertion d
David Bolen gmail.com> writes:
>
> Antoine Pitrou pitrou.net> writes:
>
> > Am I the only one getting those?
> > By the way, what happened to the Windows buildbots?
>
> Oops - sorry, mine (XP-4) apparently got stuck with C++ debug
> assertion dialogs (an assertion from the internal close.c mod
[mailto:python-dev-bounces+kristjan=ccpgames@python.org] On Behalf Of David
Bolen
Sent: 24. mars 2009 18:02
To: python-dev@python.org
Subject: Re: [Python-Dev] Test failures under Windows?
Antoine Pitrou writes:
> Am I the only one getting those?
> By the way, what happened to the W
Antoine Pitrou writes:
> Am I the only one getting those?
> By the way, what happened to the Windows buildbots?
Oops - sorry, mine (XP-4) apparently got stuck with C++ debug
assertion dialogs (an assertion from the internal close.c module) from
python_d during some earlier build. I try to catch
On Tue, 24 Mar 2009 13:49:28 + (UTC), Antoine Pitrou
wrote:
Hello,
[snip]
By the way, what happened to the Windows buildbots?
It looks like some of them are suffering from problems which I think are
common with buildbot on Windows - primarily difficulty dealing with runaway
processes or
Hello,
I've just tried running test_io under Windows (in a virtual machine) and I get
the following failures:
==
ERROR: test_error_through_destructor (test.test_io.CTextIOWrapperTest)
-
35 matches
Mail list logo
