Re: [Qemu-devel] [PATCH v9 13/13] tests: Ignore test-uuid

2016-09-20 Thread Jeff Cody
On Wed, Sep 21, 2016 at 12:27:26PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index b4a9cfc..24ac6cf 100644 > --- a/tests/.gitignore > +++

Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE

2016-09-20 Thread Wu, Feng
> -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, September 21, 2016 1:45 PM > To: Wu, Feng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode > against the

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-20 Thread Jeff Cody
On Tue, Sep 20, 2016 at 06:07:45PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > > Sample command line using JSON syntax: >

Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE

2016-09-20 Thread Peter Xu
On Thu, Sep 22, 2016 at 12:12:17AM +0800, Feng Wu wrote: > The Trigger Mode field of IOAPIC must match the Trigger Mode in > the IRTE according to VT-d Spec 5.1.5.1. > > Signed-off-by: Feng Wu Reviewed-by: Peter Xu Could I ask why we want this now? I know

Re: [Qemu-devel] [RFC PATCH v0] spapr: Disable CPU unplug in TCG mode

2016-09-20 Thread David Gibson
On Wed, Sep 21, 2016 at 10:18:00AM +0530, Bharata B Rao wrote: > CPU unplug doesn't work in TCG mode currently and causes frequent system > freeze. In addition to other potential problems, the main problem arises > of out the requirement to support synchronous removal of a CPU thread. > The CPU

Re: [Qemu-devel] [PATCH v3 06/10] monitor: fix crash for platforms without a CPU 0

2016-09-20 Thread David Gibson
On Thu, Sep 15, 2016 at 02:45:56PM +0200, Cédric Le Goater wrote: > On PowerNV, CPU ids start at 0x8 or 0x20, we don't have a CPU 0 > anymore. So let's use the first_cpu index to initialize the monitor. > > Signed-off-by: Cédric Le Goater I've rewritten the commit message to make

Re: [Qemu-devel] [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method

2016-09-20 Thread Xiao Guangrong
On 09/20/2016 10:07 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:03 +0800 Xiao Guangrong wrote: Currently, 'RLEN' is the totally buffer size written by QEMU and it is ACPI internally used only. The buffer size returned to guest should not include 'RLEN'

[Qemu-devel] [PATCH] monitor: fix crash for platforms without a CPU 0

2016-09-20 Thread David Gibson
Now that we allow CPU hot unplug on a few platforms, we can end up in a situation where we don't have a CPU with index 0. Or at least we could, if we didn't have code to explicitly prohibit unplug of CPU 0. Longer term we want to allow CPU 0 unplug, this patch is an early step in allowing this,

[Qemu-devel] [REPOST] sysbus: Remove ignored return value of FindSysbusDeviceFunc

2016-09-20 Thread David Gibson
Functions of type FindSysbusDeviceFunc currently return an integer. However, this return value is always ignored by the caller in find_sysbus_device(). This changes the function type to return void, to avoid confusion over the function semantics. Signed-off-by: David Gibson

[Qemu-devel] [V0 1/1] virtio crypto device specification: asymmetric crypto service

2016-09-20 Thread Xin Zeng
This patch introduces asymmetric crypto service into virtio crypto device. The asymmetric crypto service can be referred as signature, verification, encryption, decryption, key generation and key exchange. This patch depends on another virtio crypto device spec patch:

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-20 Thread Pavel Dovgalyuk
> From: Felipe Franciosi [mailto:fel...@nutanix.com] > If compiling with -Werror=unused-result, replay-internal.c won't build > due to a call to fwrite() where the returned value is ignored. A simple > cast to (void) is not sufficient on recent GCCs, so this fixes it. > > Signed-off-by: Felipe

Re: [Qemu-devel] [RFC PATCH v0] spapr: Disable CPU unplug in TCG mode

2016-09-20 Thread Fam Zheng
On Tue, 09/20 22:02, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > BUILD fedora > ARCHIVE qemu.tgz > ARCHIVE dtc.tgz > COPY RUNNER > RUN test-mingw in fedora > tests/docker/Makefile.include:107: recipe for target > 'docker-run-test-mingw@fedora' failed > make: ***

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-09-20 Thread Jike Song
On 09/21/2016 12:51 PM, Alex Williamson wrote: > On Wed, 21 Sep 2016 11:19:17 +0800 > Jike Song wrote: > >> On 09/21/2016 12:24 AM, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 10:50:47 +0800 >>> Jike Song wrote: >> >> /* trim the quotations */ >>

[Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers

2016-09-20 Thread Peter Xu
Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. Before that is achieved, let's open a door for vhost DMAR support, which only requires cache invalidations (UNMAP operations). Meanwhile, converting hw_error() to error_report() and exit(1), to make the error messages clean and

Re: [Qemu-devel] [RFC PATCH v0] spapr: Disable CPU unplug in TCG mode

2016-09-20 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1474433280-25652-1-git-send-email-bhar...@linux.vnet.ibm.com Subject: [Qemu-devel] [RFC PATCH v0]

[Qemu-devel] [PATCH v6 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-20 Thread Peter Xu
IOMMU Notifier list is used for notifying IO address mapping changes. Currently VFIO is the only user. However it is possible that future consumer like vhost would like to only listen to part of its notifications (e.g., cache invalidations). This patch introduced IOMMUNotifier and

[Qemu-devel] [PATCH v6 0/3] Introduce IOMMUNotifier struct

2016-09-20 Thread Peter Xu
Hi, Paolo, If this is to be merged, please take either patch 1-2 or the whole series (1-3). Both work for me. Thanks! V6: - use IOMMUTLBEntry directly for IOMMUNotifier.notify() [David] - add explicit comment for patch 1 that CHANGE should be treated as a MAP then an UNMAP [David] - add a-b

[Qemu-devel] [PATCH v6 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-20 Thread Peter Xu
The new interface can be used to replace the old notify_started() and notify_stopped(). Meanwhile it provides explicit flags so that IOMMUs can know what kind of notifications it is requested for. Acked-by: David Gibson Signed-off-by: Peter Xu ---

Re: [Qemu-devel] [PATCH v5 3/3] intel_iommu: allow UNMAP notifiers

2016-09-20 Thread Peter Xu
On Wed, Sep 21, 2016 at 01:49:10PM +1000, David Gibson wrote: > On Tue, Sep 20, 2016 at 03:28:08PM +0800, Peter Xu wrote: > > On Tue, Sep 20, 2016 at 04:14:09PM +1000, David Gibson wrote: > > > On Wed, Sep 14, 2016 at 04:25:48PM +0800, Peter Xu wrote: > > > > Intel vIOMMU is still lacking of a

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 11:19:17 +0800 Jike Song wrote: > On 09/21/2016 12:24 AM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 10:50:47 +0800 > > Jike Song wrote: > > /* trim the quotations */ > > >> Even performing a lightweight sanity check, would

[Qemu-devel] [RFC PATCH v0] spapr: Disable CPU unplug in TCG mode

2016-09-20 Thread Bharata B Rao
CPU unplug doesn't work in TCG mode currently and causes frequent system freeze. In addition to other potential problems, the main problem arises of out the requirement to support synchronous removal of a CPU thread. The CPU thread that performs the cleanup of the unplugged CPU, kicks and waits

Re: [Qemu-devel] [PATCH] tests: Ignore test executables

2016-09-20 Thread Fam Zheng
On Tue, 09/20 09:43, Eric Blake wrote: > Commits 9ef8112a and efad6682 introduced new tests, but forgot > to ignore the built executables from an in-tree build. > > Signed-off-by: Eric Blake > --- > tests/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 04:10:53 + "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Wednesday, September 21, 2016 12:23 AM > > > > > > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > > On Tue, 20 Sep 2016 19:51:58 +0530 > > > Kirti

[Qemu-devel] [PATCH v9 12/13] Add UUID files to MAINTAINERS

2016-09-20 Thread Fam Zheng
I understand that we've been keeping eyes on the uncovered files. Since I'm adding some more files I volunteer to look after them in the futuer. Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 03:56:21 + "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Tuesday, September 20, 2016 10:22 PM > > >> > > >> 'max_instance': > > >> Read-Only file. Mandatory. > > >> Returns integer. Returns maximum

[Qemu-devel] [PATCH v9 09/13] vl: Switch qemu_uuid to QemuUUID

2016-09-20 Thread Fam Zheng
Update all qemu_uuid users as well, especially get rid of the duplicated low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. Since qemu_uuid_parse is quite tangled with qemu_uuid, its switching to QemuUUID is done here too to keep everything in sync and avoid code churn.

[Qemu-devel] [PATCH v9 13/13] tests: Ignore test-uuid

2016-09-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index b4a9cfc..24ac6cf 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -70,6 +70,7 @@ test-string-output-visitor test-thread-pool

[Qemu-devel] [PATCH v9 10/13] uuid: Tighten uuid parse

2016-09-20 Thread Fam Zheng
sscanf is relatively loose (tolerate) on some invalid formats that we should fail instead of generating a wrong uuid structure, like with whitespaces and short strings. Add and use a helper function to first check the format. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v9 11/13] tests: Add uuid tests

2016-09-20 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody --- tests/Makefile.include | 2 + tests/test-uuid.c | 177 + 2 files changed, 179 insertions(+) create mode 100644 tests/test-uuid.c diff --git

[Qemu-devel] [PATCH v9 08/13] configure: Remove detection code for UUID

2016-09-20 Thread Fam Zheng
All code now uses built-in UUID implementation. Remove the code of libuuid and make --enable-uuid and --disable-uuid only print a message. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- configure | 43

[Qemu-devel] [PATCH v9 07/13] tests: No longer dependent on CONFIG_UUID

2016-09-20 Thread Fam Zheng
crypto now uses built-in uuid implementation, so this check is not needed. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- tests/test-crypto-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v9 06/13] crypto: Switch to QEMU UUID API

2016-09-20 Thread Fam Zheng
The uuid generation doesn't return error, so update the function signature and calling code accordingly. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- crypto/block-luks.c | 26 +++--- 1

[Qemu-devel] [PATCH v9 01/13] util: Add UUID API

2016-09-20 Thread Fam Zheng
A number of different places across the code base use CONFIG_UUID. Some of them are soft dependency, some are not built if libuuid is not available, some come with dummy fallback, some throws runtime error. It is hard to maintain, and hard to reason for users. Since UUID is a simple standard

[Qemu-devel] [PATCH v9 05/13] vpc: Use QEMU UUID API

2016-09-20 Thread Fam Zheng
Previously we conditionally generated footer->uuid, when libuuid was available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- block/vpc.c | 10

[Qemu-devel] [PATCH v9 03/13] vhdx: Use QEMU UUID API

2016-09-20 Thread Fam Zheng
This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng Reviewed-by: Eric

[Qemu-devel] [PATCH v9 02/13] uuid: Make null_uuid static

2016-09-20 Thread Fam Zheng
So that it doesn't have to be zeroed at each call. Suggested-by: Eric Blake Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody --- util/uuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/uuid.c b/util/uuid.c index

[Qemu-devel] [PATCH v9 04/13] vdi: Use QEMU UUID API

2016-09-20 Thread Fam Zheng
The UUID operations we need from libuuid are fully supported by QEMU UUID implementation. Use it, and remove the unused code. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- block/vdi.c | 73

[Qemu-devel] [PATCH v9 00/13] UUID clean ups for 2.8

2016-09-20 Thread Fam Zheng
v9: Add .gitignore patch. [Eric] Add Jeff's and Eric's r-b in other patches. The facts how we use libuuid now are not particularly pleasant. - VHDX driver depends on uuid, but is unconditionally checked in iotests 109. If it is not built, the test would fail, leaving no hint about that. In

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Wednesday, September 21, 2016 12:23 AM > > > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 19:51:58 +0530 > > Kirti Wankhede wrote: > > > >> On 9/20/2016 3:06 AM, Alex Williamson wrote: >

Re: [Qemu-devel] [RFC] test/docker/Makefile.include: add a generic docker-run target

2016-09-20 Thread Fam Zheng
On Tue, 09/20 14:56, Alex Bennée wrote: > This re-factors the docker makefile to include a docker-run target which > can be controlled entirely from environment variables specified on the > make command line. This allows us to run against any given docker image > we may have in our repository, for

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, September 20, 2016 10:22 PM > >> > >> 'max_instance': > >> Read-Only file. Mandatory. > >> Returns integer. Returns maximum mdev device could be created > >> at the moment when this file is read. This count would be

[Qemu-devel] [PATCH 7/9] docker: Support showing environment information

2016-09-20 Thread Fam Zheng
Add a make variable SHOW_ENV. When it's set to non empty, print the package information and environment variables. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 2 +- tests/docker/run | 11 +++ 2 files changed, 12 insertions(+), 1

Re: [Qemu-devel] [PATCH v5 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 03:16:33PM +0800, Peter Xu wrote: > On Tue, Sep 20, 2016 at 04:12:05PM +1000, David Gibson wrote: > > On Wed, Sep 14, 2016 at 04:25:46PM +0800, Peter Xu wrote: > > > IOMMU Notifier list is used for notifying IO address mapping changes. > > > Currently VFIO is the only user.

[Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure

2016-09-20 Thread Fam Zheng
This makes the configure command more obvious which usually has useful information. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/docker/common.rc b/tests/docker/common.rc index

[Qemu-devel] [PATCH 4/9] docker: Update fedora image to latest

2016-09-20 Thread Fam Zheng
Now that 23 is becoming an "old" release with 24 available. Fedora has a quick release cycle, so use latest to follow more closely. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 9/9] docker: exec $CMD

2016-09-20 Thread Fam Zheng
This is the last command to run (unless DEBUG), make it 'exec' to simplify the process tree. Signed-off-by: Fam Zheng --- tests/docker/run | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/docker/run b/tests/docker/run index

[Qemu-devel] [PATCH 3/9] docker: Generate /packages.txt in ubuntu image

2016-09-20 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/ubuntu.docker | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 5/9] docker: Flatten default target list in test-quick

2016-09-20 Thread Fam Zheng
Previously it is expanded to a whitespace separated list which is not the most appropriate format. Since it's only two items, flatten it. Signed-off-by: Fam Zheng --- tests/docker/test-quick | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 2/9] docker: Generate /packages.txt in fedora image

2016-09-20 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 1/9] docker: Generate /packages.txt in centos6 image

2016-09-20 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP

2016-09-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/docker.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index b85c165..552608e 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -21,6 +21,7 @@

Re: [Qemu-devel] [PATCH v5 3/3] intel_iommu: allow UNMAP notifiers

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 03:28:08PM +0800, Peter Xu wrote: > On Tue, Sep 20, 2016 at 04:14:09PM +1000, David Gibson wrote: > > On Wed, Sep 14, 2016 at 04:25:48PM +0800, Peter Xu wrote: > > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > > Before that is achieved, let's

[Qemu-devel] [PATCH 0/9] docker: SHOW_ENV and terminate improvements

2016-09-20 Thread Fam Zheng
The first patches add a new feature that if SHOW_ENV is set when running a test, (explicitly installed) package list and env vars will be printed. The last pactches (hopefully) improves termination of docker instance, so that in a patchew tester env, building and testing procecess (that lies

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-20 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Tue, Sep 20, 2016 at 10:40:03PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > [ Unknown signature status ] >> > On Mon, Sep 19, 2016 at 04:06:40PM +0530, Nikunj

Re: [Qemu-devel] [OpenBIOS] [PATCH] Add resolutions via the command-line

2016-09-20 Thread Alfonso Gamboa
Perhaps include a base set of resolutions that the actual mac99 machine supported, implemented in OpenBIOS, and also adding the --video-resolutions option so the user may add custom entries that would be read by the VGA device if so desired. I believe that is the best compromise vs. having a huge

Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-20 Thread David Gibson
On Mon, Aug 15, 2016 at 10:11:53AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-08-15 at 09:59 +1000, Benjamin Herrenschmidt wrote: > > Bla bla bla bla ... > > > > Seriously, we have nazi stylebot on the list now ? > > > > I made conscious decisions to style it this way and as far as the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64.

2016-09-20 Thread David Gibson
On Tue, Aug 30, 2016 at 01:02:47AM +, Nathan Whitehorn wrote: > These are mandatory per PAPR and available on Linux 4.3 and newer kernels. > The calls in question are required to run FreeBSD guests with reasonable > performance, so enable them if possible. > > Signed-off-by: Nathan

Re: [Qemu-devel] [PATCH v8 11/12] tests: Add uuid tests

2016-09-20 Thread Fam Zheng
On Tue, 09/20 10:37, Eric Blake wrote: > On 09/17/2016 11:25 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/Makefile.include | 2 + > > tests/test-uuid.c | 177 > > + > > 2 files changed, 179

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-09-20 Thread Jike Song
On 09/21/2016 12:24 AM, Alex Williamson wrote: > On Tue, 20 Sep 2016 10:50:47 +0800 > Jike Song wrote: /* trim the quotations */ >> Even performing a lightweight sanity check, would require vfio-mdev >> to be able to decode the ppos into a particular region, that means >>

Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

2016-09-20 Thread David Gibson
On Wed, Sep 21, 2016 at 12:05:47PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote: > > Ok, as noted elsewhere, I think you need to disassociate the PIR value > > from the cpu_index.  It may be a little less elegant, but it'll make > > your life much

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-20 Thread G 3
On Sep 20, 2016, at 8:41 PM, Benjamin Herrenschmidt wrote: On Tue, 2016-09-20 at 20:35 -0400, G 3 wrote: When I use the -prom-env option I can easily add properties to the options node. Can something like this be done with the chosen node? We can make it so. That or we can add code to

[Qemu-devel] [PATCH V4 0/2] Add option to configure guest vPMU

2016-09-20 Thread Wei Huang
This patchset adds a pmu=[on/off] option to enable/disable vPMU support for guest VM. There are several reasons to justify this option. First, vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an option to

[Qemu-devel] [PATCH V4 2/2] arm: virt: add PMU property to mach-virt machine type

2016-09-20 Thread Wei Huang
CPU vPMU is now turned off by default, but it was ON in virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned on in virt-2.7 machine type to make sure it

[Qemu-devel] [PATCH V4 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-20 Thread Wei Huang
This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest vCPU. This option is only available for cortex-a57/cortex-53/ host under both TCG and KVM modes, but unavailable on ARMv7 and other processors. It allows virt tools, such as libvirt, to determine the exsitence of vPMU

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v10 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-20 Thread Gonglei (Arei)
Hi Michael, > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Wednesday, September 21, 2016 3:11 AM > Subject: [virtio-dev] Re: [PATCH v10 1/2] virtio-crypto: Add virtio crypto > device >

[Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE

2016-09-20 Thread Feng Wu
The Trigger Mode field of IOAPIC must match the Trigger Mode in the IRTE according to VT-d Spec 5.1.5.1. Signed-off-by: Feng Wu --- hw/i386/intel_iommu.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 10:40:03PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Mon, Sep 19, 2016 at 04:06:40PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > [

Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

2016-09-20 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote: > Ok, as noted elsewhere, I think you need to disassociate the PIR value > from the cpu_index.  It may be a little less elegant, but it'll make > your life much easier in the short and medium term. > > Apart from that, this looks pretty good,

Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

2016-09-20 Thread David Gibson
On Thu, Sep 15, 2016 at 02:45:55PM +0200, Cédric Le Goater wrote: > This is largy inspired by sPAPRCPUCore with some simplification, no > hotplug for instance. But the differences are small and the objects > could possibly be merged. > > A set of PnvCore objects is added to the PnvChip and the

Re: [Qemu-devel] [PATCH v3 04/10] ppc/pnv: add a PIR handler to PnvChip

2016-09-20 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 11:29 +1000, David Gibson wrote: > On Thu, Sep 15, 2016 at 02:45:54PM +0200, Cédric Le Goater wrote: > > > > P9 and P8 have some differences in the CPU PIR encoding. > > The thread id isn't in the PIR at all? Yes it is. Though on P9 there could be different encodings

Re: [Qemu-devel] [PATCH v3 04/10] ppc/pnv: add a PIR handler to PnvChip

2016-09-20 Thread David Gibson
On Thu, Sep 15, 2016 at 02:45:54PM +0200, Cédric Le Goater wrote: > P9 and P8 have some differences in the CPU PIR encoding. The thread id isn't in the PIR at all? > > Signed-off-by: Cédric Le Goater > --- > hw/ppc/pnv.c | 14 ++ > include/hw/ppc/pnv.h | 1

Re: [Qemu-devel] [PATCH v6 0/3] ppc: handle broadcast tlb flush

2016-09-20 Thread David Gibson
On Tue, Sep 20, 2016 at 10:04:58PM +0530, Nikunj A Dadhania wrote: > PowerPC failed to handle broadcast TLB flush operations. Executing > instructions that are defined architecturally as synchronizing global TLB > should have a global effect. > > * tlbie on BookS > * tlbivax on BookE > *

[Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-20 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Sample command line using JSON syntax: ./qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us

Re: [Qemu-devel] [PATCH RFC v1 28/29] target-arc: decode

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:32 PM, Michael Rolnik wrote: +decode_fdecode[32] = { There's no reason to use an array here, and worse, a non-static non-const array. Just use a switch here +return decode[curr_major](ctx, curr_opcode); r~

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-20 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 20:35 -0400, G 3 wrote: > > When I use the -prom-env option I can easily add properties to the   > options node. > Can something like this be done with the chosen node? We can make it so. That or we can add code to OpenBIOS to copy the list of resolutions into the

Re: [Qemu-devel] [PATCH RFC v1 24/29] target-arc: NOP, UNIMP

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:32 PM, Michael Rolnik wrote: +int arc_gen_UNIMP(DisasCtxt *ctx) +{ +/* PC = INT_VECTOR_BACE + 0x10 */ +tcg_gen_andi_tl(cpu_pc, cpu_intvec, 0xffc0); +tcg_gen_addi_tl(cpu_pc, cpu_pc, 0x10); + +return BS_EXCP; +} This should be done via an exception, with the

Re: [Qemu-devel] [PATCH RFC v1 22/29] target-arc: ASLS, ASRS

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:32 PM, Michael Rolnik wrote: +int arc_gen_ASLS(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) Just do these as helpers. r~

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-20 Thread G 3
On Sep 20, 2016, at 8:18 PM, Benjamin Herrenschmidt wrote: On Tue, 2016-09-20 at 00:01 -0400, G 3 wrote: Something is wrong with the options node in OpenBIOS. It is inaccessible from Mac OS X. When trying to access the options node, IORegistryExplorer always crashes. The other nodes are

Re: [Qemu-devel] [virtio-dev] [PATCH] virtio crypto device specification

2016-09-20 Thread Gonglei (Arei)
> -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Xin Zeng > Sent: Tuesday, September 20, 2016 11:47 PM > Subject: [virtio-dev] [PATCH] virtio crypto device specification > > Fix spelling mistakes of keywords to make

Re: [Qemu-devel] [PATCH RFC v1 19/29] target-arc: LR, SR

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:32 PM, Michael Rolnik wrote: +int arc_gen_LR(DisasCtxt *ctx, TCGv dest, TCGv src1) +{ +TCGv cpc = tcg_const_local_i32((ctx->cpc + 3) & 0xfffc); +TCGv npc = tcg_const_local_i32((ctx->npc + 3) & 0xfffc); No need for _local here. r~

Re: [Qemu-devel] [PATCH RFC v1 17/29] target-arc: B, BL

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +caseARC_COND_HI: { +ARC_COND_IF_1(C, label_skip); +ARC_COND_IF_1(Z, label_skip); +} break; Why aren't you using AND / OR to combine these conditions? r~

Re: [Qemu-devel] [PATCH RFC v1 16/29] target-arc: BBIT0, BBIT1, BR

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +static void arc_gen_exec_delayslot(DisasCtxt *ctx) +{ +if (ctx->opt.limm == 0) { +uint32_t cpc = ctx->cpc; +uint32_t npc = ctx->npc; +uint32_t dpc = ctx->dpc; +uint32_t pcl = ctx->pcl; +options_t opt =

Re: [Qemu-devel] [PATCH RFC v1 15/29] target-arc: MUL64, MULU64, DIVAW

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-arc/translate-inst.c | 105 target-arc/translate-inst.h | 4 ++ 2 files changed, 109 insertions(+) diff --git a/target-arc/translate-inst.c

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-20 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 00:01 -0400, G 3 wrote: > > Something is wrong with the options node in OpenBIOS. It is   > inaccessible from Mac OS X. When trying to access the options node,   > IORegistryExplorer always crashes. The other nodes are accessible.   > I'm not certain what the problem could

Re: [Qemu-devel] [PATCH v2] add resolutions via command-line

2016-09-20 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 09:51 -0400, G 3 wrote: > > The malloc() function used in this driver is used to allocate a > very   > small amount of space at most. We are realistically talking under > 2k.   > Running out of space is highly unlikely. I'm sure the user could do   > something evil to try to

Re: [Qemu-devel] [PATCH RFC v1 14/29] target-arc: MPY, MPYH, MPYHU, MPYU

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_ext_i32_i64(srcA, src1); +tcg_gen_ext_i32_i64(srcB, src2); + +tcg_gen_mul_i64(rslt, srcA, srcB); + +tcg_gen_trunc_i64_tl(dest, rslt); + +if (ctx->opt.f) { +TCGv_i64 temp = tcg_temp_new_i64(); + +

Re: [Qemu-devel] [PATCH RFC v1 13/29] target-arc: NORM, NORMW

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +target_ulong helper_norm(CPUARCState *env, uint32_t src1) +{ +if (src1 == 0x || src1 == 0x) { +return 31; +} else { +if ((src1 & 0x8000) == 0x8000) { +src1 = ~src1; +} +

Re: [Qemu-devel] [PATCH RFC v1 11/29] target-arc: BCLR, BMSK, BSET, BTST, BXOR

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +int arc_gen_BCLR(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) +{ +TCGv rslt = dest; + +if (TCGV_EQUAL(dest, src1) || TCGV_EQUAL(dest, src2)) { +rslt = tcg_temp_new_i32(); +} + +tcg_gen_andi_tl(rslt, src2, 0x3f); 0x1f,

Re: [Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_subi_tl(cpu_sp, cpu_sp, 4); +tcg_gen_qemu_st_tl(src1, cpu_sp, ctx->memidx, MO_UL); You need to delay the write to the stack pointer until after the store, otherwise sp will have the incorrect contents if the page is not writable.

Re: [Qemu-devel] [PATCH RFC v1 09/29] target-arc: NEG, ABS, NOT

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_movcond_tl(TCG_COND_GEU, rslt, src1, ctx->msb32, src1, t0); Better as a signed comparison vs zero. r~

Re: [Qemu-devel] [PATCH RFC v1 07/29] target-arc: MAX, MIN

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +int arc_gen_MAX(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) +{ +if (ctx->opt.f) { +arc_gen_CMP(ctx, src1, src2); +} + +tcg_gen_movcond_tl(TCG_COND_GEU, dest, src1, src2, src1, src2); These are supposed to be signed

[Qemu-devel] [PATCH v3] Add resolutions via the command-line

2016-09-20 Thread G 3
Add the ability to add resolutions from the command-line. This patch works by looking for a property called 'resolutions' in the options node of OpenBIOS. If it is found all the resolutions are parsed and loaded. Example command-line: -prom-env

Re: [Qemu-devel] [PATCH RFC v1 06/29] target-arc: EX, LD, ST, SYNC, PREFETCH

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-arc/translate-inst.c | 230 target-arc/translate-inst.h | 10 ++ 2 files changed, 240 insertions(+) diff --git a/target-arc/translate-inst.c

Re: [Qemu-devel] [PATCH RFC v1 04/29] target-arc: AND, OR, XOR, BIC, TST

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +int arc_gen_AND(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) +{ +TCGv rslt = dest; + +if (TCGV_EQUAL(dest, src1) || TCGV_EQUAL(dest, src2)) { +rslt = tcg_temp_new_i32(); +} + +tcg_gen_and_tl(rslt, src1, src2); + +if

Re: [Qemu-devel] [PATCH RFC v1 03/29] target-arc: SUB, SUB1, SUB2, SUB3, SBC, RSUB, CMP

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +static void gen_sub_Cf(TCGv dest, TCGv src1, TCGv src2) +{ +TCGv t1 = tcg_temp_new_i32(); +TCGv t2 = tcg_temp_new_i32(); +TCGv t3 = tcg_temp_new_i32(); + +tcg_gen_not_tl(t1, src1); /* t1 = ~src1 */ +

Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +#define CPU_IMM(env)((env)->r[62]) +#define CPU_PCL(env)((env)->r[63]) You don't need to represent these as actual registers. These are better considered placeholder regnums to be filled in with actual values during translation.

Re: [Qemu-devel] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The option whether or not to use a native AIO interface really isn't a > generic option for all drivers, but only applies to the native file > protocols. This patch moves the option in blockdev-add to the > appropriate places (raw-posix and raw-win32). >

Re: [Qemu-devel] [PATCH 2/7] block/qapi: Use separate options type for curl driver

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > We're going to add an option to the file drivers which doesn't apply to > the curl drivers, so give them a separate option type. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 25 ++--- > 1 file

Re: [Qemu-devel] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add()

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The TODO comment has been addressed a while ago and this is now checked > in raw-posix, so we don't have to special case this in blockdev-add any > more. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 15

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Greg Kurz
On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, Please find some

  1   2   3   4   5   >