Re: [PATCH] replay: synchronize on every virtual timer callback

2020-05-18 Thread Pavel Dovgalyuk
On 18.05.2020 18:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: + Alex On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote: Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual clock. Therefore every callback should be logged to make replay

Audio passthroguh

2020-05-18 Thread padma jain
Hi all, I want to understand, how we can differentiate the actual sound card(PCI passthrough) and emulated sound card. Basically i want to check it in qemu itself. Any suggestions?

Re: [PATCH] replay: implement fair mutex

2020-05-18 Thread Pavel Dovgalyuk
On 18.05.2020 19:07, Alex Bennée wrote: Pavel Dovgalyuk writes: In record/replay icount mode main loop thread and vCPU thread do not perform simultaneously. They take replay mutex to synchronize the actions. Sometimes vCPU thread waits for locking the mutex for very long time, because main

Re: [PATCH 05/24] aspeed: Don't create unwanted "cortex-a7-arm-cpu" devices

2020-05-18 Thread Markus Armbruster
Joel Stanley writes: > On Mon, 18 May 2020 at 12:24, Cédric Le Goater wrote: >> >> On 5/18/20 7:03 AM, Markus Armbruster wrote: >> > The number of CPUs is controlled by property "num-cpus". >> > aspeed_soc_ast2600_init() creates the maximum supported number. >> > aspeed_soc_ast2600_realize()

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

2020-05-18 Thread Markus Armbruster
"Andrew Jeffery" writes: > On Mon, 18 May 2020, at 21:49, Cédric Le Goater wrote: >> On 5/18/20 7:03 AM, Markus Armbruster wrote: >> > These devices are optional, and controlled by @nb_nics. >> > aspeed_soc_ast2600_init() and aspeed_soc_init() create the maximum >> > supported number.

Re: [PATCH] icount: fix shift=auto for record/replay

2020-05-18 Thread Pavel Dovgalyuk
On 18.05.2020 19:14, Alex Bennée wrote: Pavel Dovgalyuk writes: This patch fixes shift=auto when record/replay is enabled. Now user does not need to guess the best shift value. Signed-off-by: Pavel Dovgalyuk --- cpus.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

2020-05-18 Thread Markus Armbruster
Joel Stanley writes: > On Mon, 18 May 2020 at 12:19, Cédric Le Goater wrote: >> >> On 5/18/20 7:03 AM, Markus Armbruster wrote: >> > These devices are optional, and controlled by @nb_nics. >> > aspeed_soc_ast2600_init() and aspeed_soc_init() create the maximum >> > supported number.

Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

2020-05-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/18/20 12:30 PM, Peter Maydell wrote: >> On Mon, 18 May 2020 at 06:04, Markus Armbruster wrote: >>> >>> xlnx_dp_init() creates these two devices, but they're never realized. >>> Affects machine xlnx-zcu102. >>> >>> I wonder how this ever worked. If the

Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

2020-05-18 Thread Markus Armbruster
Fred Konrad writes: > Le 5/18/20 à 7:03 AM, Markus Armbruster a écrit : >> xlnx_dp_init() creates these two devices, but they're never realized. >> Affects machine xlnx-zcu102. >> >> I wonder how this ever worked. If the "device becomes real only on >> realize" thing actually works, then we've

Re: [PATCH 01/24] arm/stm32f405: Fix realization of "stm32f2xx-adc" devices

2020-05-18 Thread Markus Armbruster
Alistair Francis writes: > On Sun, May 17, 2020 at 10:06 PM Markus Armbruster wrote: >> >> stm32f405_soc_initfn() creates six such devices, but >> stm32f405_soc_realize() realizes only one. Affects machine >> netduinoplus2. >> >> I wonder how this ever worked. If the "device becomes real only

Re: [PATCH v3 0/3] various: Remove unnecessary casts

2020-05-18 Thread Markus Armbruster
Cédric Le Goater writes: > On 5/18/20 3:17 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 15/05/20 07:58, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > Remove unnecessary casts using coccinelle scripts. > > The CPU()/OBJECT() patches don't

Re: [PATCH] target/i386: Fix OUTL debug output

2020-05-18 Thread Richard Henderson
On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote: > Fix OUTL instructions incorrectly displayed as OUTW. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/misc_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson as far as it goes. We

Re: [PATCH Kernel v21 0/8] Add UAPIs to support migration for VFIO devices

2020-05-18 Thread Xiang Zheng
Thank you very much, Kirti and Yan! On 2020/5/18 11:36, Yan Zhao wrote: > On Mon, May 18, 2020 at 10:39:52AM +0800, Xiang Zheng wrote: >> Hi Kirti and Yan, >> >> How can I test this patch series on my SR-IOV devices? >> I have looked through Yan's pathes for i40e VF live migration support: >>

[RISU v2 16/17] aarch64: Reorg sve reginfo to save space

2020-05-18 Thread Richard Henderson
Mirror the signal frame by storing all of the registers as a lump. Use the signal macros to pull out the values. Signed-off-by: Richard Henderson --- risu_reginfo_aarch64.h | 16 + risu_reginfo_aarch64.c | 135 + 2 files changed, 73 insertions(+),

[RISU v2 17/17] Add --dump option to inspect trace files

2020-05-18 Thread Richard Henderson
Adjust some of the aarch64 code to look at the reginfo struct instead of looking at test_sve, so that we do not need to pass the --test-sve option in order to dump sve trace files. Signed-off-by: Richard Henderson --- risu.h | 1 + risu.c | 108

[RISU v2 10/17] Pass non-OK result back through siglongjmp

2020-05-18 Thread Richard Henderson
Rather than doing some work in the signal handler and some work outside, move all of the non-resume work outside. This works because we arranged for RES_OK to be 0, which is the normal return from sigsetjmp. Signed-off-by: Richard Henderson --- risu.c | 50

[RISU v2 14/17] Add magic and size to the trace header

2020-05-18 Thread Richard Henderson
Sanity check that we're not getting out of sync with the trace stream. This will be especially bad with the change in size of the sve save data. Signed-off-by: Richard Henderson --- risu.h| 8 ++- reginfo.c | 160 -- risu.c| 6 ++

[RISU v2 11/17] Always write for --master

2020-05-18 Thread Richard Henderson
For trace, master of course must write to the file we create. For sockets, we can report mismatches from either end. At present, we are reporting mismatches from master. Reverse that so that we report mismatches from the apprentice, just as we do for trace. Signed-off-by: Richard Henderson

[RISU v2 13/17] Split RES_MISMATCH for registers and memory

2020-05-18 Thread Richard Henderson
By remembering the specific comparison that failed, we do not have to try again when it comes time to report. This makes the mem_used flag redundant. Also, packet_mismatch is now redundant with RES_BAD_IO. This means that the only thing that report_match_status does is to report on register

[RISU v2 15/17] Compute reginfo_size based on the reginfo

2020-05-18 Thread Richard Henderson
This will allow dumping of SVE frames without having to know the SVE vector length beforehand. Signed-off-by: Richard Henderson --- risu.h | 2 +- reginfo.c | 6 +++--- risu_reginfo_aarch64.c | 4 ++-- risu_reginfo_arm.c | 2 +- risu_reginfo_i386.c| 2 +-

[RISU v2 12/17] Simplify syncing with master

2020-05-18 Thread Richard Henderson
Do not pass status like RES_BAD_IO from apprentice to master. This means that when master reports i/o error that we know it came from master; the apprentice will report its own i/o error. Signed-off-by: Richard Henderson --- reginfo.c | 11 +-- 1 file changed, 5 insertions(+), 6

[RISU v2 05/17] Use EXIT_FAILURE, EXIT_SUCCESS

2020-05-18 Thread Richard Henderson
Some of the time we exit via the return value from main. This can make it easier to tell what it is we're returning. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- comms.c| 26 +- risu.c | 22 +++---

[RISU v2 07/17] Add enum RisuOp

2020-05-18 Thread Richard Henderson
Formalize the set of defines, plus -1, into an enum. Signed-off-by: Richard Henderson --- risu.h | 23 +++ reginfo.c | 32 +++- risu_aarch64.c | 6 +++--- risu_arm.c | 6 +++--- risu_i386.c| 4 ++-- risu_m68k.c| 4 ++--

[RISU v2 01/17] Use bool for tracing variables

2020-05-18 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.h| 3 ++- reginfo.c | 2 +- risu.c| 8 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/risu.h b/risu.h index 8d2d646..e2b4508 100644 --- a/risu.h +++ b/risu.h @@ -17,6 +17,7 @@ #include

[RISU v2 09/17] Unify i/o functions and use RisuResult

2020-05-18 Thread Richard Henderson
Push the trace check down from the function calling the reginfo function down into the i/o function. This means we don't have to pass a function pointer. Return a RisuResult from the i/o functions. This fixes a minor bug in send_register_info (even before the conversion to RisuResult), which

[RISU v2 08/17] Add enum RisuResult

2020-05-18 Thread Richard Henderson
Formalize the random set of numbers into an enum. Doing this makes it easy to see that one of the responses in recv_and_compare_register_info was inconsistent. Signed-off-by: Richard Henderson --- risu.h| 25 + reginfo.c | 32 risu.c

[RISU v2 03/17] Hoist trace file opening

2020-05-18 Thread Richard Henderson
We will want to share this code with --dump. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/risu.c b/risu.c index 059348f..1c66885 100644 --- a/risu.c +++

[RISU v2 02/17] Unify master_fd and apprentice_fd to comm_fd

2020-05-18 Thread Richard Henderson
Any one invocation cannot be both master and apprentice. Let's use only one variable for the file descriptor. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[RISU v2 06/17] Make some risu.c symbols static

2020-05-18 Thread Richard Henderson
These are unused in other translation units. Signed-off-by: Richard Henderson --- risu.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/risu.c b/risu.c index 979341c..24ada8f 100644 --- a/risu.c +++ b/risu.c @@ -31,18 +31,18 @@ void *memblock;

[RISU v2 04/17] Adjust tracefile open for write

2020-05-18 Thread Richard Henderson
Truncate the new output file. Rely on umask to remove group+other file permissions, if desired. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risu.c b/risu.c index 1c66885..f404d8f 100644 --- a/risu.c

[RISU v2 00/17] risu cleanups and improvements

2020-05-18 Thread Richard Henderson
This patch set does alter the format of the trace files, and thus means we'll have to re-generate these. However, the space saved for sve trace files is significant, so I consider it worthwhile. In addition, the new --dump option allows one to inspect the contents of the trace file. Version 2

RE: Simplifying the Hexagon frontend

2020-05-18 Thread Taylor Simpson
> -Original Message- > From: Alessandro Di Federico > Sent: Monday, May 18, 2020 4:15 PM > To: qemu-devel@nongnu.org Developers > Cc: Taylor Simpson ; Niccolò Izzo ; > Brian Cain > Subject: Simplifying the Hexagon frontend > > Hi, this e-mail is intended to bootstrap a public

[Bug 1879425] [NEW] The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-18 Thread cliff chen
Public bug reported: Hi Expert: The VM is hung here after (2, or 3, or 5 and the longest time is 10 hours) by qemu-kvm. Notes: for VM: OS: RHEL 7.6 CPU: 1 MEM:4G For qemu-kvm: 1) version: /usr/libexec/qemu-kvm -version QEMU emulator version

Re: checkpatch error checking target arch in libvhost-user

2020-05-18 Thread Raphael Norwitz
> Can we make it a run-time value instead? It's definitely possible, but will require a bit of refactoring. How about for now I set a reasonable maximum which is supported by all platforms (32)? That still increases it a lot from 8, and we can figure out how best increase it even more for other

Re: [PATCH 05/24] aspeed: Don't create unwanted "cortex-a7-arm-cpu" devices

2020-05-18 Thread Joel Stanley
On Mon, 18 May 2020 at 12:24, Cédric Le Goater wrote: > > On 5/18/20 7:03 AM, Markus Armbruster wrote: > > The number of CPUs is controlled by property "num-cpus". > > aspeed_soc_ast2600_init() creates the maximum supported number. > > aspeed_soc_ast2600_realize() realizes only the wanted number.

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

2020-05-18 Thread Joel Stanley
On Mon, 18 May 2020 at 12:19, Cédric Le Goater wrote: > > On 5/18/20 7:03 AM, Markus Armbruster wrote: > > These devices are optional, and controlled by @nb_nics. > > aspeed_soc_ast2600_init() and aspeed_soc_init() create the maximum > > supported number. aspeed_soc_ast2600_realize() and > >

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-05-18 Thread John Snow
On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: > 18.05.2020 21:23, John Snow wrote: >> >> >> On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 14.05.2020 08:53, John Snow wrote: move python/qemu/*.py to python/qemu/lib/*.py. To create a namespace package, the

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

2020-05-18 Thread Andrew Jeffery
On Mon, 18 May 2020, at 21:49, Cédric Le Goater wrote: > On 5/18/20 7:03 AM, Markus Armbruster wrote: > > These devices are optional, and controlled by @nb_nics. > > aspeed_soc_ast2600_init() and aspeed_soc_init() create the maximum > > supported number. aspeed_soc_ast2600_realize() and > >

Re: [PATCH v7 00/14] LUKS: encryption slot management using amend interface

2020-05-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200518122041.10694-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200518122041.10694-1-mlevi...@redhat.com Subject: [PATCH v7 00/14] LUKS: encryption slot management

Re: [PATCH Kernel v22 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

2020-05-18 Thread Alex Williamson
On Mon, 18 May 2020 11:26:34 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content

[PATCH v2 2/2] spapr: Add a new level of NUMA for GPUs

2020-05-18 Thread Reza Arbab
NUMA nodes corresponding to GPU memory currently have the same affinity/distance as normal memory nodes. Add a third NUMA associativity reference point enabling us to give GPU nodes more distance. This is guest visible information, which shouldn't change under a running guest across migration

[PATCH v2 1/2] spapr: Add associativity reference point count to machine info

2020-05-18 Thread Reza Arbab
Make the number of NUMA associativity reference points a machine-specific value, using the currently assumed default (two reference points). This preps the next patch to conditionally change it. Signed-off-by: Reza Arbab --- hw/ppc/spapr.c | 6 +- include/hw/ppc/spapr.h | 1 + 2

Re: [PATCH RFC v2 5/5] iotests: add 287 for block-dirty-bitmap-populate

2020-05-18 Thread Eric Blake
On 5/13/20 10:49 PM, John Snow wrote: Give block-dirty-bitmap-populate a workout. Signed-off-by: John Snow --- tests/qemu-iotests/287 | 242 ++ tests/qemu-iotests/287.out | 4544 Sheesh, that output file is a workout indeed.

Simplifying the Hexagon frontend

2020-05-18 Thread Alessandro Di Federico
Hi, this e-mail is intended to bootstrap a public discussion on how to improve the Hexagon frontend implementation. At rev.ng, Niccolò and I, developed an Hexagon frontend, and we're (finally!) joining forces with the QuIC guys to merge our efforts (did you see our talk [1]?). The status is as

Re: [PATCH RFC v2 3/5] qmp: expose block-dirty-bitmap-populate

2020-05-18 Thread Eric Blake
On 5/13/20 10:49 PM, John Snow wrote: This is a new job-creating command. Signed-off-by: John Snow --- qapi/block-core.json | 18 +++ qapi/transaction.json | 2 ++ blockdev.c| 74 +++ 3 files changed, 94 insertions(+) diff

Re: [PATCH not-for-merge 2/5] qom: Make "info qom-tree" show children sorted

2020-05-18 Thread Eric Blake
On 5/18/20 12:19 AM, Markus Armbruster wrote: "info qom-tree" prints children in unstable order. This is a pain when diffing output for different versions to find change. Print it sorted. Yes, this does seem reasonable to include even without the rest of the series. Signed-off-by:

[PULL 7/7] qemu-img: Add bitmap sub-command

2020-05-18 Thread Eric Blake
Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it matches what QMP commands exist). Listing is omitted, because it does not

[PULL 6/7] blockdev: Split off basic bitmap operations for qemu-img

2020-05-18 Thread Eric Blake
Upcoming patches want to add some basic bitmap manipulation abilities to qemu-img. But blockdev.o is too heavyweight to link into qemu-img (among other things, it would drag in block jobs and transaction support - qemu-img does offline manipulation, where atomicity is less important because there

[PULL 4/7] block: Make it easier to learn which BDS support bitmaps

2020-05-18 Thread Eric Blake
Upcoming patches will enhance bitmap support in qemu-img, but in doing so, it turns out to be nice to suppress output when persistent bitmaps make no sense (such as on a qcow2 v2 image). Add a hook to make this easier to query. This patch adds a new callback

Re: [PATCH RFC v2 2/5] blockdev: combine DriveBackupState and BlockdevBackupState

2020-05-18 Thread Eric Blake
On 5/13/20 10:49 PM, John Snow wrote: They have the same fields -- rename it BlockJobState. This says BlockJobState... Signed-off-by: John Snow --- blockdev.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/blockdev.c b/blockdev.c

[PULL 5/7] blockdev: Promote several bitmap functions to non-static

2020-05-18 Thread Eric Blake
The next patch will split blockdev.c, which will require accessing some previously-static functions from more than one .c file. But part of promoting a function to public is picking a naming scheme that does not reek of exposing too many internals (two of the three functions were named starting

Re: [PATCH not-for-merge 0/5] Instrumentation for "Fixes around device realization"

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:19, Markus Armbruster wrote: > This is the instrumentation mentioned in "[PATCH 00/24] Fixes around > device realization". > > PATCH 2/5 might have value on its own. You tell me. > > Shell script to smoke-test all machines: > > #!/bin/sh > success=0 > fail=0 > ulimit -c 0 >

[PULL 1/7] bitmaps: Update maintainer

2020-05-18 Thread Eric Blake
Dirty bitmaps are important to incremental backups, including exposure over NBD where I'm already maintainer. Also, I'm aware that lately I have been doing as much code/review on bitmaps as John Snow who is trying to scale back in order to focus elsewhere; and many of the recent patches have come

[PULL 3/7] qemu-img: Fix stale comments on doc location

2020-05-18 Thread Eric Blake
Missed in commit e13c59fa. Signed-off-by: Eric Blake Reviewed-by: Max Reitz Message-Id: <20200513011648.166876-3-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy --- qemu-img.c | 2 +- qemu-img-cmds.hx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PULL 2/7] docs: Sort sections on qemu-img subcommand parameters

2020-05-18 Thread Eric Blake
We already list the subcommand summaries alphabetically, we should do the same for the documentation related to subcommand-specific parameters. Signed-off-by: Eric Blake Reviewed-by: Max Reitz Message-Id: <20200513011648.166876-2-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[PULL 0/7] bitmaps patches for 2020-05-18

2020-05-18 Thread Eric Blake
The following changes since commit a28c9c8c9fc42484efe1bf5a77affe842e54e38b: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200518-pull-request' into staging (2020-05-18 16:37:09 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps

Re: [PULL 0/6] NBD patches for 2020-05-18

2020-05-18 Thread Eric Blake
On 5/18/20 11:32 AM, Eric Blake wrote: The following changes since commit debe78ce14bf8f8940c2bdf3ef387505e9e035a9: Merge remote-tracking branch 'remotes/rth/tags/pull-fpu-20200515' into staging (2020-05-15 19:51:16 +0100)

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

2020-05-18 Thread Eric Blake
On 5/13/20 10:49 PM, John Snow wrote: This job copies the allocation map into a bitmap. It's a job because there's no guarantee that allocation interrogation will be quick (or won't hang), so it cannot be retrofit into block-dirty-bitmap-merge. retrofitted It was designed with different

Re: [PATCH 22/24] qdev: Assert devices are plugged into a bus that can take them

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:04, Markus Armbruster wrote: > This would have caught some of the bugs I just fixed. > > Signed-off-by: Markus Armbruster > --- > hw/core/qdev.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 9e5538aeae..0df995eb94 100644

Re: [PATCH 15/24] macio: Fix macio-bus to be a subtype of System bus

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:03, Markus Armbruster wrote: > The devices we plug into the macio-bus are all sysbus devices > (DeviceClass member bus_type is TYPE_SYSTEM_BUS), but macio-bus does > not derive from TYPE_SYSTEM_BUS. Fix that. > > "info qtree" now shows the devices' mmio ranges, as it should >

Re: [PATCH 14/24] macio: Put "macio-nvram" device on the macio bus

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:03, Markus Armbruster wrote: > macio_oldworld_init() creates a "macio-nvram", sysbus device, but > neglects to but it on a bus. > > Put it on the macio bus. Affects machine g3beige. Visible in "info > qtree": > > bus: macio.0 >type macio-bus >

[PATCH v3 1/3] crypto/secret: move main logic from 'secret' to 'secret_common'.

2020-05-18 Thread Alexey Krasikov
Create base class 'common secret'. Move common data and logic from 'secret' to 'common_secret' class. This allowed adding abstraction layer for easier adding new 'secret' objects in future. Convert 'secret' class to child from basic 'secret_common' with 'data' and 'file' properties.

Re: [PATCH v3 4/7] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job

2020-05-18 Thread Eric Blake
On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap. Prepatch, on source we use bdrv_get_device_or_node_name() to identify the node, and on target we do bdrv_lookup_bs.

[PATCH v3 3/3] test-crypto-secret: add 'secret_keyring' object tests.

2020-05-18 Thread Alexey Krasikov
Add tests: test_secret_keyring_good; test_secret_keyring_revoked_key; test_secret_keyring_expired_key; test_secret_keyring_bad_serial_key; test_secret_keyring_bad_key_access_right; Added tests require libkeyutils. The absence of this library is not critical, because these tests will be

Re: [PATCH 10/24] macio: Bury unwanted "macio-gpio" devices

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:03, Markus Armbruster wrote: > These devices go with the "via-pmu" device, which is controlled by > property "has-pmu". macio_newworld_init() creates it unconditionally, > because the property has not been set then. macio_newworld_realize() > realizes it only when the property

[PATCH v3 2/3] crypto/linux_keyring: add 'secret_keyring' secret object.

2020-05-18 Thread Alexey Krasikov
Add the ability for the secret object to obtain secret data from the Linux in-kernel key managment and retention facility, as an extra option to the existing ones: reading from a file or passing directly as a string. The secret is identified by the key serial number. The upper layers need to

[PATCH v3 0/3] Add secret_keyring object

2020-05-18 Thread Alexey Krasikov
Add the ability to store encryption keys in the Linux keyring facility. For that, factor out common parts from secret to a new abstract class secret_common, and introduce new user-creatable secret_keyring class inheriting from it. Use '--enable-keyring/--disable-keyring' configuration parameters

[PATCH v6 21/21] hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips

2020-05-18 Thread Aleksandar Markovic
Machine file names should not have prefix "mips_". Fuloong2e machine source file will be handled in a separate patch, to avoid conflicts. That patch is pending integration into the main tree. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- MAINTAINERS

[PATCH v6 19/21] target/mips: msa: Split helpers for MSUBV.

2020-05-18 Thread Aleksandar Markovic
Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 6 ++- target/mips/msa_helper.c | 79 target/mips/translate.c | 19 -- 3 files changed, 93 insertions(+), 11 deletions(-)

[PATCH v6 18/21] target/mips: msa: Split helpers for MADDV.

2020-05-18 Thread Aleksandar Markovic
Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 6 ++- target/mips/msa_helper.c | 79 target/mips/translate.c | 19 -- 3 files changed, 92 insertions(+), 12 deletions(-)

Re: [PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices

2020-05-18 Thread Mark Cave-Ayland
On 18/05/2020 06:03, Markus Armbruster wrote: > mac_via_realize() creates a "mos6522-q800-via1" and a > "mos6522-q800-via2" device, but neglects to realize them. Affects > machine q800. > > I wonder how this ever worked. If the "device becomes real only on > realize" thing actually works, then

[PATCH v6 16/21] target/mips: fpu: Refactor conversion from ieee to mips exception flags

2020-05-18 Thread Aleksandar Markovic
The original coversion function is used for regular and MSA floating point instructions handling. Since there are some nuanced differences between regular and MSA floating point exception handling, provide two instances of the conversion function, rather than just a single common one. Inline both

[PATCH v6 15/21] target/mips: fpu: Name better paired-single variables

2020-05-18 Thread Aleksandar Markovic
Use consistently 'l' and 'h' for low and high halves. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v6 10/21] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros

2020-05-18 Thread Aleksandar Markovic
After demacroing ., these macros are not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 50 1 file changed, 50 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v6 13/21] target/mips: fpu: Demacro RINT.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-)

[PATCH v6 09/21] target/mips: fpu: Demacro NMSUB.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 44 +++- 1 file changed, 43 insertions(+),

[PATCH v6 20/21] hw/mips: Add some logging for bad register offset cases

2020-05-18 Thread Aleksandar Markovic
Log the cases where a guest attempts read or write using bad register offset. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- hw/mips/mips_malta.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v6 05/21] target/mips: fpu: Remove now unused macro FLOAT_BINOP

2020-05-18 Thread Aleksandar Markovic
After demacroing ., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c

[PATCH v6 12/21] target/mips: fpu: Remove now unused FLOAT_CLASS macro

2020-05-18 Thread Aleksandar Markovic
After demacroing CLASS., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v6 14/21] target/mips: fpu: Remove now unused FLOAT_RINT macro

2020-05-18 Thread Aleksandar Markovic
After demacroing RINT., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 13 - 1 file changed, 13 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index

[PATCH v6 04/21] target/mips: fpu: Demacro DIV.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1

[PATCH v6 11/21] target/mips: fpu: Demacro CLASS.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 70 ++-- 1 file changed, 68 insertions(+),

[PATCH v6 17/21] MAINTAINERS: Change Aleksandar Rikalo's email address

2020-05-18 Thread Aleksandar Markovic
Aleksandar Rikalo wants to use a different email address from now on. Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- .mailmap| 3 ++- MAINTAINERS | 12 ++-- 2 files changed, 8

[PATCH v6 03/21] target/mips: fpu: Demacro MUL.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1

[PATCH v6 08/21] target/mips: fpu: Demacro NMADD.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 44 +++- 1 file changed, 43 insertions(+),

[PATCH v6 07/21] target/mips: fpu: Demacro MSUB.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 40 +++- 1 file changed, 39 insertions(+),

[PATCH v6 06/21] target/mips: fpu: Demacro MADD.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 41 +++- 1 file changed, 40 insertions(+),

[PATCH v6 00/21] target/mips: MSA, FPU and other cleanups and improvements

2020-05-18 Thread Aleksandar Markovic
This series contains some pathces that split heprers in msa_helper.c. It will make easier for debugging tools to display involved source code, and also introduces some modest performance improvements gains for all involved MSA instructions. Also, this series contains mostly cosmetic FPU cleanups

[PATCH v6 02/21] target/mips: fpu: Demacro SUB.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1

[PATCH v6 01/21] target/mips: fpu: Demacro ADD.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 38 +- 1 file changed, 37 insertions(+), 1

Re: QEMU 5.1: Can we require each new device/machine to provided a test?

2020-05-18 Thread John Snow
On 5/15/20 6:23 AM, Daniel P. Berrangé wrote: > On Fri, May 15, 2020 at 12:11:17PM +0200, Thomas Huth wrote: >> On 07/04/2020 12.59, Philippe Mathieu-Daudé wrote: >>> Hello, >>> >>> Following Markus thread on deprecating unmaintained (untested) code >>> (machines) [1] and the effort done to

Re: [PATCH v4 7/9] qcow2: Expose bitmaps' size during measure

2020-05-18 Thread Vladimir Sementsov-Ogievskiy
18.05.2020 22:17, Eric Blake wrote: On 5/18/20 8:07 AM, Vladimir Sementsov-Ogievskiy wrote: 13.05.2020 04:16, Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data.  Report this value

[PATCH v5 22/22] hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips

2020-05-18 Thread Aleksandar Markovic
Machine file names should not have prefix "mips_". Fuloong2e machine source file will be handled in a separate patch, to avoid conflicts. That patch is pending integration into the main tree. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- MAINTAINERS

[PATCH v5 20/22] target/mips: msa: Split helpers for MSUBV.

2020-05-18 Thread Aleksandar Markovic
Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 6 ++- target/mips/msa_helper.c | 79 target/mips/translate.c | 19 -- 3 files changed, 93 insertions(+), 11 deletions(-)

[PATCH v5 18/22] MAINTAINERS: Change Aleksandar Rikalo's email address

2020-05-18 Thread Aleksandar Markovic
Aleksandar Rikalo wants to use a different email address from now on. Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- .mailmap| 3 ++- MAINTAINERS | 12 ++-- 2 files changed, 8

Re: [PATCH v5 01/22] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-18 Thread Aleksandar Markovic
пон, 18. мај 2020. у 21:42 Aleksandar Markovic је написао/ла: > > From: Jafar Abdi > This patch was selected by mistake to be included in this series. A ne version of this series will be sent without this patch. Sorry about this. Aleksnadar > Clean up wrong usage of FALSE and TRUE in places

[PATCH v5 16/22] target/mips: fpu: Name better paired-single variables

2020-05-18 Thread Aleksandar Markovic
Use consistently 'l' and 'h' for low and high halves. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v5 17/22] target/mips: fpu: Refactor conversion from ieee to mips exception flags

2020-05-18 Thread Aleksandar Markovic
The original coversion function is used for regular and MSA floating point instructions handling. Since there are some nuanced differences between regular and MSA floating point exception handling, provide two instances of the conversion function, rather than just a single common one. Inline both

[PATCH v5 14/22] target/mips: fpu: Demacro RINT.

2020-05-18 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-)

Re: [RISU 0/9] risu cleanups and improvements

2020-05-18 Thread Richard Henderson
On 5/18/20 12:33 PM, Richard Henderson wrote: > On 5/18/20 11:39 AM, Peter Maydell wrote: >> Richard: if you feed an old trace file to the new risu, what >> error message does it give? > > Bah, it should have generated an error vs the magic number, but doesn't -- it > silently exits with success.

  1   2   3   4   5   >