Re: [Qemu-devel] [PATCH v2] qom: Fix memory leak in object_property_set_link()

2013-11-18 Thread Amos Kong
On Fri, Nov 15, 2013 at 12:09:47PM -0500, Vlad Yasevich wrote: Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- v1-v2: Builds and works :) qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Qemu-devel] [PATCH 3/3] ui/vnc: disable adaptive update calculations if not needed

2013-11-18 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c |9 + 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index edf33be..6683ae9 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3194,7 +3194,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)

[Qemu-devel] [PATCH 1/3] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro

2013-11-18 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c | 55 ++- ui/vnc.h |6 +- 2 files changed, 39 insertions(+), 22 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..67b1f75 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -442,17

[Qemu-devel] [PATCH 0/3] ui/vnc: update optimizations

2013-11-18 Thread Peter Lieven
this series includes 2 optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. Peter Peter Lieven (3): ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro ui/vnc: optimize dirty bitmap tracking ui/vnc: disable adaptive update

[Qemu-devel] [PATCH 2/3] ui/vnc: optimize dirty bitmap tracking

2013-11-18 Thread Peter Lieven
vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does almost the same. this patch optimizes both by utilizing the heavily optimized function find_next_bit to find the offset of the next

[Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Amos Kong
rxfilter_notify() is a generic function for all nics, not only for virtio_net, so move it to net.c Signed-off-by: Amos Kong ak...@redhat.com --- v2: fix the memory leak (Stefan) --- hw/net/virtio-net.c | 32 +--- include/net/net.h | 2 ++ net/net.c | 22

[Qemu-devel] [PATCH] target-ppc: remove MMUCFG SPR from POWER7/8 class

2013-11-18 Thread Alexey Kardashevskiy
PowerISA 2.06/2.07 put MMUCFG SPR to E (embedded) category so remove it from POWER7/8 class as it is S (server) category. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/translate_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/target-ppc/translate_init.c

Re: [Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id

2013-11-18 Thread Paolo Bonzini
Il 18/11/2013 04:02, Alexey Kardashevskiy ha scritto: On 11/15/2013 09:40 PM, Paolo Bonzini wrote: Il 15/11/2013 06:14, Alexey Kardashevskiy ha scritto: It does not feel that we really need CPUState::kvm_cpu_id and direct calling of kvm_arch_vcpu_id() would be enough. Indeed -- and it

[Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- drivers/net/virtio_net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-18 Thread Alexey Kardashevskiy
On 11/12/2013 06:18 PM, Alexey Kardashevskiy wrote: On 11/09/2013 11:20 AM, Alexey Kardashevskiy wrote: On 11/09/2013 03:59 AM, Andreas Färber wrote: Am 08.11.2013 15:54, schrieb Alexey Kardashevskiy: On 11/09/2013 12:44 AM, Andreas Färber wrote: Am 08.11.2013 03:37, schrieb Alexey

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com I don't mind, but driver should

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: 2013/11/15 Stefan Hajnoczi stefa...@gmail.com On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote: On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Claudio Fontana
Hello, On 09/27/2013 08:25 PM, Richard Henderson wrote: On 09/26/2013 05:48 PM, Alexander Graf wrote: This patch adds emulation support for the orr instruction. Signed-off-by: Alexander Graf ag...@suse.de --- target-arm/helper-a64.c| 28 +++ target-arm/helper-a64.h| 1 +

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Laurent Desnogues
On Mon, Nov 18, 2013 at 11:15 AM, Claudio Fontana claudio.font...@linaro.org wrote: Hello, On 09/27/2013 08:25 PM, Richard Henderson wrote: On 09/26/2013 05:48 PM, Alexander Graf wrote: This patch adds emulation support for the orr instruction. Signed-off-by: Alexander Graf ag...@suse.de

[Qemu-devel] [Bug 1245924] Re: mips64el magnum emulation broken

2013-11-18 Thread Darkstar
I just tried with the 1-line-patch referenced in the link above and it does indeed fix the black screen problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1245924 Title: mips64el magnum

[Qemu-devel] [PATCH] Fix processing of the MMU faults caused by the helper functions

2013-11-18 Thread Pavel Dovgaluk
MMU helper functions are called from generated code and other helper functions. In both cases they try to get function's return address for using it while restoring virtual CPU state. When MMU helper is called from some other helper function (like helper_maskmov_xmm) through cpu_st* function,

Re: [Qemu-devel] [PATCH] doc: fix hardcode helper path

2013-11-18 Thread Michael S. Tsirkin
On Wed, Oct 23, 2013 at 04:49:28AM +0800, Amos Kong wrote: The install directory of qemu-bridge-helper is configurabled, but we used a fixed path in document. DEFAULT_BRIDGE_HELPER macro isn't available in texi mode, we always use /path/to/ prefix for dynamic path (eg: /path/to/image,

[Qemu-devel] [PULL for-1.8 2/2] doc: fix hardcoded helper path

2013-11-18 Thread Michael S. Tsirkin
From: Amos Kong ak...@redhat.com The install directory of qemu-bridge-helper is configurable, but we use a fixed path in the documentation. DEFAULT_BRIDGE_HELPER macro isn't available in texi mode, we should always use /path/to/ prefix for dynamic paths (e.g.: /path/to/image, /path/to/linux,

[Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-18 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it. Taking in account problems it caused see 9604f70fdf and to avoid future incompatibility issues, it's safest to disable that interface by default for all machine

[Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8

2013-11-18 Thread Michael S. Tsirkin
The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch

[Qemu-devel] [Bug 1245924] Re: mips64el magnum emulation broken

2013-11-18 Thread Peter Maydell
That's more of a workaround than a fix. Herve's patch: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg00296.html is more the right approach I suspect. (I'm not sure why his email didn't get recorded in this bug; it seems to have been on the cc.) -- You received this bug notification

[Qemu-devel] [PATCH 00/21] RFCv2: add Spice block device

2013-11-18 Thread Marc-André Lureau
Hi, The following patch series implement a Spice block device, which allows the client to redirect a block device using the NBD protocol, which greatly simplifies the Spice code by reusing an existing protocol, and allows sharing existing qemu NBD implementation. The backend only support

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
On Mon, Nov 18, 2013 at 6:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote: On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu

[Qemu-devel] [PATCH 01/21] vscclient: do not add a socket watch if there is not data to send

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Fixes the following error: ** (process:780): CRITICAL **: do_socket_send: assertion `socket_to_send-len != 0' failed Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- libcacard/vscclient.c | 10 ++ 1 file changed, 6

[Qemu-devel] [PATCH 03/21] qmp_change_blockdev() remove unused has_format

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- blockdev.c| 2 +- include/sysemu/blockdev.h | 2 +- qmp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH 04/21] include: add missing config-host.h include

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- include/ui/qemu-spice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h index 86c75c7..a93b4b2 100644 ---

[Qemu-devel] [PATCH 06/21] Split nbd block client code

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block/Makefile.objs | 2 +- block/nbd-client.c | 372 +++ block/nbd-client.h | 51 +++ block/nbd.c | 373

[Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- include/sysemu/char.h | 10 ++ qemu-char.c | 7 +++ spice-qemu-char.c | 10 ++ 3 files changed, 27 insertions(+) diff --git

[Qemu-devel] [PATCH 13/21] blockdev: add qmp_change_blockdev_int()

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Allow to pass additional arguments, such as options and opaque Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- blockdev.c| 24 +++- include/sysemu/blockdev.h | 3 +++ 2 files changed, 22

[Qemu-devel] [PATCH 07/21] nbd: don't change socket block during negotiate

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com The caller might handle non-blocking using coroutine. Leave the choice to the caller to use a blocking or non-blocking negotiate. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- nbd.c | 1 - 1 file changed, 1 deletion(-) diff

[Qemu-devel] [PATCH 10/21] nbd: finish any pending coroutine

2013-11-18 Thread Marc-André Lureau
Make sure all pending coroutines are finished when closing the session. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- block/nbd-client.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index

[Qemu-devel] [PATCH 08/21] nbd: pass export name as init argument

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com There is no need to keep the export name around, and it seems a better fit as an argument in the init() call. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block/nbd-client.c | 10 -- block/nbd-client.h | 5 ++---

[Qemu-devel] [PATCH 14/21] block: extract make_snapshot() from bdrv_open()

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block.c | 121 +--- 1 file changed, 70 insertions(+), 51 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH 11/21] nbd: avoid uninitialized warnings

2013-11-18 Thread Marc-André Lureau
==15815== Thread 1: ==15815== Syscall param socketcall.sendto(msg) points to uninitialised byte(s) ==15815==at 0x65AD5CB: send (send.c:31) ==15815==by 0x37F84B: nbd_wr_sync (nbd.c:145) ==15815==by 0x37F94B: write_sync (nbd.c:186) ==15815==by 0x380FA9: nbd_send_request (nbd.c:681)

[Qemu-devel] [PATCH 15/21] block: add snapshot.size option to avoid extra bdrv_open()

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index 09aada5..9e7632e 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH 17/21] block: allow to call bdrv_open() with an opaque

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com If the block driver already has a bs-opaque when calling bdrv_open(), pass it down to the file driver. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Conflicts: block.c --- block.c | 9 +++-- 1 file changed, 7

[Qemu-devel] [PATCH 18/21] block: do not notify change during migration

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com When starting qemu, a block driver isn't associated with a device, so no notification is emitted when the media is loaded. The Spice block driver loads the media during migration. But at that time, the device is already associated, however, we

[Qemu-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Marc-André Lureau
The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch allows a Spice interface to be associated with a

[Qemu-devel] [PATCH 21/21] block: add spice block device backend

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block/Makefile.objs | 1 + block/spicebd.c | 536 2 files changed, 537 insertions(+) create mode 100644 block/spicebd.c

Re: [Qemu-devel] [PULL 47/58] qdev-monitor: Unref device when device_add fails

2013-11-18 Thread Amos Kong
On Tue, Oct 08, 2013 at 07:44:45PM +0200, Andreas Färber wrote: From: Stefan Hajnoczi stefa...@redhat.com qdev_device_add() leaks the created device upon failure. I suspect this problem crept in because qdev_free() unparents the device but does not drop a reference - confusing name. Cc:

Re: [Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The patch description is incomplete, or the patch should be split - this patch also implements qemu_chr_fe_event for spiceport. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

[Qemu-devel] [PATCH 02/21] spice-char: remove unused field

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- spice-qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 6d147a7..e074d9e 100644 --- a/spice-qemu-char.c +++

Re: [Qemu-devel] [RESEND][PATCH 1.7] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-11-18 Thread Peter Lieven
On 24.10.2013 11:14, Paolo Bonzini wrote: Il 24/10/2013 08:21, Peter Lieven ha scritto: Additionally we memmap target memory so it is essentially zero initialized (except for e.g. option roms and bios which are loaded into target memory although they shouldn't). It was reported recently that

Re: [Qemu-devel] [Spice-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch

Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-18 Thread Amos Kong
On Fri, Nov 15, 2013 at 11:49:27AM -0500, Vlad Yasevich wrote: On 11/15/2013 10:27 AM, Stefan Hajnoczi wrote: On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: @@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, return VIRTIO_NET_ERR;

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Michael Matz
Hi, On Mon, 18 Nov 2013, Claudio Fontana wrote: +case 3: +tcg_gen_rotr_i64(r, cpu_reg(reg), tcg_shift); +break; Incorrect rotate for 32bit? 32bit rotates and shifts were fixed in a patch later than the 60er series Alex posted. See attached. (Generally there are

[Qemu-devel] [PATCH 19/21] sysemu: add vm_start_hold/release

2013-11-18 Thread Marc-André Lureau
This is a simple solution (or hack?) to allow the Spice block driver to hold the VM from starting before the migration state is completed. During migration, the destination qemu needs to initialize the NBD session. This requires waiting for the Spice client and communication before the VM is

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Peter Maydell
On 18 November 2013 13:12, Michael Matz m...@suse.de wrote: Hi, On Mon, 18 Nov 2013, Claudio Fontana wrote: +case 3: +tcg_gen_rotr_i64(r, cpu_reg(reg), tcg_shift); +break; Incorrect rotate for 32bit? 32bit rotates and shifts were fixed in a patch later than the

[Qemu-devel] [PATCH 16/21] block: learn to open a driver with a given opaque

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com If the block driver is given an opaque data, there is no need to allocate a new one. This allows to pass an existing driver state to the new driver. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block.c | 48

[Qemu-devel] [PATCH 09/21] nbd: make session_close() idempotent

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block/nbd-client.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/nbd-client.c b/block/nbd-client.c index e29227b..c0ad2c2 100644 --- a/block/nbd-client.c +++

[Qemu-devel] [PATCH 12/21] block: save the associated child name in BlockDriverState

2013-11-18 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com This allows the Spice block driver to eject the associated device. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- block.c | 58 --- include/block/block_int.h | 1

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Claudio Fontana
On 11/18/2013 02:15 PM, Peter Maydell wrote: On 18 November 2013 13:12, Michael Matz m...@suse.de wrote: Hi, On Mon, 18 Nov 2013, Claudio Fontana wrote: +case 3: +tcg_gen_rotr_i64(r, cpu_reg(reg), tcg_shift); +break; Incorrect rotate for 32bit? 32bit rotates and

[Qemu-devel] [Bug 1245924] Re: mips64el magnum emulation broken

2013-11-18 Thread Darkstar
Yeah, that patch looks better, I was already wondering why nobody seemed to care since it's a pretty easy fix. I have a another bug I want to report with MIPS Magnum but it depends on this bug here so I'd rather wait until this is fixed before submitting the other bug report (or can I make a bug

Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote: @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc-info_str); } +void rxfilter_notify(NetClientState *nc, Object *obj) +{ +QObject *event_data; +gchar *path =

Re: [Qemu-devel] [PATCH] HMP: snapshot_blkdev can not consider //root/sn1 and /root/sn1 as the same file

2013-11-18 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 10:21:40AM -0700, Eric Blake wrote: On 11/15/2013 09:42 AM, Max Reitz wrote: Actually, the same problem can occur anyway if you have a path with a couple of “.” and “..” in it – or even just a hardlink. Thus, to be completely safe, we'd have to check whether the

[Qemu-devel] [Bug 1252270] [NEW] installing NT4 on MIPS Magnum/Jazz asserts

2013-11-18 Thread Darkstar
Public bug reported: While installing NT4 on MIPS Magnum (Jazz), when the NT Installer tries to format the harddisk, QEmu 1.6.1 crashes with an assertion: qemu-system-mips64el: g364: invalid read at [00102000] qemu-system-mips64el: hw/scsi/scsi-bus.c:1577: scsi_req_data: Assertion

[Qemu-devel] [Bug 1252270] Re: installing NT4 on MIPS Magnum/Jazz asserts

2013-11-18 Thread Darkstar
As a side note, that invalid read at... warning is unrelated, as it happens right on startup -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1252270 Title: installing NT4 on MIPS Magnum/Jazz asserts

Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Amos Kong
On Mon, Nov 18, 2013 at 02:25:40PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote: @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc-info_str); } +void rxfilter_notify(NetClientState *nc,

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Claudio Fontana
Btw, in the first patch: On 11/18/2013 02:12 PM, Michael Matz wrote: From df54486da31d6329696effa61096eda5ab85395a Mon Sep 17 00:00:00 2001 From: Michael Matz m...@suse.de Date: Sun, 24 Mar 2013 02:52:42 +0100 Subject: [PATCH] Fix 32bit rotates. The 32bit shifts generally weren't careful

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Peter Maydell
On 18 November 2013 13:43, Claudio Fontana claudio.font...@linaro.org wrote: We are using gen_rotr_i32, but passing tcg_shift, which is a TCGv_i64. I remember I had compilation failures in the past when I tried something similar, so my understanding is that this can work with a certain

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Michael Matz
Hi, On Mon, 18 Nov 2013, Peter Maydell wrote: +case 3: +tcg_gen_rotr_i64(r, cpu_reg(reg), tcg_shift); +break; Incorrect rotate for 32bit? 32bit rotates and shifts were fixed in a patch later than the 60er series Alex posted. See attached. (Generally

[Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Amos Kong
object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 613f144..2b2fb57 100644

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Peter Maydell
On 18 November 2013 13:46, Michael Matz m...@suse.de wrote: On Mon, 18 Nov 2013, Peter Maydell wrote: I think we're going to need to look through and fold in those fixes, otherwise we'll end up reduplicating that work in the course of code review :-( Most probably. Authorship will be lost

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com --- hw/net/virtio-net.c | 8 1 file changed, 4

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 08:47 AM, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com -vlad --- hw/net/virtio-net.c | 8 1 file changed, 4

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Michael Matz
Hi, On Mon, 18 Nov 2013, Claudio Fontana wrote: +tcg_gen_trunc_i64_i32(tmp, cpu_reg(reg)); + tcg_gen_rotr_i32(tmp, tmp, tcg_shift); Isn't this problematic? We are using gen_rotr_i32, but passing tcg_shift, which is a TCGv_i64. With CONFIG_DEBUG_TCG it'll break, yes.

[Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1] to the list.. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I

Re: [Qemu-devel] [PULL 47/58] qdev-monitor: Unref device when device_add fails

2013-11-18 Thread Andreas Färber
Am 18.11.2013 13:29, schrieb Amos Kong: On Tue, Oct 08, 2013 at 07:44:45PM +0200, Andreas Färber wrote: From: Stefan Hajnoczi stefa...@redhat.com qdev_device_add() leaks the created device upon failure. I suspect this problem crept in because qdev_free() unparents the device but does not

Re: [Qemu-devel] [PATCH v2] target-lm32: move model features to LM32CPU

2013-11-18 Thread Andreas Färber
Am 17.11.2013 21:46, schrieb Michael Walle: Am 2013-10-14 23:46, schrieb Michael Walle: This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Michael Walle mich...@walle.cc ---

[Qemu-devel] Do chardev socket can deal with sigio

2013-11-18 Thread Xiaoziliang
Hello, I am sorry to trouble you , Now I meet a problem when I use qemu to implement my program. Do you know how to set the chardev socket can deal with sigio? It means that the vm need to be blocked like this wait_rep=1;while(wait_rep==1) until it receives the message from host . I

[Qemu-devel] First Patch, Requesting Comments‏

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1]. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I run into some

[Qemu-devel] [Bug 1252011] Re: needs pdcurses.dll to start

2013-11-18 Thread Stefan Weil
This is not a QEMU bug but a problem with privately built QEMU binaries for Windows. http://qemu.weilnetz.de/w32/old/qemu-w32-setup-20131116.exe now includes support for curses, but failed to add the necessary pdcurses.dll. http://qemu.weilnetz.de/w32/qemu-w32-setup-20131118.exe includes

[Qemu-devel] [Bug 1252010] Re: can't assign enough RAM to the VM

2013-11-18 Thread Stefan Weil
QEMU currently needs contiguous memory for the guest memory. Hosts running 32 bit Windows only provide about 2 GiB for programs. This 2 GiB is used for the executable, all loaded dlls and dynamic memory. Especially the dlls cause memory fragmentation, so newer versions of QEMU which need more dlls

[Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1] to the list.. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I

[Qemu-devel] [Bug 1252010] Re: can't assign enough RAM to the VM

2013-11-18 Thread Stefan Weil
** Changed in: qemu Status: New = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1252010 Title: can't assign enough RAM to the VM Status in QEMU: Confirmed Bug description:

[Qemu-devel] First Patch, Requesting Review

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1]. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I run into some

[Qemu-devel] [PATCH/RFC] qemu-img: show image conversion speed

2013-11-18 Thread Varad Gautam
From: Varad Gautam varadgau...@live.com Calculate and display write speed when converting image with the -p parameter. qemu-progress:qemu_progress_print() now takes speed parameter to print. Signed-off-by: Varad Gautam varadgau...@gmail.com --- include/qemu-common.h |4 ++-- qemu-img.c

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr is written. This assumes that guest driver will write all the macaddr from bit 0 to bit 5 when it changes the macaddr, this is the current behavior of linux driver

Re: [Qemu-devel] [PATCH v2] target-lm32: move model features to LM32CPU

2013-11-18 Thread Andreas Färber
Am 15.10.2013 00:46, schrieb Michael Walle: This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Michael Walle mich...@walle.cc --- changes since v1: - instead of storing

Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 09:39:26PM +0800, Amos Kong wrote: On Mon, Nov 18, 2013 at 02:25:40PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote: @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc)

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 02:52:53PM +1000, Dave Airlie wrote: So after talking to a few people at kvm forum I think the GPU code should probably use the dataplane stuff from the outset, The main advantages I think this gives me is being able to dequeue objects from the vq from a thread and

Re: [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8

2013-11-18 Thread Eric Blake
On 11/18/2013 04:53 AM, Michael S. Tsirkin wrote: The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at:

[Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak

2013-11-18 Thread Stefan Hajnoczi
object_get_canonical_path() returns a string that the caller is responsible for freeing. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b617f26..fc19cf6 100644 ---

Re: [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak

2013-11-18 Thread Andreas Färber
Am 18.11.2013 16:10, schrieb Stefan Hajnoczi: object_get_canonical_path() returns a string that the caller is responsible for freeing. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com What's the difference to Vlad's v2? Andreas --- qom/object.c | 5 +++-- 1 file changed, 3

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to

Re: [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 08:06:48AM -0700, Eric Blake wrote: On 11/18/2013 04:53 AM, Michael S. Tsirkin wrote: The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- hw/net/virtio-net.c | 8

Re: [Qemu-devel] [PATCH for-1.7] tests: add missing -display none to qtests

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 04:14:11PM +0100, Stefan Hajnoczi wrote: Commit 7ceeedd016facf8d58e14a0d1417fa7225d71072 (blockdev-test: add test case for drive_add duplicate IDs) and commit 43cd209803d6cffb1e1a028c9ff2fd0ff4fce954 (qdev-monitor-test: add device_add leak test cases) added qtest tests

Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests

2013-11-18 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 08:54:06PM +0100, Kevin Wolf wrote: Without it, you either get a window for a short time, or worse, test failures when 'make check' isn't run in an X session. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/blockdev-test.c | 2 +- tests/qdev-monitor-test.c

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-18 Thread Peter Lieven
I do not know, but this patch might introduce a regression. If I specify: -smp 2,sockets=1,cores=2,threads=1 to a Windows 2012 R2 Server it crashes at boot time. -smp 2 works. git bisect start # good: [62ecc3a0e3c77a4944c92a02dd7fae2ab1f2290d] Update VERSION for 1.6.1 release git bisect good

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Please make the default writeback so that ./check completes more quickly. Also, please also indicate in the commit description

Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests

2013-11-18 Thread Kevin Wolf
Am 18.11.2013 um 16:18 hat Stefan Hajnoczi geschrieben: On Fri, Nov 15, 2013 at 08:54:06PM +0100, Kevin Wolf wrote: Without it, you either get a window for a short time, or worse, test failures when 'make check' isn't run in an X session. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Amos Kong
object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/common | 13 -

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-18 Thread Peter Lieven
On 18.11.2013 16:23, Peter Lieven wrote: I do not know, but this patch might introduce a regression. If I specify: -smp 2,sockets=1,cores=2,threads=1 to a Windows 2012 R2 Server it crashes at boot time. -smp 2 works. for Linux /proc/cpuinfo reveals no cpu layout information (sibliings, cores,

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Kevin Wolf
Am 18.11.2013 um 16:29 hat Stefan Hajnoczi geschrieben: On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Please make the default writeback so that ./check completes more

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Kevin Wolf
Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben: On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 11:32:17PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com --- v2: put gchar *path inside rxfilter_notify_enabled

  1   2   3   >