Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

Eric Blake writes: > Leaving interpolation into JSON to qobject_from_jsonf() is more > robust than building QMP input manually; however, we have a few > places where code is already creating a QDict to interpolate > individual arguments, which cannot be reproduced with the >

Re: [Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

09.08.2017 18:41, Eric Blake wrote: On 08/09/2017 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: 09.08.2017 18:17, Vladimir Sementsov-Ogievskiy wrote: 185 can sometimes produce wrong output like this: This is because quite happens before first mirror request is done s/quite/quit/ (and, in

Re: [Qemu-devel] [PATCH v4 17/22] libqtest: Add qmp_args() helper

Eric Blake writes: > Similar to the previous helper, we can reduce the boilerplate > of most callers by passing the command name separately from > the interpolated arguments. Adjust the majority of the callers > that can use the new helpers; in the process, fixing a few >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] IDE: Do not flush empty drives

On Tue, Aug 08, 2017 at 01:57:07PM -0400, John Snow wrote: > Patches one and two here are a 2.10 bandaid that avoids a crash. > Patches three and four are a more comprehensive fix as written by > Kevin in another discussion and are being posted here for the sake > of a discussion. > > Patch three

Re: [Qemu-devel] [PATCH v4 16/22] libqtest: Add qmp_cmd() helper

Eric Blake writes: > Now that we've asserted that all of our interpolated QMP commands > include 'execute', we can reduce some of the caller boilerplate > by providing a helpr function to wrap commands with no arguments helper I don't get the dependency on asserting

Re: [Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

On 08/09/2017 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2017 18:17, Vladimir Sementsov-Ogievskiy wrote: >> 185 can sometimes produce wrong output like this: >> >> >> This is because quite happens before first mirror request is done > > s/quite/quit/ > >> (and, in specified case,

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

Am 09.08.2017 um 16:45 hat Alberto Garcia geschrieben: > On Wed 09 Aug 2017 03:42:07 PM CEST, Manos Pitsidianakis wrote: > > On Wed, Aug 09, 2017 at 02:36:20PM +0200, Alberto Garcia wrote: > >>On Wed 09 Aug 2017 11:36:12 AM CEST, Manos Pitsidianakis wrote: > >>> On Tue, Aug 08, 2017 at 05:04:48PM

Re: [Qemu-devel] [PATCH v2 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

Hi - Original Message - > This commit introduces a new vhost-user device for block, it uses a > chardev to connect with the backend, same with Qemu virito-blk device, > Guest OS still uses the virtio-blk frontend driver. > > To use it, start Qemu with command line like this: > >

Re: [Qemu-devel] [PATCH v4 15/22] libqtest: Delete qtest_qmp() wrappers

Eric Blake writes: > None of our tests were directly using qtest_qmp() and friends; > even tests like postcopy-test.c that manage multiple connections > get along just fine changing global_qtest as needed (other than > one callsite where it forgot to use the inlined form).

Re: [Qemu-devel] [PATCH v4 14/22] libqtest: Separate qmp_discard_response() from command

On 08/09/2017 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Upcoming patches will be adding new convenience methods for >> constructing QMP commands. But making every variation of sending >> support every variation of response handling becomes unwieldy; >> it's

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On Wed, 9 Aug 2017 18:11:51 +0300 Michael Tokarev wrote: > 09.08.2017 17:23, Greg Kurz wrote: > > This function has to ensure it doesn't follow a symlink that could be used > > to escape the virtfs directory. This could be easily achieved if fchmodat() > > on linux honored the

[Qemu-devel] Windows NT 4.0 PPC in PReP

There has been interest in making Windows NT 4.0 PPC work inside of the PReP machine. I was wondering if you had an idea on what the steps required to accomplish this would be.

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On Wed, 9 Aug 2017 10:01:14 -0500 Eric Blake wrote: > On 08/09/2017 09:55 AM, Eric Blake wrote: > > On 08/09/2017 09:23 AM, Greg Kurz wrote: > >> This function has to ensure it doesn't follow a symlink that could be used > >> to escape the virtfs directory. This could be

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On Wed, 9 Aug 2017 09:55:32 -0500 Eric Blake wrote: > On 08/09/2017 09:23 AM, Greg Kurz wrote: > > This function has to ensure it doesn't follow a symlink that could be used > > to escape the virtfs directory. This could be easily achieved if fchmodat() > > on linux honored

Re: [Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

09.08.2017 18:17, Vladimir Sementsov-Ogievskiy wrote: 185 can sometimes produce wrong output like this: = 185 2s ... - output mismatch (see 185.out.bad) --- /work/src/qemu/master/tests/qemu-iotests/185.out2017-07-14 \ 15:14:29.520343805 +0300 +++

Re: [Qemu-devel] [PATCH v4 13/22] libqtest: Add qmp_raw()

On 08/09/2017 09:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The majority of calls into libqtest's qmp() and friends are passing >> a JSON object that includes a command name; we can prove this by >> adding an assertion. The only outlier is qmp-test, which is

[Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

185 can sometimes produce wrong output like this: = 185 2s ... - output mismatch (see 185.out.bad) --- /work/src/qemu/master/tests/qemu-iotests/185.out2017-07-14 \ 15:14:29.520343805 +0300 +++ 185.out.bad 2017-08-07 16:51:02.231922900 +0300 @@ -37,7

Re: [Qemu-devel] [PATCH v2 1/4] vhost-user: add new vhost user messages to support virtio config space

Hi - Original Message - > Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be > used for live migration for vhost user devices, also vhost user devices > can benifit from the messages to get/set virtio config space from/to the benefit > I/O target besides Qemu. For the

Re: [Qemu-devel] [PATCH v4 14/22] libqtest: Separate qmp_discard_response() from command

Eric Blake writes: > Upcoming patches will be adding new convenience methods for > constructing QMP commands. But making every variation of sending > support every variation of response handling becomes unwieldy; > it's easier to specify that discarding a JSON response is >

Re: [Qemu-devel] [PATCH] unicore32: abort when entering "x 0" on the monitor

07.08.2017 17:16, Eduardo Otubo wrote: > On Mon, Jul 31, 2017 at 01:17:03PM +0300, Michael Tokarev wrote: >> 28.07.2017 14:51, Eduardo Otubo wrote: >>> Starting Qemu with "qemu-system-unicore32 -M puv3,accel=qtest -S -nographic" >>> and entering "x 0 " at the monitor prompt leads to abort(): >> >>

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

09.08.2017 17:23, Greg Kurz wrote: > This function has to ensure it doesn't follow a symlink that could be used > to escape the virtfs directory. This could be easily achieved if fchmodat() > on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but > it doesn't. > > The current

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On 08/09/2017 09:55 AM, Eric Blake wrote: > On 08/09/2017 09:23 AM, Greg Kurz wrote: >> This function has to ensure it doesn't follow a symlink that could be used >> to escape the virtfs directory. This could be easily achieved if fchmodat() >> on linux honored the AT_SYMLINK_NOFOLLOW flag as

[Qemu-devel] No video for Windows 2000 guest

The default vga card not longer works with a Windows 2000 guest. All I see is a black screen after a the Windows splash screen. This is the command-line I used: qemu-system-i386 -hda Windows2000HD.qcow2 -boot c -m 512 When using the -vga cirrus option video works. Testing was done with QEMU

Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On 08/09/2017 09:23 AM, Greg Kurz wrote: > This function has to ensure it doesn't follow a symlink that could be used > to escape the virtfs directory. This could be easily achieved if fchmodat() > on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but > it doesn't. Might be

Re: [Qemu-devel] [PATCH v4 13/22] libqtest: Add qmp_raw()

Eric Blake writes: > The majority of calls into libqtest's qmp() and friends are passing > a JSON object that includes a command name; we can prove this by > adding an assertion. The only outlier is qmp-test, which is testing > appropriate error responses to protocol

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

Hi Michael, On 27/07/2017 03:30, Michael Roth wrote: > This series was motivated by the discussion in this thread: > > https://www.redhat.com/archives/libvir-list/2017-June/msg01370.html > > The issue this series addresses is that when libvirt unplugs a VFIO PCI > device, > it may attempt to

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

On Wed 09 Aug 2017 03:42:07 PM CEST, Manos Pitsidianakis wrote: > On Wed, Aug 09, 2017 at 02:36:20PM +0200, Alberto Garcia wrote: >>On Wed 09 Aug 2017 11:36:12 AM CEST, Manos Pitsidianakis wrote: >>> On Tue, Aug 08, 2017 at 05:04:48PM +0200, Alberto Garcia wrote: On Tue 08 Aug 2017 04:56:20 PM

[Qemu-devel] [Bug 823733] Re: Soloaris can't be poweroff

** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/823733 Title: Soloaris can't be poweroff Status in QEMU: Triaged Bug description: Thank

Re: [Qemu-devel] [PATCH v2 0/6] block: remove legacy I/O throttling

On 08/09/2017 09:02 AM, Manos Pitsidianakis wrote: > This series depends on my other series 'add throttle block driver filter' > currently on v4. More precisely, for patchew: Based-on: <20170809100734.17540-1-el13...@mail.ntua.gr> -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [RFC PATCH 01/56] qobject: Touch up comments to say @param instead of 'param'

On 08/07/2017 09:45 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qobject/qdict.c | 68 > - > qobject/qlist.c | 2 +- > 2 files changed, 35 insertions(+), 35 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

Philippe Mathieu-Daudé writes: > On 08/08/2017 12:11 PM, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: > [...]>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 8cb94af6c5..6b83dac812 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -1633,6

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

Hi Paolo, On 07/28/2017 08:50 AM, Paolo Bonzini wrote: On 28/07/2017 08:24, Fam Zheng wrote: On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 224890643d..7854792765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1537,6 +1537,12 @@ Checkpatch S:

[Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

This function has to ensure it doesn't follow a symlink that could be used to escape the virtfs directory. This could be easily achieved if fchmodat() on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but it doesn't. The current implementation covers most use-cases, but it

[Qemu-devel] [Bug 823733] Re: Soloaris can't be poweroff

I just ran into the same issue on Arch with qemu 2.9.0 and as well Ubuntu qemu 2.8.something. Solaris 11 on powerdown shuts down to the point where it prompts you that it's now safe to power off the VM, works fine in vmware or virtualbox. In a packer build at this point you just fail as the VM

Re: [Qemu-devel] [RFC PATCH 44/47] MAINTAINERS: add missing entry for tilegx

ping? I suppose no answer/ping timeout confirms there is no maintainer for "Odd Fixes" so the "Orphan" status is correct. On 07/28/2017 02:36 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 1 file changed, 4 insertions(+)

Re: [Qemu-devel] [PATCH for-2.10 3/3] qdev: defer DEVICE_DEL event until instance_finalize()

Hi Michael, On 27/07/2017 03:30, Michael Roth wrote: > DEVICE_DEL is currently emitted when a Device is unparented, as > opposed to when it is finalized. The main design motivation for this > seems to be that after unparent()/unrealize(), the Device is no > longer visible to the guest, and thus

Re: [Qemu-devel] Making QEMU build with Python 3

On Wed, Aug 9, 2017 at 1:53 PM, Philippe Mathieu-Daudé wrote: > On 08/09/2017 07:16 AM, Stefan Hajnoczi wrote: > [...]> Python scripts needed to build QEMU are the highest priority. They >> >> are invoked by ./configure or make. I've identified the following: >> >>

[Qemu-devel] block replication

Hi Wen! I'm trying to understand block/replication code and have a question. Why should we block the region from intersecting cow requests when read? If I understand correctly regardless of writes to the secondary-disk we have consistent view of it through hidden-disk: Even if we are

[Qemu-devel] [PATCH v2 4/6] block: remove legacy I/O throttling

This commit removes all I/O throttling from block/block-backend.c. In order to support the existing interface, it is changed to use the block/throttle.c filter driver. The throttle filter node that is created by the legacy interface is stored in a 'throttle_node' field in the BlockBackendPublic

[Qemu-devel] [PATCH v2 0/6] block: remove legacy I/O throttling

This series depends on my other series 'add throttle block driver filter' currently on v4. Replacing the current I/O interface means the user will use the same options as before and QEMU will create a hidden throttle filter node beneath the device's BlockBackend. v2: new commit: require

[Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

With implicit filter nodes on the top of the graph it is not possible to generate job-ids with the name of the device in block_job_create() anymore, since the job's bs will not be a child_root. Instead we can require that job-id is not NULL in block_job_create(), and check that a job-id has been

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

On 08/08/2017 12:11 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: [...]>> diff --git a/MAINTAINERS b/MAINTAINERS index 8cb94af6c5..6b83dac812 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1633,6 +1633,7 @@ Common code M: Richard Henderson S:

[Qemu-devel] [PATCH v2 5/6] block: add iotest 191 for legacy throttling interface

Check that the implicit throttle filter driver node, used for compatibility with the legacy throttling interface on the BlockBackend level, works. Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/191 | 138 +

[Qemu-devel] [PATCH v2 1/6] block: skip implicit nodes in snapshots, blockjobs

Implicit filter nodes added at the top of nodes can interfere with block jobs. This is not a problem when they are added by other jobs since adding another job will issue a QERR_DEVICE_IN_USE, but it can happen in the next commit which introduces an implicitly created throttle filter node below

[Qemu-devel] [PATCH v2 2/6] block: add options parameter to bdrv_new_open_driver()

Allow passing a QDict *options parameter to bdrv_new_open_driver() so that it can be used if a driver needs it upon creation. The previous behaviour (empty bs->options and bs->explicit_options) remains when options is NULL. Signed-off-by: Manos Pitsidianakis --- block.c

[Qemu-devel] [PATCH v2 6/6] block: remove BlockBackendPublic

All BlockBackend level throttling (via the implicit throttle filter node) is done in block/block-backend.c and block/throttle-groups.c doesn't know about BlockBackends anymore. Since BlockBackendPublic is not needed anymore, remove it. Signed-off-by: Manos Pitsidianakis

Re: [Qemu-devel] [PATCH qemu v4 1/3] spapr_iommu: Realloc guest visible TCE table when hot(un)plugging vfio-pci

On Mon, Jul 24, 2017 at 08:48:45PM +1000, Alexey Kardashevskiy wrote: > On 24/07/17 15:53, David Gibson wrote: > > On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote: > >> This replaces g_malloc() with spapr_tce_alloc_table() as this is > >> the standard way of allocating tables

Re: [Qemu-devel] [PATCH for 2.10 v3 5/6] docker: don't install device-tree-compiler build-deps in travis.docker

On 08/07/2017 12:39 PM, Alex Bennée wrote: Installing the device-tree-compiler build-deps is a little extreme. We only actually need the binary so include it with the other packages. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée

Re: [Qemu-devel] Making QEMU build with Python 3

On Wed, Aug 9, 2017 at 2:10 PM, Daniel P. Berrange wrote: > On Wed, Aug 09, 2017 at 11:16:58AM +0100, Stefan Hajnoczi wrote: >> Ross created a bug to track Python 3 support: >> >> https://bugs.launchpad.net/qemu/+bug/1708462 >> >> Currently most Python code in QEMU is for

Re: [Qemu-devel] [PATCH v4 12/22] libqtest: Change qmp_fd_send() to drop varargs

On 08/09/2017 08:18 AM, Markus Armbruster wrote: > Eric Blake writes: > >> With the previous commit, no external clients are using qmp_fd() >> or qmp_fd_sendv(). Making qmp_fd_sendv() static lets us refactor >> the public qmp_fd_send() to be the common point where we send a

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

On Wed, Aug 09, 2017 at 02:36:20PM +0200, Alberto Garcia wrote: On Wed 09 Aug 2017 11:36:12 AM CEST, Manos Pitsidianakis wrote: On Tue, Aug 08, 2017 at 05:04:48PM +0200, Alberto Garcia wrote: On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote: So basically if we have anonymous

[Qemu-devel] [PATCH RFC 3/6] kvm: use start + size for memory ranges

Convert kvm_lookup_matching_slot(). Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f6ceeba..bec157e 100644 --- a/accel/kvm/kvm-all.c +++

[Qemu-devel] [PATCH RFC 5/6] kvm: kvm_log_start/stop are only called with known sections

Let's properly align the sections first and bail out if we would ever be called with a memory region we don't know yet. Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH RFC 4/6] kvm: we never have overlapping slots in kvm_set_phys_mem()

Due to how flatviews are handled, we will never have overlapping memory sections in kvm. address_space_update_topology_pass() will make sure that we will only get called for a) an existing memory section for which we only update parameters (log_start, log_stop). b) an existing memory section we

[Qemu-devel] [PATCH RFC 6/6] kvm: kvm_log_sync() is only called with known memory sections

Flatview will make sure that we can only end up in this function with memory sections that correspond to exactly one slot. So we don't have to iterate multiple times. There won't be overlapping slots but only matching slots. Properly align the section and look up the corresponding slot. This

[Qemu-devel] [PATCH RFC 2/6] kvm: factor out alignment of memory section

Factor it out, so we can reuse it later. Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c | 59 +++-- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index

[Qemu-devel] [PATCH RFC 1/6] kvm: require JOIN_MEMORY_REGIONS_WORKS

We already require DESTROY_MEMORY_REGION_WORKS, JOIN_MEMORY_REGIONS_WORKS was added just half a year later. In addition, with flatview overlapping memory regions are first removed before adding the changed one. So we can't really detect joining memory regions this way. Let's just get rid of this

[Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling

If I am not missing something important here, we can heavily simplify the kvm_slot code. Flatview will make sure that we don't have to deal with overlapping slots. E.g. when a memory section is resized, we are first notified about the removal and then about the new memory section. So basically,

Re: [Qemu-devel] [PATCH v4 11/22] test-qga: Simplify command construction

On 08/09/2017 06:40 AM, Markus Armbruster wrote: > Eric Blake writes: > >> When you build qga input manually like this: >> >> cmd = g_strdup_printf("{'execute': 'guest-file-write'," >> " 'arguments': {'handle': %" PRId64 "," >>

Re: [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features

On Wed, 9 Aug 2017 15:25:36 +0200 David Hildenbrand wrote: > > A comment which subfunction this is might be helpful. > > Indeed. > > /* query subfunction */ Looks good! > > > > >> +for (i = 0; i < 16; i++) { > >> +param_addr = wrap_address(env,

Re: [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features

>> @@ -792,6 +792,7 @@ static void add_qemu_cpu_model_features(S390FeatBitmap >> fbm) >> S390_FEAT_STFLE, >> S390_FEAT_EXTENDED_IMMEDIATE, >> S390_FEAT_EXTENDED_TRANSLATION_2, >> +S390_FEAT_MSA, >> S390_FEAT_EXTENDED_TRANSLATION_3, >>

Re: [Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

On 08/09/2017 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We want -Wformat to catch blatant programming errors in format >> strings that we pass to qobject_from_jsonf(). But if someone >> were to pass a JSON string "'%s'" as the format string, gcc would >>

Re: [Qemu-devel] [PATCH v4 12/22] libqtest: Change qmp_fd_send() to drop varargs

Eric Blake writes: > With the previous commit, no external clients are using qmp_fd() > or qmp_fd_sendv(). Making qmp_fd_sendv() static lets us refactor > the public qmp_fd_send() to be the common point where we send a > fixed string over the wire as well as log that string,

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

On 08/09/2017 02:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> qobject_from_jsonv() was unusual in that it took a va_list*, instead >> of the more typical va_list; this was so that callers could pass >> NULL to avoid % interpolation. While this works under the

Re: [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features

On 09.08.2017 15:01, Cornelia Huck wrote: > On Fri, 21 Jul 2017 14:56:08 +0200 > David Hildenbrand wrote: > > Finally got around to that one... > >> The STFLE bits for the MSA (extension) facilities simply indicate that >> the respective instructions can be executed. The QUERY

Re: [Qemu-devel] Making QEMU build with Python 3

On Wed, Aug 09, 2017 at 11:16:58AM +0100, Stefan Hajnoczi wrote: > Ross created a bug to track Python 3 support: > > https://bugs.launchpad.net/qemu/+bug/1708462 > > Currently most Python code in QEMU is for Python 2.6+ only. There > have only been a few patches adding Python 3 support to

Re: [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features

On Fri, 21 Jul 2017 14:56:08 +0200 David Hildenbrand wrote: Finally got around to that one... > The STFLE bits for the MSA (extension) facilities simply indicate that > the respective instructions can be executed. The QUERY subfunction can then > be used to identify which

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

On Tue, 8 Aug 2017 15:28:35 -0500 Eric Blake wrote: > On 08/08/2017 03:24 PM, Eric Blake wrote: > > On 08/08/2017 03:10 PM, Philippe Mathieu-Daudé wrote: > >>> Technically, POSIX says (and 'man 2 open' agrees, modulo the fact that > >>> Linux still lacks O_SEARCH) that you

Re: [Qemu-devel] Making QEMU build with Python 3

Hi Stefan, On 08/09/2017 07:16 AM, Stefan Hajnoczi wrote: [...]> Python scripts needed to build QEMU are the highest priority. They are invoked by ./configure or make. I've identified the following: scripts/signrom.py scripts/qapi*.py scripts/modules/module_block.py scripts/tracetool*

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

On Wed 09 Aug 2017 11:36:12 AM CEST, Manos Pitsidianakis wrote: > On Tue, Aug 08, 2017 at 05:04:48PM +0200, Alberto Garcia wrote: >>On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote: > So basically if we have anonymous groups, we accept limits in the > driver options but only

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 13:06:14 +0200 Cornelia Huck wrote: > On Wed, 9 Aug 2017 11:47:05 +0200 > Greg Kurz wrote: > > > On Wed, 9 Aug 2017 10:27:37 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > > Thomas Huth

Re: [Qemu-devel] [PATCH v4 11/22] test-qga: Simplify command construction

Eric Blake writes: > When you build qga input manually like this: > > cmd = g_strdup_printf("{'execute': 'guest-file-write'," > " 'arguments': {'handle': %" PRId64 "," > " 'buf-b64': '%s' } }", id, enc); > ret =

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 09/08/2017 12:56, Laszlo Ersek wrote: > Allow me one last question -- why (and since when) does each device have > its own separate address space? Is that related to the virtual IOMMU? No (though it helps there too). It's because a device that has bus-master DMA disabled in the command

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

Peter Xu wrote: > On Tue, Aug 08, 2017 at 11:19:35AM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: >> > >> > [...] >> > >> >> int multifd_load_setup(void) >> >> { >> >> int

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 9 August 2017 at 11:56, Laszlo Ersek wrote: > Now that I look at the "info mtree" monitor output of a random VM, I see > the following "address-space"s: > - memory > - I/O > - cpu-memory > - bunch of nameless ones, with top level regions called > "bus master container" > -

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 11:47:05 +0200 Greg Kurz wrote: > On Wed, 9 Aug 2017 10:27:37 +0200 > Cornelia Huck wrote: > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > But thinking about this again, I wonder whether it would be

Re: [Qemu-devel] [RFC 23/29] vub+postcopy: madvises

On 08/08/2017 08:06 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: On 06/28/2017 10:00 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Clear the area and turn off THP. Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 08/09/17 12:16, Paolo Bonzini wrote: > On 09/08/2017 12:00, Laszlo Ersek wrote: >> On 08/09/17 09:26, Paolo Bonzini wrote: >>> On 09/08/2017 03:06, Laszlo Ersek wrote: > 20.14% qemu-system-x86_64 [.] render_memory_region > 17.14% qemu-system-x86_64

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

On 07/08/2017 22:00, Kinsella, Ray wrote: Hi Marcel, Hi Ray, Please have a look on this thread, I think Laszlo and Paolo found the root cause. https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01368.html It seems hot-plugging the devices would not help. Thanks, MArcel Yup - I

Re: [Qemu-devel] [RFC PATCH 09/56] balloon: Make balloon size unsigned in QAPI/QMP

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Sizes should use QAPI type 'size' (uint64_t). balloon parameter > >> @value is 'int' (int64_t). qmp_balloon() implicitly converts to

Re: [Qemu-devel] [PATCH] target/i386: fix pmovsx/pmovzx in-place operations

On 08/08/2017 22:21, Joseph Myers wrote: > The SSE4.1 pmovsx* and pmovzx* instructions take packed 1-byte, 2-byte > or 4-byte inputs and sign-extend or zero-extend them to a wider vector > output. The associated helpers for these instructions do the > extension on each element in turn, starting

Re: [Qemu-devel] [PATCH] target/i386: set rip_offset for further SSE instructions

On 09/08/2017 01:51, Joseph Myers wrote: > It turns out that my recent fix to set rip_offset when emulating some > SSE4.1 instructions needs generalizing to cover a wider class of > instructions. Specifically, every instruction in the sse_op_table7 > table, coming from various instruction set

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On Tue, Aug 08, 2017 at 04:52:25PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Aug 08, 2017 at 10:06:04AM +0200, Markus Armbruster wrote: > >> Stefan Hajnoczi writes: > >> > >> > On Wed, Jul 26, 2017 at 02:24:02PM -0400,

Re: [Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

On Wed, Aug 9, 2017, at 18:28, Cédric Le Goater wrote: > On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > > The reset width register controls how the pulse on the SoC's WDTRST{1,2} > > pins behaves. A pulse is emitted if the external reset bit is set in > > WDT_CTRL. On the AST2500

Re: [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes

On Tue, Aug 08, 2017 at 02:56:47PM +0200, Lukáš Doktor wrote: > Dne 8.8.2017 v 14:38 Stefan Hajnoczi napsal(a): > > On Wed, Jul 26, 2017 at 04:42:17PM +0200, Lukáš Doktor wrote: > >> def command(self, cmd, conv_keys=True, **args): > >> +''' > >> +Invoke a QMP command and on

Re: [Qemu-devel] [PATCH v4 5/5] docs: update documentation considering PCIE-PCI bridge

On 08/08/17 21:21, Aleksandr Bezzubikov wrote: > 2017-08-08 18:11 GMT+03:00 Laszlo Ersek : >> one comment below >> >> On 08/05/17 22:27, Aleksandr Bezzubikov wrote: >> >>> +Capability layout (defined in include/hw/pci/pci_bridge.h): >>> + >>> +uint8_t id; Standard PCI

Re: [Qemu-devel] [PATCH v4 10/22] libqtest: Skip round-trip through QObject

Eric Blake writes: > When we don't have to do any % interpolation in qmp() and friends, > there is no point wasting time allocating a QObject from the format > string only to then format it back into the string we send over > the wire. True, but there's also no point in

[Qemu-devel] Making QEMU build with Python 3

Ross created a bug to track Python 3 support: https://bugs.launchpad.net/qemu/+bug/1708462 Currently most Python code in QEMU is for Python 2.6+ only. There have only been a few patches adding Python 3 support to certain scripts so far. In this email I want to highlight the most important

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 09/08/2017 12:00, Laszlo Ersek wrote: > On 08/09/17 09:26, Paolo Bonzini wrote: >> On 09/08/2017 03:06, Laszlo Ersek wrote: 20.14% qemu-system-x86_64 [.] render_memory_region 17.14% qemu-system-x86_64 [.] subpage_register 10.31%

[Qemu-devel] [PATCH v4 4/7] block: convert ThrottleGroup to object with QOM

ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP.

[Qemu-devel] [PATCH v4 5/7] block: add throttle block filter driver

block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2, \

[Qemu-devel] [PATCH v4 3/7] block: tidy ThrottleGroupMember initializations

Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos

[Qemu-devel] [PATCH v4 2/7] block: add aio_context field in ThrottleGroupMember

timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia

[Qemu-devel] [PATCH v4 7/7] block: add throttle block filter driver interface tests

Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 310 + tests/qemu-iotests/184.out | 422 + tests/qemu-iotests/group | 1 + 3 files changed, 733 insertions(+) create mode

[Qemu-devel] [PATCH v4 6/7] block: add BlockDevOptionsThrottle to QAPI

This is needed to configure throttle filter driver nodes with QAPI. Signed-off-by: Manos Pitsidianakis --- qapi/block-core.json | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index

[Qemu-devel] [PATCH v4 1/7] block: move ThrottleGroup membership to ThrottleGroupMember

This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This

[Qemu-devel] [PATCH v4 0/7] add throttle block driver filter

This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 08/09/17 09:26, Paolo Bonzini wrote: > On 09/08/2017 03:06, Laszlo Ersek wrote: >>> 20.14% qemu-system-x86_64 [.] render_memory_region >>> 17.14% qemu-system-x86_64 [.] subpage_register >>> 10.31% qemu-system-x86_64 [.] int128_add >>>

[Qemu-devel] [PATCH v2 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s

[Qemu-devel] [PATCH v2 3/4] contrib/libvhost-user: enable virtio config space messages

Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD messages in libvhost-user library, users can implement their own I/O target based on the library. This enable the virtio config space delivered between Qemu host device and the I/O target, also event notifier is added in

<    1   2   3   >