Re: [Qemu-devel] [Qemu-block] block migration and MAX_IN_FLIGHT_IO

Am 06.03.2018 um 17:35 schrieb Peter Lieven: > Am 06.03.2018 um 17:07 schrieb Stefan Hajnoczi: >> On Mon, Mar 05, 2018 at 02:52:16PM +, Dr. David Alan Gilbert wrote: >>> * Peter Lieven (p...@kamp.de) wrote: Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi: > On Thu, Feb 22, 2018 at

Re: [Qemu-devel] [PATCH QEMU v1 4/4] multiboot: fprintf(stderr...) -> error_report()

+-- On Thu, 21 Dec 2017, Jack Schwartz wrote --+ | Change all fprintf(stderr...) calls in hw/i386/multiboot.c to call | error_report() instead, including the mb_debug macro. Remove the "\n" | from strings passed to all modified calls, since error_report() appends | one. | | Signed-off-by: Jack

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

On Tue, 6 Mar 2018 23:40:18 + nee wrote: > On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huck wrote: > > On Tue, 6 Mar 2018 10:07:21 + > > Nia Alarie wrote: > > > >> Allows a branch to be removed - this function always

Re: [Qemu-devel] [PATCH QEMU v1 3/4] multiboot: Use header names when displaying fields

+-- On Thu, 21 Dec 2017, Jack Schwartz wrote --+ | Refer to field names when displaying fields in printf and debug statements. I wonder if it's required; Having variable names is helpful while going through code. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/19] uninorth: move PCI mmio memory region initialisation into init function

On 07/03/18 07:02, Mark Cave-Ayland wrote: On 06/03/18 23:44, BALATON Zoltan wrote: On Tue, 6 Mar 2018, Mark Cave-Ayland wrote: Whilst we are here, rename the memory regions to better reflect whether they belong to either a PCI or an AGP bus. Signed-off-by: Mark Cave-Ayland

Re: [Qemu-devel] [PATCH QEMU v1 2/4] multiboot: Remove unused variables from multiboot.c

+-- On Thu, 21 Dec 2017, Jack Schwartz wrote --+ | Remove unused variables: mh_mode_type, mh_width, mh_height, mh_depth | | Signed-off-by: Jack Schwartz | Reviewed-by: Daniel Kiper | --- | hw/i386/multiboot.c | 6 -- | 1 file changed, 6

Re: [Qemu-devel] [PATCH QEMU v1 1/4] multiboot: bss_end_addr can be zero

+-- On Thu, 21 Dec 2017, Jack Schwartz wrote --+ | The multiboot spec (https://www.gnu.org/software/grub/manual/multiboot/), | section 3.1.3, allows for bss_end_addr to be zero. | | A zero bss_end_addr signifies there is no .bss section. | | Suggested-by: Daniel Kiper |

Re: [Qemu-devel] [PATCH 1/3] vfio/pci: Pull BAR mapping setup from read-write path

On Wed, Feb 28, 2018 at 01:14:46PM -0700, Alex Williamson wrote: > This creates a common helper that we'll use for ioeventfd setup. > > Signed-off-by: Alex Williamson Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH 3/5] vfio/quirks: ioeventfd quirk acceleration

On Wed, Feb 28, 2018 at 01:45:54PM -0700, Alex Williamson wrote: > The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found > in device MMIO space. Normally PCI config space is considered a slow > path and further optimization is unnecessary, however NVIDIA uses a > register here to

[Qemu-devel] [PATCH] HMP: Initialize err before using

When bdrv_snapshot_delete return fail, the errp will not be assigned a valid value in error_propagate as errp didn't be initialized in hmp_delvm, then error_reportf_err will use an uninitialized value(call by hmp_delvm), and qemu crash. Signed-off-by: zhangjixiang ---

Re: [Qemu-devel] [PATCH 2/5] vfio/quirks: Add quirk reset callback

On Wed, Feb 28, 2018 at 01:45:37PM -0700, Alex Williamson wrote: > Quirks can be self modifying, provide a hook to allow them to cleanup > on device reset if desired. > > Signed-off-by: Alex Williamson Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH 1/5] vfio/quirks: Add common quirk alloc helper

On Wed, Feb 28, 2018 at 01:45:23PM -0700, Alex Williamson wrote: > This will later be used to include list initialization. > > Reviewed-by: Eric Auger > Signed-off-by: Alex Williamson Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/19] uninorth: move PCI mmio memory region initialisation into init function

On 06/03/18 23:44, BALATON Zoltan wrote: On Tue, 6 Mar 2018, Mark Cave-Ayland wrote: Whilst we are here, rename the memory regions to better reflect whether they belong to either a PCI or an AGP bus. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/uninorth.c |

[Qemu-devel] [PATCH] qemu-doc: Add the paragraph about the -no-frame deprecation again

The section has accidentially been removed while resolving a contextual conflict during a rebase, so add this again. Fixes: f29d4450428fe07e9d6b0655cef2e59bfa0b2ea5 Signed-off-by: Thomas Huth --- NB: I also slightly changed the wording and removed the "SDL 2.0 lacks support

[Qemu-devel] [PATCH v5 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when mmap, munmap, mprotect, mremap or shmat is called for an address outside the guest address space. mmap and mprotect should return ENOMEM in such case. Change

Re: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form

On 7/3/18 5:24 pm, Thomas Huth wrote: > On 07.03.2018 04:38, Alexey Kardashevskiy wrote: >> On 01/02/18 20:35, Alexey Kardashevskiy wrote: >>> Signed-off-by: Alexey Kardashevskiy >> >> Ping? >> >> >>> --- >>> slirp/arp_table.c | 4 ++-- >>> slirp/socket.c| 8 >>>

Re: [Qemu-devel] [RFC PATCH qemu] slirp: Update forwarding IP address if guest receiver non-default IP

On 07.03.2018 04:39, Alexey Kardashevskiy wrote: > On 08/02/18 15:29, Alexey Kardashevskiy wrote: >> On 01/02/18 20:36, Alexey Kardashevskiy wrote: >>> If we run QEMU with -netdev user,id=USER0,hostfwd=tcp::-:22, it starts >>> a DHCP server and starts allocating client IPs from 10.0.2.15 so

Re: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form

On 07.03.2018 04:38, Alexey Kardashevskiy wrote: > On 01/02/18 20:35, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy > > Ping? > > >> --- >> slirp/arp_table.c | 4 ++-- >> slirp/socket.c| 8 >> slirp/udp.c | 4 ++-- >> 3 files changed, 8

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

On Wed, Feb 28, 2018 at 01:15:20PM -0700, Alex Williamson wrote: [...] > @@ -1174,6 +1206,8 @@ static int vfio_pci_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > vdev->irq_type = VFIO_PCI_NUM_IRQS; > mutex_init(>igate); > spin_lock_init(>irqlock); > +

Re: [Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

On Tue, Mar 06, 2018 at 07:45:39AM +, Liu, Yi L wrote: [...] > > Do you have online branch so that I can check out? > > yes, I should have pasted it. Here it is: > https://github.com/luxis1999/sva_notifier.git Thanks. > > > The patches are a bit scattered and it's really hard for me to >

Re: [Qemu-devel] [PATCH] tests: Silence migration-test 'bad' test

On Tue, Mar 06, 2018 at 05:30:42PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In 2c9bb29703c I added a migration test that purposely fails; > unfortunately it prints a copy of the failure message to stderr > which makes the output a bit

Re: [Qemu-devel] [PATCH v1 07/22] RISC-V: Remove unused class definitions from

On Wed, Mar 7, 2018 at 5:14 PM, Michael Clark wrote: > > > On Wed, Mar 7, 2018 at 12:27 PM, Philippe Mathieu-Daudé > wrote: > >> >> Ok until here. >> >> > diff --git a/include/hw/riscv/sifive_e.h b/include/hw/riscv/sifive_e.h >> > index 0aebc57..818fbdc 100644

Re: [Qemu-devel] [PATCH 02/19] uninorth: remove second set of uninorth token registers

On Tue, Mar 06, 2018 at 08:30:46PM +, Mark Cave-Ayland wrote: > Commit 593c181160: "PPC: Newworld: Add second uninorth control register set" > added a second set of uninorth registers at 0xf300. > > Testing MacOS 9.2 to MacOS X 10.4 reveals no accesses to this address and I > can't find

Re: [Qemu-devel] [PATCH v1 09/22] RISC-V: Include hexidecimal instruction in

On Wed, Mar 7, 2018 at 12:09 PM, Philippe Mathieu-Daudé wrote: > On 03/06/2018 05:43 PM, Michael Clark wrote: > > This was added to help debug issues using -d in_asm. It is > > useful to see the instruction bytes, as one can detect if > > one is trying to execute ASCII or

Re: [Qemu-devel] [PATCH v1 07/22] RISC-V: Remove unused class definitions from

On Wed, Mar 7, 2018 at 12:27 PM, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 03/06/2018 05:43 PM, Michael Clark wrote: > > Removes a whole lot of unnecessary boilerplate code. Machines > > don't need to be objects. The expansion of the SOC object model > > for the RISC-V

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

On 15/02/18 16:43, Alexey Kardashevskiy wrote: > On 10/01/18 19:59, David Gibson wrote: >> On Mon, Jan 08, 2018 at 07:35:43PM +1100, Alexey Kardashevskiy wrote: >>> On 03/01/18 11:09, David Gibson wrote: On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: > On 11/12/17

Re: [Qemu-devel] Outreachy 2017-DecemberMarch Aspirant for Vulkan-ize_virgl Project

Hi Stefan, I have not been able to contact with Marc-Andre. Could you suggest someone else who could help with this ? Regards, Anusha Srivastava On 3 March 2018 at 11:13, Anusha Srivastava wrote: > Hi Marc-Andre, > > Any update on this as to how to get started on this

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

On Wed, Mar 7, 2018 at 12:09 AM, Peter Maydell wrote: > On 6 March 2018 at 01:30, Michael Clark wrote: > > I've squashed the trivial spike rename fix and rebased against master as > of > > commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562 Merge

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

On Tue, Mar 6, 2018 at 10:13 PM, Andrea Bolognani wrote: > On Tue, 2018-03-06 at 14:30 +1300, Michael Clark wrote: > > I'm currently working on some changes locally to split the firmware from > > the kernel image. Currently the kernel image is embedded in the firmware > (r >

Re: [Qemu-devel] [RFC PATCH qemu] slirp: Update forwarding IP address if guest receiver non-default IP

On 08/02/18 15:29, Alexey Kardashevskiy wrote: > On 01/02/18 20:36, Alexey Kardashevskiy wrote: >> If we run QEMU with -netdev user,id=USER0,hostfwd=tcp::-:22, it starts >> a DHCP server and starts allocating client IPs from 10.0.2.15 so >> this is what the guest normally receives. Since QEMU

Re: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form

On 01/02/18 20:35, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Ping? > --- > slirp/arp_table.c | 4 ++-- > slirp/socket.c| 8 > slirp/udp.c | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/slirp/arp_table.c

[Qemu-devel] [PATCH v1] RISC-V: Convert cpu definition towards future model

- Model borrowed from target/sh4/cpu.c - Rewrote riscv_cpu_list to use object_class_get_list - Dropped 'struct RISCVCPUInfo' and used TypeInfo array - Replaced riscv_cpu_register_types with DEFINE_TYPES - Marked base class as abstract Cc: Igor Mammedov Cc: Palmer Dabbelt

Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

I have applied this patch and when I run the following qmp commands I I do not see the crash anymore but there is still something wrong because only /root/a is opened from qemu. It looks like nbd-server-stop is also getting rid of the nodes added with blockdev-snapshot-sync, therfore is than not

Re: [Qemu-devel] [PATCH] migration: fix applying wrong capabilities

On Tue, Mar 06, 2018 at 08:08:37PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > When setting migration capabilities via QMP/HMP, we'll apply them even > > if the capability check failed. Fix it. > > > > Fixes: 4a84214ebe ("migration: provide

[Qemu-devel] [RFC PATCH v1] spapr: Support ibm, dynamic-memory-v2 property

The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v0: http://lists.gnu.org/archive/html/qemu-ppc/2018-02/msg00236.html Changes in v1: - Rebased on top of Haozhong Zhang's

Re: [Qemu-devel] [PATCH v8 03/23] RISC-V CPU Core Definition

On Tue, Mar 6, 2018 at 9:58 PM, Igor Mammedov wrote: > On Tue, 6 Mar 2018 11:24:02 +1300 > Michael Clark wrote: > > > On Mon, Mar 5, 2018 at 10:44 PM, Igor Mammedov > wrote: > > > > > On Sat, 3 Mar 2018 02:51:31 +1300 > > > Michael

Re: [Qemu-devel] [RFC v4 15/21] blockjobs: add prepare callback

On 02/28/2018 12:04 PM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> Some jobs upon finalization may need to perform some work that can >> still fail. If these jobs are part of a transaction, it's important >> that these callbacks fail the entire transaction. >> >> We

Re: [Qemu-devel] [PATCH] block: include original filename when reporting invalid URIs

On Tue, Feb 06, 2018 at 10:52:04AM +, Daniel P. Berrangé wrote: > Consider passing a JSON based block driver to "qemu-img commit" > > $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ > "volume":"gv0","path":"sn1.qcow2", >

Re: [Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

On 03/06/2018 09:23 PM, David Gibson wrote: > On Wed, Mar 07, 2018 at 12:15:15AM +0100, BALATON Zoltan wrote: >> An exit function was mistakenly left here but it's not needed because >> the PCI bars are organised differently in this device. Calling this >> exit function during device_del was

Re: [Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

On Wed, Mar 07, 2018 at 12:15:15AM +0100, BALATON Zoltan wrote: > An exit function was mistakenly left here but it's not needed because > the PCI bars are organised differently in this device. Calling this > exit function during device_del was causing an abort with > memory_region_del_subregion:

Re: [Qemu-devel] [PATCH 01/19] uninorth: trivial style fixups

On Tue, Mar 06, 2018 at 08:30:45PM +, Mark Cave-Ayland wrote: > This makes sure we keep patchew/checkpatch happy during the remainder of this > patchset. > > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > hw/pci-host/uninorth.c | 29

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

On 26/02/18 19:36, Alexey Kardashevskiy wrote: > On 19/02/18 13:46, Alexey Kardashevskiy wrote: >> On 16/02/18 16:28, David Gibson wrote: >>> On Wed, Feb 14, 2018 at 08:55:41AM -0700, Alex Williamson wrote: On Wed, 14 Feb 2018 19:09:16 +1100 Alexey Kardashevskiy wrote:

Re: [Qemu-devel] [PATCH V3 0/4] vfio: Introduce Live migration capability to vfio_mdev device

> From: Zhang, Yulei > Sent: Tuesday, March 6, 2018 9:35 PM > > Hi Kirti, > > Yes, that is the plan and we will address it in the coming versions. > In this version we just rebase the code and looking for more inputs. It's not how a new version is expected to provide. For review comments which

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

Hi Kevin and everyone. On 2018-03-05 00:13, Kevin Wolf wrote: Am 02.03.2018 um 20:32 hat Jack Schwartz geschrieben: Hi Kevin. On 2018-01-15 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero

Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target

On Tue, 03/06 17:17, Marc-André Lureau wrote: > Available when configure --enable-modules. > > Signed-off-by: Marc-André Lureau > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index 9a75c48ae0..5d9ef3b8fd 100644 >

Re: [Qemu-devel] [PATCH 1/1] scsi-disk.c: consider bl->max_transfer in INQUIRY emulation

On Tue, 03/06 12:44, Daniel Henrique Barboza wrote: > The calculation of the max_transfer atribute of BlockDriverState > makes considerations such as max_segments and transfer_length via > the BLKSECTGET ioctl (if available). > > However, bl->max_transfer isn't considered when emulating the

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

On Tue, 03/06 16:20, Daniel P. Berrangé wrote: > On Tue, Mar 06, 2018 at 08:05:18AM -0800, no-re...@patchew.org wrote: > > Hi, > > > > This series failed docker-mingw@fedora build test. Please find the testing > > commands and > > their output below. If you have Docker installed, you can

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

On Tue, 03/06 16:22, Daniel P. Berrangé wrote: > RFE for patchew... > > Now we're sending separate email alerts for each build job, can we > make patchew include the job name in the subject line, so it is > immediately obvious which job failed without needing to read the > body. Yes, doable. Do

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

FYI - Travis completed builds for v8.2 and it's all green. - https://travis-ci.org/riscv/riscv-qemu/builds/349981074 The Travis folks kindly bumped our build timeout limit so we can run the full upstream Travis checks. I've manually tested Linux in all of the relevant machines, including SMP in

Re: [Qemu-devel] [PATCH v1 00/22] Spec conformance bug fixes and cleanups

On Wed, Mar 7, 2018 at 12:47 PM, Emilio G. Cota wrote: > On Wed, Mar 07, 2018 at 12:07:18 +1300, Michael Clark wrote: > > BTW Apologies for the duplicate emails. I'm still getting to grips with > the > > git-sendemail workflow and was using a sed script to Add Cc's which > munged

Re: [Qemu-devel] [PATCH v1 00/22] Spec conformance bug fixes and cleanups

On Wed, Mar 07, 2018 at 12:07:18 +1300, Michael Clark wrote: > BTW Apologies for the duplicate emails. I'm still getting to grips with the > git-sendemail workflow and was using a sed script to Add Cc's which munged > the headers as it didn't take into account Subject lines flowing to two > lines.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/19] uninorth: move PCI mmio memory region initialisation into init function

On Tue, 6 Mar 2018, Mark Cave-Ayland wrote: Whilst we are here, rename the memory regions to better reflect whether they belong to either a PCI or an AGP bus. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/uninorth.c | 28 ++-- 1 file

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huck wrote: > On Tue, 6 Mar 2018 10:07:21 + > Nia Alarie wrote: > >> Allows a branch to be removed - this function always returns 0. >> >> Signed-off-by: Nia Alarie >> Reviewed-by:

Re: [Qemu-devel] [Qemu-ppc] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller

On Tue, 6 Mar 2018, Thomas Huth wrote: On 11.01.2018 05:59, David Gibson wrote: From: BALATON Zoltan This is a common generic PCI SATA controller that is also used in PCs but more importantly guests running on the Sam460ex board prefer this card and have a driver for it

[Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

An exit function was mistakenly left here but it's not needed because the PCI bars are organised differently in this device. Calling this exit function during device_del was causing an abort with memory_region_del_subregion: `Assertion subregion->container == mr' failed. Reported-by: Thomas Huth

Re: [Qemu-devel] [PATCH v4 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

On Tue, Mar 6, 2018 at 1:40 PM, Laurent Vivier wrote: > Le 06/03/2018 à 20:34, Max Filippov a écrit : >> In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger >> than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when >> mmap, munmap, mprotect,

Re: [Qemu-devel] [PATCH] README: Fix typo 'git-publish'

On 03/05/2018 11:43 PM, Fam Zheng wrote: > Reported-by: Alberto Garcia > Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README >

Re: [Qemu-devel] [PATCH] migration: fix minor finalize leak

On 03/06/2018 02:09 PM, Marc-André Lureau wrote: > Spotted thanks to ASAN: > QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/migration-test -p > /x86_64/migration/bad_dest > > ==30302==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 48 byte(s) in 1 object(s) allocated

Re: [Qemu-devel] [PATCH 2/3] net: allow using any PCI NICs in -net or -nic

On 03/06/2018 01:49 PM, Paolo Bonzini wrote: > Remove the hard-coded list of PCI NIC names; instead, fill an array > using all PCI devices listed under DEVICE_CATEGORY_NETWORK. Keep > the old shortcut "virtio" for virtio-net-pci. > > Suggested-by: Thomas Huth > Cc: Jason Wang

Re: [Qemu-devel] [PATCH 1/3] qom: introduce object_class_get_list_sorted

On 03/06/2018 01:49 PM, Paolo Bonzini wrote: > Unify half a dozen copies of very similar code (the only difference being > whether comparisons were case-sensitive) and use it also in Tricore, > which did not do any sorting of CPU model names. > > Signed-off-by: Paolo Bonzini

[Qemu-devel] [Bug 1753309] Re: Ethernet interrupt vectors for sabrelite machine are defined backwards

#3: Correct, Linux version 4.14 and older registers two interrupt lines, both the correct and the wrong one. With qemu version, the kernel receives interrupts on irq 151, with the other on 150. So, yes, I guess it works by accident. My question is what to do with older (pre-4.14) kernels.

Re: [Qemu-devel] [PATCH v1 18/22] RISC-V: Remove braces from satp case statement with

On 03/06/2018 05:43 PM, Michael Clark wrote: > Signed-off-by: Michael Clark > Signed-off-by: Palmer Dabbelt Reviewed-by: Philippe Mathieu-Daudé > --- > target/riscv/op_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH v1 09/22] RISC-V: Include hexidecimal instruction in

On 03/06/2018 05:43 PM, Michael Clark wrote: > This was added to help debug issues using -d in_asm. It is > useful to see the instruction bytes, as one can detect if > one is trying to execute ASCII or device-tree magic. clean :) > > Signed-off-by: Michael Clark >

Re: [Qemu-devel] [PATCH v1 00/22] Spec conformance bug fixes and cleanups

On Wed, Mar 7, 2018 at 9:43 AM, Michael Clark wrote: > This is the series of spec conformance bug fixes and code cleanups. > We would like to get this series in after our core changes in v8.2. > > - Implements WARL behavior for CSRs that don't support writes > - Improves

Re: [Qemu-devel] [PATCH v1 05/22] RISC-V: Remove redundant identity_translate from

On 03/06/2018 05:43 PM, Michael Clark wrote: > When load_elf is called with NULL as an argument to the > address translate callback, it does an identity translation. > This commit removes the redundant identity_translate callback. > > Signed-off-by: Michael Clark >

Re: [Qemu-devel] [PATCH v1 02/22] RISC-V: Replace hardcoded constants with enum values

On 03/06/2018 05:43 PM, Michael Clark wrote: > The RISC-V device-tree code has a number of hard-coded > constants and this change moves them into header enums. > > Signed-off-by: Michael Clark > Signed-off-by: Palmer Dabbelt Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 16/19] uninorth: rename UNINState to UNINHostState

On 03/06/2018 05:31 PM, Mark Cave-Ayland wrote: > The existing UNINState actually represents the PCI/AGP host bridge stage so > rename it accordingly. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH 05/19] uninorth: move uninorth definitions into uninorth.h

On 03/06/2018 05:30 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/pci-host/uninorth.c | 22 +-- > include/hw/pci-host/uninorth.h | 49 > ++ > 2 files changed, 50

Re: [Qemu-devel] [PATCH 01/19] uninorth: trivial style fixups

On 03/06/2018 05:30 PM, Mark Cave-Ayland wrote: > This makes sure we keep patchew/checkpatch happy during the remainder of this > patchset. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/pci-host/uninorth.c |

[Qemu-devel] [PATCH 4/6] grackle: move PCI IO (ISA) memory region into the grackle device

This simplifies the Old World machine to simply mapping the ISA memory region into the main address space. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/grackle.c | 7 ++- hw/ppc/mac_oldworld.c | 9 +++-- 2 files changed, 9 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 2/6] grackle: general tidy-up and QOMify

This is the first step towards removing the old-style pci_grackle_init() function. Following on from the previous commit we can now pass the heathrow device as an object link and wire up the heathrow IRQs via qdev GPIOs. Signed-off-by: Mark Cave-Ayland ---

[Qemu-devel] [PATCH 5/6] mac_oldworld: remove pics IRQ array and wire up macio to heathrow directly

Introduce constants for the pre-defined Old World IRQs to help keep things readable. Signed-off-by: Mark Cave-Ayland --- hw/ppc/mac.h | 8 hw/ppc/mac_oldworld.c | 27 ++- 2 files changed, 22 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 0/6] heathrow/grackle/mac_oldworld board wiring improvements

[This is for Old World Machines: there is a corresponding patch for New World Machines] This patchset is a combination of heathrow/grackle/mac_oldworld cleanup with the final aim of removing the remaining custom init functions and switching IRQ arrays over to qdev GPIOs. Patch 1 removes the

[Qemu-devel] [PATCH 6/6] mac_oldworld: move wiring of macio IRQs to macio_oldworld_realize()

Since the macio device has a link to the PIC device, we can now wire up the IRQs directly via qdev GPIOs rather than having to use an intermediate array. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 37 ++---

[Qemu-devel] [PATCH 3/6] grackle: remove deprecated pci_grackle_init() function

Instead wire up the grackle device inside the Mac Old World machine. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/grackle.c | 28 +--- hw/ppc/mac.h | 3 --- hw/ppc/mac_oldworld.c | 21 ++--- 3 files changed, 19

[Qemu-devel] [PATCH 1/6] heathrow: remove obsolete heathow_init() function

Instead wire up heathrow to the CPU and grackle PCI host using qdev GPIOs. Signed-off-by: Mark Cave-Ayland --- hw/intc/heathrow_pic.c | 23 +-- hw/ppc/mac.h | 4 hw/ppc/mac_oldworld.c | 20

[Qemu-devel] [Bug 1753309] Re: Ethernet interrupt vectors for sabrelite machine are defined backwards

"4.14+: Both versions of qemu (as-is and interrupts reverted) work fine" Hm. I really wonder how it can be possible that Linux works with the interrupt vectors reversed, though to be fair I have not looked at the Linux i.MX6 ENET driver code. I suppose it's possible that the driver is binding the

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

On 02/05/2018 03:22 PM, Max Reitz wrote: > This series implements .bdrv_refresh_filename() for the ssh block > driver, along with an appropriate .bdrv_dirname() so we don't chop off > query strings for backing files with relative filenames. > > This series depends on my “block: Fix some

Re: [Qemu-devel] [PATCH v4 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

Le 06/03/2018 à 20:34, Max Filippov a écrit : > In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger > than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when > mmap, munmap, mprotect, mremap or shmat is called for an address outside > the guest address space. mmap

[Qemu-devel] [PATCH v1 17/22] RISC-V: Hardwire satp to 0 for no-mmu case

satp is WARL so it should not trap on illegal writes, rather it can be hardwired to zero and silently ignore illegal writes. It seems the RISC-V WARL behaviour is preferred to having to bear trap overhead, versus simply reading back the value and checking if the write took (saves hundreds of

[Qemu-devel] [PATCH v1 21/22] RISC-V: No traps on writes to misa/minstret/mcycle

These fields are marked WARL in the specification so illegal writes are silently dropped. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/op_helper.c | 26 +- 1 file changed, 13 insertions(+), 13

Re: [Qemu-devel] [RFC PATCH v2 00/22] remove i386/pc dependency: generic SuperIO

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180305211928.466-1-f4...@amsat.org Subject: [Qemu-devel] [RFC PATCH v2 00/22] remove

[Qemu-devel] [PATCH v1 15/22] RISC-V: Use memory_region_is_ram in pte update

After reading cpu_physical_memory_write and friends, it seems that memory_region_is_ram is a more appropriate interface, and matches the intent of the code that is calling it. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt ---

[Qemu-devel] [PATCH v1 19/22] RISC-V: riscv-qemu port supports sv39 and sv48

Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 7c4482b..f47fc9c 100644 --- a/target/riscv/cpu.h +++

[Qemu-devel] [PATCH v1 10/22] RISC-V: Hold rcu_read_lock when accessing memory

>From reading other code that accesses memory regions directly, it appears that the rcu_read_lock needs to be held. Note: the original code for accessing RAM directly was added because there is no other way to use atomic_cmpxchg easily. Signed-off-by: Michael Clark

[Qemu-devel] [PATCH v1 18/22] RISC-V: Remove braces from satp case statement

Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/op_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index dd3e417..f79716a 100644 ---

[Qemu-devel] [Bug 1753309] Re: Ethernet interrupt vectors for sabrelite machine are defined backwards

Followup on #1: The relevant upstream commit is 4c8777892e80b ("ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround"). Test results with various kernel versions: 4.14+: Both versions of qemu (as-is and interrupts reverted) work fine 4.9.y: Requires cherry-pick of 4c8777892e80b for

[Qemu-devel] [PATCH v1 05/22] RISC-V: Remove identity_translate from load_elf

When load_elf is called with NULL as an argument to the address translate callback, it does an identity translation. This commit removes the redundant identity_translate callback. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt ---

Re: [Qemu-devel] [RESEND PATCH v7 0/3] Initial i.MX7 support

On Mon, Mar 05, 2018 at 07:50:23AM -0800, Andrey Smirnov wrote: > On Mon, Mar 5, 2018 at 7:31 AM, Peter Maydell > wrote: > > On 5 March 2018 at 06:12, Andrey Smirnov wrote: > >> RESEND due to botched original v7 submission (patch 1/3 broken) >

[Qemu-devel] [PATCH v1 13/22] RISC-V: Make some header guards more specific

Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- include/hw/riscv/spike.h | 4 ++-- include/hw/riscv/virt.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/riscv/spike.h b/include/hw/riscv/spike.h index

[Qemu-devel] [PATCH v1 03/22] RISC-V: Make virt board description match spike

This makes 'qemu-system-riscv64 -machine help' output more tidy and consistent. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt.c

[Qemu-devel] [PATCH v1 09/22] RISC-V: Include hexidecimal in disassembly

This was added to help debug issues using -d in_asm. It is useful to see the instruction bytes, as one can detect if one is trying to execute ASCII or device-tree magic. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- disas/riscv.c | 39

Re: [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board wiring improvements

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180306203103.25563-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board wiring improvements === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v1 08/22] RISC-V: Make sure rom has space for fdt

Remove a potential buffer overflow (not seen in practice). Perhaps cpu_physical_memory_write already has bound checks. This change however makes space for the maximum device tree size and adds an explicit bounds check and error message. It doesn't trigger, but it may help in the future if the

[Qemu-devel] [PATCH v1 22/22] RISC-V: Remove support for adhoc X_COP interrupt

This is essentially dead-code elimination. Support for more local interrupts will be added in a future revision, as they will be defined in a future version of the Privileged ISA specification. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt ---

[Qemu-devel] [PATCH v1 07/22] RISC-V: Remove unused class definitions

Removes a whole lot of unnecessary boilerplate code. Machines don't need to be objects. The expansion of the SOC object model for the RISC-V machines will happen in the future as SiFive plans to add their FE310 and FU540 SOCs to QEMU. However, it seems that this present boilerplate is complete

Re: [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board wiring improvements

On 06/03/18 20:59, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180306203103.25563-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board

Re: [Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

Hello Thomas, thanks for report but I at this time I am and can be some time in condition which does not allow me to access e-mail and normal work On Tuesday 06 of March 2018 16:29:19 Thomas Huth wrote: > On 14.01.2018 21:14, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa

[Qemu-devel] [PATCH v1 20/22] RISC-V: vectored traps are optional

Vectored traps for asynchrounous interrupts are optional. The mtvec/stvec mode field is WARL and hence does not trap if an illegal value is written. Illegal values are ignored. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt ---

[Qemu-devel] [PATCH v1 17/22] RISC-V: Ingore satp writes and return 0 for reads

satp is WARL so it should not trap on illegal writes, rather it can be hardwired to zero and silently ignore illegal writes. It seems the RISC-V WARL behaviour is preferred to having to bear trap overhead, versus simply reading back the value and checking if the write took (saves hundreds of

  1   2   3   4   5   >