On 7/6/20 4:15 PM, Gerd Hoffmann wrote:
> On Sat, Jul 04, 2020 at 05:38:53PM +0200, Philippe Mathieu-Daudé wrote:
>> This code hasn't been QOM'ified yet. Warn the user.
>
> False positive IMHO. This is designed to be integrated into other
> devices for boot display. vfio/display.c uses it that
On Sat, Jul 04, 2020 at 05:38:53PM +0200, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
False positive IMHO. This is designed to be integrated into other
devices for boot display. vfio/display.c uses it that way. There
also is a standalone version (initial
On Mon, 6 Jul 2020 14:25:20 +0100
Stefan Hajnoczi wrote:
> On Thu, May 28, 2020 at 05:35:55PM +0200, Cornelia Huck wrote:
> > On Wed, 27 May 2020 11:29:21 +0100
> > Stefan Hajnoczi wrote:
> >
> > > Multi-queue devices achieve the best performance when each vCPU has a
> > > dedicated queue. Th
On Sun, Jul 05, 2020 at 07:48:14AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 03, 2020 at 09:25:10PM +0200, Gerd Hoffmann wrote:
> > On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote:
> > > On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote:
> > > > +/* copy AML
On 7/3/20 10:12 AM, Thomas Huth wrote:
+++ b/util/qemu-openpty.c
@@ -35,7 +35,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
-#if defined(__GLIBC__)
+#if defined CONFIG_PTY
Shouldn't there be some parentheses around CONFIG_PTY here?
No, they are optional, and omitting them i
Hi Peter,
On 7/6/20 3:26 PM, Peter Maydell wrote:
> On Thu, 2 Jul 2020 at 16:27, Eric Auger wrote:
>>
>> Instead of using a Jenkins hash function to generate
>> the key let's just use a 64 bit unsigned integer that
>> contains the asid and the 40 upper bits of the iova.
>> A maximum of 52-bit IOV
Automatically size the number of request virtqueues to match the number
of vCPUs. This ensures that completion interrupts are handled on the
same vCPU that submitted the request. No IPI is necessary to complete
an I/O request and performance is improved. The maximum number of MSI-X
vectors and v
Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and
vhost-user-scsi-pci request virtqueues to match the number of vCPUs.
Other transports continue to default to 1 request virtqueue.
A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are
handled on the same vCPU that
Multi-queue devices achieve the best performance when each vCPU has a
dedicated queue. This ensures that virtqueue used notifications are
handled on the same vCPU that submitted virtqueue buffers. When another
vCPU handles the the notification an IPI will be necessary to wake the
submission vCPU a
v4:
* Sorry for the long delay. I considered replacing this series with a simpler
approach. Real hardware ships with a fixed number of queues (e.g. 128). The
equivalent can be done in QEMU too. That way we don't need to magically size
num_queues. In the end I decided against this approach
Automatically size the number of virtio-blk-pci request virtqueues to
match the number of vCPUs. Other transports continue to default to 1
request virtqueue.
A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are
handled on the same vCPU that submitted the request. No IPI is
necessa
The event and control virtqueues are always present, regardless of the
multi-queue configuration. Define a constant so that virtqueue number
calculations are easier to read.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Cornelia Huck
Reviewed-by: Pankaj Gupta
Reviewed-by: Philippe Mathieu-Daudé
On 7/3/20 8:06 AM, Alberto Garcia wrote:
+printf -v expected_bitmap "%llu" $expected_bitmap # Convert to unsigned
Does the length modifier “ll” actually do anything?
+
+printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry" "$bitmap"
Or the “l” here?
Actually they don't (I
You're getting close.
1. From the build directory, find the import library created, e.g. `find
. -name 'libqemu_plugin.dll.a'`. If you're building x86_64-linux-user,
it should be in `x86_64-linux-user/libqemu_plugin.dll.a`.
2. Go back to the `build/tests/plugin` directory.
3. Link the empty plug
On 7/6/20 3:12 AM, Markus Armbruster wrote:
diff between v2 rebased and v3, with hunks that change only whitespace
dropped:
Thanks, that's useful.
Overall, the series looks ready to go from my perspective. It looks
like the changes from v2 were minimal enough that I don't have any R-b
to ad
Let blk_attach_dev() take an Error* object to return helpful
information. Adapt the callers.
$ qemu-system-arm -M n800
qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card'
because it is already attached by device 'omap2-mmc'
Drive 'sd0' is already in use because it h
Add a trace event to follow devices attaching block drives:
$ qemu-system-arm -M n800 -trace blk_\*
9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device
'omap2-mmc'
9513@1594040428.738189:blk_attach_dev attaching blk 'sd0' to device 'sd-card'
qemu-system-arm: sd_init failed
On Thu, 2 Jul 2020 at 16:27, Eric Auger wrote:
>
> Instead of using a Jenkins hash function to generate
> the key let's just use a 64 bit unsigned integer that
> contains the asid and the 40 upper bits of the iova.
> A maximum of 52-bit IOVA is supported. This change in the
> key format also prepa
A pair of patches which helps me debug an issue with block
drive already attached.
Suggestions to correctly/better use the Error API welcome, in
particular in qdev-properties-system::set_drive_helper().
Philippe Mathieu-Daudé (2):
block/block-backend: Trace blk_attach_dev()
block/block-backen
On Thu, May 28, 2020 at 05:35:55PM +0200, Cornelia Huck wrote:
> On Wed, 27 May 2020 11:29:21 +0100
> Stefan Hajnoczi wrote:
>
> > Multi-queue devices achieve the best performance when each vCPU has a
> > dedicated queue. This ensures that virtqueue used notifications are
> > handled on the same
Hi,
> >>> build: fix device module builds
> >> No code review at all? :-(
> >
> > Well, there have been 5 revisions on the list, partly due to bugs being
> > fixed, partly with changes as response to review comments. So it got
> > some review (not much though) even though the v5 series (pos
On 06/07/20 14:50, Daniel P. Berrangé wrote:
> If one of the qtests fails, the TAP driver prints out a message like:
>
> ERROR - too few tests run (expected 3, got 1)
>
> which fails to tell you which test program failed. This is a critical
> ommission when many tests are running in parallel as
Hi,
> Hi, if I recall correctly I encountered this.
>
> It has to do with the convoluted rules in rules.mak for modules.
>
> There are multiple specific problems there, beyond design issues.
I guess you just figured why there is a plan to replace the current
build system with a meson based on
On Thu, 2 Jul 2020 at 16:27, Eric Auger wrote:
>
> Introduce the smmu_get_iotlb_key() helper and the
> SMMU_IOTLB_ASID() macro. Also move smmu_get_iotlb_key and
> smmu_iotlb_key_hash in the IOTLB related code section.
>
> Signed-off-by: Eric Auger
>
> ---
>
> v1 -> v2:
> - creation
> ---
Reviewe
On Thu, 2 Jul 2020 at 16:27, Eric Auger wrote:
>
> Page and block PTE decoding can share some code. Let's
> first handle table PTE and factorize some code shared by
> page and block PTEs.
>
> Signed-off-by: Eric Auger
>
> ---
>
> v1 -> v2:
> - restore goto error in case get_pte() fails
> ---
Re
Hi,
any comments from FPU emulation maintainers?
Thanks,
Laurent
Le 12/06/2020 à 16:04, Laurent Vivier a écrit :
> According to the comment, this definition of invalid encoding is given
> by intel developer's manual, and doesn't comply with 680x0 FPU.
>
> With m68k, the explicit integer bit can
If one of the qtests fails, the TAP driver prints out a message like:
ERROR - too few tests run (expected 3, got 1)
which fails to tell you which test program failed. This is a critical
ommission when many tests are running in parallel as their output is
interleaved. The improved message is:
From: Andreas Konopik
Signed-off-by: Andreas Konopik
Signed-off-by: David Brenken
Signed-off-by: Georg Hofstetter
Signed-off-by: Robert Rasche
Signed-off-by: Lars Biermanski
---
hw/tricore/Kconfig | 8 ++
hw/tricore/Makefile.objs | 2 +
hw/tricore/tc27x_soc.c |
From: Andreas Konopik
Hello everyone,
this patch adds the AURIX TC277 D-Step TriBoard as QEMU machine
(-M AURIX_TriBoard_TC277D). Memory maps are implemented according to the
"AURIX TC27x D-Step User's Manual V2.2 2014-12". AURIX memory layouts
are specified by the processor, that is why this pa
On 7/6/20 2:04 PM, Stefan Hajnoczi wrote:
> On Sat, Jul 04, 2020 at 11:30:51PM +0200, Philippe Mathieu-Daudé wrote:
>> @@ -683,6 +676,17 @@ static bool nvme_add_io_queue(BlockDriverState *bs,
>> Error **errp)
>> s->queues = g_renew(NVMeQueuePair *, s->queues, n + 1);
>> s->queues[n] = q
On Sat, Jul 04, 2020 at 11:30:51PM +0200, Philippe Mathieu-Daudé wrote:
> @@ -683,6 +676,17 @@ static bool nvme_add_io_queue(BlockDriverState *bs,
> Error **errp)
> s->queues = g_renew(NVMeQueuePair *, s->queues, n + 1);
> s->queues[n] = q;
> s->nr_queues++;
> +
> +ret = qemu_vf
Philippe Mathieu-Daudé writes:
> On 7/6/20 12:01 PM, Marc-André Lureau wrote:
>> Hi
>>
>> On Mon, Jul 6, 2020 at 12:44 PM Philippe Mathieu-Daudé
>> wrote:
[...]
>>> Yet another sneaky way to force forks to either update to QOM or die...
>>
>> You can't blame upstream from doing cleanups and m
Hi Dave,
On 2020/7/3 22:20, Dr. David Alan Gilbert wrote:
> * Keqian Zhu (zhukeqi...@huawei.com) wrote:
>> real_dirty_pages becomes equal to total ram size after dirty log sync
>> in ram_init_bitmaps, the reason is that the bitmap of ramblock is
>> initialized to be all set, so old path counts the
On Sat, Jul 04, 2020 at 11:30:50PM +0200, Philippe Mathieu-Daudé wrote:
> We are going to use this callback in nvme_add_io_queue()
> in the next commit. To avoid forward-declaring it, move
> it before. No logical change.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/nvme.c | 18 +++
On Sat, Jul 04, 2020 at 11:30:49PM +0200, Philippe Mathieu-Daudé wrote:
> As we want to do per-queue polling, extract the nvme_poll_queue()
> method which operates on a single queue.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Stefan better double check here!
> ---
> block/nvme.c | 44
On Fri, 3 Jul 2020 at 21:05, Philippe Mathieu-Daudé wrote:
>
> The 'cpu_type' has been moved from BCM283XState to BCM283XClass
> in commit 210f47840d, but we forgot to remove the old variable.
> Do it now.
>
> Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
> Signed-off-by: Philipp
On Mon, 6 Jul 2020 13:23:11 +0200
Halil Pasic wrote:
> On Fri, 3 Jul 2020 12:06:49 +0200
> Cornelia Huck wrote:
>
> > From: Halil Pasic
> >
> > The atomic_cmpxchg() loop is broken because we occasionally end up with
> > old and _old having different values (a legit compiler can generate code
On Sat, Jul 04, 2020 at 11:30:41PM +0200, Philippe Mathieu-Daudé wrote:
> Rearrange nvme_add_io_queue() by using a common error path.
> This will be proven useful in few commits where we add IRQ
> notification to the IO queues.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/nvme.c | 9 +
Greg Kurz writes:
> On Mon, 6 Jul 2020 10:09:09 +0200
> Markus Armbruster wrote:
>
>> Convert
>>
>> foo(..., &err);
>> if (err) {
>> ...
>> }
>>
>> to
>>
>> if (!foo(..., &err)) {
>> ...
>> }
>>
>> for qdev_realize(), qdev_realize_and_unref(), qbus_realiz
On Tue, 19 May 2020 at 19:57, Richard Henderson
wrote:
>
> Executable guest pages are never directly executed by
> the host, but do need to be readable for translation.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/mmap.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
On Tue, 19 May 2020 at 19:57, Richard Henderson
wrote:
>
> The kernel will return -EINVAL for bits set in the prot argument
> that are unknown or invalid. Previously we were simply cropping
> out the bits that we care about.
>
> Introduce validate_prot_to_pageflags to perform this check in a
> si
On Wed, 20 May 2020 at 18:28, Richard Henderson
wrote:
>
> For aarch64, this includes the GNU_PROPERTY_AARCH64_FEATURE_1_BTI bit,
> which indicates that the image should be mapped with guarded pages.
>
> Signed-off-by: Richard Henderson
> ---
> v9: Only map the startup executable with BTI; anythi
On Fri, 3 Jul 2020 12:06:50 +0200
Cornelia Huck wrote:
> From: Halil Pasic
>
> The atomic_cmpxchg() loop is broken because we occasionally end up with
> old and _old having different values (a legit compiler can generate code
> that accessed *ind_addr again to pick up a value for _old instead
On Fri, 3 Jul 2020 12:06:49 +0200
Cornelia Huck wrote:
> From: Halil Pasic
>
> The atomic_cmpxchg() loop is broken because we occasionally end up with
> old and _old having different values (a legit compiler can generate code
> that accessed *ind_addr again to pick up a value for _old instead
06.07.2020 11:09, Markus Armbruster wrote:
When using the Error object to check for error, we need to receive it
into a local variable, then propagate() it to @errp.
Using the return value permits allows receiving it straight to @errp.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
On Sat, 4 Jul 2020 14:34:04 -0400
"Michael S. Tsirkin" wrote:
> On Tue, Jun 16, 2020 at 06:50:34AM +0200, Halil Pasic wrote:
> > The atomic_cmpxchg() loop is broken because we occasionally end up with
> > old and _old having different values (a legit compiler can generate code
> > that accessed *
On Wed, 20 May 2020 at 18:28, Richard Henderson
wrote:
>
> This test requires gcc 10 for -mbranch-protection=standard.
>
> Signed-off-by: Richard Henderson
> ---
> v9: Expect and require gcc 10.
> ---
> tests/tcg/aarch64/bti-1.c | 62 +++
> tests/tcg/aarch64/b
On Wed, 20 May 2020 at 18:28, Richard Henderson
wrote:
>
> Transform the prot bit to a qemu internal page bit, and save
> it in the page tables.
>
> Signed-off-by: Richard Henderson
> ---
> include/exec/cpu-all.h | 2 ++
> linux-user/syscall_defs.h | 4
> linux-user/mmap.c |
On Wed, 20 May 2020 at 18:28, Richard Henderson
wrote:
>
> The kernel sets btype for the signal handler as if for a call.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/aarch64/signal.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/aarch6
We have an issue when using the VFIO-over-socket libmuser PoC
(https://www.mail-archive.com/qemu-devel@nongnu.org/msg692251.html) instead of
the VFIO kernel module: we notice that DMA regions used by the emulated device
can be abruptly removed while the device is still using them.
The PCI device w
From: Andrew Melnychenko
There is an issue when callback may be called with invalid vdev.
It happens on unplug when vdev already deleted and VirtIOPciProxy is not.
So now, callbacks accept proxy device, and vdev retrieved from it.
Technically memio callbacks should be removed during the flatview
On Sat, Jul 04, 2020 at 11:30:40PM +0200, Philippe Mathieu-Daudé wrote:
> Do not use the same error message for different failures.
> Display a different error whether it is the CQ or the SQ.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/nvme.c | 4 ++--
> 1 file changed, 2 insertions(
Hi,
The third report of the TCG Continuous Benchmarking series utilizes
the tools presented in the previous report for comparing the
performance of 17 different targets across two versions of QEMU. The
two versions addressed are 5.0 and 5.1-pre-soft-freeze (current state
of QEMU).
After summarizi
Patchew URL:
https://patchew.org/QEMU/20200706100432.2301919-1-mre...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/31] Block patches
Type: series
Message-id: 20200706100432.2301919-1-mre...@redhat.com
=== TEST
On Tue, Jun 09, 2020 at 02:07:44PM -0400, Michael S. Tsirkin wrote:
> On Tue, Jun 09, 2020 at 06:02:15PM +0100, Stefan Hajnoczi wrote:
> > Many vhost devices in QEMU currently do not involve the device backend
> > in feature negotiation. This seems fine at first glance when no
> > device-specific f
On 7/6/20 12:01 PM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jul 6, 2020 at 12:44 PM Philippe Mathieu-Daudé
> wrote:
>>
>> On 1/7/20 4:04 PM, Marc-André Lureau wrote:
>>> No longer used in the tree. The comment about user_creatable is still
>>> quite relevant, but there is already a similar com
Hi Philippe,
On Fri, 3 Jul 2020 at 19:40, Philippe Mathieu-Daudé wrote:
>
> Hi Alex,
>
> On 7/3/20 6:15 PM, Alex Richardson wrote:
> > After merging latest QEMU upstream into our CHERI fork, I noticed that
> > some of the FPU tests in our MIPS baremetal testsuite
>
> I understand by baremetal you
From: Vladimir Sementsov-Ogievskiy
Currently this field only set by qed and qcow2. But in fact, all
backing-supporting formats (parallels, qcow, qcow2, qed, vmdk) share
these semantics: on unallocated blocks, if there is no backing file they
just memset the buffer with zeroes.
So, document this
From: Vladimir Sementsov-Ogievskiy
vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is
always assumed for it in bdrv_co_block_status().
unallocated_blocks_are_zero is useless (it doesn't affect the only user
of the field: bdrv_co_block_status()), drop it.
Signed-off-by: Vladimi
From: Maxim Levitsky
blockdev-amend will be used similiar to blockdev-create
to allow on the fly changes of the structure of the format based block devices.
Current plan is to first support encryption keyslot management for luks
based formats (raw and embedded in qcow2)
Signed-off-by: Maxim Lev
On Mon, 6 Jul 2020 10:09:09 +0200
Markus Armbruster wrote:
> Convert
>
> foo(..., &err);
> if (err) {
> ...
> }
>
> to
>
> if (!foo(..., &err)) {
> ...
> }
>
> for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their
> wrappers isa_realize_an
From: Vladimir Sementsov-Ogievskiy
In case when get_image_offset() returns -1, we do zero out the
corresponding chunk of qiov. So, this should be reported as ZERO.
Note that this changes visible output of "qemu-img map --output=json"
and "qemu-io -c map" commands. For qemu-img map, the change is
From: Maxim Levitsky
Now that we have all the infrastructure in place,
wire it in the qcow2 driver and expose this to the user.
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Max Reitz
Message-Id: <20200608094030.670121-9-mlevi...@redhat.com>
Signed-off-by: Max Rei
From: Vladimir Sementsov-Ogievskiy
We set bdi->unallocated_blocks_are_zero = iscsilun->lbprz, but
iscsi_co_block_status doesn't return 0 in case of iscsilun->lbprz, it
returns ZERO when appropriate. So actually unallocated_blocks_are_zero
is useless (it doesn't affect the only user of the field:
From: Eric Blake
The other four drivers that support backing files (qcow, qcow2,
parallels, vmdk) all rely on the block layer to populate zeroes when
reading beyond EOF of a short backing file. We can simplify the qed
code by doing likewise.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Seme
From: Vladimir Sementsov-Ogievskiy
raw_co_block_status() in block/file-posix.c never returns 0, so
unallocated_blocks_are_zero is useless (it doesn't affect the only user
of the field: bdrv_co_block_status()). Drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message
From: Maxim Levitsky
Some options are only useful for creation
(or hard to be amended, like cluster size for qcow2), while some other
options are only useful for amend, like upcoming keyslot management
options for luks
Since currently only qcow2 supports amend, move all its options
to a common m
From: Vladimir Sementsov-Ogievskiy
It's false by default, no needs to set it. We are going to drop this
variable at all, so drop it now here, it doesn't hurt.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20200528094405.145708-6-vsement...@virtuozzo.com>
Sign
From: Vladimir Sementsov-Ogievskiy
The function has only one user: bdrv_co_block_status(). Inline it to
simplify reviewing of the following patches, which will finally drop
unallocated_blocks_are_zero field too.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <2
From: Vladimir Sementsov-Ogievskiy
In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk
of qiov. So, this should be reported as ZERO.
Note that this changes visible output of "qemu-img map --output=json"
and "qemu-io -c map" commands. For qemu-img map, the change is obvious:
we
From: Maxim Levitsky
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Max Reitz
Message-Id: <20200608094030.670121-13-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
qapi/block-core.json | 14 -
block/crypto.c | 72 ---
From: Vladimir Sementsov-Ogievskiy
qemu-img convert wants to distinguish ZERO which comes from short
backing files. unallocated_blocks_are_zero field of bdi is unrelated:
space after EOF is always considered to be zero anyway. So, just make
post_backing_zero true in case of short backing file.
S
From: Maxim Levitsky
'force' option will be used for some unsafe amend operations.
This includes things like erasing last keyslot in luks based formats
(which destroys the data, unless the master key is backed up
by external means), but that _might_ be desired result.
Signed-off-by: Maxim Levit
From: Maxim Levitsky
This commit adds two tests, which test the new amend interface
of both luks raw images and qcow2 luks encrypted images.
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
[mreitz: Let 293 verify that LUKS works; drop $(seq) usage from 293;
drop 293 and
From: Maxim Levitsky
Next few patches will expose that functionality to the user.
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Message-Id: <20200608094030.670121-3-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
qapi/crypto.json| 59 ++-
crypto/block-luks.c | 416
From: Maxim Levitsky
This implements the encryption key management using the generic code in
qcrypto layer and exposes it to the user via qemu-img
This code adds another 'write_func' because the initialization
write_func works directly on the underlying file, and amend
works on instance of luks
From: Maxim Levitsky
This commit adds two tests that cover the
new blockdev-amend functionality of luks and qcow2 driver
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
[mreitz: Let 295 verify that LUKS works; drop 295 and 296 from the auto
group]
Signed-off-by: Max Reit
From: Maxim Levitsky
This will be used first to implement luks keyslot management.
block_crypto_amend_opts_init will be used to convert
qemu-img cmdline to QCryptoBlockAmendOptions
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Message-Id: <20200608094030.670121-2-mlevi...@redh
From: Maxim Levitsky
Currently the implementation only supports amending the encryption
options, unlike the qemu-img version
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Max Reitz
Message-Id: <20200608094030.670121-14-mlevi...@redhat.com>
Signed-off-by: Max Reitz
This function will be used by the next patch, which intends to check
both the exit code and qemu-img's output.
Signed-off-by: Max Reitz
Message-Id: <20200625125548.870061-5-mre...@redhat.com>
Reviewed-by: Maxim Levitsky
[mreitz: Rebased on 49438972b8c2e]
Signed-off-by: Max Reitz
---
tests/qemu
From: Maxim Levitsky
Some qcow2 create options can't be used for amend.
Remove them from the qcow2 create options and add generic logic to detect
such options in qemu-img
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
[mreitz: Dropped some iotests reference output hunks that bec
From: Maxim Levitsky
This allows more tests to be able to have same output on both qcow2 luks
encrypted images
and raw luks images
Signed-off-by: Maxim Levitsky
Signed-off-by: Max Reitz
Reviewed-by: Maxim Levitsky
Message-Id: <20200625125548.870061-3-mre...@redhat.com>
---
tests/qemu-iotest
From: Maxim Levitsky
rename the write_func to create_write_func, and init_func to create_init_func.
This is preparation for other write_func that will be used to update the
encryption keys.
No functional changes
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Message-Id: <20200
Similar to _require_working_luks for bash tests, these functions can be
used to check whether our luks driver can actually create images.
Signed-off-by: Max Reitz
Message-Id: <20200625125548.870061-6-mre...@redhat.com>
Reviewed-by: Maxim Levitsky
---
tests/qemu-iotests/iotests.py | 39 +
Whenever running an iotest for the luks format, we should check whether
luks actually really works.
Tests that try to create luks-encrypted qcow2 images should do the same.
Signed-off-by: Max Reitz
Message-Id: <20200625125548.870061-7-mre...@redhat.com>
Reviewed-by: Maxim Levitsky
---
tests/qe
That the luks driver is present is little indication on whether it is
actually working. Without the crypto libraries linked in, it does not
work. So add this function, which tries to create a luks image to see
whether that actually works.
Signed-off-by: Max Reitz
Message-Id: <20200625125548.870
Right now, _filter_img_create just filters out everything that looks
format-dependent, and applies some filename filters. That means that we
have to add another filter line every time some format gets a new
creation option. This can be avoided by instead discarding everything
and just keeping wha
The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200703'
into staging (2020-07-04 16:08:41 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-202
From: Vladimir Sementsov-Ogievskiy
ret may be > 0 on success path at this point. Fix assertion, which may
crash currently.
Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20200526181347.489557-1-vsement...@virtuozzo.com>
Signed-off-by: Ma
From: Alberto Garcia
When resizing an image with qcow2_co_truncate() using the falloc or
full preallocation modes the code assumes that both the old and new
sizes are cluster-aligned.
There are two problems with this:
1) The calculation of how many clusters are involved does not always
g
Hi
On Mon, Jul 6, 2020 at 12:44 PM Philippe Mathieu-Daudé wrote:
>
> On 1/7/20 4:04 PM, Marc-André Lureau wrote:
> > No longer used in the tree. The comment about user_creatable is still
> > quite relevant, but there is already a similar comment in qdev-core.h.
> >
> > Reviewed-by: Peter Maydell
On 7/6/20 8:12 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix a missing cpu_to conversion by moving conversion to just before
> returning instead.
>
> Signed-off-by: Klaus Jensen
> Suggested-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 6 +++---
> 1 file changed, 3 insertions(+)
On 7/6/20 8:12 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add various additional tracing and streamline nvme_identify_ns and
> nvme_identify_nslist (they do not need to repeat the command, it is
> already in the trace name).
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c |
On 7/6/20 8:13 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Reject the nsid broadcast value (0x) and 0xfffe in the
> Active Namespace ID list.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/hw/block/
On 7/6/20 8:13 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> The SUBNQN field is mandatory in NVM Express 1.3.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 07d58aa945f2..e3984
On 7/4/20 11:30 PM, Philippe Mathieu-Daudé wrote:
> To be able to use multiple queues on the same hardware,
> we need to have each queuepair able to receive IRQ
> notifications in the correct AIO context.
>
> The AIO context and the notification handler have to be proper
> to each queue, not to th
The end address calculation for NA4 mode is wrong because the address
used isn't shifted.
That imply all NA4 setup are not applied by the PMP.
The solution is to use the shifted address calculated for start address
variable.
Modifications are tested on Zephyr OS userspace test suite which works
On Wed, Jun 10, 2020 at 01:01:26AM -0400, Michael S. Tsirkin wrote:
> On Tue, Jun 09, 2020 at 06:02:14PM +0100, Stefan Hajnoczi wrote:
> > +For devices other than the networking device, masters may assume the
> > following
> > +feature bits are always set in ``VHOST_USER_GET_FEATURES`` for
> > co
On 06/07/20 01:17, Cathy Zhang wrote:
> This patchset is to add two new features for intel processors
> which support them, like Sapphire Rapids. SERIALIZE is a faster
> serializing instruction which does not modify registers,
> arithmetic flags or memory, will not cause VM exit. TSX suspend
> load
06.07.2020 11:28, Max Reitz wrote:
On 28.05.20 11:43, Vladimir Sementsov-Ogievskiy wrote:
In case when get_image_offset() returns -1, we do zero out the
corresponding chunk of qiov. So, this should be reported as ZERO.
Note that this changes visible output of "qemu-img map --output=json"
and "q
301 - 400 of 470 matches
Mail list logo
