Re: [PULL 3/9] audio: fix size calculation in AUD_get_buffer_size_out()

2025-07-09 Thread Volker Rümelin
Am 09.07.25 um 04:24 schrieb Michael Tokarev: > On 25.05.2025 16:27, marcandre.lur...@redhat.com wrote: >> From: Volker Rümelin >> >> The buffer size calculated by AUD_get_buffer_size_out() is often >> incorrect. sw->hw->samples * sw->hw->info.bytes_per_frame is the >> size of the mixing engine bu

Re: [PATCH v2 0/7] esp.c: only allow ESP commands permitted in the current mode

2025-07-09 Thread Mark Cave-Ayland
On 18/06/2025 07:12, Mark Cave-Ayland wrote: This series contains a few minor tidy-ups along with an implementation of the logic to only allow ESP commands permitted in the current mode. The motivation is to fix GitLab issue #2464 which causes Windows NT MIPS to bluescreen on boot. Patches 1 to

[PATCH v4 04/11] net: Add get_vhost_net callback to NetClientInfo

2025-07-09 Thread Laurent Vivier
The get_vhost_net() function previously contained a large switch statement to find the VHostNetState pointer based on the net client's type. This created a tight coupling, requiring the generic vhost layer to be aware of every specific backend that supported vhost, such as tap, vhost-user, and vhos

[PATCH v4 02/11] net: Define net_client_set_link()

2025-07-09 Thread Laurent Vivier
The code to set the link status is currently located in qmp_set_link(). This function identifies the device by name, searches for the corresponding NetClientState, and then updates the link status. In some parts of the code, such as vhost-user.c, the NetClientState are already available. Calling q

[PATCH v2 5/5] tests/functional: Add a test for s390x pxelinux.cfg network booting

2025-07-09 Thread Thomas Huth
From: Thomas Huth Check the various ways of booting a kernel via pxelinux.cfg file, e.g. by specifying the config file name via the MAC address or the UUID of the guest. Also check whether we can successfully load an alternate kernel via the "loadparm" parameter here and whether the boot menu sho

[PATCH v2 0/5] pc-bios/s390-ccw: Add "loadparm" and menu for pxelinux.cfg network booting

2025-07-09 Thread Thomas Huth
Since we're linking the network booting code into the main s390-ccw.img firmware binary nowadays, we can support the "loadparm" parameter now quite easily for pxelinux.cfg config files that contain multiple entries, and also add support for a simple boot menu here. v2: - Abort the boot process if

[PATCH v2 1/5] pc-bios/s390-ccw: Allow to select a different pxelinux.cfg entry via loadparm

2025-07-09 Thread Thomas Huth
From: Thomas Huth Since we're linking the network booting code into the main firmware binary nowadays, we can support the "loadparm" parameter now quite easily for pxelinux.cfg config files that contain multiple entries. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 32 ++

[PATCH v2 3/5] pc-bios/s390-ccw: Make get_boot_index() from menu.c global

2025-07-09 Thread Thomas Huth
From: Thomas Huth We are going to reuse this function for selecting an entry from the pxelinux.cfg menu, so rename this function with a "menu_" prefix and make it available globally. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/menu.c | 6 +++--- 2 fil

[PATCH v2 4/5] pc-bios/s390-ccw: Add a boot menu for booting via pxelinux.cfg

2025-07-09 Thread Thomas Huth
From: Thomas Huth Show a simple boot menu for pxelinux.cfg, too, if the user requested it. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c index 6f6

[PATCH v2 2/5] pc-bios/s390-ccw: Allow up to 31 entries for pxelinux.cfg

2025-07-09 Thread Thomas Huth
From: Thomas Huth We're going to support a menu for the pxelinux.cfg code, and to be able to reuse some functionality from menu.c, we should align the maximum amount of possible entries with the MAX_BOOT_ENTRIES constant that is used there. Thus replace MAX_PXELINUX_ENTRIES with MAX_BOOT_ENTRIES.

Synced invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday (BST) (qemu-devel@nongnu.org)

2025-07-09 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20250624T13Z DTEND:20250624T14Z RRULE:FREQ=WEEKLY;WKST=MO;UNTIL=20250707T235959Z;INTERVAL=2;BYDAY=TU DTSTAMP:20250709T085120Z ORGANIZER;CN=QEMU Project Calend

Re: [PATCH] hw/vfio-user: fix use of uninitialized variable

2025-07-09 Thread Mark Cave-Ayland
On 08/07/2025 16:49, John Levon wrote: Coverity reported: CID 1611805: Uninitialized variables in vfio_user_dma_map(). This can occur in the happy path when ->async_ops was not set; as this doesn't typically happen, it wasn't caught during testing. Align both map and unmap implementat

[PATCH v6 1/1] hw/display: Allow injection of virtio-gpu EDID name

2025-07-09 Thread Andrew Keesler
Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display Identification Data) is propagated by QEMU such that a virtual display presents legitimate metadata (e.g., name, serial number, preferred resolutions, etc.) to its connected guest. This change adds the ability to specify the EDID nam

[PATCH v6 0/1] Allow injection of virtio-gpu EDID name

2025-07-09 Thread Andrew Keesler
Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display Identification Data) is propagated by QEMU such that a virtual display presents legitimate metadata (e.g., name, serial number, preferred resolutions, etc.) to its connected guest. This change adds the ability to specify the EDID nam

[PATCH v2] docs: use :kbd: role in sphinx docs

2025-07-09 Thread Manos Pitsidianakis
Sphinx supports the :kbd: role for notating keyboard input. They get formatted as HTML elements in the readthedocs theme we currently use for Sphinx. Besides the better visual formatting, it also helps with accessibility as screen readers can announce the semantics of the element to the user. S

Re: [PATCH 0/4] vhost: drop backend_features

2025-07-09 Thread Vladimir Sementsov-Ogievskiy
ping:) On 03.07.25 15:47, Vladimir Sementsov-Ogievskiy wrote: This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's finally do. Vladimir Sementsov-Ogievskiy (4): vhost: introduce vhost_ops->vhost_set_vring_enable_supported method vhost-us

Re: [PATCH] Adds the GDB register XML files for Sparc and Sparc64.

2025-07-09 Thread Alex Bennée
Rot127 writes: > From 6c116b968cb28bcc0d0236913f1926206f50a9b4 Mon Sep 17 00:00:00 2001 > From: Rot127 > Date: Fri, 27 Jun 2025 04:51:25 -0500 > Subject: [PATCH] Adds the GDB register XML files for Sparc and > Sparc64. These seems like a mangled commit. I can't get it to apply cleanly with eit

Re: [PATCH] docs: use :kbd: role in sphinx docs

2025-07-09 Thread Alex Bennée
Manos Pitsidianakis writes: > Sphinx supports the :kbd: role for notating keyboard input. They get > formatted as HTML elements in the readthedocs theme we currently > use for Sphinx. > > Besides the better visual formatting, it also helps with accessibility > as screen readers can announce the

Re: [PATCH] igvm: add initial support for non-cc firmware in igvm format

2025-07-09 Thread Gerd Hoffmann
On Wed, Jul 09, 2025 at 03:34:20PM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 9/7/25 14:30, Gerd Hoffmann wrote: > > Implement a ConfidentialGuestSupportClass for non-confidential VMs. > > This allows the igvm support code work without sev/tdx. > > Is this something we only want in no

RE: [PATCH v7 02/12] hw/arm/smmu-common: Check SMMU has PCIe Root Complex association

2025-07-09 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Tuesday, July 8, 2025 9:57 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; imamm...@redh

RE: [PATCH v7 07/12] hw/pci: Introduce pci_setup_iommu_per_bus() for per-bus IOMMU ops retrieval

2025-07-09 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Tuesday, July 8, 2025 10:26 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; imamm...@red

Re: [PATCH V3 1/3] qom: qom-list-getv

2025-07-09 Thread Markus Armbruster
Steve Sistare writes: > Define the qom-list-getv command, which fetches all the properties and > values for a list of paths. This is faster than qom-tree-get when > fetching a subset of the QOM tree. See qom.json for details. > > Signed-off-by: Steve Sistare You cover letter explains *why* we

Re: [PATCH] rust/bindings: allow unnecessary_transmutes (1.88)

2025-07-09 Thread Bernhard Beschow
Am 3. Juli 2025 14:20:22 UTC schrieb Manos Pitsidianakis : >This is a new lint introduced in Rust 1.88. It does not affect >compilation when using a previous version or our MSRV, 1.77. But with >1.88 compilation fails because we deny all warnings: > > error: unnecessary transmute > --> rus

Re: [PATCH] rust: Fix compilation with rustc v1.88

2025-07-09 Thread Bernhard Beschow
Am 9. Juli 2025 06:22:11 UTC schrieb Manos Pitsidianakis : >Hi Bernhard, > >Thanks for your patch! > >There was an identical patch last week on the list: >https://lore.kernel.org/qemu-rust/20250703-rust_bindings_allow_unnecessary_transmutes-v1-1-692ca210d...@linaro.org/ > Oh, I missed it. I ju

Synced invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday (BST) (qemu-devel@nongnu.org)

2025-07-09 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20250708T13Z DTEND:20250708T14Z RRULE:FREQ=WEEKLY;WKST=MO;INTERVAL=2;BYDAY=TU DTSTAMP:20250709T085121Z ORGANIZER;CN=QEMU Project Calendar:mailto:c_k5p2lpgvbpt

Re: [PATCH v2 1/7] esp.c: only raise IRQ in esp_transfer_data() for CMD_SEL, CMD_SELATN and CMD_TI commands

2025-07-09 Thread Philippe Mathieu-Daudé
On 18/6/25 08:12, Mark Cave-Ayland wrote: Clarify the logic in esp_transfer_data() to ensure that the deferred interrupt code can only be triggered for CMD_SEL, CMD_SELATN and CMD_TI commands. This should already be the case, but make it explicit to ensure the logic isn't triggered unexpectedl

Re: [PATCH v2 3/7] esp.h: remove separate ESPState typedef

2025-07-09 Thread Philippe Mathieu-Daudé
On 18/6/25 08:12, Mark Cave-Ayland wrote: This is not needed as it is now handled by the OBJECT_DECLARE_SIMPLE_TYPE() macro. Signed-off-by: Mark Cave-Ayland --- include/hw/scsi/esp.h | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 5/7] esp.c: only call dma_memory_write function if transfer length is non-zero

2025-07-09 Thread Philippe Mathieu-Daudé
On 18/6/25 08:12, Mark Cave-Ayland wrote: In the cases where mixed DMA/non-DMA transfers are used or no data is available, it is possible to for the calculated transfer length to be zero. Only call the dma_memory_write function where the transfer length is non-zero to avoid invoking the DMA engin

Re: [PATCH v2 4/7] esp.c: only call dma_memory_read function if transfer length is non-zero

2025-07-09 Thread Philippe Mathieu-Daudé
On 18/6/25 08:12, Mark Cave-Ayland wrote: In the cases where mixed DMA/non-DMA transfers are used or no data is available, it is possible to for the calculated transfer length to be "to ~for~ the..." zero. Only call the dma_memory_read function where the transfer length is non-zero to avoid i

Re: [PATCH v2 2/7] esp.c: improve comment in esp_transfer_data()

2025-07-09 Thread Philippe Mathieu-Daudé
On 18/6/25 08:12, Mark Cave-Ayland wrote: Whilst working on the previous patch, the existing comment was not enough to document when the TI command codepath was being used. Update and improve the comment accordingly. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 5 +++-- 1 file changed

Re: [PATCH v2 0/7] esp.c: only allow ESP commands permitted in the current mode

2025-07-09 Thread Philippe Mathieu-Daudé
Hi Mark, On 9/7/25 09:50, Mark Cave-Ayland wrote: On 18/06/2025 07:12, Mark Cave-Ayland wrote: This series contains a few minor tidy-ups along with an implementation of the logic to only allow ESP commands permitted in the current mode. The motivation is to fix GitLab issue #2464 which causes

Re: [PATCH v4 1/3] net/af-xdp: Remove XDP program cleanup logic

2025-07-09 Thread Ilya Maximets
On 7/4/25 3:05 PM, Daniel Borkmann wrote: > There are two issues with the XDP program removal in af_xdp_cleanup(): > > 1) Starting from libxdp 1.3.0 [0] the XDP program gets automatically >detached when we call xsk_socket__delete() for the last successfully >configured queue. libxdp intern

Re: [PATCH v4 2/3] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-07-09 Thread Ilya Maximets
On 7/4/25 3:05 PM, Daniel Borkmann wrote: > While testing, it turned out that upon error in the queue creation loop, > we never trigger the af_xdp_cleanup() handler. This is because we pass > errp instead of a local err pointer into the various AF_XDP setup functions > instead of a scheme like: >

Re: [PATCH v2 3/3] hw/intc/arm_gicv3_kvm: Drop DPRINTF macro

2025-07-09 Thread Richard Henderson
On 7/8/25 05:52, Peter Maydell wrote: We don't generally like DPRINTF debug macros, preferring tracepoints. In this case the macro is used in only three places (reset, realize, and in the unlikely event the host kernel doesn't have GICv3 register access support). These don't seem worth converting

Re: [PATCH v2 1/3] hw/intc/arm_gicv3_dist: Implement GICD_TYPER2 as 0

2025-07-09 Thread Richard Henderson
On 7/8/25 05:52, Peter Maydell wrote: The GIC distributor registers GICD_TYPER2 is present when the GICv4.1 is implemented, and RES0 otherwise. QEMU's TCG implementation is only GICv4.0, so this register is RES0. However, since it's reasonable for GICv4.1-aware software to read the register, expe

Re: [PATCH] linux-user: Implement fchmodat2 syscall

2025-07-09 Thread Richard Henderson
On 7/8/25 10:10, Peter Maydell wrote: You could argue that the fallback-to-libc-fchmodat here isn't worth bothering with, I guess. Indeed not. Support for fchmodat2 is at least 2 years old already. r~

[PATCH v4 01/11] net: Refactor stream logic for reuse in '-net passt'

2025-07-09 Thread Laurent Vivier
To prepare for the implementation of '-net passt', this patch moves the generic stream handling functions from net/stream.c into new net/stream_data.c and net/stream_data.h files. This refactoring introduces a NetStreamData struct that encapsulates the generic fields and logic previously in NetStr

[PATCH v4 00/11] net: Add passt netdev backend

2025-07-09 Thread Laurent Vivier
This series introduces support for passt as a new network backend for QEMU. The purpose of this new backend is to help to use passt daemon as easily as the user backend ('-nic passt' as we have '-nic user'). All the passt functionalities will not be available to keep it simple, and the goal is not

[PATCH v4 08/11] net: Allow network backends to advertise max TX queue size

2025-07-09 Thread Laurent Vivier
This commit refactors how the maximum transmit queue size for virtio-net devices is determined, making the mechanism more generic and extensible. Previously, virtio_net_max_tx_queue_size() contained hardcoded checks for specific network backend types (vhost-user and vhost-vdpa) to determine their

[PATCH v4 09/11] net: Add is_vhost_user flag to vhost_net struct

2025-07-09 Thread Laurent Vivier
Introduce a boolean is_vhost_user field to the vhost_net structure. This flag is initialized during vhost_net_init based on whether the backend is vhost-user. This refactoring simplifies checks for vhost-user specific behavior, replacing direct comparisons of 'net->nc->info->type' with the new fla

[PATCH v4 06/11] net: Add get_acked_features callback to VhostNetOptions

2025-07-09 Thread Laurent Vivier
This patch continues the effort to decouple the generic vhost layer from specific network backend implementations. Previously, the vhost_net initialization code contained a hardcoded check for the vhost-user client type to retrieve its acked features by calling vhost_user_get_acked_features(). Thi

[PATCH v4 07/11] net: Add save_acked_features callback to vhost_net

2025-07-09 Thread Laurent Vivier
This commit introduces a save_acked_features function pointer to vhost_net and converts the vhost_net function into a generic dispatcher. The vhost-user backend provides the callback, making its function static. With this change, no other module has a direct dependency on the vhost-user implementa

[PATCH v4 03/11] vhost_net: Rename vhost_set_vring_enable() for clarity

2025-07-09 Thread Laurent Vivier
This is a cosmetic change with no functional impact. The function vhost_set_vring_enable() is specific to vhost_net and is used outside of vhost_net.c (specifically, in hw/net/virtio-net.c). To prevent confusion with other similarly named vhost functions, such as the one found in cryptodev-vhost.c

[PATCH] target/i386: Add TSA feature flags

2025-07-09 Thread Borislav Petkov (AMD)
Hi, I *think* this is how it should be done but I might be forgetting something. It seems to work in my testing here. Babu, double-check me pls. Thx. --- Add CPUID leaf 0x8000_0021.ECX support and add the TSA CPUID flags. Signed-off-by: Borislav Petkov (AMD) --- target/i386/cpu.c | 20 +

Re: Python ecosystem versions overview

2025-07-09 Thread Markus Armbruster
John Snow writes: > On Tue, Jul 8, 2025, 7:23 PM Paolo Bonzini wrote: > >> On 7/8/25 22:36, John Snow wrote: >> > centos_stream_9 3.9.23 21.3.1 53.0.0 3.4.3 BaseOS, CRB >> >> Ok, so the lowest version of Sphinx (3.4.3) is currently used for CentOS >> Stream 9. It's supported for r

Re: [PATCH] igvm: add initial support for non-cc firmware in igvm format

2025-07-09 Thread Philippe Mathieu-Daudé
Hi Gerd, On 9/7/25 14:30, Gerd Hoffmann wrote: Implement a ConfidentialGuestSupportClass for non-confidential VMs. This allows the igvm support code work without sev/tdx. Is this something we only want in non-KVM builds due to security boundary concerns? RfC: Not fully sure this is the best

[PATCH v4 10/11] net: Add passt network backend

2025-07-09 Thread Laurent Vivier
This commit introduces support for passt as a new network backend. passt is an unprivileged, user-mode networking solution that provides connectivity for virtual machines by launching an external helper process. The implementation reuses the generic stream data handling logic. It launches the pass

[PATCH v4 11/11] net/passt: Implement vhost-user backend support

2025-07-09 Thread Laurent Vivier
This commit adds support for the vhost-user interface to the passt network backend, enabling high-performance, accelerated networking for guests using passt. The passt backend can now operate in a vhost-user mode, where it communicates with the guest's virtio-net device over a socket pair using th

[PATCH v4 05/11] net: Consolidate vhost feature bits into vhost_net structure

2025-07-09 Thread Laurent Vivier
Previously, the vhost_net_get_feature_bits() function in hw/net/vhost_net.c used a large switch statement to determine the appropriate feature bits based on the NetClientDriver type. This created unnecessary coupling between the generic vhost layer and specific network backends (like TAP, vhost-us

Re: [PATCH v5 1/1] hw/display: Allow injection of virtio-gpu EDID name

2025-07-09 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 8, 2025 at 9:07 PM Andrew Keesler wrote: >> >> Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display >> Identification Data) is propagated by QEMU such that a virtual display >> presents legitimate metadata (e.g., name, serial number, pre

Re: [PATCH v3] hw/riscv/virt: Add acpi ged and powerdown support

2025-07-09 Thread liu.xuemei1
On 7/1/25 2:00 AM, dbarb...@ventanamicro.com wrote: > > From: Xuemei Liu > > > > This adds powerdown support by implementing the ACPI GED. > > > > Signed-off-by: Xuemei Liu > > Co-authored-by: Björn Töpel > > > > --- > > Changes in v3: > > - Added missing param to virt_is_acpi_enabled > > - F

Re: [PATCH v4 3/3] net/af-xdp: Support pinned map path for AF_XDP sockets

2025-07-09 Thread Ilya Maximets
On 7/4/25 3:05 PM, Daniel Borkmann wrote: > Extend 'inhibit=on' setting with the option to specify a pinned XSK map > path along with a starting index (default 0) to push the created XSK > sockets into. Example usage: > > # ./build/qemu-system-x86_64 [...] \ >-netdev > af-xdp,ifname=enp2s0f

[PATCH] igvm: add initial support for non-cc firmware in igvm format

2025-07-09 Thread Gerd Hoffmann
Implement a ConfidentialGuestSupportClass for non-confidential VMs. This allows the igvm support code work without sev/tdx. RfC: Not fully sure this is the best way to implement this. Alternatively we could add this directly into the igvm backend and run it in case no confidential guest support ob

Re: [PATCH] net/tap: drop too small packets

2025-07-09 Thread Vladimir Sementsov-Ogievskiy
On 07.07.25 06:49, Jason Wang wrote: On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in case of !s->using_vne

Re: [PATCH-for-10.1 v6 02/14] qemu/target-info: Factor target_arch() out

2025-07-09 Thread Zhao Liu
On Mon, Jul 07, 2025 at 07:19:56PM +0200, Philippe Mathieu-Daudé wrote: > Date: Mon, 7 Jul 2025 19:19:56 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-10.1 v6 02/14] qemu/target-info: Factor target_arch() > out > X-Mailer: git-send-email 2.49.0 > > To keep "qemu/target-info.h" self

Re: [PATCH] target/i386: Add TSA feature flags

2025-07-09 Thread Moger, Babu
Hi Boris, On 7/9/25 05:49, Borislav Petkov (AMD) wrote: > Hi, > > I *think* this is how it should be done but I might be forgetting something. > It seems to work in my testing here. > > Babu, double-check me pls. > > Thx. Patch looks good. Few comments. Is KVM aware of these bits? I didn’t n

Re: [PATCH v3 02/20] hw/pci: Introduce pci_device_get_viommu_cap()

2025-07-09 Thread Nicolin Chen
On Wed, Jul 09, 2025 at 01:55:46PM -0400, Donald Dutile wrote: > > > +enum { > > > +VIOMMU_CAP_STAGE1 = BIT_ULL(0), /* stage1 page table supported */ > > > +}; > > > > Thanks for this work. I am happy to see that we can share the > > common code that allocates a NESTING_PARENT in the core usi

Re: Build platform guarantees, docs, tests, and snakes in the garden

2025-07-09 Thread Paolo Bonzini
Il mer 9 lug 2025, 20:39 John Snow ha scritto: > You are right. However, the mkvenv configuration tool we pioneered has > been largely un-noticed by contributors and appears to "just work" for > the last several years. I believe that cost has been *largely* > amortized by yours truly, and I have

Re: [PATCH v4 0/7] Move memory listener register to vhost_vdpa_init

2025-07-09 Thread Jonah Palmer
On 7/8/25 4:17 AM, Markus Armbruster wrote: Jonah Palmer writes: On 7/4/25 11:00 AM, Markus Armbruster wrote: Jonah Palmer writes: [...] So, total time increases: early pinning (before main loop) takes more time than we save pinning (in the main loop). Correct? Correct. We only sav

Re: [PATCH v4 4/6] target/arm: Add FEAT_TCR2

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: Add FEAT_TCR2, which introduces the TCR2_EL1 and TCR2_EL2 registers. These registers are extensions of the TCR_ELx registers and provide top-level control of the EL10 and EL20 translation regimes. Since the bits in these registers depend on other CPU featur

Re: [PATCH v4 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: This commit implements the two cache maintenance instructions introduced by FEAT_MEC, DC CIPAE and DC CIGDPAE. Because QEMU does not model the cache topology, all cache maintenance instructions are implemented as NOPs, hence these new instructions are imple

Re: [PATCH v4 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: At this point, no real memory encryption is supported, but most software stacks that rely on FEAT_MEC to run should work properly. s/most //? Anyway, Reviewed-by: Richard Henderson r~

Re: [PATCH v4 3/6] target/arm: Add FEAT_SCTLR2

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h index 552d8757b7..44d6b655a9 100644 --- a/target/arm/cpu-features.h +++ b/target/arm/cpu-features.h @@ -416,6 +416,11 @@ static inline bool isar_feature_aa64_rdm(const ARMISARegisters *id)

Re: [PATCH v4 3/6] target/arm: Add FEAT_SCTLR2

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: @@ -7816,6 +7818,78 @@ static const ARMCPRegInfo actlr2_hactlr2_reginfo[] = { .resetvalue = 0 }, }; +static CPAccessResult sctlr2_el2_access(CPUARMState *env, +const ARMCPRegInfo *ri, +

[PATCH] linux-user/mips/o32: Drop sa_restorer functionality

2025-07-09 Thread Thomas Weißschuh
-/* ??? This is always present, but ignored unless O32. */ -abi_ulong sa_restorer; -#endif }; #else struct target_old_sigaction { --- base-commit: df6fe2abf2e990f767ce755d426bc439c7bba336 change-id: 20250709-mips-sa-restorer-42943dfab13b Best regards, -- Thomas Weißschuh

Re: [PATCH-for-10.1 v6 10/14] hw/core/null-machine: Define machine as generic QOM type

2025-07-09 Thread Zhao Liu
On Mon, Jul 07, 2025 at 07:20:04PM +0200, Philippe Mathieu-Daudé wrote: > Date: Mon, 7 Jul 2025 19:20:04 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-10.1 v6 10/14] hw/core/null-machine: Define machine as > generic QOM type > X-Mailer: git-send-email 2.49.0 > > While DEFINE_MACHIN

Re: [PATCH 2/5] arm/cpu: store id_aa64afr{0,1} into the idregs array

2025-07-09 Thread Eric Auger
On 7/4/25 4:19 PM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Reviewed-by: Eric Auger Eric > --- > target/arm/cpu-sysregs.h.inc | 2 ++ > target/arm/cpu.h | 2 -- > target/arm/helper.c | 4 ++-- > target/arm/tcg/cpu64.c | 16 > 4 files

Re: [PATCH V3 3/3] tests/qtest/qom-test: unit test for qom-list-getv

2025-07-09 Thread Steven Sistare
On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote: Hi Steve, On 8/7/25 19:24, Steve Sistare wrote: Add a unit test for qom-list-getv. Signed-off-by: Steve Sistare ---   tests/qtest/qom-test.c | 64 ++   1 file changed, 64 insertions(+) diff --gi

Re: [PATCH 1/5] arm/cpu: store id_afr0 into the idregs array

2025-07-09 Thread Eric Auger
Hi Connie, On 7/4/25 4:19 PM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Reviewed-by: Eric Auger Eric > --- > hw/intc/armv7m_nvic.c| 2 +- > target/arm/cpu-sysregs.h.inc | 1 + > target/arm/cpu.h | 1 - > target/arm/cpu64.c | 4 ++-- > target/arm/help

Re: [PATCH 3/5] arm/cpu: fix trailing ',' for SET_IDREG

2025-07-09 Thread Eric Auger
On 7/4/25 4:19 PM, Cornelia Huck wrote: > While a trailing comma is not broken for SET_IDREG invocations, it > does look odd; use a semicolon instead. > > Fixes: f1fd81291c91 ("arm/cpu: Store aa64mmfr0-3 into the idregs array") > Fixes: def3f1c1026a ("arm/cpu: Store aa64dfr0/1 into the idregs ar

Re: [PATCH 4/5] arm/cpu: store clidr into the idregs array

2025-07-09 Thread Eric Auger
On 7/4/25 4:19 PM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Reviewed-by: Eric Auger Eric > --- > hw/intc/armv7m_nvic.c| 2 +- > target/arm/cpu-sysregs.h.inc | 1 + > target/arm/cpu.h | 3 +-- > target/arm/cpu64.c | 4 ++-- > target/arm/helper.c

Re: [PATCH 5/5] arm/kvm: shorten one overly long line

2025-07-09 Thread Eric Auger
On 7/4/25 4:19 PM, Cornelia Huck wrote: > Fixes: 804cfc7eedb7 ("arm/cpu: Store aa64isar0/aa64zfr0 into the idregs > arrays") > Signed-off-by: Cornelia Huck Reviewed-by: Eric Auger Eric > --- > target/arm/kvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/targ

Re: [PATCH v4 2/6] target/arm: Add FEAT_MEC registers

2025-07-09 Thread Richard Henderson
On 7/9/25 12:03, Gustavo Romero wrote: Add all FEAT_MEC registers. To work properly, FEAT_MEC also depends on FEAT_SCTLR2 and FEAT_TCR2, which are not implemented in this commit. The bits in SCTLR2 and TCR2 control which translation regimes use MECIDs, and determine which MECID is selected. FEA

Re: Build platform guarantees, docs, tests, and snakes in the garden

2025-07-09 Thread John Snow
On Wed, Jul 9, 2025, 3:40 PM Paolo Bonzini wrote: > > > Il mer 9 lug 2025, 20:39 John Snow ha scritto: > >> You are right. However, the mkvenv configuration tool we pioneered has >> been largely un-noticed by contributors and appears to "just work" for >> the last several years. I believe that c

[PATCH v4 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-09 Thread Gustavo Romero
Advertise FEAT_MEC in AA64MMFR3 ID register for the Arm64 cpu max as a first step to fully support FEAT_MEC. The FEAT_MEC is an extension to FEAT_RME that implements multiple Memory Encryption Contexts (MEC) so the memory in a realm can be encrypted and accessing it from the wrong encryption conte

[PATCH v4 3/6] target/arm: Add FEAT_SCTLR2

2025-07-09 Thread Gustavo Romero
Add FEAT_SCTLR2, which introduces the SCTLR2_EL1, SCTLR2_EL2, and SCTLR2_EL3 registers. These registers are extensions of the SCTLR_ELx ones. Because the bits in these registers depend on other CPU features, and only FEAT_MEC is supported at the moment, this commit only implements the EMEC bits in

[PATCH v4 2/6] target/arm: Add FEAT_MEC registers

2025-07-09 Thread Gustavo Romero
Add all FEAT_MEC registers. To work properly, FEAT_MEC also depends on FEAT_SCTLR2 and FEAT_TCR2, which are not implemented in this commit. The bits in SCTLR2 and TCR2 control which translation regimes use MECIDs, and determine which MECID is selected. FEAT_MEC also requires two new cache managem

[PATCH v4 1/6] target/arm: Add the MECEn SCR_EL3 bit

2025-07-09 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu

[PATCH v4 4/6] target/arm: Add FEAT_TCR2

2025-07-09 Thread Gustavo Romero
Add FEAT_TCR2, which introduces the TCR2_EL1 and TCR2_EL2 registers. These registers are extensions of the TCR_ELx registers and provide top-level control of the EL10 and EL20 translation regimes. Since the bits in these registers depend on other CPU features, and only FEAT_MEC is supported at the

Re: [RFC PATCH-for-10.1 v3 3/5] target/arm: Add FEAT_SCTLR2

2025-07-09 Thread Richard Henderson
On 7/8/25 13:17, Gustavo Romero wrote: Add FEAT_SCTLR2, which introduces the SCTLR2_EL1, SCTLR2_EL2, and SCTLR2_EL3 registers. These registers are extensions of the SCTLR_ELx ones. Because the bits in these registers depend on other CPU features, and only FEAT_MEC is supported at the moment, thi

[PATCH-for-10.1 v4 0/6] target/arm: Add FEAT_MEC to max cpu

2025-07-09 Thread Gustavo Romero
This series adds support for all FEAT_MEC registers and cache instructions to the arm64 max CPU. It includes the FEAT_MEC registers and cache maintenance instructions, but does not modify the translation regimes to support the MECIDs, so no encryption is supported yet. However, most software stack

[PATCH v4 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-09 Thread Gustavo Romero
This commit implements the two cache maintenance instructions introduced by FEAT_MEC, DC CIPAE and DC CIGDPAE. Because QEMU does not model the cache topology, all cache maintenance instructions are implemented as NOPs, hence these new instructions are implemented as NOPs too. Signed-off-by: Gusta

NVMe VMStateDescription

2025-07-09 Thread chefkiss
Hello, I am working with an SoC that only supports NVMe, and would like to be able to savevm/loadvm, and maybe also record/replay. The NVMe has a VMStateDescription with just unmigratable = 1 ever since it was first added in 2013. Is there a technical or other limitation/reason for why this is t

Re: [PATCH v7 07/12] hw/pci: Introduce pci_setup_iommu_per_bus() for per-bus IOMMU ops retrieval

2025-07-09 Thread Nicolin Chen
On Wed, Jul 09, 2025 at 08:20:35AM +, Shameerali Kolothum Thodi wrote: > > On Tue, Jul 08, 2025 at 04:40:50PM +0100, Shameer Kolothum wrote: > > > @@ -2909,6 +2909,19 @@ static void > > pci_device_get_iommu_bus_devfn(PCIDevice *dev, > > > } > > > } > > > > > > +/*

Re: [PATCH v3 02/20] hw/pci: Introduce pci_device_get_viommu_cap()

2025-07-09 Thread Donald Dutile
On 7/9/25 3:20 PM, Nicolin Chen wrote: On Wed, Jul 09, 2025 at 01:55:46PM -0400, Donald Dutile wrote: +enum { +VIOMMU_CAP_STAGE1 = BIT_ULL(0), /* stage1 page table supported */ +}; Thanks for this work. I am happy to see that we can share the common code that allocates a NESTING_PARENT

Re: [PATCH V3 1/3] qom: qom-list-getv

2025-07-09 Thread Steven Sistare
On 7/9/2025 4:39 AM, Markus Armbruster wrote: Steve Sistare writes: Define the qom-list-getv command, which fetches all the properties and values for a list of paths. This is faster than qom-tree-get when fetching a subset of the QOM tree. See qom.json for details. Signed-off-by: Steve Sist

Re: Python ecosystem versions overview

2025-07-09 Thread John Snow
Top-posting (Gasp!) to share a gitlab URL where this script is now located. https://gitlab.com/jsnow/repology-dashboard# GPL2.0-or-later, barely polished, a bit hacky. Have fun! This script outputs more data than you've ever wanted to stdout, json and csv. Suggestions/patches welcome if you find

Re: [PATCH v3 02/20] hw/pci: Introduce pci_device_get_viommu_cap()

2025-07-09 Thread Donald Dutile
On 7/8/25 8:39 PM, Nicolin Chen wrote: On Tue, Jul 08, 2025 at 07:05:43AM -0400, Zhenzhong Duan wrote: diff --git a/include/hw/iommu.h b/include/hw/iommu.h new file mode 100644 index 00..e80aaf4431 --- /dev/null +++ b/include/hw/iommu.h @@ -0,0 +1,16 @@ +/* + * General vIOMMU capabili

Re: [PATCH v4 01/11] target/loongarch: move some machine dfine to virt.h

2025-07-09 Thread Bibo Mao
On 2025/7/3 下午5:26, Song Gao wrote: move some machine define to virt.h Signed-off-by: Song Gao --- include/hw/loongarch/virt.h | 19 +++ target/loongarch/cpu.h | 21 - 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/include/hw/loo

Re: [PATCH v4 02/11] hw/loongarch: add virt feature avecintc support

2025-07-09 Thread Bibo Mao
On 2025/7/3 下午5:26, Song Gao wrote: LoongArchVirtMachinState add avecintc features, and it use to check whether virt machine support advance interrupt controller and default set avecintc = ON_OFF_AUTO_ON. LoongArchVirtMachineState add misc_feature and misc_status for misc fetures and status. a

Re: [PATCH] linux-user/mips/o32: Drop sa_restorer functionality

2025-07-09 Thread Philippe Mathieu-Daudé
On 9/7/25 22:57, Thomas Weißschuh wrote: The Linux kernel dropped support for sa_restorer on O32 MIPS in the release 2.5.48 because it was unused. See the comment in arch/mips/include/uapi/asm/signal.h. Applications using the kernels UAPI headers will not reserve enough space for qemu-user to co

Re: [PATCH v6 29/36] hw/acpi/ged: Support migration of AcpiPciHpState

2025-07-09 Thread Prasad Pandit
On Wed, 9 Jul 2025 at 01:30, Eric Auger wrote: > Add a subsection to migrate the AcpiPciHpState state. > > Signed-off-by: Eric Auger > Reviewed-by: Igor Mammedov > Reviewed-by: Jonathan Cameron > --- > hw/acpi/generic_event_device.c | 20 > 1 file changed, 20 insertions(+)

Re: Build platform guarantees, docs, tests, and snakes in the garden

2025-07-09 Thread John Snow
On Mon, Jul 7, 2025 at 5:11 AM Daniel P. Berrangé wrote: > > On Wed, Jul 02, 2025 at 03:24:09PM -0400, Paolo Bonzini wrote: > > Il mar 24 giu 2025, 02:45 Markus Armbruster ha scritto: > > > > > > ... I think I value this a bit higher than Markus, but not really > > > because of offline builds. R

Re: [PATCH v2 5/5] tests/functional: Add a test for s390x pxelinux.cfg network booting

2025-07-09 Thread Jared Rossi
Reviewed-by: Jared Rossi On 7/9/25 4:34 AM, Thomas Huth wrote: From: Thomas Huth Check the various ways of booting a kernel via pxelinux.cfg file, e.g. by specifying the config file name via the MAC address or the UUID of the guest. Also check whether we can successfully load an alternate ker

Re: [PATCH v2 2/5] pc-bios/s390-ccw: Allow up to 31 entries for pxelinux.cfg

2025-07-09 Thread Jared Rossi
Reviewed-by: Jared Rossi On 7/9/25 4:34 AM, Thomas Huth wrote: From: Thomas Huth We're going to support a menu for the pxelinux.cfg code, and to be able to reuse some functionality from menu.c, we should align the maximum amount of possible entries with the MAX_BOOT_ENTRIES constant that is u

Re: [PATCH v2 1/5] pc-bios/s390-ccw: Allow to select a different pxelinux.cfg entry via loadparm

2025-07-09 Thread Jared Rossi
Reviewed-by: Jared Rossi On 7/9/25 4:34 AM, Thomas Huth wrote: From: Thomas Huth Since we're linking the network booting code into the main firmware binary nowadays, we can support the "loadparm" parameter now quite easily for pxelinux.cfg config files that contain multiple entries. Signed-o

Re: [PATCH v2 3/5] pc-bios/s390-ccw: Make get_boot_index() from menu.c global

2025-07-09 Thread Jared Rossi
Reviewed-by: Jared Rossi On 7/9/25 4:34 AM, Thomas Huth wrote: From: Thomas Huth We are going to reuse this function for selecting an entry from the pxelinux.cfg menu, so rename this function with a "menu_" prefix and make it available globally. Signed-off-by: Thomas Huth --- pc-bios/s390

Re: [PATCH v2 4/5] pc-bios/s390-ccw: Add a boot menu for booting via pxelinux.cfg

2025-07-09 Thread Jared Rossi
Reviewed-by: Jared Rossi On 7/9/25 4:34 AM, Thomas Huth wrote: From: Thomas Huth Show a simple boot menu for pxelinux.cfg, too, if the user requested it. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 26 ++ 1 file changed, 26 insertions(+) diff --gi

Re: [PATCH v7 02/12] hw/arm/smmu-common: Check SMMU has PCIe Root Complex association

2025-07-09 Thread Nicolin Chen
On Wed, Jul 09, 2025 at 08:08:49AM +, Shameerali Kolothum Thodi wrote: > > On Tue, Jul 08, 2025 at 04:40:45PM +0100, Shameer Kolothum wrote: > > > @@ -937,11 +939,32 @@ static void smmu_base_realize(DeviceState > > *dev, Error **errp) > > > g_free, g_free);

Re: [PATCH] target/i386: Add TSA feature flags

2025-07-09 Thread Xiaoyao Li
On 7/9/2025 11:02 PM, Moger, Babu wrote: Hi Boris, On 7/9/25 05:49, Borislav Petkov (AMD) wrote: Hi, I *think* this is how it should be done but I might be forgetting something. It seems to work in my testing here. Babu, double-check me pls. Thx. Patch looks good. Few comments. Is KVM aw

  1   2   >