Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Blue Swirl
On Mon, Apr 30, 2012 at 13:52, Mark Cave-Ayland wrote: > On 30/04/12 14:27, Peter Maydell wrote: > > Hi Peter, > > >>> IMO the best fix is to unsysbus the device and qomify it instead.  This >>> way we're 100% flexible in how we can attach it. >> >> >> You don't need to wait for QOM to grow enough

[Qemu-devel] [PATCH] rbd: add discard support

2012-04-30 Thread Josh Durgin
Change the write flag to an operation type in RBDAIOCB, and make the buffer optional since discard doesn't use it. Discard is first included in librbd 0.1.2 (which is in Ceph 0.46). If librbd is too old, leave out qemu_rbd_aio_discard entirely, so the old behavior is preserved. Signed-off-by: Jos

[Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface

2012-04-30 Thread Stefan Weil
If neither width nor height changes, nothing has to be done. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- This patch improves SDL for any host (for example with remote X displays), but the main reason why I wrote it was another problem: On w32 / w64 hosts, qemu-system-arm has a deadlock

[Qemu-devel] To run (replay) the intermediate micro-ops directly

2012-04-30 Thread Yue Chen
Hi, Does anyone know, how to run(replay) the intermediate micro-ops directly? For example, I have traced some micro-op instructions, and want to see what happens with these instructions(after being translated into host code and then run). Probably with Graphic User Interface. Any approach to do

[Qemu-devel] [PATCH for-1.1 1/2] configure: Reindent VirtFS check

2012-04-30 Thread Andreas Färber
Avoid tab-indention and fit in with the surrounding code. Signed-off-by: Andreas Färber Cc: Aneesh Kumar K.V --- configure | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 25697bb..641f147 100755 --- a/configure +++ b/configure @@

[Qemu-devel] [PATCH for-1.1 2/2] configure: Assure printing "yes" or "no" for VirtFS support

2012-04-30 Thread Andreas Färber
When auto-detecting VirtFS support, virtfs="". Set it to "no" after checking whether it was explicitly requested through --enable-virtfs. Signed-off-by: Andreas Färber Cc: Aneesh Kumar K.V --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configu

[Qemu-devel] [PATCH for-1.1 0/2] configure: Cosmetic VirtFS fix

2012-04-30 Thread Andreas Färber
Hello, I recently noticed that lack of VirtFS support leads to configure printing just "VirtFS support". This mini-series fixes it to say "VirtFS support no". I'm not sure if we have a definitive Coding Style for shell scripts (or Python code for that matter), so encountering tabs I went for th

Re: [Qemu-devel] [PULL] MAINTAINERS tidying and stable trees

2012-04-30 Thread Andreas Färber
Am 25.04.2012 17:17, schrieb Andreas Färber: > Hello Anthony, > > Please pull the uncontroversial parts of MAINTAINERS updates. Ping! This is still missing in master. Blue, can you pull please? Andreas > I'm leaving out the Maintained upgrades and would ask you to apply the 0.15 > patch once we

Re: [Qemu-devel] ARM target w/ self modifying code

2012-04-30 Thread Peter Maydell
On 30 April 2012 22:54, Emmanuel Blot wrote: > The platform is using an ARM7TDMI core with no cache. Neat trick given QEMU doesn't support the 7TDMI :-) Have you added that? > Up to now everything was working fine, but I've recently bumped into > an issue I have real hard time to solve: > > The

Re: [Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro

2012-04-30 Thread Andreas Färber
Am 01.05.2012 00:15, schrieb Andreas Färber: > From: Pavel Borzenkov > > Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac > OS X host. The patch is based on Ben Leslie's patch: > http://patchwork.ozlabs.org/patch/97859/ > > Signed-off-by: Ben Leslie > Signed-off-by: Pavel

[Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro

2012-04-30 Thread Andreas Färber
From: Pavel Borzenkov Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac OS X host. The patch is based on Ben Leslie's patch: http://patchwork.ozlabs.org/patch/97859/ Signed-off-by: Ben Leslie Signed-off-by: Pavel Borzenkov Signed-off-by: Andreas Färber --- block/raw-pos

[Qemu-devel] [PATCH 2/3] configure: add '--disable-cocoa' switch

2012-04-30 Thread Andreas Färber
From: Pavel Borzenkov When SDL support is disabled, there is no way to build QEMU without Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and allows to build QEMU without both SDL and Cocoa frontends. Signed-off-by: Pavel Borzenkov [AF: Adapt help output] Signed-off-by: Andre

[Qemu-devel] [PULL] Cocoa patch queue 2012-05-01

2012-04-30 Thread Andreas Färber
Hello Blue, Please pull the Cocoa queue into qemu.git master. The following changes since commit 42fe1c245f0239ebcdc084740a1777ac3699d071: Stefan Weil (1): main-loop: Fix build for w32 and w64 are available in the git repository at: git://repo.or.cz/qemu/afaerber.git cocoa-for-upstr

[Qemu-devel] ARM target w/ self modifying code

2012-04-30 Thread Emmanuel Blot
Hi, I'm porting QEMU (1.0.x) to a new ARM based platform (qemu-system-arm on a x86/64 host) The platform is using an ARM7TDMI core with no cache. Up to now everything was working fine, but I've recently bumped into an issue I have real hard time to solve: The native ARM code is replicating time

Re: [Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2012-04-30 Thread Andreas Färber
Am 30.04.2012 22:14, schrieb Matthew Anderson: > I pulled the latest version from Git and on first attempt it said the > hv_relaxed feature was not present. I checked the source and the > 'hv_relaxed' feature was not included in a 'feature_name' array so the > flag was being discarded before it cou

[Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2012-04-30 Thread Matthew Anderson
Thanks for the quick reply, I pulled the latest version from Git and on first attempt it said the hv_relaxed feature was not present. I checked the source and the 'hv_relaxed' feature was not included in a 'feature_name' array so the flag was being discarded before it could be enabled. Once added

Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch

2012-04-30 Thread Andreas Färber
Am 17.01.2012 00:46, schrieb Andrzej Zaborowski: > On 14 January 2012 01:42, Andreas Färber wrote: >> Am 08.12.2011 01:41, schrieb Andreas Färber: >>> Am 10.11.2011 19:40, schrieb Pavel Borzenkov: When SDL support is disabled, there is no way to build QEMU without Cocoa support on MacOS

Re: [Qemu-devel] [PATCH v2 06/24] qdev: fix -device foo,?

2012-04-30 Thread Paolo Bonzini
Il 27/04/2012 17:44, Anthony Liguori ha scritto: > On 04/27/2012 04:37 AM, Jiri Denemark wrote: >> On Wed, Apr 11, 2012 at 23:30:24 +0200, Paolo Bonzini wrote: >>> Since most property types do not have a parse property now, this was >>> broken. Fix it by looking at the setter instead. >>> >>> Sign

Re: [Qemu-devel] [PATCH] main-loop: Calculate poll timeout using timeout argument

2012-04-30 Thread Paolo Bonzini
Il 29/04/2012 19:15, Stefan Weil ha scritto: > The timeout argument was unused up to now, > but it can be used to reduce the poll_timeout when it is infinite > (negative value) or larger than timeout. > > Signed-off-by: Stefan Weil > --- > main-loop.c |6 +- > 1 files changed, 5 insertio

[Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2012-04-30 Thread Anthony Liguori
This should be resolved by using Hyper-V relaxed timers which is in the latest development version of QEMU. You would need to add -cpu host,+hv_relaxed to the command line to verify this. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you a

[Qemu-devel] [Bug 992067] [NEW] Windows 2008R2 very slow cold boot when >4GB memory

2012-04-30 Thread Matthew Anderson
Public bug reported: I've been having a consistent problem booting 2008R2 guests with 4096MB of RAM or greater. On the initial boot the KVM process starts out with a ~200MB memory allocation and will use 100% of all CPU allocated to it. The RES memory of the KVM process slowly rises by around 200m

Re: [Qemu-devel] [PATCH v2 4/6] prep: move int-ack register from PReP to Raven PCI emulation

2012-04-30 Thread Andreas Färber
Am 30.04.2012 10:43, schrieb Avi Kivity: > On 04/29/2012 11:12 PM, Andreas Färber wrote: >> Am 29.04.2012 10:32, schrieb Avi Kivity: >>> On 04/28/2012 09:46 PM, Andreas Färber wrote: Am 14.04.2012 22:48, schrieb Hervé Poussineau: > Register is one byte-wide (as per specification), so there

Re: [Qemu-devel] Poking a sun4v machine

2012-04-30 Thread Artyom Tarasenko
On Mon, Apr 30, 2012 at 7:15 PM, Andreas Färber wrote: > Am 30.04.2012 18:39, schrieb Artyom Tarasenko: >> Tried to boot QEMU Niagara machine with the firmware from the >> OpenSPARC T1 emulator ( www.opensparc.net/opensparc-t1/download.html ) >> , and it dies very early. >> The reason: in translat

Re: [Qemu-devel] Poking a sun4v machine

2012-04-30 Thread Andreas Färber
Am 30.04.2012 18:39, schrieb Artyom Tarasenko: > Tried to boot QEMU Niagara machine with the firmware from the > OpenSPARC T1 emulator ( www.opensparc.net/opensparc-t1/download.html ) > , and it dies very early. > The reason: in translate.c > > #define hypervisor(dc) (dc->mem_idx == MMU_HYPV_IDX)

[Qemu-devel] [PATCH] sdl: Disable broken scaling

2012-04-30 Thread Stefan Weil
SDL scaling uses a broken version of SDL_rotozoom which does out-of-bounds memory access. Disable it for QEMU 1.1 until a better solution is found. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- qemu-doc.texi |4 ++-- ui/sdl.c | 12 2 files changed, 14 insertions(+)

Re: [Qemu-devel] [PATCH 10/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-30 Thread Andreas Färber
Am 30.04.2012 18:21, schrieb Paul Brook: >> Move feature register value setup to per-CPU init functions. > >> +env->cp15.c0_c1[0] = cpu->id_pfr0; >> +env->cp15.c0_c1[1] = cpu->id_pfr1; >> +env->cp15.c0_c1[2] = cpu->id_dfr0; >> +env->cp15.c0_c1[3] = cpu->id_afr0; >> +env->cp15.c

[Qemu-devel] Poking a sun4v machine

2012-04-30 Thread Artyom Tarasenko
Tried to boot QEMU Niagara machine with the firmware from the OpenSPARC T1 emulator ( www.opensparc.net/opensparc-t1/download.html ) , and it dies very early. The reason: in translate.c #define hypervisor(dc) (dc->mem_idx == MMU_HYPV_IDX) #define supervisor(dc) (dc->mem_idx >= MMU_KERNEL_IDX) and

Re: [Qemu-devel] [PATCH 10/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-30 Thread Peter Maydell
On 30 April 2012 17:21, Paul Brook wrote: >> Move feature register value setup to per-CPU init functions. > >> +    env->cp15.c0_c1[0] = cpu->id_pfr0; >> +    env->cp15.c0_c1[1] = cpu->id_pfr1; >> +    env->cp15.c0_c1[2] = cpu->id_dfr0; >> +    env->cp15.c0_c1[3] = cpu->id_afr0; >> +    env->cp15.

Re: [Qemu-devel] [PATCH 10/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-30 Thread Paul Brook
> Move feature register value setup to per-CPU init functions. > +env->cp15.c0_c1[0] = cpu->id_pfr0; > +env->cp15.c0_c1[1] = cpu->id_pfr1; > +env->cp15.c0_c1[2] = cpu->id_dfr0; > +env->cp15.c0_c1[3] = cpu->id_afr0; > +env->cp15.c0_c1[4] = cpu->id_mmfr0; > +env->cp15.c0_c1[5

Re: [Qemu-devel] [Bug 990364] [NEW] virtio_ioport_write: unexpected address 0x13 value 0x1

2012-04-30 Thread Vadim Rozenfeld
On Monday, April 30, 2012 03:31:03 PM Stefan Hajnoczi wrote: > Hi Vadim, > Here is a recent bug report with virtio-win-0.1-22.iso. Wanted to > bring it to your attention, please let me know if you already monitor > these bug emails. Hi Stefan, Yes, it's on my radar. Cheers, Vadim. > > Stefan > >

Re: [Qemu-devel] [PATCH V3 11/13] SD card: introduce "spi" property for SD card objects

2012-04-30 Thread Paul Brook
> And drop passing is_spi argument to SDCardClass::init function. > "spi" property could be set while SD card is in IDLE state. It defaults to > "false". Why? This isn't something that should be under user or board control. The SD card object is an implementation detail. It's something that's

[Qemu-devel] [PATCH for-1.1 0/2] qemu-ga: Build fixes for Solaris/illumos

2012-04-30 Thread Andreas Färber
Hello, Here's a mini-series fixing the build on illumos like I had requested Lee to do. Patch 1 introduces a Solaris-only workaround for O_ASYNC that we could generalize for 1.2 (ifdef O_ASYNC seemed a bit risky to me on Hard Freeze eve in case some platform uses an enum rather than preprocessor

[Qemu-devel] [PATCH for-1.1 2/2] configure: Add libraries for qemu-ga on Solaris

2012-04-30 Thread Andreas Färber
Move socket-related Solaris libraries to $solarisnetlibs and use them for both $LIBS and $libs_qga. Fixes build on illumos without --disable-guest-agent. Signed-off-by: Lee Essen Signed-off-by: Andreas Färber --- configure |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --g

[Qemu-devel] [PATCH for-1.1 1/2] qemu-ga: Implement alternative to O_ASYNC

2012-04-30 Thread Andreas Färber
ga_channel_open() was using open flag O_ASYNC for SIGIO-driven I/O. This breaks on illumos, so fall back to POSIX I_SETSIG ioctl (SIGPOLL). Signed-off-by: Lee Essen Signed-off-by: Andreas Färber --- qga/channel-posix.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-04-30 Thread Michael Tokarev
This value is used currently for virtio-blk only. It was defined as uint16_t before, which is the same as in kernel<=>user interface (in virtio_blk.h, struct virtio_blk_config). But the problem is that in kernel<=>user interface the units are sectors (which is usually 512 bytes or more), while in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 20/22] ppc: move load and store helpers, switch to AREG0 free mode

2012-04-30 Thread malc
On Mon, 30 Apr 2012, Alexander Graf wrote: > > On 30.04.2012, at 12:45, Alexander Graf wrote: > > > > > On 22.04.2012, at 15:26, Blue Swirl wrote: > > > >> Add an explicit CPUPPCState parameter instead of relying on AREG0 > >> and rename op_helper.c (which only contains load and store helpers)

Re: [Qemu-devel] [PATCH] Fix SPI SD emulation

2012-04-30 Thread Paul Brook
> >> If this command could be issued in transfer state maybe in addition to > >> IDLE_STATE you also need to set other bits (ADDRESS_ERROR, > >> COM_CRC_ERROR, ILLEGAL_COMMAND, ERASE_SEQ_ERROR) in MSB of R3 response? > > > > In theory, yes. I was thinking of a follow-up patch to move the spi > >

[Qemu-devel] [PATCH 4/5] prep: Initialize PC speaker

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Speaker init has been added in 506b7ddf889312659b36c667f7ae17bc9e909418, but audio subsystem init was missing. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/ppc_prep.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/

[Qemu-devel] [PULL v2] PReP patch queue 2012-04-30

2012-04-30 Thread Andreas Färber
Hello Blue, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. The following changes since commit 42fe1c245f0239ebcdc084740a1777ac3699d071: main-loop: Fix build for w32 and w64 (2012-04-28 09:25:54 +) are available in the git repository at: git://repo.or.cz/qe

[Qemu-devel] [PATCH 5/5] prep: Move int-ack register from PReP to Raven PCI emulation

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Register is one byte-wide (as per specification), so there is no need to specify endianness. Signed-off-by: Hervé Poussineau [AF: Limit access validity to size 1] Signed-off-by: Andreas Färber --- hw/ppc_prep.c | 36 hw/prep_pci.c

[Qemu-devel] [PATCH 2/5] fdc: Parametrize ISA base, IRQ and DMA

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Keep the PC values as defaults but allow to override them for PReP. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber Reviewed-by: Markus Armbruster --- hw/fdc.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/fd

[Qemu-devel] [PATCH 1/5] i82378/i82374: Do not create DMA controller twice

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau This fixes a crash in PReP emulation when using DMA controller to access floppy drive. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/i82374.c |5 - hw/i82378.c |5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 3/5] isa: Add isa_bus_from_device() method

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Acked-by: Gerd Hoffmann Signed-off-by: Andreas Färber --- hw/isa.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index 40373fb..f7bc4b5 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -76,6 +76,1

Re: [Qemu-devel] [PULL] PReP patch queue 2012-04-30

2012-04-30 Thread Andreas Färber
Am 30.04.2012 16:47, schrieb Andreas Färber: > Hello Blue, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. > > The following changes since commit 42fe1c245f0239ebcdc084740a1777ac3699d071: > > main-loop: Fix build for w32 and w64 (2012-04-28 09:25:54 +) >

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Andreas Färber
Am 30.04.2012 16:55, schrieb Mark Cave-Ayland: > Note that if properties can't be set by the caller after construction, > then I'm effectively going to have to copy the entire esp_init() > function; The idea would be to use the QOM way of creating the object, using QOM and/or custom ways to set pr

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 15:55, Mark Cave-Ayland wrote: > I > might as well just keep a copy in sun4m.c with my local modifications as > sun4_esp_init() and be done with it. Slightly frustrating, but I think > that's going to be the easiest solution for the moment. You will need to address the properties

Re: [Qemu-devel] [PATCH] ppce500_spin: Replace assert by hw_error (fixes compiler warning)

2012-04-30 Thread Andreas Färber
Am 30.04.2012 10:54, schrieb Alexander Graf: > > On 28.04.2012, at 17:52, Stefan Weil wrote: > >> The default case in function spin_read should never be reached, >> therefore the old code used assert(0) to abort QEMU. >> >> This does not work when QEMU is compiled with macro NDEBUG defined. >> In

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 15:55, Mark Cave-Ayland wrote: > Note that if properties can't be set by the caller after construction, then > I'm effectively going to have to copy the entire esp_init() function Yes. As I say, these init functions are purely convenience functions for the simple case. (My opinio

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Mark Cave-Ayland
On 30/04/12 15:39, Peter Maydell wrote: Right I think I'm starting to understand this now - in which case it becomes a matter of just copying a handful of lines within sun4m which is more bearable. In your view, would a suitable fix be to change dma_memory_read, dma_memory_write, dma_opaque, it

Re: [Qemu-devel] [PATCH] ppce500_spin: Replace assert by hw_error (fixes compiler warning)

2012-04-30 Thread Stefan Weil
Am 30.04.2012 10:54, schrieb Alexander Graf: On 28.04.2012, at 17:52, Stefan Weil wrote: The default case in function spin_read should never be reached, therefore the old code used assert(0) to abort QEMU. This does not work when QEMU is compiled with macro NDEBUG defined. In this case (and al

[Qemu-devel] [PATCH 4/5] prep: Initialize PC speaker

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Speaker init has been added in 506b7ddf889312659b36c667f7ae17bc9e909418, but audio subsystem init was missing. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/ppc_prep.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/

[Qemu-devel] [PULL] PReP patch queue 2012-04-30

2012-04-30 Thread Andreas Färber
Hello Blue, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. The following changes since commit 42fe1c245f0239ebcdc084740a1777ac3699d071: main-loop: Fix build for w32 and w64 (2012-04-28 09:25:54 +) are available in the git repository at: git://repo.or.cz/qe

[Qemu-devel] [PATCH 5/5] prep: Move int-ack register from PReP to Raven PCI emulation

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Register is one byte-wide (as per specification), so there is no need to specify endianness. Signed-off-by: Hervé Poussineau [AF: Limit access validity to size 1] Signed-off-by: Andreas Färber --- hw/ppc_prep.c | 36 hw/prep_pci.c

[Qemu-devel] [PATCH 2/5] fdc: Parametrize ISA base, IRQ and DMA

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Keep the PC values as defaults but allow to override them for PReP. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber Reviewed-by: Markus Armbruster --- hw/fdc.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/fd

[Qemu-devel] [PATCH 3/5] isa: Add isa_bus_from_device() method

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Acked-by: Gerd Hoffmann Signed-off-by: Andreas Färber --- hw/isa.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index 40373fb..f7bc4b5 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -76,6 +76,1

[Qemu-devel] [PATCH 1/5] i82378/i82374: Do not create DMA controller twice

2012-04-30 Thread Andreas Färber
From: Hervé Poussineau This fixes a crash in PReP emulation when using DMA controller to access floppy drive. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/i82374.c |5 - hw/i82378.c |5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH] qemu: fix cpuid eax for kvm cpu

2012-04-30 Thread Michael S. Tsirkin
cpuid eax should return the max leaf so that guests can find out the valid range. This matches Xen et al. Tested using -cpu kvm64. Signed-off-by: Michael S. Tsirkin --- target-i386/kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kv

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 15:33, Mark Cave-Ayland wrote: > On 30/04/12 15:03, Peter Maydell wrote: > Right I think I'm starting to understand this now - in which case it becomes > a matter of just copying a handful of lines within sun4m which is more > bearable. > > In your view, would a suitable fix be to

[Qemu-devel] [PATCH v6 4/7] qapi: String visitor, use %f representation for floats

2012-04-30 Thread Michael Roth
Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it uses 6 significant figures instead of 6 decimal places, which means something like 155777.5 (which even has an exact floating point

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Mark Cave-Ayland
On 30/04/12 15:03, Peter Maydell wrote: Therefore I can't change it to my (modified) sbus_mmio_map() function because it would break other non-SPARC platforms, and AIUI there is nothing in the memory API that allows me to move a subregion to a different MemoryRegion parent, even if I can get a r

Re: [Qemu-devel] KVM call agenda for May, Thrusday 1st

2012-04-30 Thread Peter Portante
On Mon, Apr 30, 2012 at 7:58 AM, Anthony Liguori wrote: > On 04/30/2012 04:17 AM, Juan Quintela wrote: > >> >> >> Hi >> >> Please send in any agenda items you are interested in covering. >> > > FYI, I won't be able to attend as I'll be at the LF End User Summit. > > Regards, > > Anthony Liguori >

Re: [Qemu-devel] [PATCH 4/7] qapi: String visitor, use %f represenation for floats

2012-04-30 Thread Michael Roth
On Sat, Apr 28, 2012 at 06:20:47PM +0200, Andreas Färber wrote: > Am 27.04.2012 22:21, schrieb Michael Roth: > > Currently string-output-visitor formats floats as %g, which is nice in > > that trailing 0's are automatically truncated, but otherwise this causes > > some issues: > > > > - it 6 uses

Re: [Qemu-devel] scsi-testsuite for virtio-scsi

2012-04-30 Thread Anthony Liguori
On 04/30/2012 09:01 AM, Christoph Hellwig wrote: On Mon, Apr 30, 2012 at 12:59:53PM +0100, Stefan Hajnoczi wrote: It's not ideal but if we had a kickstart file or another way of building the guest with a single command, then at least regular QEMU SCSI contributors and maintainers can use the tes

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 14:52, Mark Cave-Ayland wrote: > The key problem is that this doesn't worked with shared peripherals, such as > the ESP device which is also used on various PPC Mac models as well as > SPARC. That's because its init function looks like this: > > > > void esp_init(target_phys_addr_

Re: [Qemu-devel] scsi-testsuite for virtio-scsi

2012-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2012 at 12:59:53PM +0100, Stefan Hajnoczi wrote: > It's not ideal but if we had a kickstart file or another way of > building the guest with a single command, then at least regular QEMU > SCSI contributors and maintainers can use the test suite - I think a > Fedora guest would be fi

Re: [Qemu-devel] scsi-testsuite for virtio-scsi

2012-04-30 Thread Christoph Hellwig
On Fri, Apr 27, 2012 at 04:15:43PM +0100, Stefan Hajnoczi wrote: > Christoph Hellwig has announced a new testsuite for the Linux > in-kernel SCSI target: > > http://risingtidesystems.com/git/?p=scsi-testsuite.git;a=tree > > We will need something similar for virtio-scsi. Maybe we can > contribut

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Mark Cave-Ayland
On 30/04/12 14:27, Peter Maydell wrote: Hi Peter, IMO the best fix is to unsysbus the device and qomify it instead. This way we're 100% flexible in how we can attach it. You don't need to wait for QOM to grow enough features to replace sysbus. If you don't like what sysbus_mmio_map() does, y

Re: [Qemu-devel] [PULL] qemu-ga: fsfreeze hardening/fixes

2012-04-30 Thread Michael Roth
On Sun, Apr 29, 2012 at 03:10:11PM -0500, Anthony Liguori wrote: > On 04/27/2012 05:39 PM, Michael Roth wrote: > >The following changes since commit a8b69b8e2431edfcb6c4cfb069787e9071d6235b: > > > > Merge remote-tracking branch 'qmp/queue/qmp' into staging (2012-04-27 > > 12:00:06 -0500) > > > >

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Anthony Liguori
On 04/30/2012 08:36 AM, Avi Kivity wrote: On 04/30/2012 04:27 PM, Peter Maydell wrote: On 30 April 2012 14:23, Avi Kivity wrote: IMO the best fix is to unsysbus the device and qomify it instead. This way we're 100% flexible in how we can attach it. You don't need to wait for QOM to grow eno

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 14:36, Avi Kivity wrote: > On 04/30/2012 04:27 PM, Peter Maydell wrote: >> On 30 April 2012 14:23, Avi Kivity wrote: >> > IMO the best fix is to unsysbus the device and qomify it instead.  This >> > way we're 100% flexible in how we can attach it. >> >> You don't need to wait for

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Mark Cave-Ayland
On 30/04/12 14:23, Avi Kivity wrote: Hi Avi, My understanding based upon this is that it would be impossible to register a different parent MemoryRegion without duplicating the init function for all shared devices which seems undesirable :( What are the requirements? You need a different cat

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Avi Kivity
On 04/30/2012 04:27 PM, Peter Maydell wrote: > On 30 April 2012 14:23, Avi Kivity wrote: > > IMO the best fix is to unsysbus the device and qomify it instead. This > > way we're 100% flexible in how we can attach it. > > You don't need to wait for QOM to grow enough features to > replace sysbus.

[Qemu-devel] [PATCH qemu 7/6] vl.c: actually change defconfig variable to bool

2012-04-30 Thread Eduardo Habkost
I changed everything on my previous patch to change 'defconfig', but forgot to actually change the variable data type. As the incomplete change doesn't cause any issues or compiler warnings, I am simply sending this additional patch instead of respinning the whole series. Signed-off-by: Eduardo H

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Peter Maydell
On 30 April 2012 14:23, Avi Kivity wrote: > IMO the best fix is to unsysbus the device and qomify it instead.  This > way we're 100% flexible in how we can attach it. You don't need to wait for QOM to grow enough features to replace sysbus. If you don't like what sysbus_mmio_map() does, you can a

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Avi Kivity
On 04/30/2012 03:17 PM, Mark Cave-Ayland wrote: > On 30/04/12 09:41, Avi Kivity wrote: > >> Yes. I think it's even possible to do this now, you can create an mmio >> region for the bus and add subregions to it. All subregions >> automatically overlap the container region. >> >> Simply replace >>

Re: [Qemu-devel] [PATCH qemu 4/6] vl.c: change 'defconfig' variable to bool

2012-04-30 Thread Eduardo Habkost
On Sat, Apr 28, 2012 at 07:53:41AM +, Blue Swirl wrote: > On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost wrote: > > Signed-off-by: Eduardo Habkost > > --- > >  vl.c |    4 ++-- > >  1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index 1e5e593..a4f4676 10

Re: [Qemu-devel] [PATCH 2/2] qcow2: fix the byte endian convertion

2012-04-30 Thread Stefan Hajnoczi
On Sat, Apr 28, 2012 at 8:38 AM, wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- >  block/qcow2-refcount.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/2] qcow2: remove a line of unnecessary code

2012-04-30 Thread Stefan Hajnoczi
On Sat, Apr 28, 2012 at 8:37 AM, wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- >  block/qcow2-cluster.c |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi I took a look to understand why that line of code was there. This can be import

Re: [Qemu-devel] [Bug 990364] [NEW] virtio_ioport_write: unexpected address 0x13 value 0x1

2012-04-30 Thread Stefan Hajnoczi
Hi Vadim, Here is a recent bug report with virtio-win-0.1-22.iso. Wanted to bring it to your attention, please let me know if you already monitor these bug emails. Stefan On Sat, Apr 28, 2012 at 9:49 AM, Vitalis wrote: > Public bug reported: > > Hello! I have: > > virtio_ioport_write: unexpecte

[Qemu-devel] [PATCH V16 6/7] Introduce --enable-tpm-passthrough configure option

2012-04-30 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger --- configure | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/configure b/configure index b4e9cf9..1911204 100755 --- a/configure +++ b/configure @@ -196,6 +196,7 @@ guest_a

[Qemu-devel] [PATCH V16 7/7] Add fd parameter for TPM passthrough driver

2012-04-30 Thread Stefan Berger
Enable the passing of a file descriptor via fd=<..> to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger --- hw/tpm_passthrough.c | 61 ++--- qemu-config.c|5 qemu-options.hx | 11

[Qemu-devel] [PATCH V16 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-04-30 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

[Qemu-devel] [PATCH V16 3/7] Add a debug register

2012-04-30 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger --- hw/tpm_tis.c | 70 +++

[Qemu-devel] [PATCH V16 1/7] Support for TPM command line options

2012-04-30 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa

[Qemu-devel] [PATCH V16 5/7] Add a TPM Passthrough backend driver implementation

2012-04-30 Thread Stefan Berger
>From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "Qemu Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch adds a passthrough backend driver for passing command

[Qemu-devel] [PATCH V16 4/7] Build the TPM frontend code

2012-04-30 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- Makefile.target |2 ++ configure | 11 +++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index 1cf6943..6a5f26f 100644 --- a/Makefile.t

[Qemu-devel] [PATCH V16 0/7] Qemu Trusted Platform Module (TPM) integration

2012-04-30 Thread Stefan Berger
The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabling for examp

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-04-30 Thread Mark Cave-Ayland
On 30/04/12 09:41, Avi Kivity wrote: Yes. I think it's even possible to do this now, you can create an mmio region for the bus and add subregions to it. All subregions automatically overlap the container region. Simply replace memory_region_init(&bus->address_space, ...) memory_region_

[Qemu-devel] [PATCH 1/2] Fix SPI SD card command responses

2012-04-30 Thread Paul Brook
When in SPI mode, we give a bogus response to CMD8 (part of the SD physical spec v2). This command should return both the status byte and the register value. The current code returns "long" status words from sd.c, then parses translates those to SPI status bytes ssi-sd.c. For CMD8 (and CMD58 to

[Qemu-devel] [PATCH 2/2] hw/sd.c: Implement CMD58

2012-04-30 Thread Paul Brook
Implement CMD58. This command is only valid in SPI mode, and required when we implement CMD8. Most of the code is already there, we just need to trigger it. Signed-off-by: Paul Brook --- hw/sd.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/sd.c b/hw/

[Qemu-devel] [PATCH 0/2] SPI SDcard fixes v2

2012-04-30 Thread Paul Brook
Recent testing showed the SPI mode SD card emulation (ssi-sd.c) doesn't actually work if the guest tries to use features from the SD Physical Layer Specification v2 (this incluldes SDHC). This series replaces my previous single patch. Paul Brook (2): Fix SPI SD card command responses hw/sd.c:

Re: [Qemu-devel] scsi-testsuite for virtio-scsi

2012-04-30 Thread Anthony Liguori
On 04/30/2012 06:59 AM, Stefan Hajnoczi wrote: On Sun, Apr 29, 2012 at 8:12 PM, Anthony Liguori wrote: On 04/28/2012 09:34 AM, Paolo Bonzini wrote: Il 28/04/2012 03:45, Zhi Yong Wu ha scritto: It's based on qemu-iotests, so the structure is familiar but uses sg3-utils to send SCSI commands

Re: [Qemu-devel] scsi-testsuite for virtio-scsi

2012-04-30 Thread Stefan Hajnoczi
On Sun, Apr 29, 2012 at 8:12 PM, Anthony Liguori wrote: > On 04/28/2012 09:34 AM, Paolo Bonzini wrote: >> >> Il 28/04/2012 03:45, Zhi Yong Wu ha scritto: > > It's based on qemu-iotests, so the structure is familiar but uses > sg3-utils to send SCSI commands instead of qemu-io. >>> >>>

Re: [Qemu-devel] KVM call agenda for May, Thrusday 1st

2012-04-30 Thread Anthony Liguori
On 04/30/2012 04:17 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. FYI, I won't be able to attend as I'll be at the LF End User Summit. Regards, Anthony Liguori Thanks, Juan.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 20/22] ppc: move load and store helpers, switch to AREG0 free mode

2012-04-30 Thread Alexander Graf
On 30.04.2012, at 12:45, Alexander Graf wrote: > > On 22.04.2012, at 15:26, Blue Swirl wrote: > >> Add an explicit CPUPPCState parameter instead of relying on AREG0 >> and rename op_helper.c (which only contains load and store helpers) >> to mem_helper.c. Remove AREG0 swapping in >> tlb_fill().

[Qemu-devel] [PATCH v2 5/5] tracetool: avoid pkgutil.iter_modules() Python 2.7 function

2012-04-30 Thread Stefan Hajnoczi
The pkgutil.iter_modules() function provides a way to enumerate child modules. Unfortunately it's missing in Python <2.7 so we must implement similar behavior ourselves. Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/__init__.py |8 ++-- scripts/tracetool/format/__init__.p

[Qemu-devel] [PATCH v2 2/5] tracetool: use Python 2.4-compatible __import__() arguments

2012-04-30 Thread Stefan Hajnoczi
In Python 2.5 keyword arguments were added to __import__(). Avoid using them to achieve Python 2.4 compatibility. Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/trace

[Qemu-devel] [PATCH v2 3/5] tracetool: avoid str.rpartition() Python 2.5 function

2012-04-30 Thread Stefan Hajnoczi
The str.rpartition() function is related to str.split() and is used for splitting strings. It was introduced in Python 2.5 and therefore cannot be used in tracetool as Python 2.4 compatibility is required. Replace the code using str.rsplit(). Signed-off-by: Stefan Hajnoczi --- scripts/tracetoo

[Qemu-devel] [PATCH v2 4/5] configure: check for supported Python 2.x versions

2012-04-30 Thread Stefan Hajnoczi
The tracetool code requires Python 2.4, which was released in 2004. Check for a supported Python version so we can give a clear error message. Signed-off-by: Stefan Hajnoczi --- configure |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 25

[Qemu-devel] [PATCH v2 1/5] tracetool: use Python 2.4-compatible exception handling syntax

2012-04-30 Thread Stefan Hajnoczi
The newer "except as :" syntax is not supported by Python 2.4, we need to use "except , :". Tested all trace backends with Python 2.4. Reported-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- scripts/tracetool.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

  1   2   >