Re: [Qemu-devel] [PATCH] Implement query-usbhost QMP command

2018-04-13 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1523675125-14022-1-git-send-email-...@godking.net Subject: [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PATCH v2 16/17] translate-all: remove tb_lock mention from cpu_restore_state_from_tb

2018-04-13 Thread Richard Henderson
On 04/05/2018 04:13 PM, Emilio G. Cota wrote: > tb_lock was needed when the function did retranslation. However, > since fca8a500d519 ("tcg: Save insn data and use it in > cpu_restore_state_from_tb") we don't do retranslation. > > Get rid of the comment. > > Signed-off-by: Emilio G. Cota

Re: [Qemu-devel] [PATCH v2 13/17] translate-all: discard TB when tb_link_page returns an existing matching TB

2018-04-13 Thread Richard Henderson
On 04/05/2018 04:13 PM, Emilio G. Cota wrote: > Use the recently-gained QHT feature of returning the matching TB if it > already exists. This allows us to get rid of the lookup we perform > right after acquiring tb_lock. > > Suggested-by: Richard Henderson > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 12/17] translate-all: add page_collection assertions

2018-04-13 Thread Richard Henderson
On 04/05/2018 04:13 PM, Emilio G. Cota wrote: > +static __thread bool page_collection_locked; > + > +void assert_page_collection_locked(bool val) > +{ > +tcg_debug_assert(page_collection_locked == val); > +} > + > +static inline void set_page_collection_locked(bool val) > +{ > +

Re: [Qemu-devel] [PATCH v2 11/17] translate-all: add page_locked assertions

2018-04-13 Thread Richard Henderson
On 04/05/2018 04:13 PM, Emilio G. Cota wrote: > +#ifdef CONFIG_DEBUG_TCG > + > +struct page_lock_debug { > +const PageDesc *pd; > +QLIST_ENTRY(page_lock_debug) entry; > +}; > + > +static __thread QLIST_HEAD(, page_lock_debug) page_lock_debug_head; > + > +static struct page_lock_debug

Re: [Qemu-devel] [PATCH v2 10/17] translate-all: use per-page locking in !user-mode

2018-04-13 Thread Richard Henderson
On 04/05/2018 04:13 PM, Emilio G. Cota wrote: > +/** > + * struct page_collection - tracks a set of pages (i.e. page_entry's) > + * @tree: Binary search tree (BST) of the pages, with key == page index > + * @max:Pointer to the page in @tree with the highest page index > + * > + * To avoid

[Qemu-devel] [PATCH] Implement query-usbhost QMP command

2018-04-13 Thread Alexander Kappner
Implement a QMP command similar to the HMP's "info usbhost" command. This allows a QMP client to query which USB devices may be available for redirection. Because the availability of the command needs to depend on the target's (not the build host's) USB configuration, a qmp_nousb.c is provided for

[Qemu-devel] [Bug 1126369] Re: qemu-img snapshot -c is unreasonably slow

2018-04-13 Thread Stefan Hajnoczi
Code inspection shows that qcow2_update_cluster_refcount() no longer calls bdrv_flush(). This issue has been fixed. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1516446] Re: Migration always causes guest freeze in one direction.

2018-04-13 Thread Thomas Huth
Can you still reproduce the issue with a recent Linux kernel and the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-04-13 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumerated Boot Menu.

Re: [Qemu-devel] [PATCH] acpi: fix a comment about aml_call0()

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 01:45 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé > --- > hw/acpi/aml-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/aml-build.c

[Qemu-devel] [Bug 1446726] Re: qemu stable 2.0 crashes during loadvm

2018-04-13 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-13 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signed-off-by: Collin

[Qemu-devel] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu

2018-04-13 Thread Collin Walling
Change Log: v2 - added r-b's - s/zipl_println/zipl_print_entry - prints entry and returns entry number - while loop now handles valid_entries These patches fix the following: - The QEMU zIPL boot menu does not allow accurate selection of

[Qemu-devel] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-04-13 Thread Collin Walling
Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an empty string or a series of spaces.

[Qemu-devel] [PATCH 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

2018-04-13 Thread Collin Walling
The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h to make it available

[Qemu-devel] [Bug 1435973] Re: Qemu crash when a guest linux issues specific scsi command via ioctl(SG_IO) with SCSI disk emulation.

2018-04-13 Thread Thomas Huth
Looks like this has been fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c170aad8b057223b1139d7 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1423668] Re: Unable to set scsi drive serial if it contains spaces.

2018-04-13 Thread Thomas Huth
This error message comes from libvirt, not from QEMU, so please report the error there if it still persists: https://libvirt.org/bugs.html ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1362635] Re: bdrv_read co-routine re-entered recursively

2018-04-13 Thread Thomas Huth
Closing this ticket now, since it's not about upstream QEMU code. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1362635 Title: bdrv_read

[Qemu-devel] [Bug 1190525] Re: fdisk still shows the "/dev/sdb" partitions even after the removal of scsi disk

2018-04-13 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1190525 Title: fdisk still shows the "/dev/sdb" partitions even after the removal of scsi disk

[Qemu-devel] [Bug 1195012] Re: x86_64 and i386 return 0 when reading MSR_TSC

2018-04-13 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2018-04-13 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-13 Thread Richard W.M. Jones
On Fri, Apr 13, 2018 at 10:26:03PM +0300, Nir Soffer wrote: > When a management application expose images using qemu-nbd, it needs a > secure way to allow temporary access to the disk. Using a random export > name can solve this problem: > >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper

2018-04-13 Thread John Snow
On 04/13/2018 01:44 PM, Vladimir Sementsov-Ogievskiy wrote: > > will add, as always, thank you for natural rewording) Hm, I have a > question: why do you often use double white-space "  " between > sentences? Is it something meaningful? There is some GREAT DEBATE in the English-speaking world

[Qemu-devel] [Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

2018-04-13 Thread David Wilder
FYI: To workaround this issue you can limit the docker container to a single cpu like this: docker run --cpuset-cpus 0 -it cross-test3 go build hello.go This works for docker build as well. docker build--cpuset-cpus 0 . -- You received this bug notification because you are a member of

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test new qemu-nbd --nolist option

2018-04-13 Thread Nir Soffer
Add new test module for tesing the --nolist option. Signed-off-by: Nir Soffer --- tests/qemu-iotests/214 | 46 ++ tests/qemu-iotests/214.out | 2 ++ tests/qemu-iotests/group | 1 + 3 files changed, 49 insertions(+) create

[Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-13 Thread Nir Soffer
When a management application expose images using qemu-nbd, it needs a secure way to allow temporary access to the disk. Using a random export name can solve this problem: nbd://server:10809/22965f19-9ab5-4d18-94e1-cbeb321fa433 Assuming that the url is passed to the user in a secure way, and

[Qemu-devel] [PATCH 2/3] iotests.py: Add helper for running commands

2018-04-13 Thread Nir Soffer
Add few helpers for running external commands: - CommandFailed: exception, keeping all the info related to a failed command, and providing a useful error message. (Unfortunately subprocess.CalledProcessError does not). - run(): run a command collecting output from the underlying process

[Qemu-devel] [PATCH 0/3] qemu-nbd: Disallow listing exports

2018-04-13 Thread Nir Soffer
oVirt uses random URLs to expose images temporarily via HTTPS. We would like to integrated qemu-nbd in the same system, proving a user an easy and uniform way to access an image - either using HTTPS: https://server:54322/images/dc72d3cc-b933-45e8-89a2-e028e1c2ef3d Or using NBD over TLS:

[Qemu-devel] [Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

2018-04-13 Thread David Wilder
I missed a step for reproduction. Step 1 should be: docker run --rm --privileged multiarch/qemu-user-static:register This modprobes binfmt and registers qemu-ppc64le-static as the interpreter for ppc64le executables. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-13 Thread Richard Henderson
On 04/13/2018 04:23 AM, Peter Maydell wrote: > The MIPS TCG target makes the assumption that the offset from the > target env pointer to the tlb_table is less than about 64K. This > used to be true, but gradual addition of features to the Arm > target means that it's no longer true there. This

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

2018-04-13 Thread Richard Henderson
On 04/12/2018 04:02 AM, Peter Maydell wrote: > AArch64 stack frames include a 'frame record' which holds a pointer > to the next frame record in the chain and the LR on entry to the > function. The procedure calling standard doesn't mandate where > exactly this frame record is in the stack frame,

Re: [Qemu-devel] [PATCH v2 15/17] target/riscv: convert to DisasJumpType

2018-04-13 Thread Richard Henderson
> Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > > Signed-off-by: Emilio G. Cota > --- > target/riscv/translate.c | 72 >

Re: [Qemu-devel] [PATCH for 2.13 v3 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

2018-04-13 Thread Richard Henderson
On 04/11/2018 08:45 AM, Laurent Vivier wrote: > Instead of calling setup_frame() conditionally to a list of known targets, > define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function > and call it only if the macro is defined. > > Move declarations of setup_frame() and

Re: [Qemu-devel] [PATCH v3 11/22] target/arm: Fix bitmask for PMCCFILTR writes

2018-04-13 Thread Aaron Lindsay
On Apr 12 17:41, Peter Maydell wrote: > On 16 March 2018 at 20:31, Aaron Lindsay wrote: > > It was shifted to the left one bit too few. > > > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/helper.c | 2 +- > > 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-13 Thread Richard Henderson
On 04/06/2018 08:19 AM, Emilio G. Cota wrote: > Notes: > > - Did not convert {num,max}_insns, since the corresponding code > will go away in the next patch. > > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. > > While at it, convert the remaining tb->cflags readers

Re: [Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-13 Thread Richard Henderson
On 04/06/2018 08:20 AM, Emilio G. Cota wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Signed-off-by: Emilio G. Cota > --- >

[Qemu-devel] [PATCH v2 2/3] nbd/server: implement dirty bitmap export

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap selects bitmap to export. For now, only one bitmap may be

[Qemu-devel] [PATCH v2 3/3] qapi: new qmp command nbd-server-add-bitmap

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json | 23 +++ blockdev-nbd.c | 23 +++ 2 files changed, 46 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index c694524002..cc0e607b5b 100644 ---

[Qemu-devel] [PATCH v2 1/3] nbd/server: add nbd_meta_single_query helper

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
The helper will be reused for bitmaps namespace. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- nbd/server.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/3] NBD export bitmaps

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
Hi all. This is a proposal and realization of new NBD meta context: qemu. (I hope to send corresponding proposal to NBD protocol soon) New possible queries will look like: qemu:dirty-bitmap: Mapping from export-bitmap-name to BdrvDirtyBitmap is done through qmp command nbd-server-add-bitmap.

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Collin Walling
On 04/13/2018 02:06 PM, Philippe Mathieu-Daudé wrote: > On 04/13/2018 01:59 PM, Halil Pasic wrote: On 04/13/2018 04:30 PM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 01:59 PM, Halil Pasic wrote: >>> On 04/13/2018 04:30 PM, Thomas Huth wrote: "size_t" should be an unsigned type - the signed counterpart is called "ssize_t" in the C standard instead. Thus we should also use this >>> The first sentence sounds like ssize_t is too a type

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-13 Thread Auger Eric
Hi Igor, On 12/04/18 18:40, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on ordering of >

Re: [Qemu-devel] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
21.03.2018 18:05, Eric Blake wrote: On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: The helper will be reused for bitmaps namespace. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   nbd/server.c | 41 -   1 file

Re: [Qemu-devel] [PATCH v4 2/5] qcow2: Document some maximum size constraints

2018-04-13 Thread Max Reitz
On 2018-02-28 15:20, Alberto Garcia wrote: > On Wed 28 Feb 2018 03:01:33 PM CET, Eric Blake wrote: > The refcount table has implications on the maximum host file size; a larger cluster size is required for the refcount table to cover larger offsets. >>> >>> Why is this? Because of

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Halil Pasic
On 04/13/2018 05:50 PM, Thomas Huth wrote: > On 13.04.2018 17:28, Halil Pasic wrote: >> >> On 04/13/2018 04:30 PM, Thomas Huth wrote: >>> "size_t" should be an unsigned type - the signed counterpart is called >>> "ssize_t" in the C standard instead. Thus we should also use this >> The first

[Qemu-devel] [PATCH] acpi: fix a comment about aml_call0()

2018-04-13 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 3fa557cea1..1e43cd736d 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -627,7

Re: [Qemu-devel] [RFC V4 PATCH 0/4] vfio: Introduce live migation capability to

2018-04-13 Thread Zhang, Yulei
Hi Kirti, what do you think of the pre-copy interface in this series? Thanks, Yulei > -Original Message- > From: Zhang, Yulei > Sent: Tuesday, April 10, 2018 2:02 PM > To: qemu-devel@nongnu.org > Cc: Tian, Kevin ; joonas.lahti...@linux.intel.com; >

[Qemu-devel] [PATCH v4 0/4] RFC: simplify qobject refcount

2018-04-13 Thread Marc-André Lureau
Hi, This series aims to get rid of the distinction between QObject, that must use qobject_incref/qobject_decref and its various derived types that have to use QINCREF/QDECREF. Instead, replace it with qobject_ref/qobject_unref for all types. v4: - rename QObjectCommon->QObjectBase_ - add back

[Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

2018-04-13 Thread Marc-André Lureau
By moving the base fields to a QObjectBase_, QObject can be a type which also has a 'base' field. This allows to write a generic QOBJECT() macro that will work with any QObject type, including QObject itself. The container_of() macro ensures that the object to cast has a QObjectBase_ base field,

[Qemu-devel] [PATCH v4 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

2018-04-13 Thread Marc-André Lureau
Following a discussion on the mailing list: while it may be convenient to accept NULL value in qobject_unref() (for similar reasons as free() accepts NULL), it is a probably a bad idea to accept NULL argument in qobject_ref(). Furthermore, it is convenient and more clear to call qobject_ref() at

[Qemu-devel] [PATCH v4 1/4] qobject: ensure base is at offset 0

2018-04-13 Thread Marc-André Lureau
All QObject types have the base QObject as first field. This allows to simplify qobject_to() and will allow further simplification in following patch. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qobject.h | 5 ++--- qobject/qobject.c | 9 +

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Bastian Koppelmann
On 04/13/2018 05:29 PM, Peter Maydell wrote: > On 13 April 2018 at 16:24, Bastian Koppelmann > wrote: >> However, my risu-like tests found another flag raising problem with >> float32_div. I'll investigate it on Monday. > > Is it a regression from our previous

Re: [Qemu-devel] [PATCH v3 3/4] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF

2018-04-13 Thread Paolo Bonzini
On 29/03/2018 18:23, Eric Blake wrote: >> >>   +/** >> + * qobject_ref(): Increment QObject's reference count >> + */ >> +#define qobject_ref(obj)    \ >> +    qobject_ref(QOBJECT(obj)) > > ...below the functions of the same name.  C preprocessor rules guarantee > that you

Re: [Qemu-devel] [PATCH v3 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

2018-04-13 Thread Marc-André Lureau
Hi On Thu, Mar 29, 2018 at 6:10 PM, Eric Blake wrote: > On 03/29/2018 10:48 AM, Marc-André Lureau wrote: >> >> Following a discussion on the mailing list: while it may be convenient >> to accept NULL value in qobject_unref() (for similar reasons as free() >> accepts NULL), it

[Qemu-devel] [Bug 1753437] Re: pc-bios/s390-ccw/libc: size_t should be unsigned

2018-04-13 Thread Thomas Huth
** Summary changed: - qemu/pc-bios/s390-ccw/libc.c:82: bad test ? + pc-bios/s390-ccw/libc: size_t should be unsigned -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1753437 Title:

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-04-13 Thread Markus Armbruster
Ian Jackson writes: > This allows the caller to specify a uid and gid to use, even if there > is no corresponding password entry. This will be useful in certain > Xen configurations. > > We don't support just -runas because: (i) deprivileging without > calling

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Thomas Huth
On 13.04.2018 17:28, Halil Pasic wrote: > > > On 04/13/2018 04:30 PM, Thomas Huth wrote: >> "size_t" should be an unsigned type - the signed counterpart is called >> "ssize_t" in the C standard instead. Thus we should also use this > > The first sentence sounds like ssize_t is too a type

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 16:28, Halil Pasic wrote: > > > On 04/13/2018 04:30 PM, Thomas Huth wrote: >> "size_t" should be an unsigned type - the signed counterpart is called >> "ssize_t" in the C standard instead. Thus we should also use this > > The first sentence sounds

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-13 Thread Daniel Vetter
On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: > On 04/10/2018 08:26 PM, Dongwon Kim wrote: > > On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: > > > On 04/06/2018 09:57 PM, Dongwon Kim wrote: > > > > On Fri, Apr 06, 2018 at 03:36:03PM +0300,

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 16:24, Bastian Koppelmann wrote: > However, my risu-like tests found another flag raising problem with > float32_div. I'll investigate it on Monday. Is it a regression from our previous (2.11) behaviour? thanks -- PMM

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Halil Pasic
On 04/13/2018 04:30 PM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this The first sentence sounds like ssize_t is too a type defined by some C standard. Is it or does ssize_t come

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Bastian Koppelmann
On 04/13/2018 04:07 PM, Peter Maydell wrote: > On 13 April 2018 at 15:06, Bastian Koppelmann > wrote: >> On 04/13/2018 04:03 PM, Alex Bennée wrote: >>> The re-factor broke the raising of INVALID when NaN/Inf is passed to >>> the float_to_int conversion functions.

Re: [Qemu-devel] [ARM/FDPIC 0/4] FDPIC ABI for ARM

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Hello, > > This patch series implements the QEMU contribution of the FDPIC > ABI for ARM targets. > I am currently working on updating the patches for the other toolchain > components, and will upstream them soon. This

Re: [Qemu-devel] [ARM/FDPIC 3/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > The FDPIC restorer needs to deal with a function descriptor, hence we > have to extend 'retcode' such that it can hold the instructions needed > to perform this. > > The restorer sequence uses the same thumbness as the

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 03:23:36PM +0100, Peter Maydell wrote: > The MIPS TCG target makes the assumption that the offset from the > target env pointer to the tlb_table is less than about 64K. This > used to be true, but gradual addition of features to the Arm > target means that it's no longer

Re: [Qemu-devel] [ARM/FDPIC 2/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Add FDPIC info into image_info structure since interpreter info is on > stack and needs to be saved to be accessed later on. > > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon

Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Adds --enable-fdpic and --disable-fdpic configure options. This > feature is disabled by default, that's why it is not described in the > "Optional features" help section (which are enabled by default if > possible). > >

Re: [Qemu-devel] [ARM/FDPIC 4/4] linux-user: ARM-FDPIC: Add arm get tls syscall support

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon > > diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h > index 94e2a42..afc0772

Re: [Qemu-devel] [PATCH] scripts/dump-qcow2.pl: Script to dump qcow2 metadata

2018-04-13 Thread Alberto Garcia
On Fri 13 Apr 2018 04:45:15 PM CEST, Max Reitz wrote: > OK, now that that's out of the way... I'm wondering why you want to > add this to the qemu tree? If you'd written an iotest that would make > use of it, sure. But if it's just for debugging, then I'd personally > think it would be better

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-04-13 Thread Max Reitz
On 2018-03-14 09:29, Alberto Garcia wrote: > The L2 and refcount caches have default sizes that can be overridden > using the l2-cache-size and refcount-cache-size (an additional > parameter named cache-size sets the combined size of both caches). > > Unless forced by one of the aforementioned

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-13 Thread Collin Walling
On 04/13/2018 02:14 AM, Thomas Huth wrote: > On 10.04.2018 17:01, Collin Walling wrote: >> zIPL boot menu entries can be non-sequential. Let's account >> for this issue for the s390 zIPL boot menu. Since this boot >> menu is actually an imitation and is not completely capable >> of everything the

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Collin Walling
On 04/13/2018 10:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in

Re: [Qemu-devel] [PATCH] scripts/dump-qcow2.pl: Script to dump qcow2 metadata

2018-04-13 Thread Max Reitz
On 2018-03-28 15:38, Alberto Garcia wrote: > This script takes a qcow2 image and dumps its metadata: header, > snapshot table and some extensions (although not all qcow2 features > are supported yet). > > It can also display a list of all host clusters and the guest -> host > address mappings, so

[Qemu-devel] [Bug 1126369] Re: qemu-img snapshot -c is unreasonably slow

2018-04-13 Thread Thomas Huth
Looking through old bug tickets... have this issue been fixed, i.e. could we close this ticket nowadays? Or is there still something left to do? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
13.04.2018 17:31, Vladimir Sementsov-Ogievskiy wrote: Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 3 ++-

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 11:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in

Re: [Qemu-devel] [PATCH 0/2] Minor fixes about compressed clusters with OFLAG_COPIED

2018-04-13 Thread Max Reitz
On 2018-04-10 18:05, Alberto Garcia wrote: > Hi, > > while reviewing one previous patch about data corruption and > compressed clusters we discussed that the documentation doesn't > clarify that L2 entries for compressed clusters are not supposed to > have the OFLAG_COPIED bit set. > > Here's a

Re: [Qemu-devel] [PATCH] update-linux-headers: drop hyperv.h

2018-04-13 Thread Paolo Bonzini
On 13/04/2018 16:33, Roman Kagan wrote: > As of mainline linux commit 5a485803221777013944cbd1a7cd5c62efba3ffa > "x86/hyper-v: move hyperv.h out of uapi" by Vitaly Kuznetsov, no linux > uapi header includes it, so we no longer need to create a stub for it. > > Cc: Vitaly Kuznetsov

[Qemu-devel] [PATCH] update-linux-headers: drop hyperv.h

2018-04-13 Thread Roman Kagan
As of mainline linux commit 5a485803221777013944cbd1a7cd5c62efba3ffa "x86/hyper-v: move hyperv.h out of uapi" by Vitaly Kuznetsov, no linux uapi header includes it, so we no longer need to create a stub for it. Cc: Vitaly Kuznetsov Signed-off-by: Roman Kagan

[Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 3 ++- nbd/server.c| 10 ++ 2 files changed, 8

[Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Thomas Huth
"size_t" should be an unsigned type - the signed counterpart is called "ssize_t" in the C standard instead. Thus we should also use this convention in the s390-ccw firmware to avoid confusion. I checked the sources, and apart from one spot in libc.c (which now uses ssize_t with this patch), the

[Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-13 Thread Peter Maydell
The MIPS TCG target makes the assumption that the offset from the target env pointer to the tlb_table is less than about 64K. This used to be true, but gradual addition of features to the Arm target means that it's no longer true there. This results in the build-time assertion failing: In file

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-13 Thread Max Reitz
On 2018-04-12 19:07, Alberto Garcia wrote: > Hello, > > I mentioned this some time ago, but I'd like to retake it now: I'm > checking how to copy arbitrary nodes on a backing chain, so if I have > e.g. > >[A] <- [B] <- [C] <- [D] > > I'd like to end up with > >[A] <- [E] <- [C] <- [D]

Re: [Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

2018-04-13 Thread Bastian Koppelmann
On 04/12/2018 03:41 PM, Alex Bennée wrote: > Bastian Koppelmann writes: > >> On 04/11/2018 01:01 PM, Alex Bennée wrote: >>> Bastian Koppelmann writes: >>> On 04/10/2018 10:07 PM, Alex Bennée wrote: > Yeah it looks like it

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:18, Laurent Vivier wrote: > Le 12/04/2018 à 16:02, Peter Maydell a écrit : >> @@ -1850,12 +1856,6 @@ static void target_setup_frame(int usig, struct >> target_sigaction *ka, >> fr_ofs = layout.total_size; >> layout.total_size += sizeof(struct

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

2018-04-13 Thread Laurent Vivier
Le 12/04/2018 à 16:02, Peter Maydell a écrit : > AArch64 stack frames include a 'frame record' which holds a pointer > to the next frame record in the chain and the LR on entry to the > function. The procedure calling standard doesn't mandate where > exactly this frame record is in the stack

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:03, Alex Bennée wrote: > The re-factor broke the raising of INVALID when NaN/Inf is passed to > the float_to_int conversion functions. round_to_uint_and_pack got this > right for NaN but also missed out the Inf handling. > > Fixes

Re: [Qemu-devel] [PATCH qemu v4 2/2] qmp: Add qom-list-properties to list QOM object properties

2018-04-13 Thread Markus Armbruster
Alexey Kardashevskiy writes: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > It does not handle abstract

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Bastian Koppelmann
On 04/13/2018 04:03 PM, Alex Bennée wrote: > The re-factor broke the raising of INVALID when NaN/Inf is passed to > the float_to_int conversion functions. round_to_uint_and_pack got this > right for NaN but also missed out the Inf handling. > > Fixes https://bugs.launchpad.net/qemu/+bug/1759264 >

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 16:06, Peter Maydell wrote: > On 13 April 2018 at 15:01, Auger Eric wrote: >> On 13/04/18 15:41, Peter Maydell wrote: >>> I think it would be better to explicitly check "do we have >>> support for split redistributors" rather than looking at >>>

[Qemu-devel] [PATCH v3 1/3] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Elie Tournier
v2: Rebase on top of master v3: Fix the json format (Eric Blake) Fix a comparison issue (Gerd Hoffmann) Signed-off-by: Elie Tournier --- qapi/ui.json | 20 +++- vl.c | 10 +- 2 files changed, 24 insertions(+), 6 deletions(-) diff

Re: [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-04-13 Thread Markus Armbruster
Daniel Henrique Barboza writes: > Ping Michael, you reviewed v4 (at least in part), can you have a look?

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:06, Bastian Koppelmann wrote: > On 04/13/2018 04:03 PM, Alex Bennée wrote: >> The re-factor broke the raising of INVALID when NaN/Inf is passed to >> the float_to_int conversion functions. round_to_uint_and_pack got this >> right for NaN but

[Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-13 Thread Elie Tournier
Hi, v2: Rebase on top of master v3: Fix the json format (Eric Blake) Move DisplayOptions from ui/sdl2.c to include/ui/sdl2.h (Gerd Hoffmann) Fix a comparison issue (Gerd Hoffmann) Currently, virglrenderer [1] support OpenGL ES 2.0 on the guest side and OpenGL ES 3.0 on the host side.

[Qemu-devel] [PATCH v3 3/3] sdl: Allow OpenGL ES context creation

2018-04-13 Thread Elie Tournier
Signed-off-by: Elie Tournier --- qemu-options.hx | 2 +- ui/sdl2-gl.c| 19 +-- vl.c| 4 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ca4e412f2f..333dd1f1c8 100644 ---

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:01, Auger Eric wrote: > On 13/04/18 15:41, Peter Maydell wrote: >> I think it would be better to explicitly check "do we have >> support for split redistributors" rather than looking at >> KVM_MAX_VCPUS. It's not impossible that a distro kernel >>

[Qemu-devel] [PATCH v2 0/2] Softfloat Fixes for 2.12

2018-04-13 Thread Alex Bennée
Hi, The float_invalid patch now handles the Inf case as well and includes the fix to round_to_uint_and_pack. Alex Bennée (1): fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack Emilio G. Cota (1): softfloat: fix {min,max}nummag for same-abs-value inputs

[Qemu-devel] [PATCH v3 2/3] sdl: Move DisplayOptions global to sdl2_console

2018-04-13 Thread Elie Tournier
Suggested-by: Gerd Hoffmann Signed-off-by: Elie Tournier --- include/ui/sdl2.h | 1 + ui/sdl2.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index

  1   2   >