Re: [Qemu-devel] [PATCH v4 1/2] Implement .hex file loader

2018-04-16 Thread Su Hang
> -Original Messages- > From: "Su Hang" > Sent Time: 2018-04-16 22:49:48 (Monday) > To: "stefan hajnoczi" > Cc: "jim mussared" , qemu-devel > , "joel stanley" > Subject: Re:

Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-16 Thread Nikhil Balachandra
Hi Stefan, Thanks for the review. I'll be sending v2 version of this patch in next 3-4 days with the following changes. 1) New scripts/update-xnu-headers.sh script to import if_bridgevar.h[4] into include/standard-headers/xnu directory. @qemu-devel - Please let me know if there is a better

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

2018-04-16 Thread Dan Williams
On Mon, Apr 16, 2018 at 5:05 PM, Schmauss, Erik wrote: > >> -Original Message- >> From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- >> ow...@vger.kernel.org] On Behalf Of Dan Williams >> Sent: Monday, April 16, 2018 4:22 PM >> To: Schmauss, Erik

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-16 Thread Bharata B Rao
On Mon, Apr 16, 2018 at 07:47:29PM +0300, Serhii Popovych wrote: > Bharata B Rao wrote: > > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: > >> Now recent kernels (i.e. since linux-stable commit a346137e9142 > >> ("powerpc/numa: Use ibm,max-associativity-domains to discover

Re: [Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

2018-04-16 Thread Thomas Huth
On 16.04.2018 18:56, Collin Walling wrote: > Change Log: > > v3 > > - added r-b's > - added check around memset > > v2 > > - added r-b's > - s/zipl_println/zipl_print_entry > - prints entry and returns entry number > - while loop now

[Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

2018-04-16 Thread Richard Henderson
Without bounding the increment, we can overflow exp either here in scalbn_decomposed or when adding the bias in round_canonical. This can result in e.g. underflowing to 0 instead of overflowing to infinity. The old softfloat code did bound the increment. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH for-2.12 0/2] softfloat fixes

2018-04-16 Thread Richard Henderson
An alternate fix for Bastian's division problem and another fix for a scalbn problem exposed during SVE testing. Again, the SVE issue should be visible with normal NEON insns too. r~ Richard Henderson (2): fpu: Check for inf/x before x/0 fpu: Bound increment for scalbn fpu/softfloat.c |

[Qemu-devel] [PATCH 1/2] fpu: Check for inf/x before x/0

2018-04-16 Thread Richard Henderson
The re-factoring of div_floats changed the order of checking meaning an operation like -inf/0 erroneously raises the divbyzero flag. IEEE-754 (2008) specifies this should only occur for operations on finite operands. We fix this by moving the check on the dividend being Inf/0 to before the

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-16 Thread Tiwei Bie
On Mon, Apr 16, 2018 at 03:47:06PM +0800, Stefan Hajnoczi wrote: > On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB > > Naming suggestion: "PREFILL_IOTLB" instead of "NEED_ALL_IOTLB". > > I wasn't able to guess what

Re: [Qemu-devel] [PATCH] vfio/pci-quirks.c: Make stolen memory size adjustable for igd VFIO

2018-04-16 Thread Zhang, Xiong Y
> On Wed, 11 Apr 2018 13:24:10 +0800 > Xiong Zhang wrote: > > > Currenly linux guest with kernel above 3.19 couldn't boot up on igd > > passthrough env. The root case is i915 driver use stolen memory, but > > qemu vfio doesn't support it. > > > > This patch set stolen

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-16 Thread Jason Wang
On 2018年04月16日 15:47, Stefan Hajnoczi wrote: On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB Naming suggestion: "PREFILL_IOTLB" instead of "NEED_ALL_IOTLB". I wasn't able to guess what "NEED_ALL_IOTLB" does.

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-16 Thread David Gibson
On Mon, Apr 16, 2018 at 10:19:14AM +0200, Igor Mammedov wrote: > On Mon, 16 Apr 2018 12:43:55 +1000 > David Gibson wrote: > > > On Thu, Apr 12, 2018 at 06:40:19PM +0200, Igor Mammedov wrote: > > > platform-bus were using machine_done notifier to get and map > > >

Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

2018-04-16 Thread David Gibson
On Mon, Apr 16, 2018 at 02:25:12PM +0530, Bharata B Rao wrote: > The new property ibm,dynamic-memory-v2 allows memory to be represented > in a more compact manner in device tree. > > Signed-off-by: Bharata B Rao > --- > v2 -

Re: [Qemu-devel] [Consult] nfs-vsocks support

2018-04-16 Thread Roy, Arindam
Hi Jing, Busybox is a standalone statically linked bash env. You can download the source from here: https://busybox.net/downloads/ Or you can just download and copy it to your /usr/sbin : https://busybox.net/downloads/binaries/ The script is creating a runtime filesystem for your guest. Its

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

2018-04-16 Thread Dan Williams
On Mon, Apr 16, 2018 at 4:15 PM, Schmauss, Erik wrote: > [ trimming ] >> >> Rafael, we may want to hold back on the module-level code changes >> >> (the patches below) for rc1. Between this and the strange _TSS issue, >> >> it seems like there are a few more things to

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-16 Thread David Lechner
I have filed a new bug: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1764555 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU:

Re: [Qemu-devel] [PATCH V4] migration: add capability to bypass the shared memory

2018-04-16 Thread Lai Jiangshan
On Tue, Apr 10, 2018 at 1:30 AM, Dr. David Alan Gilbert wrote: >> >> +bool migrate_bypass_shared_memory(void) >> +{ >> +MigrationState *s; >> + >> +/* it is not workable with postcopy yet. */ >> +if (migrate_postcopy_ram()) { >> +return false; >> +} >

Re: [Qemu-devel] qapi: [PATCH v2] Implement query-usbhost QMP command

2018-04-16 Thread Alexander Kappner
Hi Gerd, thanks for reviewing. I'll follow up with a v3 of the patch addressing your proposed changes. >> This allows a QMP client to query which USB devices may be available >> for redirection. > At least libvirt sandboxes qemu, for security reasons, and you wouldn't > get any useful results

Re: [Qemu-devel] [PATCH] vfio/pci-quirks.c: Make stolen memory size adjustable for igd VFIO

2018-04-16 Thread Alex Williamson
On Wed, 11 Apr 2018 13:24:10 +0800 Xiong Zhang wrote: > Currenly linux guest with kernel above 3.19 couldn't boot up on igd > passthrough env. The root case is i915 driver use stolen memory, but > qemu vfio doesn't support it. > > This patch set stolen memory size to

Re: [Qemu-devel] [Xen-devel] [PATCH v3 14/41] hw/display: Use the BYTE-based definitions

2018-04-16 Thread Alistair Francis
On Sun, Apr 15, 2018 at 4:42 PM, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 29/41] hw/mips: Use the BYTE-based definitions

2018-04-16 Thread Alistair Francis
On Sun, Apr 15, 2018 at 4:42 PM, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size

2018-04-16 Thread Alistair Francis
On Mon, Apr 16, 2018 at 9:05 AM, mar.krzeminski wrote: > W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: >> >> >From the datasheet (3368J–SEEPR) description: >> The AT25128A/256A provides 131,072/262,144 bits of serial >> electrically-erasable

Re: [Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

2018-04-16 Thread Justin Terry (VM) via Qemu-devel
Hey Eduardo/Paolo, I have not forgotten about your responses. I am working out how best to do this in our platform and will send a follow up patch (this one is already merged) to fully support the -cpu flag. It looks like all the pieces are in place between the two and we just need a bit of

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

2018-04-16 Thread Alex Williamson
On Tue, 10 Apr 2018 14:03:13 +0800 Yulei Zhang wrote: > Instead of using vm state description, add SaveVMHandlers for VFIO > device to support live migration. > > Introduce new Ioctl VFIO_DEVICE_GET_DIRTY_BITMAP to fetch the memory > bitmap that dirtied by vfio device

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

2018-04-16 Thread Alex Williamson
On Mon, 16 Apr 2018 20:14:27 +0530 Kirti Wankhede wrote: > On 4/10/2018 11:32 AM, Yulei Zhang wrote: > > VM status change handler is added to change the vfio pci device > > status during the migration, write the demanded device status > > to the DEVICE STATUS subregion to

Re: [Qemu-devel] [RFC PATCH V4 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

2018-04-16 Thread Alex Williamson
On Mon, 16 Apr 2018 20:14:03 +0530 Kirti Wankhede wrote: > On 4/10/2018 11:32 AM, Yulei Zhang wrote: > > New VFIO sub region VFIO_REGION_SUBTYPE_DEVICE_STATE is added > > to fetch and restore the status of mdev device vGPU during the > > live migration. > > > >

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/16/2018 05:53 AM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 04/10/2018 04:39 PM, Alex Bennée wrote: Now all the build infrastructure is in place we can build tests for each guest that we

Re: [Qemu-devel] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

2018-04-16 Thread Richard Henderson
On 04/16/2018 05:19 AM, Peter Maydell wrote: > In commit 8c5931de0ac7738809 we added support for SVE extended > sigframe records. These mean that the signal frame might now be > larger than the size of the target_rt_sigframe record, so make sure > we call lock_user on the entire frame size when

[Qemu-devel] [PATCH] dump: add Windows dump format to dump-guest-memory

2018-04-16 Thread Viktor Prutyanov
This patch adds Windows crashdumping feature. Now QEMU can produce crashdump file understandable for WinDbg. The crashdump will be obtained by joining physical memory dump and 8K header exposed through vmcoreinfo/fw_cfg device by guest driver at BSOD time. Option '-w' was added to

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-16 Thread Richard Henderson
On 04/16/2018 03:54 AM, Alex Bennée wrote: > +/* Inf / x or 0 / x */ > +if (a.cls == float_class_inf || a.cls == float_class_zero) { > +a.sign = sign; > +return a; > +} 0/0 should raise an exception. I find inf/0 non-intuitive, but there ya go. r~

[Qemu-devel] Patch for ARM memory barriers and getdent

2018-04-16 Thread Henry Wertz
Please find submitted a patch for ARM memory barriers. This patch is against qemu-2.12-rc2 but I do believe it should apply for anything from 2.11.x to current. I found with qemu 2.11.x or newer that I would get an illegal instruction error running some Intel binaries on my ARM chromebook. On

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-16 Thread Daniel P . Berrangé
On Mon, Apr 16, 2018 at 07:28:28PM +0100, Peter Maydell wrote: > On 16 April 2018 at 19:18, Marc-André Lureau > wrote: > > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > > regression, but was inadvertently broken again in merge commit > >

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Daniel P . Berrangé
On Mon, Apr 16, 2018 at 08:13:42PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Apr 16, 2018 at 06:30:45PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > A user trying out SMBIOS "OEM strings"

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 19:18, Marc-André Lureau wrote: > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > regression, but was inadvertently broken again in merge commit > 2d6752d38d8acda. > > Fixes: > https://bugs.launchpad.net/qemu/+bug/1654137 > >

[Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-16 Thread Marc-André Lureau
Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the regression, but was inadvertently broken again in merge commit 2d6752d38d8acda. Fixes: https://bugs.launchpad.net/qemu/+bug/1654137 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Apr 16, 2018 at 06:30:45PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > A user trying out SMBIOS "OEM strings" feature reported that the data >> > they are exposing to the guest was

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-04-16 Thread Markus Armbruster
Ian Jackson writes: > Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide > new -runas : facility"): >> Ian Jackson writes: >> > That would defer the getpwnam from argument parsing to os_setup_post. >> > I think that's

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-16 Thread Thomas Huth
** Changed in: qemu Assignee: (unassigned) => elmarco (marcandre-lureau) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654137 Title: Ctrl-A b not working in 2.8.0 Status in QEMU:

Re: [Qemu-devel] Purpose of memory-backend-file.discard-data

2018-04-16 Thread Eduardo Habkost
(CCing Zack Cornelius) On Fri, Apr 13, 2018 at 08:21:26AM +0200, Michal Privoznik wrote: > Eduardo et al, > > I'm looking at 11ae6ed8affdd131e and I wanted to implement libvirt > support for that. But more I look at it less I understand it. My > understanding it is an optimization (although not

[Qemu-devel] [PATCH] tests: request access to locality 0 before sending command

2018-04-16 Thread Stefan Berger
Recent changes to the CRB code now require that access to locality 0 be requested before the locality can be used for sending a command. This patch adds the request to access the locality. Signed-off-by: Stefan Berger --- tests/tpm-util.c | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 18:46, Eduardo Habkost wrote: > On Mon, Apr 16, 2018 at 02:42:52PM -0300, Eduardo Habkost wrote: >> On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: >> > On 16 April 2018 at 17:39, Eduardo Habkost wrote: >> > > Last

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

2018-04-16 Thread Eduardo Habkost
On Mon, Apr 16, 2018 at 07:41:29PM +0200, Thomas Huth wrote: > The CAN device crashes have been fixed with the commit > 089eac81e1d34d202471c0a023284f47f4c5f00e already. > > Signed-off-by: Thomas Huth Queued, thanks. -- Eduardo

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Eduardo Habkost
On Mon, Apr 16, 2018 at 02:42:52PM -0300, Eduardo Habkost wrote: > On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: > > On 16 April 2018 at 17:39, Eduardo Habkost wrote: > > > Last remaining fix for -rc4. > > > > > > The following changes since commit > > >

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Eduardo Habkost
On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: > On 16 April 2018 at 17:39, Eduardo Habkost wrote: > > Last remaining fix for -rc4. > > > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: > > > > Merge remote-tracking branch > >

[Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

2018-04-16 Thread Thomas Huth
The CAN device crashes have been fixed with the commit 089eac81e1d34d202471c0a023284f47f4c5f00e already. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index

Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 10:37, Michael Tokarev wrote: > Fixes 722cd7496474cebb2218f21e038592fad8603365 > > Signed-off-by: Michael Tokarev > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index

Re: [Qemu-devel] [PATCH for-2.13 4/4] arm/boot: split load_dtb() from arm_load_kernel()

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 17:40, Igor Mammedov wrote: > load_dtb() depends on arm_load_kernel() to figure out place > in RAM where it should be loaded, but it's not required for > arm_load_kernel() to work. Sometimes it's neccesary for > devices added with -device/device_add to be

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 17:40, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 3/4] arm: always start from first_cpu when registering loader cpu reset callback

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 19:29, Peter Maydell wrote: > On 12 April 2018 at 17:40, Igor Mammedov wrote: >> if arm_load_kernel() were passed non first_cpu, QEMU would end up >> with partially set do_cpu_reset() callback leaving some CPUs without it. >> >>

[Qemu-devel] [PATCH 8/9] iotests: Copy 197 for COR filter driver

2018-04-16 Thread Max Reitz
iotest 197 tests copy-on-read using the (now old) copy-on-read flag. Copy it to 215 and modify it to use the COR filter driver instead. Signed-off-by: Max Reitz --- tests/qemu-iotests/215 | 120 + tests/qemu-iotests/215.out |

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 05:53 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> Now all the build infrastructure is in place we can build tests for >>> each guest that we support. That support mainly depends on having >>> cross

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-04-16 Thread Ian Jackson
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility"): > Ian Jackson writes: > > That would defer the getpwnam from argument parsing to os_setup_post. > > I think that's undesriable. > > No argument. But why can't

[Qemu-devel] [PATCH v2 for 2.13] migration: Don't activate block devices if using -S

2018-04-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Activating the block devices causes the locks to be taken on the backing file. If we're running with -S and the destination libvirt hasn't started the destination with 'cont', it's expecting the locks are still untaken. Don't activate the

[Qemu-devel] [PATCH 7/9] iotests: Clean up wrap image in 197

2018-04-16 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/197 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/197 b/tests/qemu-iotests/197 index 5e869fe2b7..3ae4975eec 100755 --- a/tests/qemu-iotests/197 +++ b/tests/qemu-iotests/197 @@ -44,6 +44,7 @@ esac

[Qemu-devel] [PATCH 9/9] iotests: Add test for COR across nodes

2018-04-16 Thread Max Reitz
COR across nodes (that is, you have some filter node between the actually COR target and the node that performs the COR) cannot reliably work together with the permission system when there is no explicit COR node that can request the WRITE_UNCHANGED permission for its child. This is because COR

[Qemu-devel] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes

2018-04-16 Thread Max Reitz
Signed-off-by: Max Reitz --- block/io.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index 134b2a498f..fada4efbf3 100644 --- a/block/io.c +++ b/block/io.c @@ -1115,13 +1115,15 @@ static int coroutine_fn

[Qemu-devel] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED

2018-04-16 Thread Max Reitz
We just need to forward it to quorum's children (except in case of a rewrite because of corruption), but for that we first have to support flags in child requests at all. Signed-off-by: Max Reitz --- block/quorum.c | 19 +-- 1 file changed, 13 insertions(+), 6

[Qemu-devel] [PATCH 1/9] block: Add COR filter driver

2018-04-16 Thread Max Reitz
This adds a simple copy-on-read filter driver. It relies on the already existing COR functionality in the central block layer code, which may be moved here once we no longer need it there. Signed-off-by: Max Reitz --- block/Makefile.objs | 2 +- qapi/block-core.json | 5

[Qemu-devel] [PATCH 6/9] block: Support BDRV_REQ_WRITE_UNCHANGED in filters

2018-04-16 Thread Max Reitz
Update the rest of the filter drivers to support BDRV_REQ_WRITE_UNCHANGED. They already forward write request flags to their children, so we just have to announce support for it. This patch does not cover the replication driver because that currently does not support flags at all, and because it

[Qemu-devel] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED

2018-04-16 Thread Max Reitz
Currently we never actually check whether the WRITE_UNCHANGED permission has been taken for unchanging writes. But the one check that is commented out checks both WRITE and WRITE_UNCHANGED; and considering that WRITE_UNCHANGED is already documented as being weaker then WRITE, we should probably

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 17:39, Eduardo Habkost wrote: > Last remaining fix for -rc4. > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' > into staging (2018-04-16

[Qemu-devel] [PATCH 0/9] block: Add COR filter driver

2018-04-16 Thread Max Reitz
In our quest to... (Oh, man, I always struggle with writing cover letters. But rarely have I become stuck so early on.) Orthogonalize? the block layer (that is, turn hard-coded special options into independent data processing nodes you can put anywhere in your data flow graph), this series adds

[Qemu-devel] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag

2018-04-16 Thread Max Reitz
This flag signifies that a write request will not change the visible disk content. With this flag set, it is sufficient to have the BLK_PERM_WRITE_UNCHANGED permission instead of BLK_PERM_WRITE. Signed-off-by: Max Reitz --- include/block/block.h | 6 +- block/io.c

[Qemu-devel] [PATCH v3 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

2018-04-16 Thread Collin Walling
The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h to make it available

[Qemu-devel] [PATCH v3 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-04-16 Thread Collin Walling
Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an empty string or a series of spaces.

[Qemu-devel] [PATCH v3 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-04-16 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumerated Boot Menu.

[Qemu-devel] [PATCH v3 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-16 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signed-off-by: Collin

[Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

2018-04-16 Thread Collin Walling
Change Log: v3 - added r-b's - added check around memset v2 - added r-b's - s/zipl_println/zipl_print_entry - prints entry and returns entry number - while loop now handles valid_entries These patches fix the following: - The

Re: [Qemu-devel] [PATCH v11 14/17] hw/arm/virt: Introduce the iommu option

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:38, Eric Auger wrote: > ARM virt machine now exposes a new "iommu" option. > The SMMUv3 IOMMU is instantiated using -machine virt,iommu=smmuv3. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

2018-04-16 Thread Marc-André Lureau
On Mon, Apr 16, 2018 at 10:31 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Marc-André Lureau writes: >> >>> By moving the base fields to a QObjectBase_, QObject can be a type >>> which also has a 'base' field.

Re: [Qemu-devel] [PATCH v11 08/17] hw/arm/smmuv3: Event queue recording helper

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > Let's introduce a helper function aiming at recording an > event in the event queue. > > Signed-off-by: Eric Auger > > --- > v9 -> v10: > - rework SMMU_EVENT_STRING > - trigger a GERROR EVENTQ_ABT_ERR in

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

2018-04-16 Thread Marc-André Lureau
Hi On Mon, Apr 16, 2018 at 10:12 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> By moving the base fields to a QObjectBase_, QObject can be a type >> which also has a 'base' field. This allows to write a generic >> QOBJECT() macro

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-16 Thread Serhii Popovych
Bharata B Rao wrote: > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: >> Now recent kernels (i.e. since linux-stable commit a346137e9142 >> ("powerpc/numa: Use ibm,max-associativity-domains to discover possible >> nodes") >> support this property to mark initially memory-less

[Qemu-devel] [PULL 0/1] vhost: bugfix

2018-04-16 Thread Michael S. Tsirkin
The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 1/1] vhost: do not verify ring mappings when IOMMU is enabled

2018-04-16 Thread Michael S. Tsirkin
From: Jason Wang When IOMMU is enabled, we store virtqueue metadata as iova (though it may has _phys suffix) and access them through dma helpers. Any translation failures could be reported by IOMMU. In this case, trying to validate iova against gpa won't work and will cause

Re: [Qemu-devel] [PATCH v11 07/17] hw/arm/smmuv3: Implement MMIO write operations

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > Now we have relevant helpers for queue and irq > management, let's implement MMIO write operations. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa > -int

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-16 Thread Daniel Berrange
@elmarco could you take a look at this possible regression since bisect claims it was due to the mux refactor -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654137 Title: Ctrl-A b not working in

Re: [Qemu-devel] [PATCH v11 06/17] hw/arm/smmuv3: Queue helpers

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > We introduce helpers to read/write into the command and event > circular queues. > > smmuv3_write_eventq and smmuv3_cmq_consume will become static > in subsequent patches. > > Invalidation commands are not yet dealt with. We do

[Qemu-devel] [PULL 1/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Eduardo Habkost
The assumption in the cpu->max_features code is that anything enabled on GET_SUPPORTED_CPUID should be enabled on "-cpu host". This shouldn't be the case for FEAT_KVM_HINTS. This adds a new FeatureWordInfo::no_autoenable_flags field, that can be used to prevent FEAT_KVM_HINTS bits to be enabled

[Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-16 Thread Eduardo Habkost
Last remaining fix for -rc4. The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' into staging (2018-04-16 15:30:54 +0100) are available in the Git repository at:

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Daniel P . Berrangé
On Mon, Apr 16, 2018 at 06:30:45PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > A user trying out SMBIOS "OEM strings" feature reported that the data > > they are exposing to the guest was truncated at 1023 bytes, which breaks > > the app consuming in

Re: [Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

2018-04-16 Thread Eduardo Habkost
On Thu, Apr 05, 2018 at 05:50:20PM +0200, Paolo Bonzini wrote: > On 28/03/2018 22:48, Justin Terry (VM) wrote: [...] > > If we use [2] to inject the answers at creation time WHPX needs access > > to the CPUX86State at accel init which also doesn't seem to be possible > > in QEMU today. WHPX could

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > A user trying out SMBIOS "OEM strings" feature reported that the data > they are exposing to the guest was truncated at 1023 bytes, which breaks > the app consuming in the guest. After searching for the cause I > eventually found that the

[Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

2018-04-16 Thread Bastian Koppelmann
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759264 Title: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns Status

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

2018-04-16 Thread Daniel P . Berrangé
On Mon, Aug 14, 2017 at 01:24:17PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Aug 11, 2017 at 12:47:44PM -0500, Eric Blake wrote: > >> On 08/11/2017 11:05 AM, Markus Armbruster wrote: > >> > We've wanted -object to support non-scalar

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

2018-04-16 Thread Daniel P . Berrangé
On Mon, Aug 14, 2017 at 07:49:54AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/11/2017 11:05 AM, Markus Armbruster wrote: > >> We've wanted -object to support non-scalar properties for a while. > >> Dan Berrange tried in "[PATCH v4 00/10]Provide a

Re: [Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

2018-04-16 Thread Daniel P . Berrangé
Just a ping to say I'd like us to restart work this patch and try to get it mergable for the 2.13 cycle, so I can rely it on for the ACL support I've had out of tree since 2.6 :-) On Fri, Aug 11, 2017 at 06:05:20PM +0200, Markus Armbruster wrote: > v2: > * PATCH 1: Whitespace change dropped

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-04-16 Thread Markus Armbruster
Ian Jackson writes: > Thanks for the review. Taking your comments out of order slightly: > > Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide > new -runas : facility"): >> [change_process_uid] is the only user of @user_pwd, @user_uid,

Re: [Qemu-devel] [PATCH v2 2/2] docs: Document the new default sizes of the qcow2 caches

2018-04-16 Thread Max Reitz
On 2018-03-14 09:29, Alberto Garcia wrote: > We have just reduced the refcount cache size to the minimum unless > the user explicitly requests a larger one, so we have to update the > documentation to reflect this change. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-04-16 Thread Max Reitz
On 2018-03-14 09:29, Alberto Garcia wrote: > The L2 and refcount caches have default sizes that can be overridden > using the l2-cache-size and refcount-cache-size (an additional > parameter named cache-size sets the combined size of both caches). > > Unless forced by one of the aforementioned

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-16 Thread Andreas Gustafsson
This regression is still unfixed three months after being reported, and it's rendering qemu 2.11.1 unusable for my present use case, so I just reverted my system to the ever reliable qemu 0.15.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-04-16 Thread Markus Armbruster
Peter Maydell writes: > On 16 April 2018 at 15:11, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 12 March 2018 at 13:18, Stefan Hajnoczi wrote: Warn if files are

Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size

2018-04-16 Thread mar.krzeminski
W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: >From the datasheet (3368J–SEEPR) description: The AT25128A/256A provides 131,072/262,144 bits of serial electrically-erasable programmable read only memory (EEPROM) organized as 16,384/32,768 words of 8 bits each. However

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-16 Thread David Hildenbrand
> > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index 0cdbc15..0d5b0f7 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = { > S390_FEAT_ADAPTER_INT_SUPPRESSION, >

Re: [Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 16:29, Alex Bennée wrote: > > Peter Maydell writes: >> CNTVCT_EL0 isn't much use without CNTFRQ_EL0 which tells >> you how fast it ticks... > > I've added it but of course: > > /* Note that CNTFRQ is purely

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 16:25, Jan Kiszka wrote: > On 2018-04-01 23:17, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when >> E1000_ICR_OTHER is set in EIAC. In fact, removing this code

Re: [Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

2018-04-16 Thread Alex Bennée
Peter Maydell writes: > On 16 April 2018 at 15:03, Alex Bennée wrote: >> Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 >> trap..) user-space has been able to read this system register. This >> patch enables access to that

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-16 Thread Paolo Bonzini
On 16/04/2018 16:27, Igor Mammedov wrote: > On Mon, 16 Apr 2018 15:30:39 +0200 > Paolo Bonzini wrote: > >> On 16/04/2018 15:20, Igor Mammedov wrote: >>> Generally object doesn't need to know its own name, >>> we use it only for debugging and nice error reporting so far. >>>

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-16 Thread Jan Kiszka
On 2018-04-01 23:17, Jan Kiszka wrote: > From: Jan Kiszka > > The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when > E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the > issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e:

Re: [Qemu-devel] [PULL 0/2] Block patches for 2.12.0-rc4

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 13:38, Max Reitz wrote: > The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 > 10:11:17 +0100) > > are available in the

  1   2   3   >