Hello, I have a question I would like to ask.
If I add the -incoming parameter when starting the qemu virtual machine, the
virtual machine will block all the time, waiting for the migration connection
request to arrive.
I want to modify the time of this blocking wait, how should I modify the
On 12/24/2018 11:34 AM, Peter Xu wrote:
On Fri, Dec 21, 2018 at 05:36:57PM +0800, Fei Li wrote:
On 12/19/2018 08:14 PM, Fei Li wrote:
On 12/19/2018 06:10 PM, Markus Armbruster wrote:
Fei Li writes:
On 12/13/2018 03:26 PM, Markus Armbruster wrote:
There's a question for David Gibson
The second argument used by qdev_create() is typename and 'name' is very
confusing. Rename it from 'name' to 'type', which is the same used by
qdev_try_create().
Signed-off-by: Dongli Zhang
---
hw/core/qdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
> From: Kővágó, Zoltán [mailto:dirty.ice...@gmail.com]
> diff --git a/replay/replay-audio.c b/replay/replay-audio.c
> index b113836de4..efe1628727 100644
> --- a/replay/replay-audio.c
> +++ b/replay/replay-audio.c
> @@ -16,18 +16,18 @@
> #include "sysemu/sysemu.h"
> #include "audio/audio.h"
>
>
Patchew URL:
https://patchew.org/QEMU/20181217150116.10446-1-alex.ben...@linaro.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On Sat, 2018-12-22 at 10:13 +0100, Paolo Bonzini wrote:
> On 22/12/18 02:01, Robert Hoo wrote:
> > On Fri, 2018-12-21 at 16:27 +0100, Paolo Bonzini wrote:
> > > On 21/12/18 16:22, Philippe Mathieu-Daudé wrote:
> > > > Hi Paolo,
> > > >
> > > > On 12/21/18 7:30 AM, Paolo Bonzini wrote:
> > > > >
On Fri, Dec 21, 2018 at 05:36:57PM +0800, Fei Li wrote:
>
> On 12/19/2018 08:14 PM, Fei Li wrote:
> >
> > On 12/19/2018 06:10 PM, Markus Armbruster wrote:
> > > Fei Li writes:
> > >
> > > > On 12/13/2018 03:26 PM, Markus Armbruster wrote:
> > > > > There's a question for David Gibson inline.
thank u.
>t can either use TCG or a HW based acceleration
>like KVM. HW based acceleration is only available on the same machine
>type.
BTW, if use the HW acceleration like KVM, no TCG translation between target
instruction and host instruction happened, right?
thanks!
At
Hi Phil,
On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote:
> Hi Zoltán,
>
> On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
>> There's already a MIN and MAX macro in include/qemu/osdep.h, use them
>> instead.
>>
>> Signed-off-by: Kővágó, Zoltán
>>
>> ---
>>
>> Changes from v1:
>> * removed
On 12/22/18 00:12, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote:
Don't expect read(2) can always read as many as it's told.
Signed-off-by: Li Zhijian
Reviewed-by: Richard Henderson
This is more a theoretical bugfix than a refactoring right?
Yes，
Ping..
Li Qiang 于2018年12月15日周六 下午8:06写道：
> Currently, the vhost-user-test is not correct.
> When in qtest mode, the accel is qtest, not kvm.
> So when the client side of vhost-user-test send
> 'VHOST_USER_SET_VRING_CALL' msg, the 'fd' will
> no be added in 'fds' in 'vhost_set_vring_file'.
> In
Hi Zoltán,
On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> There's already a MIN and MAX macro in include/qemu/osdep.h, use them
> instead.
>
> Signed-off-by: Kővágó, Zoltán
>
> ---
>
> Changes from v1:
> * removed audio_MIN, audio_MAX macros
> ---
[...]>
> diff --git a/audio/audio.h
Hi,
I've updated my audio patchset to the current git master. Other than that not
much happened since my last update [1], fixed a few small problems that I
noticed while rebasing my patches.
Please review.
[1]: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg02451.html
Kővágó, Zoltán
They are required for flat unions (you still have to allocate the
structs).
Signed-off-by: Kővágó, Zoltán
---
include/qapi/opts-visitor.h | 7 +++
qapi/opts-visitor.c | 16
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/include/qapi/opts-visitor.h
This patch adds documentation of an -audiodev command line option, that
deprecates the old QEMU_* environment variables for audio backend
configuration. It's syntax is similar to existing options (-netdev,
-device, etc):
-audiodev driver_name,property=value,...
Although now it's possible to
This means you should probably stop using -soundhw (as it doesn't allow
you to specify any options) and add the device manually with -device.
The exception is pcspk, it's currently not possible to manually add it.
To use it with audiodev, use something like this:
-audiodev id=foo,... -global
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c | 10
audio/wavaudio.c | 58 +++-
2 files changed, 19 insertions(+), 49 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index 6d95b761b8..71bbda04e2 100644
---
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c | 7 +++
audio/sdlaudio.c | 22 --
2 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index 1f99d21803..6d95b761b8 100644
--- a/audio/audio_legacy.c
+++
The bit shifting trick worked because the number of bytes per frame was
always a power-of-two (since QEMU only supports mono, stereo and 8, 16
and 32 bit samples). But if we want to add support for surround sound,
this no longer holds true.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c
I had to include an enum for audio sampling formats into qapi, but that
meant duplicating the audfmt_e enum. This patch replaces audfmt_e and
associated values with the qapi generated AudioFormat enum.
This patch is mostly a search-and-replace, except for switches where the
qapi generated
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 28
audio/audio.h | 10 ++
audio/audio_int.h | 4 ++--
audio/paaudio.c| 20
audio/spiceaudio.c | 14 --
5 files changed, 52 insertions(+), 24 deletions(-)
diff
Implementation of the previously added mixeng option.
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 70 ++
audio/audio_template.h | 46 ---
2 files changed, 92 insertions(+), 24 deletions(-)
diff --git a/audio/audio.c
Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before
initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the
initial size of the STSampleBuffer. The next commit tries to fix this
inconsistency.
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 130
Add an option to change the channel map used by pulseaudio. If not
specified, falls back to an OSS compatible channel map.
Signed-off-by: Kővágó, Zoltán
---
audio/paaudio.c | 18 ++
qapi/audio.json | 5 -
qemu-options.hx | 9 +
3 files changed, 27 insertions(+), 5
This will allow us to disable mixeng when we use a decent backend.
Disabling mixeng have a few advantages:
* we no longer convert the audio output from one format to another, when
the underlying audio system would just convert it to a third format.
We no longer convert, only the underlying
There's already a MIN and MAX macro in include/qemu/osdep.h, use them
instead.
Signed-off-by: Kővágó, Zoltán
---
Changes from v1:
* removed audio_MIN, audio_MAX macros
---
audio/alsaaudio.c | 6 +++---
audio/audio.c | 20 ++--
audio/audio.h |
Which currently only means removing some checks. Old code won't require
more than two channels, but new code will need it.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 7 ---
audio/audio.c | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/audio/alsaaudio.c
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 42 ++
audio/audio_int.h | 7 ---
2 files changed, 6 insertions(+), 43 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 1897e22444..4c33e057d7 100644
--- a/audio/audio.c
+++
Finally add audiodev= options to audio frontends so users can specify
which backend to use when multiple backends exist. Not specifying an
audiodev= option currently causes the first audiodev to be used, this is
fixed in the next commit.
Example usage: -audiodev pa,id=foo -device
Signed-off-by: Kővágó, Zoltán
---
audio/wavaudio.c | 54
1 file changed, 9 insertions(+), 45 deletions(-)
diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index 58300663ff..31db03aadb 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -34,52
Currently this needs a workaround due to bug #74624 in pulseaudio.
Reviewed-by: Marc-André Lureau
Signed-off-by: Kővágó, Zoltán
---
audio/paaudio.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 306 --
1 file changed, 81 insertions(+), 225 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 69e7a3868c..56271b1174 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@
SDL2 is still a big mess, but it's probably not worse than the current
version.
Signed-off-by: Kővágó, Zoltán
---
audio/sdlaudio.c | 136 +--
1 file changed, 50 insertions(+), 86 deletions(-)
diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
index
Signed-off-by: Kővágó, Zoltán
---
audio/coreaudio.c | 130 --
1 file changed, 69 insertions(+), 61 deletions(-)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index a45d69..a532e862dd 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@
Signed-off-by: Kővágó, Zoltán
---
audio/spiceaudio.c | 112 +++--
1 file changed, 38 insertions(+), 74 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index f963853ed8..d1605d3939 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
audio_run is called manually by alsa and oss backends when polling.
In this case only the requesting backend should be run, not all of them.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 7 +--
audio/audio.c | 14 +-
audio/audio_int.h | 2 +-
audio/ossaudio.c | 12
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 211 -
audio/audio_int.h | 45 +++--
audio/audio_template.h | 1 +
3 files changed, 247 insertions(+), 10 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index
Signed-off-by: Kővágó, Zoltán
---
audio/ossaudio.c | 287 +--
1 file changed, 104 insertions(+), 183 deletions(-)
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 05c7d6f85c..f1b57c87b4 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@
This assumption is no longer true when mixeng is turned off.
Signed-off-by: Kővágó, Zoltán
---
hw/usb/dev-audio.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index 589977d96c..510585ad7a 100644
---
Unless we disable stream moving, pulseaudio can easily move the stream
on connect, effectively ignoring the source/sink specified by the user.
Signed-off-by: Kővágó, Zoltán
---
audio/paaudio.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 8 +-
audio/audio.c | 162
audio/audio.h | 4 +-
audio/audio_int.h | 22 +++---
audio/audio_template.h | 6 +-
audio/mixeng.h | 11 ++-
Audio drivers now get an Audiodev * as config paramters, instead of the
global audio_option structs. There is some code in audio/audio_legacy.c
that converts the old environment variables to audiodev options (this
way backends do not have to worry about legacy options). It also
contains a
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c | 17 +
audio/ossaudio.c | 153 ---
2 files changed, 59 insertions(+), 111 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index 48a22c390a..f37407586b 100644
---
With stereo playback, they need about 375 minutes of continuous audio
playback to overflow, which is usually not a problem (as stopping and
later resuming playback resets the counters). But with 7.1 audio, they
only need about 95 minutes to overflow.
After the overflow, the buf->prod %
This way we no longer need vararg functions, improving compile time
error detection. Also now it's possible to check actually what commands
are supported, without needing to manually update ctl_caps.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 56 +++---
Signed-off-by: Kővágó, Zoltán
---
audio/noaudio.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/audio/noaudio.c b/audio/noaudio.c
index c49f2df4b3..6a3a1c418b 100644
--- a/audio/noaudio.c
+++ b/audio/noaudio.c
@@ -40,10 +40,9 @@
This commit removes the ad-hoc rate-limiting code from noaudio and
wavaudio, and replaces them with a (slightly modified) code from
spiceaudio. This way multiple write calls (for example when the
circular buffer wraps around) do not cause problems.
Signed-off-by: Kővágó, Zoltán
---
This patch removes the samples member from HWVoiceIn and HWVoiceOut.
Backends can specify buffer size via the newly added buffer_size_in and
buffer_size_out functions in audio_pcm_ops. They are optional, if not
defined qemu will fall back to some built-in constant.
Signed-off-by: Kővágó, Zoltán
They just called audio_pcm_sw_read/write anyway, so it makes no sense
to have them too. (The noaudio's read is the only exception, but it
should work with the generic code too.)
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 12
audio/audio.c | 8
Signed-off-by: Kővágó, Zoltán
---
audio/Makefile.objs | 1 -
audio/audio_pt_int.c | 174
audio/audio_pt_int.h | 22 ---
audio/paaudio.c | 372 ++-
configure| 5 -
5 files changed, 45 insertions(+), 529
---
audio/dsound_template.h | 45 +++---
audio/dsoundaudio.c | 328 ++--
2 files changed, 102 insertions(+), 271 deletions(-)
diff --git a/audio/dsound_template.h b/audio/dsound_template.h
index 96181efb36..ff5a1f85fd 100644
--- a/audio/dsound_template.h
Remove glob_audio_state from functions, where possible without breaking
the API. This means that most static functions in audio.c now take an
AudioState pointer instead of implicitly using glob_audio_state. Also
included a pointer in SWVoice*, HWVoice* structs, so that functions
dealing them can
Audio functions no longer access glob_audio_state, instead they get an
AudioState as a parameter. This is required in order to support
multiple backends.
glob_audio_state is also gone, and replaced with a tailq so we can store
more than one states.
Signed-off-by: Kővágó, Zoltán
---
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c| 12 +
audio/dsound_template.h | 6 ++---
audio/dsoundaudio.c | 59 -
3 files changed, 32 insertions(+), 45 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index
Pulseaudio normally assumes that when the server wants it, the client
can generate the audio samples and send it right away. Unfortunately
this is not the case with QEMU -- it's up to the emulated system when
does it generate the samples. Buffering the samples and sending them
from a background
On 23.12.18 18:10, Aleksandar Markovic wrote:
> Hi, Stefan,
>
> My plan is to accept this patch plus (in the same patch) following
> changes in nanomips.h:
>
> This code:
>
> typedef unsigned short uint16;
> typedef unsigned int uint32;
> typedef long long int64;
> typedef unsigned long long
From: Kővágó, Zoltán
The current OptsVisitor flattens the whole structure, if there are same
named fields under different paths (like `in' and `out' in `Audiodev'),
the current visitor can't cope with them (for example setting
`frequency=44100' will set the in's frequency to 44100 and leave
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c | 11 ++
audio/paaudio.c | 80
2 files changed, 40 insertions(+), 51 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index f37407586b..1f99d21803 100644
---
Remove no longer needed code.
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 201 +-
audio/audio_int.h | 17
2 files changed, 4 insertions(+), 214 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index e7f25ea84b..0c3f0efd46
Signed-off-by: Kővágó, Zoltán
---
audio/audio_legacy.c | 10 ++
audio/coreaudio.c| 47 ++--
2 files changed, 20 insertions(+), 37 deletions(-)
diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c
index f91ce0c3e2..42b55035e3 100644
---
Signed-off-by: Kővágó, Zoltán
---
audio/spiceaudio.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index affc3df17f..4f7873af5a 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -373,10 +373,6 @@ static int line_in_ctl (HWVoiceIn *hw,
Signed-off-by: Kővágó, Zoltán
---
audio/noaudio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/audio/noaudio.c b/audio/noaudio.c
index 2cc274c5e5..f1eb048d80 100644
--- a/audio/noaudio.c
+++ b/audio/noaudio.c
@@ -163,7 +163,6 @@ static struct audio_pcm_ops no_pcm_ops = {
static struct
This patch adds structures into qapi to replace the existing
configuration structures used by audio backends currently. This qapi
will be the base of the -audiodev command line parameter (that replaces
the old environment variables based config).
This is not a 1:1 translation of the old options,
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c| 314 ---
audio/audio_legacy.c | 64 +
2 files changed, 152 insertions(+), 226 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 8302f3e882..6f75644538 100644
---
On Mon, Dec 17, 2018 at 9:11 PM Aleksandar Markovic
wrote:
>
> From: Aleksandar Markovic
>
> Add translation handlers for max/min MXU instructions.
>
> Signed-off-by: Aleksandar Markovic
> ---
> target/mips/translate.c | 356 +---
> 1 file changed, 335
On Tue, Nov 27, 2018 at 1:19 PM Stefan Weil wrote:
>
> Signed-off-by: Stefan Weil
> ---
> disas/nanomips.cpp | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
Hi, Stefan,
My plan is to accept this patch plus (in the same patch) following
changes in nanomips.h:
Patchew URL: https://patchew.org/QEMU/20181214231512.5295-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181214231512.5295-1-js...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove
Following on from the previous work, there are numerous endian-related hacks
in int_helper.c that can now be replaced with Vsr* macros.
Signed-off-by: Mark Cave-Ayland
---
target/ppc/int_helper.c | 205 +---
1 file changed, 70 insertions(+), 135
These macros can be eliminated by instead using the relavant Vsr* macros in
the few locations where they appear.
Signed-off-by: Mark Cave-Ayland
---
target/ppc/int_helper.c | 66 -
1 file changed, 27 insertions(+), 39 deletions(-)
diff --git
The current implementations make use of the endian-specific macros HI_IDX and
LO_IDX directly to calculate array offsets.
Rework the implementation to use the Vsr* macros so that these per-endian
references can be removed.
Signed-off-by: Mark Cave-Ayland
---
target/ppc/int_helper.c | 48
The current implementations make use of the endian-specific macros MRGLO/MRGHI
and also reference HI_IDX and LO_IDX directly to calculate array offsets.
Rework the implementation to use the Vsr* macros so that these per-endian
references can be removed.
Signed-off-by: Mark Cave-Ayland
---
The original purpose of these macros was to correctly reference the high and low
parts of the VSRs regardless of the host endianness.
Replace these direct references to high and low parts with the relevant VsrD
macro instead, and completely remove the now-unused HI_IDX and LO_IDX macros.
>From working on the TCG vector operations patchset, it is apparent that there
are a large number endian-based hacks in int_helper.c which can be removed by
making use of the various Vsr* macros.
Patch 1 is simple enough, and implements the complete set of Vsr* macros for
both big endian and
This prepares us for eliminating the use of direct array access within the VMX
instruction implementations.
Signed-off-by: Mark Cave-Ayland
---
target/ppc/internal.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/target/ppc/internal.h b/target/ppc/internal.h
index
Patchew URL: https://patchew.org/QEMU/20181214165657.749-1-rka...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181214165657.749-1-rka...@virtuozzo.com
Type: series
Subject: [Qemu-devel] [RFC PATCH 0/5] expose
Now that the VMX and VSR register sets have been combined, the same macros can
be used to access both AVR and VSR field members.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
---
target/ppc/int_helper.c | 30 +-
1 file changed, 13 insertions(+), 17
Instead of accessing the FPR, VMX and VSX registers through static arrays of
TCGv_i64 globals, remove them and change the helpers to load/store data directly
within cpu_env.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
Acked-by: David Gibson
---
target/ppc/translate.c
The VSX register array is a block of 64 128-bit registers where the first 32
registers consist of the existing 64-bit FP registers extended to 128-bit
using new VSR registers, and the last 32 registers are the VMX 128-bit
registers as show below:
64-bit 64-bit
Since the VSX registers are actually a superset of the VMX registers then they
can be represented by the same type. Merge ppc_avr_t into ppc_vsr_t and change
ppc_avr_t to be a simple typedef alias.
Note that due to a difference in the naming of the float32 member between
ppc_avr_t and ppc_vsr_t,
These helpers allow us to move VSR register values to/from the specified
TCGv_i64
argument.
To prevent VSX helpers accessing the cpu_vsr array directly, add extra TCG
temporaries as required.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
Acked-by: David Gibson
---
These helpers allow us to move FP register values to/from the specified TCGv_i64
argument in the VSR helpers to be introduced shortly.
To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG
temporaries as required.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard
These ensure that we consistently handle signed and unsigned extensions
correctly
when decoding immediates from instruction opcodes.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
---
target/ppc/internal.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
This patchset is an attempt at trying to improve the VMX (Altivec) instruction
performance by laying the groundwork for use of the new TCG vector operations.
Patches 1 and 2 fix a sign-extension error discovered in EXTRACT_SHELPER and an
associated typo in the SIMM5 macro which were discovered
These helpers allow us to move AVR register values to/from the specified
TCGv_i64
argument.
To prevent VMX helpers accessing the cpu_avr{l,h} arrays directly, add extra TCG
temporaries as required.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
Acked-by: David Gibson
---
As the macro name suggests, the argument should be signed and not unsigned.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
---
target/ppc/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/internal.h b/target/ppc/internal.h
index
Patchew URL:
https://patchew.org/QEMU/20181214144214.1260-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181214144214.1260-1-peter.mayd...@linaro.org
Type: series
Subject: [Qemu-devel] [PULL 00/22]
Patchew URL:
https://patchew.org/QEMU/20181214154130.4069-1-tom.des...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181214154130.4069-1-tom.des...@gmail.com
Type: series
Subject: [Qemu-devel] [PATCH v3] Add
87 matches
Mail list logo
