if
the enhancement is not present, we assume 1.5 behavior of the old name).
If you can prove we can introspect the change in the command line (ie.
prove this is option #1), then you can add:
Reviewed-by: Eric Blake ebl...@redhat.com
although I still think it might be worth considering option #3 in a
respin
+ MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \
+ ./$seq $tmp.out 21
THIS file requires /bin/bash, so using a bashism here is just fine.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description
:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
it to:
MALLOC_PERTURB_=
which meant you were setting it to the empty variable; and thus had no
randomness but no syntax error to tell you your mistake.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
On 05/21/2013 09:33 AM, Tomoki Sekiyama wrote:
Add configuration for c++ compiler (${corss_prefix}g++ as default) in
s/corss/cross/
configure and Makefiles.
Currently, usage of c++ language is only for access to Windows VSS
using COM+ services in qemu-guest-agent for Windows.
--
Eric
of the temp directory even if you
Ctrl-C the script in the middle of a potentially long-running msiextract?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
is this functionality? How frequently
does VSS even get us into that state? That is, are Windows guests going
to frequently hit our current first-round implementation limits that
fail to let them do auto-recovery?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
of you having to hard-code
all the elements into your domain XML), so we have a design to base it
on. But until someone adds such a feature for libvirt, then OpenStack
should be passing explicit XML to libvirt, and tracking defaults at the
OpenStack layer.
--
Eric Blake eblake redhat com+1-919
, \
+ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(($$RANDOM % 255 + 1))} \
Same problem on dash, same fix is needed.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
: 1265044230, microseconds: 450486 } }
+RX_FILTER_CHANGED
+-
+
DEVICE_TRAY_MOVED
-
Isn't this file supposed to be kept in sorted order, to minimize merge
conflicts when backporting events?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
/
+- unicast-overflow: unicast table is overflow (json-bool)
and again
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
return vs. a dictionary return.
But I'd definitely favor some structure into the new QMP command, where
you build up that structure by actually parsing qapi-schema.json instead
of using it as-is.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
/. It wouldn't be anything
fancy, but I ended up not finishing it.
Even if you post the draft, that might help spur some ideas.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
sure we have a solution that addresses them.
Agreed.
None of that should hold back schema introspection...
Agreed.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
and sets the flag, but the event is
one-shot until the next patch adds the query to clear the flag. And
again, the flag should be per-device, not global.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
, and probably deserves
its own series, I'm fine with taking this patch as-is.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, does C99 even allow anonymous unions, or is that a gcc extension?
Overall, I like the direction this is headed. The conversion looks
reasonable, although it didn't quite go far enough for getting rid of
buffers.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
: that-entry, cur-size: 1024, max-size: 21504 },
+ { name: other-entry, cur-size: 4096, max-size: 41472 } ]
+ } ]
+ }
Looks reasonable.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
hash ordering
demonstrated in your example below). Or are you asking how macaddr
strings within multicast-table are sorted (JSON arrays DO convey
ordering relations), rather than how the name-value pairs are (not)
sorted in the overall array entry dictionary?
--
Eric Blake eblake redhat com
disjoint bitfields?
Everything else looked okay to me.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
of a
per-nic flag, then you will fail to emit an event for NIC2 if it changes
in between the time that NIC1 fired an event and libvirt finally does
the query, and libvirt wouldn't realize that NIC2 also needs a macvtap
change.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
, now that the qemu-kvm tree has been
merged upstream and is no longer actively maintained.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the filtering in place.
It was you who suggested a filter command?
No, Stefan suggested it on v1:
https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03102.html
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
its first technical corrigendum [aka POSIX 2013]).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
with.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
that I don't have a
good handle on what is really wanted.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
,
+ clock_buf);
Now that 'buf' is no longer in scope, it might be nice to rename 'buf1'
to something more meaningful; maybe size_buf to go along with the other
two named buffers. But the choice of naming doesn't impact the
correctness, so
Reviewed-by: Eric Blake ebl
/block.h| 26 ++--
include/block/snapshot.h | 53
savevm.c | 23 +---
6 files changed, 217 insertions(+), 143 deletions(-)
create mode 100644 block/snapshot.c
create mode 100644 include/block/snapshot.h
Reviewed-by: Eric Blake ebl
|7 ++-
qapi-schema.json | 10 +++-
qemu-img.c | 10 +++-
qmp-commands.hx | 69 +++-
7 files changed, 242 insertions(+), 37 deletions(-)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
xiaw...@linux.vnet.ibm.com
---
block/qapi.c | 36 ++--
include/block/qapi.h |6 +++---
qemu-img.c | 11 ++-
3 files changed, 39 insertions(+), 14 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake
/images/test.snapshot1).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
change to actually
populate the new field. This hunk should probably be squashed with the
patch that implements the field. Also, are you missing any changes to
qmp-commands.hx?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
enabled.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
Embarassing how long it's taking to get this right :P
But at least the code review process prevents your embarrassment from
being codified into qemu.git across multiple commits :)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric
)
Gerd Hoffmann (2):
Revert chardev: Get filename for new qapi backend
chardev: fix info chardev output
Series: Reviewed-by: Eric Blake ebl...@redhat.com
qemu-char.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
Eric Blake eblake redhat com
-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
handler sufficient? In other words, if this is
debug-only, can we just leave it undocumented instead of listing an
example only to declare the example non-portable?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description
now.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
cmd.c | 28 ++--
cmd.h | 2 --
qemu-io.c | 10 --
3 files changed, 2 insertions(+), 38 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
5 files changed, 20 insertions(+), 12 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
+++ b/qemu-img.c
@@ -84,8 +84,9 @@ static void help(void)
options are: 'none', 'writeback' (default, except for
convert), 'writethrough',\n
'directsync
of precision if there is no '.' in the
value being parsed, while still providing the flexibility of 0.5G
parsing when precision isn't important).
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
On 05/28/2013 09:27 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-io.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
;
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
/created/unplugged/
+#
+# Returns: Nothing on success
+#
+# Since 1.6
+##
+{ 'command': 'cpu-del', 'data': {'id': 'int'} }
+
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 05/29/2013 02:13 AM, Kevin Wolf wrote:
Am 28.05.2013 um 18:07 hat Eric Blake geschrieben:
On 05/28/2013 09:27 AM, Kevin Wolf wrote:
The QMP version is flagged with a __org.qemu.debug- prefix in order to
reinforce the statement that qemu-io is for testing and debugging only,
with no API
sure memory is aligned by default, or purposefully
qemuio_misaligned if
* that is specified on the command line.
+
+int qemuio_misalign;
Should this variable be typed 'bool'?
Other than that,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
++-
qemu-io-cmds.c | 24
3 files changed, 31 insertions(+), 39 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
/messages.po
doesn't contain any mention of cmd.c, so it's not like we were actually
translating the strings, even if they were marked for translation. So
no real change.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
| 2 --
qemu-io.c | 17 -
3 files changed, 16 insertions(+), 32 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
changed, 148 insertions(+), 178 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
there may be some older options that
still need to be taught to honor that escaping.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
backing_file='2.qcow2'
encryption=off cluster_size=65536 lazy_refcounts=off
[$] qemu-io -c read -v 0 512 1.qcow2
^CSegmentation fault (core dumped)
Also make sure that 'qemu-img info 1.qcow2' and 'qemu-img info
--backing-chain 1.qcow2' don't crash.
--
Eric Blake eblake redhat com+1-919
-abort, if only to be clear that it is not a normal
interface.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
') || mode[1] != 0) {
fprintf(stderr, qemu_popen: Argument validity check failed\n);
+fclose(stdio_file);
You MUST use pclose() (not fclose) on any FILE obtained by popen(), to
avoid resource leaks.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-desc[i].name,
+list-desc[i].help ?
+list-desc[i].help : No description available);
+}
+}
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, and the code
itself looks okay;
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
insertions(+), 12 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
insertions(+), 52 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
will probably
follow the same pattern, so allow .commit() to be NULL.
Suggested-by: Eric Blake ebl...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
blockdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
Is it worth
(chardevs, chr, next);
return ret;
} else {
Peter was telling me on IRC that this patch is still broken with regards
to libvirt; I've cc'd him to provide more details...
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
| 2 +-
savevm.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
This version of the savevm.c fix is nicer than Stefan's attempt:
https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg04506.html
Reviewed-by: Eric Blake ebl...@redhat.com
+++ b/savevm.c
@@ -322,16 +322,16
, don't send images when a copy-and-paste of the terminal
contents will do; or at a minimum consider posting the screenshot to a
website then posting only the URL to that website in your mail message.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
);
+exit(1);
Reviewed-by: Eric Blake ebl...@redhat.com
However, I prefer exit(EXIT_FAILURE) rather than exit(1), to make it a
bit easier to grep for known failure exits. Libvirt has a syntax
checker (taken from gnulib) that enforces such a style, if qemu would
like to adopt that style
.
+if (!hdrs-has_file + !hdrs-has_data != 1) {
Meanwhile, the post-patch logic is harder to read, in my opinion.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
+++
3 files changed, 189 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
...@redhat.com
---
blockdev.c | 15 ---
1 file changed, 15 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(+), 3 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
': { ...inlined contents of DictType... } }
But that is a cleanup that would apply to other existing qapi commands,
and is therefore better done as an independent series, and therefore
does not stop me from giving:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
some of this work to someone else in the near
future.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
MAINTAINERS | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
QAPI Schema
M: Eric Blake ebl...@redhat.com
M: Luiz Capitulino lcapitul...@redhat.com
-by: Eric Blake ebl...@redhat.com
But see questions about whether 2/2 missed some files.
Also, be aware that I'm on vacation June 6-26, so I won't be able to do
much with my increased responsibility until after that point.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
++
hw/tpm/tpm_nvram.h | 25 +++
hw/tpm/tpm_tis.c |8 +
5 files changed, 435 insertions(+), 0 deletions(-)
create mode 100644 hw/tpm/tpm_nvram.c
create mode 100644 hw/tpm/tpm_nvram.h
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
/show_bug.cgi?id=970761
to remind us to fix libvirt.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 06/04/2013 01:35 PM, Corey Bryant wrote:
On 06/04/2013 03:23 PM, Eric Blake wrote:
On 06/04/2013 12:18 PM, Corey Bryant wrote:
This patch series provides persistent storage support that a TPM
can use to store NVRAM data. It uses QEMU's block driver to store
data on a drive image
is only portable on sockets, not pipes. It may work on Linux,
but you'll need to be aware of what it does on other platforms.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
On 06/04/2013 09:58 PM, Wanlong Gao wrote:
Add monitor command mem-nodes to show the huge mapped
memory nodes locations.
Missing a QMP counterpart. Libvirt would probably like to use this
command, and providing it HMP-only is not friendly.
--
Eric Blake eblake redhat com+1-919-301-3266
may break clients that are expecting this field to exist.
Rather than reverting the entire patch, you should consider keeping this
field present in QMP, even if you now always populate it with 0.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http
as a mention that this mode is not supported via QMP
but only exists so that the code generator will support the mode needed
internally? Is there any way to refactor things so that you don't have
to munge the QAPI just to provide this internal-only mode?
--
Eric Blake eblake redhat com+1-919-301
+250,9 @@
#
# @backing-image: #optional info of the backing image (since 1.6)
#
+# @info-string: #optional string supplying additional format-specific
s/string/struct/
With that one word fixed, I'm fine with:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1
/block/block_int.h | 1 +
4 files changed, 14 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
a respin for just
that (if someone DOES reuse this function in the future, they can tweak
underscores at that time, if you don't do it now).
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
, add qcow2_get_specific_info, which returns this information.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2.c| 19 +++
qapi-schema.json | 16
2 files changed, 35 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake
message of what input is being stripped by this patch.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
current form, but can live with this
patch as-is if we don't bother with testing JSON form. Does 5/6 even
need to worry about stripping JSON form, if you aren't going to test
JSON form? Depending on the answer to that question:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat
insertions(+), 1 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 09/08/2013 08:57 PM, Wenchao Xia wrote:
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block/qcow2-snapshot.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
);
On the surface, this makes sense, but I'd rather defer the technical
review to someone more familiar with qcow2 code.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Xia xiaw...@linux.vnet.ibm.com
---
block/blkdebug.c |4
include/block/block.h |4
2 files changed, 8 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
changed, 17 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(-)
Reviewed-by: Eric Blake ebl...@redhat.com
I would have squashed 4 and 5 into a single patch (declaring the enums
doesn't add any functionality without the event actually using the enum
values, and neither patch is so large in isolation where combining them
would ips the balance towards too large
the
stack to the caller rather than losing it except during a debug build.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
can tell whether
this feature is available? Furthermore, 'ft' is an awfully short name;
for QMP, we prefer to use full words where possible, such as
'fault-tolerant'.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
passes after applying it.
So feel free to add:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
of `` and $PWD instead of `pwd` in patch 6 and
indent format specific information in reference output (according
to change in patch 3)
- rebased on Kevin's block branch (changed some line numbers and the
diff environment in patch 5)
Series: Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric
is not inserted, return
+ * -ENOMEDIUM. If @bs is not readonly, return -EINVAL. If @bs did not support
+ * internal snapshot, return -ENOTSUP. If qemu can't find one matching @id
and
+ * @name, return -ENOENT. If @bs do not support parameter @snapshot_id or
s/do/does/
--
Eric Blake eblake
; but
here --load is NOT short for --load-snapshot, because it could also be
short for --load-snapshot1. And why the 1 suffix? Can you come up with
a better name that distinguishes why you have to have two different long
options, and which doesn't overlap on as much of a common prefix?
--
Eric Blake
form. Then you only burn one short option letter,
and avoid the problem with ambiguous abbreviation that I complained
about in 2/7.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
/
+_supported_fmt qcow2
+_supported_proto generic
+_supported_os Linux
Is this test truly Linux-only?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
1 - 100 of 23009 matches
Mail list logo
