On Thu, 13 May 2010 19:23:11 +0300
Avi Kivity a...@redhat.com wrote:
On 05/13/2010 06:01 PM, Daniel P. Berrange wrote:
Yes, we do and it's used by libvirt iirc.
This command has been in QEMU for quite a long time now (0.9.x IIRC).
It wasn't in QMP until 0.12. We
On Fri, 14 May 2010 10:15:32 +0200
Kevin Wolf kw...@redhat.com wrote:
Am 13.05.2010 12:30, schrieb Daniel P. Berrange:
The 'parent' field in the 'query-blockstats' monitor command is
part of the top level block device QDict, not part of the 2nd
level 'stats' QDict.
* block.c: Fix docs
On Fri, 14 May 2010 09:38:58 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
On Fri, May 14, 2010 at 6:46 AM, Markus Armbruster arm...@redhat.com wrote:
There's also
3. Convert it anyway. Clean up the mess. Change the output.
I agree.
It seams to me that no one is
On Fri, 14 May 2010 10:39:29 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Thu, 13 May 2010 16:48:13 +0300
Avi Kivity a...@redhat.com wrote:
On 05/05/2010 10:11 PM, Luiz Capitulino wrote:
One of the most important missing feature
On Fri, 14 May 2010 19:03:36 +0200
Markus Armbruster arm...@redhat.com wrote:
What about PCI domains?
Good point. Better to provide for them neatly now, instead of kludging
them in later.
When I did this conversion I asked Micheal for help with that and he said
QEMU doesn't support PCI
On Fri, 14 May 2010 19:08:07 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Avi Kivity wrote:
On 05/14/2010 08:01 PM, Avi Kivity wrote:
On 05/14/2010 07:52 PM, Jan Kiszka wrote:
In order not to compromise QMP adoption and make users' life easier,
this commit adds a simple text
On Sat, 15 May 2010 10:42:44 +0200
Jan Kiszka jan.kis...@web.de wrote:
Luiz Capitulino wrote:
On Fri, 14 May 2010 19:08:07 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Avi Kivity wrote:
On 05/14/2010 08:01 PM, Avi Kivity wrote:
On 05/14/2010 07:52 PM, Jan Kiszka wrote:
In order
On Tue, 18 May 2010 11:51:26 +0200
Markus Armbruster arm...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws writes:
On 05/15/2010 01:19 AM, Avi Kivity wrote:
On 05/15/2010 01:54 AM, Luiz Capitulino wrote:
On Fri, 14 May 2010 19:03:36 +0200
Markus Armbrusterarm...@redhat.com
On Tue, 18 May 2010 13:21:36 +0200
Markus Armbruster arm...@redhat.com wrote:
Jan Kiszka jan.kis...@web.de writes:
[...]
nothing needs to be delayed any further.
Well, it's being delayed :)
Let's commit the sucker as is. We can still move it into
qemu-monitor.hx afterwards. Commits
On Tue, 18 May 2010 09:32:32 -0500
Anthony Liguori aligu...@linux.vnet.ibm.com wrote:
Hi,
Here's my current thinking for the 0.13.0 release. Since there's a lot
of activity going on with QMP, I'd like to move the release out to July 1st.
Here's what I'd like to do between now and then:
On Tue, 18 May 2010 15:55:41 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, May 18, 2010 at 09:34:06AM -0500, Anthony Liguori wrote:
On 05/18/2010 09:09 AM, Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 08:53:19AM -0500, Anthony Liguori wrote:
On 05/17/2010 10:23 PM,
On Tue, 18 May 2010 17:16:54 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, May 18, 2010 at 01:00:40PM -0300, Luiz Capitulino wrote:
On Tue, 18 May 2010 15:55:41 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, May 18, 2010 at 09:34:06AM -0500, Anthony Liguori
From: Jan Kiszka jan.kis...@siemens.com
Push the doc fragments for the info command to the end of
qemu-monitor.hx. This helps to establish a proper layout in the upcoming
QMP documentation.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
qemu-monitor.hx | 166
This new version moves the documentation to qemu-monitor.hx and now
QMP/qmp-commands.txt is generated from there (thanks Jan!).
I hope I've addressed all review comments in this version and now it should
describe reality.
Next step is to fix glitches (after this series is merged, of course).
the current situation. To avoid at
least divering from the user monitor help and texi snippets, QMP bits
are also maintained inside qemu-monitor.hx, and hxtool is extended to
generate a single text file from them.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul
.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
block.c | 69
hw/pci.c| 61 ---
hw/qdev.c | 13 ---
input.c | 18 --
migration.c | 38 --
monitor.c | 102
On Wed, 19 May 2010 11:15:16 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
From: Jan Kiszka jan.kis...@siemens.com
One of the most important missing feature in QMP today is its
supported commands documentation.
The plan is to make it part of self-description
On Wed, 19 May 2010 15:30:43 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
[...]
I didn't submit the syntax checking bits on purpose, there's something
failing there and I didn't want to check it now.
You already did for QMP, just skipped the STEXI/ETEXI
On Wed, 19 May 2010 15:50:56 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
On Wed, 19 May 2010 15:30:43 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
[...]
I didn't submit the syntax checking bits on purpose, there's something
On Tue, 18 May 2010 17:38:27 -0500
Anthony Liguori aligu...@linux.vnet.ibm.com wrote:
Hi,
In an effort to improve the 0.13 release quality, I'd like to host a Bug
Day on June 1st, 2010. I've setup a quick wiki page with some more info
(http://wiki.qemu.org/BugDay/June2010).
Tuesday is
From: Markus Armbruster arm...@redhat.com
We don't want pci_del in QMP. Use device_del instead.
This reverts commit 6848d827162fea039f2658414a4adb6164a4f9b0.
Conflicts:
hw/pci-hotplug.c
sysemu.h
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/pci-hotplug.c |5
From: Markus Armbruster arm...@redhat.com
Short story: We don't want pci_add in QMP. Long story follows.
pci_add can do two things:
* Hot plug a PCI NIC. device_add is more general.
* Hot plug a PCI disk controller, and a drive connected to it.
The controller is either virtio-blk-pci
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
---
QMP/qmp-spec.txt | 55 ++
1 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
index
- Change from GPL to LGPL
- Add license text when missing
- Minor cosmetic changes to make all headers look the same
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c |3 +++
check-qfloat.c |5 -
check-qint.c|3 +++
check-qlist.c |4 ++--
check
This reverts commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d.
Next commits will do the same thing in a better way.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |3 +--
sysemu.h |2 --
vl.c | 18 --
3 files changed, 1 insertions(+), 22
) are available in
the following repository:
git://repo.or.cz/qemu/qmp-unstable.git for-anthony
Luiz Capitulino (4):
Revert Monitor: Return before exiting with 'quit'
sysemu: Export 'no_shutdown'
Monitor: Return before exiting with 'quit'
Fix qtypes' licenses
Markus Armbruster (3
It's a global variable already, do_quit() will use it.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
sysemu.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index 48ee66c..879446a 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -128,6 +128,7
if QEMU exited because of a problem or
because the 'quit' command has been executed.
This commit fixes that by making do_quit() use
qemu_system_shutdown_request(), so that we exit gracefully.
Thanks to Paolo Bonzini pbonz...@redhat.com for suggesting
this solution.
Signed-off-by: Luiz Capitulino
Hi Anthony,
While investigating a QMP bug reported by a user, I've found a few issues
in our parser/lexer.
The patches in this series fix the problems I was able to solve, but we
still have the following issues:
1. Our 'private extension' is open to the public
Eg. The following input
The 'lexer' variable is passed by the caller, it can contain anything
(eg. garbage).
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
json-lexer.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 9d64920..0b145d1 100644
The JSON escape sequence \/ and \\ are valid and should be
handled.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
json-lexer.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 0b145d1..5cc7e6c 100644
--- a/json-lexer.c
While there make the fail_unless() calls print error messages.
IMPORTANT: The test for \/ is failing, don't know why.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qjson.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/check-qjson.c b
It's valid JSON and should be handled.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
json-parser.c |4
qjson.c |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index b55d763..83212bc 100644
--- a/json-parser.c
It's not needed, use qobject_put() instead and get a cleaner code.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
json-streamer.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/json-streamer.c b/json-streamer.c
index 610ffea..f7e7a68 100644
--- a/json
QString supports adding a single char, 'buf' is unneeded.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
json-lexer.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 5cc7e6c..1d9b81f 100644
--- a/json-lexer.c
+++ b/json
On Wed, 19 May 2010 16:43:08 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/19/2010 04:15 PM, Luiz Capitulino wrote:
Hi Anthony,
While investigating a QMP bug reported by a user, I've found a few issues
in our parser/lexer.
The patches in this series fix the problems
On Wed, 19 May 2010 16:44:47 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/19/2010 04:15 PM, Luiz Capitulino wrote:
The JSON escape sequence \/ and \\ are valid and should be
handled.
Signed-off-by: Luiz Capitulinolcapitul...@redhat.com
Good catch.
I think there's
On Thu, 20 May 2010 17:16:01 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
On 05/20/2010 03:44 PM, Luiz Capitulino wrote:
I think there's another issue in the handling of strings.
The spec says that valid unescaped chars are in the following range:
unescaped = %x20-21 / %x23
On Thu, 20 May 2010 17:18:23 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
On 05/19/2010 11:43 PM, Anthony Liguori wrote:
4. Lexer expects a 'terminal' char to process a token
Which means clients must send a sort of end of line char, so that we
process their input.
On Thu, 20 May 2010 17:26:03 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
On 05/20/2010 05:25 PM, Luiz Capitulino wrote:
On Thu, 20 May 2010 17:16:01 +0200
Paolo Bonzinipbonz...@redhat.com wrote:
On 05/20/2010 03:44 PM, Luiz Capitulino wrote:
I think there's another issue
On Thu, 20 May 2010 10:50:41 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 10:16 AM, Paolo Bonzini wrote:
On 05/20/2010 03:44 PM, Luiz Capitulino wrote:
I think there's another issue in the handling of strings.
The spec says that valid unescaped chars
On Thu, 20 May 2010 10:54:42 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 10:35 AM, Luiz Capitulino wrote:
I meant that we're just accepting some invalid JSON and that's not a big
deal.
It can become a big deal if clients rely on it and for some reason we
On Thu, 20 May 2010 10:52:58 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 10:18 AM, Paolo Bonzini wrote:
On 05/19/2010 11:43 PM, Anthony Liguori wrote:
4. Lexer expects a 'terminal' char to process a token
Which means clients must send a sort of end of line
On Thu, 20 May 2010 11:55:00 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 11:27 AM, Luiz Capitulino wrote:
On Thu, 20 May 2010 10:50:41 -0500
Anthony Liguorianth...@codemonkey.ws wrote:
On 05/20/2010 10:16 AM, Paolo Bonzini wrote:
On 05/20/2010 03:44
On Thu, 20 May 2010 13:52:08 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 01:47 PM, Luiz Capitulino wrote:
On Thu, 20 May 2010 11:55:00 -0500
Anthony Liguorianth...@codemonkey.ws wrote:
On 05/20/2010 11:27 AM, Luiz Capitulino wrote:
On Thu, 20 May
On Thu, 20 May 2010 10:35:52 -0300
Luiz Capitulino lcapitul...@redhat.com wrote:
2. QMP doesn't check the return of json_message_parser_feed()
Which means we don't handle JSON syntax errors. While the fix might
seem
trivial (ie. just return an error!), I'm not sure what's
On Sun, 23 May 2010 09:57:43 +0200
Jan Kiszka jan.kis...@web.de wrote:
Avi Kivity wrote:
[...]
+- full: report full state (json-bool, optional)
Is this needed for QMP? The client can always truncate it to any length.
The effect may not be needed for QMP, but I do need this
On Mon, 24 May 2010 14:29:58 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/20/2010 02:22 PM, Luiz Capitulino wrote:
On Thu, 20 May 2010 13:52:08 -0500
Anthony Liguorianth...@codemonkey.ws wrote:
On 05/20/2010 01:47 PM, Luiz Capitulino wrote:
On Thu, 20 May
On Tue, 25 May 2010 16:21:01 +0200
Juan Quintela quint...@redhat.com wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 16 ++--
migration.h |2 +-
vl.c|7 ++-
3 files changed, 17 insertions(+), 8 deletions(-)
diff --git
On Tue, 25 May 2010 11:10:23 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
There should be some information about why it failed, no? Preferrably
in a QError format.
At this point, we have basically -1 :(
I can add a field with an error number, but we are very bad at
On Tue, 25 May 2010 17:35:53 +0200
Juan Quintela quint...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/25/2010 09:21 AM, Juan Quintela wrote:
+MIGRATION_CANCELED
+--
+
+Emitted when migration is canceled. This is emitted in the source.
On Tue, 25 May 2010 16:21:03 +0200
Juan Quintela quint...@redhat.com wrote:
They are emitted when migration starts, ends, has a failure or is canceled.
Signed-off-by: Juan Quintela quint...@redhat.com
---
QMP/qmp-events.txt | 50 ++
On Tue, 25 May 2010 13:51:01 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/25/2010 01:31 PM, Luiz Capitulino wrote:
On Tue, 25 May 2010 16:21:03 +0200
Juan Quintelaquint...@redhat.com wrote:
They are emitted when migration starts, ends, has a failure or is canceled
On Wed, 26 May 2010 11:55:31 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/26/2010 10:15 AM, Daniel P. Berrange wrote:
On Wed, May 26, 2010 at 09:54:22AM -0500, Anthony Liguori wrote:
On 05/26/2010 05:33 AM, Daniel P. Berrange wrote:
I'm not sure why you would need
On Thu, 27 May 2010 17:58:03 +0200
Juan Quintela quint...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com wrote:
On Wed, 26 May 2010 11:55:31 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
That's exactly how the protocol is designed. That was one of the major
On Tue, 18 May 2010 14:07:39 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
The VLANClientState structure has the member info_str, a simple string that
is filled with information about NIC devices and used on monitor calls.
There is no coherent formatting of this string by all
On Tue, 18 May 2010 14:07:40 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
This is a helper function that converts a QDict to a QString, using
the format:
key1=value1 SEP key2=value2 SEP key3=value3
Handy for debugging and formating the Monitor output.
Signed-off-by:
On Tue, 18 May 2010 14:07:44 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com
---
net/tap-win32.c |9 -
net/tap.c | 18 +-
2 files changed, 25 insertions(+), 2 deletions(-)
diff
On Tue, 18 May 2010 14:07:45 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com
---
net/vde.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/net/vde.c b/net/vde.c
index
On Thu, 20 May 2010 09:18:52 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Looks good.
---
Makefile |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
On Sun, 23 May 2010 12:59:19 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Allow to specify the device to be removed via device_del not only by ID
but also by its full or abbreviated qtree path. For this purpose,
qdev_find is introduced which combines
On Sun, 23 May 2010 12:59:23 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
This reserves JSON objects that contain the key '__class__' for QMP-specific
complex objects. First user will be the buffer class.
Signed-off-by: Jan Kiszka
On Sun, 23 May 2010 12:59:26 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Ported commands that are marked 'user_only' will not be considered for
QMP monitor sessions. This allows to implement new commands that do not
(yet) provide a sufficiently stable
On Sun, 23 May 2010 12:59:29 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Remove the arbitrary limitation of 1024 characters per return string and
read complete lines instead. Required for device_show.
Thanks for both fixes, I have started working on a
On Fri, 28 May 2010 00:19:48 +0200
Jan Kiszka jan.kis...@web.de wrote:
Luiz Capitulino wrote:
On Sun, 23 May 2010 12:59:19 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Allow to specify the device to be removed via device_del not only by ID
On Fri, 28 May 2010 00:20:08 +0200
Jan Kiszka jan.kis...@web.de wrote:
Luiz Capitulino wrote:
On Sun, 23 May 2010 12:59:26 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Ported commands that are marked 'user_only' will not be considered for
QMP
On Fri, 28 May 2010 14:17:07 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/28/2010 02:13 PM, Kevin Wolf wrote:
Am 28.05.2010 20:21, schrieb Markus Armbruster:
I'd like to give posting documentation of new QMP commands for review
before posting code a try. But first let me
On Mon, 31 May 2010 13:05:37 +0200
Markus Armbruster arm...@redhat.com wrote:
Avi Kivity a...@redhat.com writes:
On 05/28/2010 10:24 PM, Luiz Capitulino wrote:
If a password is needed, we should throw an error and let the QMP client
set the password and try again.
It's what
On Sat, 29 May 2010 10:50:55 +0200
Jan Kiszka jan.kis...@web.de wrote:
Luiz Capitulino wrote:
This new version moves the documentation to qemu-monitor.hx and now
QMP/qmp-commands.txt is generated from there (thanks Jan!).
I hope I've addressed all review comments in this version and now
From: Jan Kiszka jan.kis...@siemens.com
Push the doc fragments for the info command to the end of
qemu-monitor.hx. This helps to establish a proper layout in the upcoming
QMP documentation.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
qemu-monitor.hx | 186
Rebase.. Let's try to merge this ASAP, please.
changelog
-
v3 - v4
- Rebased
- Minor commit log clarification
v2 - v3
- Rebased
- Addressed review comments
- Move contents to qemu-monitor.hx (Jan)
v1 - v2
- Rebased
- Addressed Markus's comments
- Changed
the current situation. To avoid at
least divering from the user monitor help and texi snippets, QMP bits
are also maintained inside qemu-monitor.hx, and hxtool is extended to
generate a single text file from them.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul
a QMP command.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
block.c | 69
hw/pci.c| 61 ---
hw/qdev.c | 13 ---
input.c | 18 --
migration.c | 38
On Mon, 31 May 2010 16:13:12 +0200
Markus Armbruster arm...@redhat.com wrote:
We need Device IDs to be unique and not contain '/' so device tree
nodes can always be unambigously referenced by tree path.
We already have some protection against duplicate IDs, but it got
holes:
* We don't
On Tue, 01 Jun 2010 15:09:34 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
Two bugs that might not be related to this thread:
* id member is not mandatory for the device_add command:
{ execute: device_add, arguments: { driver: e1000 } }
{return
On Tue, 01 Jun 2010 15:19:59 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
On Tue, 01 Jun 2010 15:09:34 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
Two bugs that might not be related to this thread:
* id member is not mandatory
On Mon, 31 May 2010 21:22:22 +0100
Stefan Hajnoczi stefa...@gmail.com wrote:
On Mon, May 31, 2010 at 6:43 PM, Luiz Capitulino lcapitul...@redhat.com
wrote:
Hi Luiz,
I'm interested in QMP, have left some feedback. As I get up to speed
with QMP my questions and suggestions will hopefully
On Tue, 01 Jun 2010 09:40:44 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Stefan Hajnoczi wrote:
On Mon, May 31, 2010 at 6:43 PM, Luiz Capitulino lcapitul...@redhat.com
wrote:
Hi Luiz,
I'm interested in QMP, have left some feedback. As I get up to speed
with QMP my questions
On Tue, 01 Jun 2010 16:44:24 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Mon, 31 May 2010 16:13:12 +0200
Markus Armbruster arm...@redhat.com wrote:
We need Device IDs to be unique and not contain '/' so device tree
nodes can
On Tue, 01 Jun 2010 18:10:26 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
From: Jan Kiszka jan.kis...@siemens.com
One of the most important missing feature in QMP today is its
supported commands documentation.
The plan is to make it part of self-description
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index 175bc17..ca3c3b1 100644
--- a/qdict.c
+++ b/qdict.c
@@ -287,6 +287,24 @@ int64_t qdict_get_try_int
Current QMP's client argument checker implementation is more complex than it
should be and has a flaw: it ignores unknown arguments.
This series solves both problems by introducing a new, simple and ultra-poweful
argument checker. This wasn't trivial to get right due to the number of errors
.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 107 +
1 files changed, 107 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index bc3cc18..47a0da8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4259,6
to the specification.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 45 +
1 files changed, 45 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1875731..654b193 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4271,6 +4271,45
default behavior
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
migration.c | 16 +++-
monitor.c | 19 ---
2 files changed, 11 insertions(+), 24 deletions(-)
diff --git a/migration.c b/migration.c
index 706fe55..efecbdc
We couldn't do it before, otherwise we would break the intention
of the previous checker, which was to ensure that opts_list wasn't
a NULL before checking it.
Debug code, pretty minor, still I decided to maintain its original
behavior.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
Previous commit added qmp_check_input_obj(), it does this
checking for us.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 654b193..f849456 100644
--- a/monitor.c
+++ b
Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.
It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers
converted to QMP, this is just dead code.
Signed-off-by: Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 44d0bf8..b26224e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -177,6 +177,10 @@ static const QErrorStringTable
qdict and for each argument we check if it exists and if
its type is correct.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 77 -
1 files changed, 76 insertions(+), 1 deletions(-)
diff --git a/monitor.c b
On Wed, 02 Jun 2010 08:35:16 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions
On Wed, 02 Jun 2010 08:59:11 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
[...]
+
+type = qobject_to_qstring(obj);
+assert(type != NULL);
+
+if (qstring_get_str(type)[0] == 'O') {
+QemuOptsList *opts_list
On Wed, 02 Jun 2010 09:39:26 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
This is similar to qmp_check_client_args(), but checks if
the input object follows the specification (QMP/qmp-spec.txt
section 2.3).
As we're limited to three
On Wed, 02 Jun 2010 09:31:24 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
This commit introduces check_client_args_type(), which is
called by qmp_check_client_args() and complements the
previous commit.
Now the new client's argument
** Changed in: qemu
Status: New = Confirmed
--
migrate exec ignores exit status
https://bugs.launchpad.net/bugs/391879
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Confirmed
Status in “qemu-kvm” package in
Works for me, I believe this is already fixed.
** Changed in: qemu
Status: New = Fix Committed
** Changed in: qemu
Status: Fix Committed = New
--
Unable to set fullscreen anymore
https://bugs.launchpad.net/bugs/450522
You received this bug notification because you are a member of
Why did this bug get the windows tag?
--
remote migration fails with message load of migration failed
https://bugs.launchpad.net/bugs/491345
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Remote
** Changed in: qemu
Status: New = Fix Committed
--
Unable to set fullscreen anymore
https://bugs.launchpad.net/bugs/450522
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Fix Committed
Bug description:
:
could not configure /dev/net/tun: Device or resource busy
(there are 2 messages like that in the same function)
This fixes Debian bug #578154, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154
Signed-off-by: Michael Tokarev m...@tls.msk.ru
Signed-off-by: Luiz Capitulino lcapitul
Michael's fix is good, but it got forgotten, probably because he has
submitted it in the middle of a thread.
I'm going resubmit it again.
** Changed in: qemu
Status: Incomplete = In Progress
--
no useful error message when tap device open fails
https://bugs.launchpad.net/bugs/584153
You
701 - 800 of 5290 matches
Mail list logo
