Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Alexey Kardashevskiy
On 05/31/2013 08:41 PM, Paolo Bonzini wrote: Il 31/05/2013 12:25, Alexey Kardashevskiy ha scritto: On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: And another question (sorry I am not very familiar with terminology but

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Paolo Bonzini
Il 01/06/2013 02:01, Benjamin Herrenschmidt ha scritto: On Fri, 2013-05-31 at 12:41 +0200, Paolo Bonzini wrote: It may be halfway through, but it is always restarted on the destination. restarted as in the whole transfer is restarted if any right ? So we can essentially consider as a new

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 07:46, Alexey Kardashevskiy ha scritto: Ok. I implemented {save|load}_request for IBMVSCSI, started testing - the destination system behaves very unstable, sometime it is a fault in _raw_spin_lock or it looks okay but any attempt to read the filesystem leads to 100% cpu load in

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 17:05, Gleb Natapov ha scritto: Anthony requested that patches be made that generate the ACPI tables in QEMU for the upcoming hotplug work, so that they could be evaluated to see if they truly do need to live in QEMU or if the code could live in the firmware. There were no

Re: [Qemu-devel] fstrim and cache=none

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 22:21, Dusty Mabe ha scritto: Hi, Is it valid to have cache=none and discard=unmap together? I notice that when I have cache=none the fstrim operations inside of my guests gives me an error What error? Can you add an extra disk and try dd if=/dev/urandom of=/dev/sdc bs=1M

Re: [Qemu-devel] [PATCH 14/15] memory: return MemoryRegion from qemu_ram_addr_from_host

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 18:04, Peter Maydell ha scritto: On 2 June 2013 16:43, Paolo Bonzini pbonz...@redhat.com wrote: -int qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); +MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); ram_addr_t qemu_ram_addr_from_host_nofail(void

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 18:12, Peter Maydell ha scritto: On 2 June 2013 16:43, Paolo Bonzini pbonz...@redhat.com wrote: Reference counting the region piggybacks on reference counting of a QOM object, the owner of the region. The owner API is designed so that it will be called as little as possible.

Re: [Qemu-devel] [PATCH 02/15] memory: add ref/unref

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 17:58, Peter Maydell ha scritto: + * memory_region_ref: Add 1 to a memory region's reference count + * + * Whenever memory regions are accessed outside the BQL, they need to be + * preserved against hot-unplug. MemoryRegions actually do not have their + * own reference

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-06-03 Thread Gleb Natapov
On Fri, May 31, 2013 at 04:52:18PM +0800, Xiao Guangrong wrote: Luiz Capitulino reported that guest refused to boot and qemu complained with: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument It is caused by commit 235e8982ad that did double free for the memslot so

Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-06-03 Thread Amit Shah
On (Fri) 31 May 2013 [14:12:48], Cole Robinson wrote: 'default_backend' isn't always set, but 'rng' is, so use that. $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 Segmentation fault (core dumped) Regressed with

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-06-03 Thread Jordan Justen
On Sun, Jun 2, 2013 at 2:43 AM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, May 31, 2013 at 01:45:55PM +0200, Laszlo Ersek wrote: On 05/31/13 09:09, Jordan Justen wrote: Why is updating the ACPI tables in seabios viewed as such a burden? Either qemu does it, or seabios... (And, OVMF

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-06-03 Thread Paolo Bonzini
Il 01/06/2013 17:28, Blue Swirl ha scritto: This means that memory.c is getting knowledge about CPU types and it becomes more specific to current target. I think memory.c should be generic and target agnostic (maybe one day compiled just once) with exec.c implementing the target specific

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-03 Thread Peter Crosthwaite
Hi Peter and Peter :) On Sun, Jun 2, 2013 at 7:27 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 2 June 2013 06:46, Peter Cheung mcheun...@hotmail.com wrote: I just tried to compile the latest qemu on Fedora 18 64 bits, it is also fail. When i press c in gdb, the qemu won't start

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 09:42, Peter Crosthwaite ha scritto: Hi Peter and Peter :) On Sun, Jun 2, 2013 at 7:27 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 2 June 2013 06:46, Peter Cheung mcheun...@hotmail.com wrote: I just tried to compile the latest qemu on Fedora 18 64 bits, it is

Re: [Qemu-devel] [PATCH] do not check pointers after dereferencing them

2013-06-03 Thread Stefan Hajnoczi
On Fri, May 31, 2013 at 06:46:21AM -0600, Eric Blake wrote: On 05/31/2013 06:00 AM, Paolo Bonzini wrote: Two instances, both spotted by Coverity. In one, two blocks were swapped. In the other, the check is not needed anymore. Cc: qemu-sta...@nongnu.org Cc: qemu-triv...@nongnu.org

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Benjamin Herrenschmidt
On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: Ok. I implemented {save|load}_request for IBMVSCSI, started testing - the destination system behaves very unstable, sometime it is a fault in _raw_spin_lock or it looks okay but any attempt to read the filesystem leads to 100% cpu

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-06-03 Thread Stefan Priebe - Profihost AG
Am 31.05.2013 13:02, schrieb Amos Kong: ... thanks for this great explanation. I've done what you sayd but it still does not work. Here is the output of the seabis debug log where you see the loop: http://pastebin.com/raw.php?i=e53rdW2b | found virtio-scsi at 0:5 | Searching bootorder

[Qemu-devel] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-03 Thread Stefan Hajnoczi
If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1) with error returns in the PCI device .init() function, but leave that for another patch since exit(1) is currently

[Qemu-devel] [PATCH v2 1/2] vhost-scsi: fix k-set_guest_notifiers() NULL dereference

2013-06-03 Thread Stefan Hajnoczi
Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for !k-set_guest_notifiers and error out. The check probably got copied but instead of erroring we actually use the function pointer! Cc: Nicholas Bellinger n...@linux-iscsi.org Cc: Asias He as...@redhat.com Cc:

[Qemu-devel] [PATCH v2 0/2] vhost-scsi and ivshmem fixes for Coverity issues

2013-06-03 Thread Stefan Hajnoczi
The following fixes address NULL pointer dereferences spotted by Coverity. v2: * Dropped savevm.c popen(3) leak fix since Paolo has a better fix [eblake] Stefan Hajnoczi (2): vhost-scsi: fix k-set_guest_notifiers() NULL dereference ivshmem: add missing error exit(2) hw/misc/ivshmem.c|

Re: [Qemu-devel] [PATCH v2 1/2] vhost-scsi: fix k-set_guest_notifiers() NULL dereference

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 10:58, Stefan Hajnoczi ha scritto: Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for !k-set_guest_notifiers and error out. The check probably got copied but instead of erroring we actually use the function pointer! Exactly. :) Applied to scsi branch,

Re: [Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort

2013-06-03 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 04:27:48PM -0600, Eric Blake wrote: On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: notifier_list_notify() has no return value. This is fine when we just want to invoke side-effects. Sometimes it's useful for notifiers to produce a return value. This allows

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-06-03 Thread Libaiqing
Hi, Thanks for your advice,it works well when using prefix=x86_64-w64-mingw32-. The dlls may download from here: http://qemu.weilnetz.de/w64/dll/. One more question: Qemu-ga.exe can't run successfully under normal account which belongs to Administration group. Qemu-ga service

[Qemu-devel] [PATCH] net: tap: fix NULL dereference when passing both fd and vhostfds to tap

2013-06-03 Thread Jason Wang
This is because vhostfdname were passed as NULL to net_init_tap_one() when vhostfd were not specified, but net_init_tap_one() will still pass it to monitor_handle_fd_param() when tap-has_vhostfds is true. Since file descriptor (fd, vhostfd) and file descriptor set (fds, vhostfds) were not

Re: [Qemu-devel] [PATCH] softfloat: Fix shift128Right for shift counts 64..127

2013-06-03 Thread Paolo Bonzini
Il 02/06/2013 17:17, Peter Maydell ha scritto: shift128Right would give the wrong result for a shift count between 64 and 127. This was never noticed because all of our uses of this function are guaranteed not to use shift counts in this range. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-06-03 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 04:57:21PM -0600, Eric Blake wrote: On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs

[Qemu-devel] [PATCH trivial] acpi: actually require either data= or file= for -acpitable

2013-06-03 Thread Michael Tokarev
Initially the code ensured that we have exactly one of data= or file= option for -acpitable. But after some transformations, the condition becomes if (has_data == has_file) { error } to mean, probably, that both should not be set at the same time. But this condition does not cover the case

Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction

2013-06-03 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote: On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and .cleanup() code paths for all previous actions. Another

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Peter Maydell
On 3 June 2013 07:47, Paolo Bonzini pbonz...@redhat.com wrote: Il 02/06/2013 18:12, Peter Maydell ha scritto: What happens if I take a MemoryRegion* that another device has exposed to me as a sysbus mmio region (and so claimed ownership of) and pass it to pci_register_bar()? You get an

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-06-03 Thread Gleb Natapov
On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: I try to hotplug 28 * 8 multiple-function devices to guest with old host kernel, ioeventfds in host kernel will be exhausted, then qemu fails to allocate ioeventfds for blk/nic devices. It's better to add detail error here.

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Alexey Kardashevskiy
On 06/03/2013 06:07 PM, Benjamin Herrenschmidt wrote: On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: Ok. I implemented {save|load}_request for IBMVSCSI, started testing - the destination system behaves very unstable, sometime it is a fault in _raw_spin_lock or it looks okay

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 11:22, Peter Maydell ha scritto: Who owns it at that point? [That's a legitimate thing to do, I think, though I don't suppose anybody does it at the moment. Sysbus MMIOs aren't only for mapping in the system address space, they're a general way for one device to expose a

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 11:37, Alexey Kardashevskiy ha scritto: On 06/03/2013 06:07 PM, Benjamin Herrenschmidt wrote: On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: Ok. I implemented {save|load}_request for IBMVSCSI, started testing - the destination system behaves very unstable,

Re: [Qemu-devel] [PATCH 1/4] tcg/aarch64: more low level ops in preparation of tlb, lookup

2013-06-03 Thread Claudio Fontana
On 31.05.2013 21:07, Richard Henderson wrote: On 05/31/2013 10:57 AM, Jani Kokkonen wrote: +ARITH_SUBS = 0x6b, Any reason you're adding SUBS here, but not ANDS? I also forgot ANDS, I'll add them and reorder. +/* encode a logical immediate, mapping user parameter + M=set bits pattern

Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations

2013-06-03 Thread Claudio Fontana
On 31.05.2013 21:13, Richard Henderson wrote: On 05/31/2013 11:05 AM, Jani Kokkonen wrote: +static inline void tcg_out_uxt(TCGContext *s, int s_bits, + TCGReg rd, TCGReg rn) +{ +/* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00 + of UBFM Wd, Wn, #0,

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Peter Maydell
On 3 June 2013 10:40, Paolo Bonzini pbonz...@redhat.com wrote: Il 03/06/2013 11:22, Peter Maydell ha scritto: arm11mpcore.c does this: sysbus_init_mmio(dev, sysbus_mmio_get_region(s-priv, 0)); which I suspect will assert with your patches. Thanks for the pointer. All other occurrences of

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement byte swap operations

2013-06-03 Thread Claudio Fontana
On 31.05.2013 21:11, Richard Henderson wrote: On 05/31/2013 11:01 AM, Jani Kokkonen wrote: +static inline void tcg_out_rev(TCGContext *s, int ext, TCGReg rd, TCGReg rm) +{ +/* using REV 0x5ac00800 */ +unsigned int base = ext ? 0xdac00c00 : 0x5ac00800; +tcg_out32(s, base | rm 5 |

Re: [Qemu-devel] broken incoming migration

2013-06-03 Thread Alexey Kardashevskiy
On 05/31/2013 12:38 AM, Peter Lieven wrote: Am 30.05.2013 um 15:41 schrieb Paolo Bonzini pbonz...@redhat.com: Il 30/05/2013 11:08, Peter Lieven ha scritto: Am 30.05.2013 10:18, schrieb Alexey Kardashevskiy: On 05/30/2013 05:49 PM, Paolo Bonzini wrote: Il 30/05/2013 09:44, Alexey

[Qemu-devel] [PATCH 3/7] pci: add VMSTATE_MSIX

2013-06-03 Thread Gerd Hoffmann
Using a trick cut+pasted from vmstate_scsi_device to wind up msix_save and msix_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/msix.c | 33 + include/hw/pci/msix.h | 11 +++ 2 files

[Qemu-devel] [PATCH 4/7] xhci: add XHCISlot-addressed

2013-06-03 Thread Gerd Hoffmann
Preparing for live-migration support, post_load will need that. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8813bdf..ac683ce 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PULL 0/7] usb patch queue

2013-06-03 Thread Gerd Hoffmann
Hi, Here is the usb patch queue, bringing two little bug fixes and live migration support for xhci. cheers, Gerd The following changes since commit f10acc8b38d65a66ffa0588a036489d7fa6a593e: tcx: Fix 24-bit display mode (2013-06-02 16:45:40 +) are available in the git repository at:

[Qemu-devel] [PATCH 1/7] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-06-03 Thread Gerd Hoffmann
From: Michael Marineau m...@marineau.org USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a Fitbit Base Station USB dongle was triggering this assert. Signed-off-by: Michael Marineau m...@marineau.org Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 5/7] xhci: add xhci_alloc_epctx

2013-06-03 Thread Gerd Hoffmann
Factor out endpoint context allocation to a separate function. xhci live migration will need that too, in post_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH 2/7] host-libusb: Correct test for USB packet state

2013-06-03 Thread Gerd Hoffmann
From: Ed Maste ema...@freebsd.org USB_RET_ASYNC is -6, so inflight was always false. Signed-off-by: Ed Maste ema...@freebsd.org Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 6/7] xhci: add xhci_init_epctx

2013-06-03 Thread Gerd Hoffmann
Factor out endpoint context initialization to a separate function. xhci live migration will need that too, in post_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-)

[Qemu-devel] [PATCH 7/7] xhci: add live migration support

2013-06-03 Thread Gerd Hoffmann
With all preparing pieces in place we can finally drop in the vmstate structs and the postload function. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 164 - 1 file changed, 163 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 11:58, Peter Maydell ha scritto: On 3 June 2013 10:40, Paolo Bonzini pbonz...@redhat.com wrote: Il 03/06/2013 11:22, Peter Maydell ha scritto: arm11mpcore.c does this: sysbus_init_mmio(dev, sysbus_mmio_get_region(s-priv, 0)); which I suspect will assert with your patches.

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-06-03 Thread Andreas Färber
Am 03.06.2013 09:31, schrieb Paolo Bonzini: Il 01/06/2013 17:28, Blue Swirl ha scritto: This means that memory.c is getting knowledge about CPU types and it becomes more specific to current target. I think memory.c should be generic and target agnostic (maybe one day compiled just once) with

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Peter Maydell
On 3 June 2013 11:12, Paolo Bonzini pbonz...@redhat.com wrote: 1) I could set the owner to NULL before calling the sysbus_init_mmio; 2) I could add a variant of sysbus_init_mmio that doesn't set the owner; 3) I could skip setting the owner for sysbus altogether, since it is only strictly

Re: [Qemu-devel] [PATCH] net: tap: fix NULL dereference when passing both fd and vhostfds to tap

2013-06-03 Thread Laszlo Ersek
comments below On 06/03/13 11:04, Jason Wang wrote: This is because vhostfdname were passed as NULL to net_init_tap_one() when vhostfd were not specified, but net_init_tap_one() will still pass it to monitor_handle_fd_param() when tap-has_vhostfds is true. Since file descriptor (fd,

Re: [Qemu-devel] [PATCH 14/15] memory: return MemoryRegion from qemu_ram_addr_from_host

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 08:40, Paolo Bonzini ha scritto: Il 02/06/2013 18:04, Peter Maydell ha scritto: On 2 June 2013 16:43, Paolo Bonzini pbonz...@redhat.com wrote: -int qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); +MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr);

Re: [Qemu-devel] [PATCH 00/15] Memory/IOMMU patches part 4: region ownership

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 12:25, Peter Maydell ha scritto: On 3 June 2013 11:12, Paolo Bonzini pbonz...@redhat.com wrote: 1) I could set the owner to NULL before calling the sysbus_init_mmio; 2) I could add a variant of sysbus_init_mmio that doesn't set the owner; 3) I could skip setting the owner for

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-06-03 Thread Thomas Schwinge
Hi! On Fri, 31 May 2013 15:45:55 +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 31 May 2013 14:01, Thomas Schwinge tho...@codesourcery.com wrote: On Fri, 31 May 2013 13:34:12 +0100, Peter Maydell peter.mayd...@linaro.org wrote: That said, I think any new patches to fpu/ need to

Re: [Qemu-devel] [PATCH] linux-user: Allow getdents to be provided by getdents64

2013-06-03 Thread Laurent Vivier
Tested on m68k on x86_64 as described in the patch comment, in a a debian-etch linux container. Works fine, except the drec_len differs between getdents() and getdents64(). See comment below. Le 2 juin 2013 à 19:10, Peter Maydell peter.mayd...@linaro.org a écrit : Newer architectures may

Re: [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-06-03 Thread Jani Kokkonen
On 5/31/2013 10:25 PM, Richard Henderson wrote: On 05/31/2013 11:07 AM, Jani Kokkonen wrote: +/* Load and compare a TLB entry, leaving the flags set. Leaves X2 pointing + to the tlb entry. Clobbers X0,X1,X2,X3 and TMP. */ + +static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, +

Re: [Qemu-devel] [PATCH] linux-user: Allow getdents to be provided by getdents64

2013-06-03 Thread Peter Maydell
On 3 June 2013 12:11, Laurent Vivier laur...@vivier.eu wrote: Tested on m68k on x86_64 as described in the patch comment, in a a debian-etch linux container. Works fine, except the drec_len differs between getdents() and getdents64(). Le 2 juin 2013 à 19:10, Peter Maydell

Re: [Qemu-devel] [PATCH] linux-user: Allow getdents to be provided by getdents64

2013-06-03 Thread Laurent Vivier
I agree with all your comments. Tested-by: Laurent Vivier laur...@vivier.eu Reviewed-by: Laurent Vivier laur...@vivier.eu Le 3 juin 2013 à 13:28, Peter Maydell peter.mayd...@linaro.org a écrit : On 3 June 2013 12:11, Laurent Vivier laur...@vivier.eu wrote: Tested on m68k on x86_64 as

Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-06-03 Thread Michael S. Tsirkin
On Fri, May 31, 2013 at 02:12:48PM -0400, Cole Robinson wrote: 'default_backend' isn't always set, but 'rng' is, so use that. $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 Segmentation fault (core dumped) Regressed

Re: [Qemu-devel] [PATCH] correct RTC_CHANGE_EVENT description

2013-06-03 Thread Luiz Capitulino
On Fri, 31 May 2013 15:24:03 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Applied to the qmp branch, thanks. diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-03 Thread Eric Blake
On 06/01/2013 02:09 PM, Peter Cheung wrote: i start my qemu by this ~/qemu/bin/qemu-system-x86_64 -hda hd10meg.img -gdb tcp::1234 -k en-us -S -m 256m it was working before, but not for the latest code. When i use GDB to connect to it, it show up a warning message and i was unable to start

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-06-03 Thread Luiz Capitulino
On Mon, 3 Jun 2013 09:12:55 + Libaiqing libaiq...@huawei.com wrote: Hi, Thanks for your advice,it works well when using prefix=x86_64-w64-mingw32-. The dlls may download from here: http://qemu.weilnetz.de/w64/dll/. One more question: Qemu-ga.exe can't run successfully

Re: [Qemu-devel] [PATCH 2/3] ivshmem: add missing error exit(2)

2013-06-03 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1) with error returns in the PCI device .init() function, but leave

Re: [Qemu-devel] [PATCH v1 0/3] Memory: Trivial fixes

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 07:31, peter.crosthwa...@xilinx.com ha scritto: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some trivial fixes to memory API. Peter Crosthwaite (3): memory: Fix comment typo memory: as_update_topology_pass: Improve comments memory: render_memory_region:

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-03 Thread Eric Blake
On 06/03/2013 02:58 AM, Stefan Hajnoczi wrote: If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1) with error returns in the PCI device .init() function, but

Re: [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo

2013-06-03 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The copied code comes from vhost_scsi_start. Spotted by Coverity. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Same as Stefan's [PATCH 1/3] vhost-scsi: fix k-set_guest_notifiers() NULL dereference

Re: [Qemu-devel] [PATCH trivial] acpi: actually require either data= or file= for -acpitable

2013-06-03 Thread Eric Blake
On 06/03/2013 03:20 AM, Michael Tokarev wrote: Initially the code ensured that we have exactly one of data= or file= option for -acpitable. But after some transformations, the condition becomes if (has_data == has_file) { error } to mean, probably, that both should not be set at the

Re: [Qemu-devel] [PATCH trivial] acpi: actually require either data= or file= for -acpitable

2013-06-03 Thread Michael Tokarev
03.06.2013 16:34, Eric Blake wrote: On 06/03/2013 03:20 AM, Michael Tokarev wrote: Initially the code ensured that we have exactly one of data= or file= option for -acpitable. But after some transformations, the condition becomes if (has_data == has_file) { error } to mean, probably,

[Qemu-devel] [PATCH] qemu-doc, help: update options/keys for GTK/SDL

2013-06-03 Thread Peter Wu
The GTK display type has been introduced in 1.5, replacing SDL as default. Some options only work with SDL and not GTK. This patch tries to address them. The `-display` option is updated with the new `gtk` option. The `-alt-grab` and `-ctrl-alt` options are not possible in GTK according to

[Qemu-devel] [Bug 1186935] [NEW] [1.5] QEMU monitor gets overlapped by GTK menu bar

2013-06-03 Thread Lekensteyn
Public bug reported: The QEMU minitor gets partially hidden by the menu bar which was introduced in QEMU version 1.5.0. Steps to reproduce: 1. Run `qemu-system-x86_64` 2. Press Ctrl + Alt + 2 (or use the menu bar) 3. Observe that the monitor output is partially shown, without the

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-03 Thread Stefan Hajnoczi
On Mon, Jun 03, 2013 at 06:26:22AM -0600, Eric Blake wrote: On 06/03/2013 02:58 AM, Stefan Hajnoczi wrote: If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1)

Re: [Qemu-devel] [Xen-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu, just like unplug the ide disk?

2013-06-03 Thread Konrad Rzeszutek Wilk
On Thu, May 30, 2013 at 11:23:44AM +, Gonglei (Arei) wrote: Hi all, My environment is xen-4.1.2 + qemu-1.2.2 I made a pvscsi driver for Redhat guest, but I encountered a problem that I could see two scsi disks, one was simulated by QEMU, another was passthrough. Actually

Re: [Qemu-devel] [Xen-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu, just like unplug the ide disk?

2013-06-03 Thread Gonglei (Arei)
-Original Message- From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] Sent: Monday, June 03, 2013 9:16 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Luonengjun; Jinwenwu Subject: Re: [Xen-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu,

[Qemu-devel] [PATCH 0/4] aarch64 TCG tlb fast lookup prerequisites

2013-06-03 Thread Claudio Fontana
This series is a split of: [PATCH 0/4] ARM aarch64 TCG tlb fast lookup http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg04803.html It implements the low level operations that are necessary in order to implement the tlb fast lookup, which will be a separate series. It requires the

[Qemu-devel] [PATCH 1/4] tcg/aarch64: improve arith shifted regs operations

2013-06-03 Thread Claudio Fontana
for arith operations, add SUBS, ANDS, ADDS and add a shift parameter so that all arith instructions can make use of shifted registers. Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- tcg/aarch64/tcg-target.c | 46 +- 1 file changed, 29

[Qemu-devel] [PATCH 3/4] tcg/aarch64: implement byte swap operations

2013-06-03 Thread Claudio Fontana
implement the optional byte swap operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- tcg/aarch64/tcg-target.c | 32 tcg/aarch64/tcg-target.h | 10 +- 2 files changed, 37 insertions(+), 5

[Qemu-devel] [PATCH 2/4] tcg/aarch64: implement AND/TEST immediate pattern

2013-06-03 Thread Claudio Fontana
add functions to AND/TEST registers with immediate patterns. Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- tcg/aarch64/tcg-target.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index

[Qemu-devel] [PATCH 4/4] tcg/aarch64: implement sign/zero extend operations

2013-06-03 Thread Claudio Fontana
implement the optional sign/zero extend operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- tcg/aarch64/tcg-target.c | 58 ++-- tcg/aarch64/tcg-target.h | 20 - 2 files

[Qemu-devel] [Bug 1186984] Re: large -initrd crashes qemu

2013-06-03 Thread Richard Jones
I'm using qemu from git (f10acc8b38d65a66ffa0588a036489d7fa6a593e). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1186984 Title: large -initrd crashes qemu Status in QEMU: New Bug description:

[Qemu-devel] [Bug 1186984] [NEW] large -initrd crashes qemu

2013-06-03 Thread Richard Jones
Public bug reported: We don't use large -initrd in libguestfs any more, but I noticed that a large -initrd file now crashes qemu spectacularly: $ ls -lh /tmp/kernel /tmp/initrd -rw-r--r--. 1 rjones rjones 273M Jun 3 14:02 /tmp/initrd lrwxrwxrwx. 1 rjones rjones 35 Jun 3 14:02 /tmp/kernel -

Re: [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 14:27, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: The copied code comes from vhost_scsi_start. Spotted by Coverity. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Same as Stefan's [PATCH 1/3] vhost-scsi: fix

[Qemu-devel] [PATCH v2 0/7] target-arm: cpregs list for migration, kvm reset

2013-06-03 Thread Peter Maydell
This patch series overhauls how we handle ARM coprocessor registers, so that we use a consistent approach for migration, reset and QEMU-KVM synchronisation, driven by the kernel's list of supported registers. The basic principle here is that we trust the kernel's list of what registers it knows

[Qemu-devel] [PATCH v2] MAINTAINERS: add tcg/aarch64 maintainer

2013-06-03 Thread Claudio Fontana
Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be02724..f4836f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -745,6 +745,12 @@ M: qemu-devel@nongnu.org S: Maintained F: tcg/

[Qemu-devel] [PATCH v2 3/7] target-arm: mark up cpregs for no-migrate or raw access

2013-06-03 Thread Peter Maydell
Mark up coprocessor register definitions to add raw access functions or mark the register as non-migratable where necessary. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.c | 140 ++- 1 file changed, 94 insertions(+),

[Qemu-devel] [PATCH v2 6/7] target-arm: Reinitialize all KVM VCPU registers on reset

2013-06-03 Thread Peter Maydell
Since the ARM KVM API doesn't include a reset this VCPU ioctl, we have to capture the initial values of every register it knows about so that we can reset the VCPU by feeding those values back again. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu-qom.h |6 +-

[Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-03 Thread Bas van Sisseren
reorder slirp config options. first check the dns-server-address, then check the first-dhcp-address. the original code was comparing the first-dhcp-address with the default dns-server-address, not the configured dns-server-address. Signed-off-by: Bas van Sisseren b...@quarantainenet.nl ---

[Qemu-devel] [PULL 1/1] Fix rfe instruction

2013-06-03 Thread Peter Maydell
From: Peter Chubb peter.ch...@nicta.com.au The rfe instruction has been broken since patch 5a839c0d54fac9db0516904db873a4fe01f50f4b because of a typo. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 0/4] aarch64 TCG tlb fast lookup prerequisites

2013-06-03 Thread Richard Henderson
On 06/03/2013 06:23 AM, Claudio Fontana wrote: Changes from the original series: * added ADDS and ANDS to the shifted regs ops, reorder * split shifted regs ops and test/and immediate into 2 patches * for byte swapping, remove REV32, we can just use REV * fix broken comment in tcg_out_uxt

[Qemu-devel] [PATCH v2 1/7] target-arm: Allow special cpregs to have flags set

2013-06-03 Thread Peter Maydell
Relax the is this a valid ARMCPRegInfo type value? check to permit special cpregs to have flags other than ARM_CP_SPECIAL set. At the moment none of the other flags are relevant for special regs, but the migration related flag we're about to introduce can apply here too. Signed-off-by: Peter

[Qemu-devel] [PATCH] MAINTAINERS: add tcg/aarch64 maintainer

2013-06-03 Thread Claudio Fontana
Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be02724..f4836f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -745,6 +745,12 @@ M: qemu-devel@nongnu.org S: Maintained F: tcg/

[Qemu-devel] [PATCH v2 7/7] target-arm: Use tuple list to sync cp regs with KVM

2013-06-03 Thread Peter Maydell
Use the tuple list of cp registers for syncing KVM state to QEMU, rather than only syncing a very minimal set by hand. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/kvm.c | 103 +- 1 file changed, 33 insertions(+), 70

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-06-03 Thread Richard Henderson
On 06/02/2013 10:15 AM, Peter Maydell wrote: So for a new architecture how do we determine whether we need to fiddle with the start address or not? (More specifically, is aarch64 going to need a linker script or just to go in the configure list of hosts which don't need one ?) Basically, for

[Qemu-devel] [PULL 0/1] target-arm queue

2013-06-03 Thread Peter Maydell
Only one change in this pullreq, but I'm going away for a week and I think the bugfix is worth getting into master before then. Please pull. thanks -- PMM The following changes since commit f10acc8b38d65a66ffa0588a036489d7fa6a593e: tcx: Fix 24-bit display mode (2013-06-02 16:45:40 +) are

Re: [Qemu-devel] [PATCH 1/4] tcg-ppc64: Fix RLDCL opcode

2013-06-03 Thread Richard Henderson
On 06/02/2013 05:27 AM, Anton Blanchard wrote: The rldcl instruction doesn't have an sh field, so the minor opcode of 8 is actually 4 when using the XO30 macro. Cc: qemu-sta...@nongnu.org Signed-off-by: Anton Blanchard an...@samba.org --- Index: b/tcg/ppc64/tcg-target.c

Re: [Qemu-devel] [PATCH 2/4] tcg-ppc64: bswap64 rotates output 32 bits

2013-06-03 Thread Richard Henderson
On 06/02/2013 05:28 AM, Anton Blanchard wrote: If our input and output is in the same register, bswap64 tries to undo a rotate of the input. This just ends up rotating the output. Cc: qemu-sta...@nongnu.org Signed-off-by: Anton Blanchard an...@samba.org Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 3/4] tcg-ppc64: Fix add2_i64

2013-06-03 Thread Richard Henderson
On 06/02/2013 05:29 AM, Anton Blanchard wrote: add2_i64 was adding the lower double word to the upper double word of each input. Fix this so we add the lower double words, then the upper double words with carry propagation. Cc: qemu-sta...@nongnu.org Signed-off-by: Anton Blanchard

Re: [Qemu-devel] [PATCH 4/4] tcg-ppc64: rotr_i32 rotates wrong amount

2013-06-03 Thread Richard Henderson
On 06/02/2013 05:30 AM, Anton Blanchard wrote: rotr_i32 calculates the amount to left shift and puts it into a temporary, but then doesn't use it when doing the shift. Cc: qemu-sta...@nongnu.org Signed-off-by: Anton Blanchard an...@samba.org --- Reviewed-by: Richard Henderson

[Qemu-devel] Biweekly upstream qemu-kvm test report (using autotest + manual) - June 3rd, 2013

2013-06-03 Thread chandrashekar shastri
Hi, Please find the result of upstream testing, we ran the test cases against following git versions: Host kernel 3.9.0+ (Upstream), Base Kernel is RHEL 7 Alpha 3 x86_64 v3.9-10518-gd7ab73 Branch master SHA1 d7ab7302f970a254997687a1cdede421a5635c68 uname -a Linux localhost.localdomain

[Qemu-devel] [PATCH v2 2/7] target-arm: Add raw_readfn and raw_writefn to ARMCPRegInfo

2013-06-03 Thread Peter Maydell
For reading and writing register values from the kernel for KVM, we need to provide accessor functions which are guaranteed to succeed and don't impose access checks, mask out unwritable bits, etc. Define new fields raw_readfn and raw_writefn for this purpose; these only need to be provided if

[Qemu-devel] [PATCH v2 5/7] target-arm: Initialize cpreg list from KVM when using KVM

2013-06-03 Thread Peter Maydell
When using KVM, use the kernel's initial state to set up the cpreg list, and sync to and from the kernel when doing migration. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/Makefile.objs |1 + target-arm/kvm-stub.c| 23 +++ target-arm/kvm.c | 164

[Qemu-devel] [Bug 1186935] Re: [1.5] QEMU monitor gets overlapped by GTK menu bar

2013-06-03 Thread Anthony Liguori
What version of gtk is this? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1186935 Title: [1.5] QEMU monitor gets overlapped by GTK menu bar Status in QEMU: New Bug description: The QEMU

  1   2   3   >