Re: [Qemu-devel] [PATCH v3 11/11] tcg: Merge tb_find_slow() and tb_find_fast()

Sergey Fedorov writes: > From: Sergey Fedorov > > These functions are not too big and can be merged together. This makes > locking scheme more clear and easier to follow. > > Signed-off-by: Sergey Fedorov > Signed-off-by:

[Qemu-devel] [PATCH v4 03/11] block: Accept node-name for blockdev-backup

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an

Re: [Qemu-devel] [PATCH v3 04/11] tcg: Prepare safe access to tb_flushed out of tb_lock

On 14/07/16 15:45, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> Ensure atomicity of CPU's 'tb_flushed' access for future translation >> block lookup out of 'tb_lock'. >> >> This field can only be touched from another

[Qemu-devel] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t

We keep here the sum of int fields. Thus this could easily overflow, especially when we will start sending big requests in next patches. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

Re: [Qemu-devel] [RFC 1/2] linux-user: Don't leak cpus on thread exit

On Thu, Jul 14, 2016 at 10:52:48AM +0100, Peter Maydell wrote: > On 14 July 2016 at 08:57, David Gibson wrote: > > Currently linux-user does not correctly clean up CPU instances properly > > when running a threaded binary. > > > > On thread exit, do_syscall() removes

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

On 14/07/16 15:53, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> These functions will be used to make translation block invalidation safe >> with concurrent lockless lookup in the global hash table. >> >> Most targets

Re: [Qemu-devel] [PATCH v9 08/17] qapi: Plumb in 'boxed' to qapi generator lower levels

Eric Blake writes: > The next patch will add support for passing a qapi union type > as the 'data' of a command. But to do that, the user function > for implementing the command, as called by the generated > marshal command, must take the corresponding C struct as a > single

Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb

On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote: > Added support for sending data larger than 4gb. > Also implemented > object properties so that Windows can receive >4gb files. Can you please split those into two separate patches? > +case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER: > +

Re: [Qemu-devel] [PATCH v9 0/7] trace: Per-vCPU tracing states

Stefan Hajnoczi writes: > On Mon, Jul 11, 2016 at 12:53:19PM +0200, Lluís Vilanova wrote: >> NOTE: This series applies on top of "trace: [*-user] Add commandline >> arguments >> to control tracing". [...] > Thanks, applied to my tracing tree: > https://github.com/stefanha/qemu/commits/tracing

[Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

Add a qmp_mixed_input_visitor_new() method which returns a QMP input visitor that accepts either strings or the native data types. Signed-off-by: Daniel P. Berrange --- NB, just a demo - this should have tests added before submitting for real.

Re: [Qemu-devel] [PATCH v5 04/15] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion

On 07/04/2016 06:28 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Since the function became use a vector instead of a buffer there is no > sense to use a recursive code. Grammar suggestion: Now that the function uses a vector instead of a buffer, there is no

Re: [Qemu-devel] [PATCH v9 16/17] qapi: Tweak QmpInputVisitor to optionally do string conversion

On Thu, Jul 14, 2016 at 06:43:16AM -0600, Eric Blake wrote: > On 07/14/2016 02:04 AM, Daniel P. Berrange wrote: > > On Wed, Jul 13, 2016 at 09:50:27PM -0600, Eric Blake wrote: > >> Currently the QmpInputVisitor assumes that all scalar > >> values are directly represented as their final types. > >>

Re: [Qemu-devel] [PATCH v3 07/11] tcg: Prepare TB invalidation for lockless TB lookup

On 14/07/16 15:59, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> When invalidating a translation block, set an invalid CPU state into the >> TranslationBlock structure first. All subsequent changes are ordered >>

[Qemu-devel] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend

The builtin NBD server uses its own BlockBackend now instead of reusing the monitor/guest device one. This means that it has its own writethrough setting now. The builtin NBD server always uses writeback caching now regardless of whether the guest device has WCE enabled. qemu-nbd respects the

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

Sergey Fedorov writes: > From: Sergey Fedorov > > These functions will be used to make translation block invalidation safe > with concurrent lockless lookup in the global hash table. > > Most targets don't use 'cs_base'; so marking TB as invalid

[Qemu-devel] [PATCH v4 01/11] block: Accept node-name for block-stream

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-stream to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the

[Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout

On a slower machine the test can take more than 30 seconds. Increase the timeout to 100 seconds. Signed-off-by: Marcel Apfelbaum --- tests/prom-env-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c index

[Qemu-devel] [PATCH v8 6/7] util: add QAuthZSimple object type for a simple access control list

Add a QAuthZSimple object type that implements the QAuthZ interface. This simple built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the functionality currently provided by the qemu_acl module. To create an

Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events

Eric Blake writes: > Turn on the ability to pass command and event arguments in > a single boxed parameter, which must name a non-empty type > (although the type can be a struct with all optional members). > For structs, it makes it possible to pass a single qapi type >

Re: [Qemu-devel] [PATCH v3 10/19] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug()

On Thu, 14 Jul 2016 12:03:19 -0300 Eduardo Habkost wrote: > On Thu, Jul 14, 2016 at 11:18:36AM +0200, Igor Mammedov wrote: > > On Wed, 13 Jul 2016 20:37:13 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, Jul 13, 2016 at 06:59:21PM -0400, Bandan

Re: [Qemu-devel] [PATCH v4 0/6] virtio: Merge virtio-{blk, scsi} host notifier handling paths

On Wed, Jul 13, 2016 at 12:32:59PM +0200, Paolo Bonzini wrote: > On 13/07/2016 07:09, Fam Zheng wrote: > > v4: Drop patch 1. [Cornelia] > > Add the last trivial patch. > > > > v3: Rebase to master. > > Squash 4 into 3. [Paolo] > > Add comment and commit message. [Stefan] > > Add

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/6] Auto-fragment large transactions at the block layer

On Fri, Jul 08, 2016 at 04:35:58PM -0600, Eric Blake wrote: > We have max_transfer documented in BlockLimits, but while we > honor it during pwrite_zeroes, we were blindly ignoring it > during pwritev and preadv, leading to multiple drivers having > to implement fragmentation themselves. This

[Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

replace tab with spaces Signed-off-by: Cao jin --- async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/async.c b/async.c index 1f9754b..8589017 100644 --- a/async.c +++ b/async.c @@ -217,7 +217,7 @@ aio_ctx_check(GSource *source) for (bh =

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On Jun 10 12:16, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use the avx2 primitives during the test, thus making sure that the > compiler and assembler could actually use avx2. > > This also detects the failure case on gcc 4.8.x with

[Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts change-backing-file to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

On Thu, Jul 14, 2016 at 03:50:56PM +0530, Bharata B Rao wrote: > On Thu, Jul 14, 2016 at 3:24 PM, Peter Maydell > wrote: > > On 14 July 2016 at 08:57, David Gibson wrote: > >> With CONFIG_USER_ONLY, generation of cpu_index values is done

[Qemu-devel] [PATCH 3/7] hw/mips: fix PCI bus initialization

Delay the host-bridge 'realization' until the PCI root bus is attached. Signed-off-by: Marcel Apfelbaum --- hw/mips/gt64xxx_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 3f4523d..4811843 100644

[Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an

Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement

On 07/14/2016 02:14 AM, Thomas Huth wrote: > No need to include error-report.h twice here. > > Signed-off-by: Thomas Huth > --- > target-ppc/mmu-hash64.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Eric Blake Markus, do your header cleanup scripts

[Qemu-devel] [PATCH v8 5/7] util: add QAuthZ object as an authorization base class

The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server) were expected to create ACLs

Re: [Qemu-devel] [PULL 00/14] SCSI, chardev, build fixes for 2016-07-13

On 13 July 2016 at 14:26, Paolo Bonzini wrote: > The following changes since commit a91a4e7d8cfe6ece610aacf7c52738188f5b5cb5: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into > staging (2016-07-11 15:08:47 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On Jul 14 14:23, Peter Maydell wrote: > On 14 July 2016 at 14:15, Paolo Bonzini wrote: > > On 14/07/2016 15:13, Aaron Lindsay wrote: > >> I'm configuring with: > >> # ./configure \ > >> --static \ > >> --disable-gtk \ > >> --target-list=aarch64-softmmu > > >

Re: [Qemu-devel] [PATCH v3 3/8] mirror: create mirror_throttle helper

On 07/14/2016 07:33 AM, Denis V. Lunev wrote: > The patch also places last_pause_ns from stack in mirror_run into > MirrorBlockJob structure. This helper will be useful in next patches. > > Signed-off-by: Denis V. Lunev > CC: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PULL 03/36] hw/pci: delay bus_master_enable_region initialization

On 07/11/2016 09:41 PM, Mark Cave-Ayland wrote: On 11/07/16 16:18, Marcel Apfelbaum wrote: On 07/11/2016 05:42 PM, Leon Alrae wrote: Hi, This commit causes regressions in my MIPS tests. QEMU segfaults when booting Linux on Malta board; Hi Leon, Is a good thing you caught it in the pull

Re: [Qemu-devel] [PATCH v3 04/11] tcg: Prepare safe access to tb_flushed out of tb_lock

Sergey Fedorov writes: > From: Sergey Fedorov > > Ensure atomicity of CPU's 'tb_flushed' access for future translation > block lookup out of 'tb_lock'. > > This field can only be touched from another thread by tb_flush() in user > mode

Re: [Qemu-devel] [RFC 1/2] linux-user: Don't leak cpus on thread exit

On Thu, 14 Jul 2016 22:02:36 +1000 David Gibson wrote: > On Thu, Jul 14, 2016 at 10:52:48AM +0100, Peter Maydell wrote: > > On 14 July 2016 at 08:57, David Gibson wrote: > > > > > Currently linux-user does not correctly clean up CPU

Re: [Qemu-devel] [PATCH v3 04/11] tcg: Prepare safe access to tb_flushed out of tb_lock

Sergey Fedorov writes: > On 14/07/16 15:45, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> From: Sergey Fedorov >>> >>> Ensure atomicity of CPU's 'tb_flushed' access for future translation >>> block lookup out of

[Qemu-devel] [PATCH v4 09/11] block: Accept node-name for drive-mirror

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the

[Qemu-devel] [PULL v2 0/1] updated fw_cfg option ROM 2016-07-13

The following changes since commit a91a4e7d8cfe6ece610aacf7c52738188f5b5cb5: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-07-11 15:08:47 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream-fwcfg for

[Qemu-devel] [PATCH 6/7] hw/prep: realize the PCI root bus as part of the prep init

'Realize' the PCI root bus manually since the 'realize' mechanism does not propagate to child devices yet. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/prep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 487e32e..5580293

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

On 14/07/16 16:56, Paolo Bonzini wrote: > > On 13/07/2016 19:50, Sergey Fedorov wrote: >> On 13/07/16 10:36, Paolo Bonzini wrote: >>> On 13/07/2016 01:19, Emilio G. Cota wrote: I wouldn't put those comments in the source--seqlock callers should know what they're doing, and what barriers

[Qemu-devel] [PATCH 4/7] hw/apb: fix PCI bus initialization

Create and connect the PCI root bus to the host bridge before the later is 'realized'. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/apb.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index

Re: [Qemu-devel] [PATCH v3 10/19] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug()

On Thu, Jul 14, 2016 at 11:18:36AM +0200, Igor Mammedov wrote: > On Wed, 13 Jul 2016 20:37:13 -0300 > Eduardo Habkost wrote: > > > On Wed, Jul 13, 2016 at 06:59:21PM -0400, Bandan Das wrote: > > > Eduardo Habkost writes: > > > > > > > On Wed, Jul 13,

Re: [Qemu-devel] [PATCH v4 01/11] block: Accept node-name for block-stream

On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-stream to accept a node-name without lifting the restriction that > we're operating at a root node. > > In

Re: [Qemu-devel] [PATCH v3] aio-posix: remove useless parameter

On 07/14/2016 06:57 AM, Cao jin wrote: > Parameter **errp of aio_context_setup() is useless, remove it > and clean up the related code. > > Cc: Stefan Hajnoczi > Cc: Fam Zheng > Cc: Eric Blake > Signed-off-by: Cao jin

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On 14 July 2016 at 15:27, Aaron Lindsay wrote: > On Jul 14 14:23, Peter Maydell wrote: >> On 14 July 2016 at 14:15, Paolo Bonzini wrote: >> > On 14/07/2016 15:13, Aaron Lindsay wrote: >> >> I'm configuring with: >> >> # ./configure \ >> >>

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

On Thu, Jun 23, 2016 at 04:36:59PM -0700, Matthew Garrett wrote: > Trusted Boot is based around having a trusted store of measurement data and a > secure communications channel between that store and an attestation target. In > actual hardware, that's a TPM. Since the TPM can only be accessed via

Re: [Qemu-devel] [PATCH v3 10/11] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump()

Sergey Fedorov writes: > From: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Much better than my

Re: [Qemu-devel] [PULL 0/1] updated fw_cfg option ROM 2016-07-13

On 14/07/2016 14:43, Peter Maydell wrote: > On 13 July 2016 at 13:55, Paolo Bonzini wrote: >> The following changes since commit a91a4e7d8cfe6ece610aacf7c52738188f5b5cb5: >> >> Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into >> staging

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

Paolo Bonzini writes: > On 14/07/2016 14:02, Alex Bennée wrote: >> Looking at the perf data it looks like the hotest part of the code now >> is cpu_get_tb_cpu_state which is required to get the initial hash to >> search for the next tb. > > It should be possible to keep the

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On 14 July 2016 at 14:15, Paolo Bonzini wrote: > On 14/07/2016 15:13, Aaron Lindsay wrote: >> I'm configuring with: >> # ./configure \ >> --static \ >> --disable-gtk \ >> --target-list=aarch64-softmmu > Hmm, it's possible that we have to disable ifunc

[Qemu-devel] [PATCH v4 11/11] nbd-server: Allow node name for nbd-server-add

There is no reason why an NBD server couldn't be started for any node, even if it's not on the top level. This converts nbd-server-add to accept a node-name. Note that there is a semantic difference between using a BlockBackend name and the node name of its root: In the former case, the NBD

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

* Aaron Lindsay (alind...@codeaurora.org) wrote: > On Jun 10 12:16, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Use the avx2 primitives during the test, thus making sure that the > > compiler and assembler could actually use avx2. > > > >

Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

On 07/14/2016 07:10 AM, Cao jin wrote: > replace tab with spaces > > Signed-off-by: Cao jin > --- > async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Whitespace-only changes are best done as part of a series that is already touching nearby code for other

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: > Add a qmp_mixed_input_visitor_new() method which returns > a QMP input visitor that accepts either strings or the > native data types. > > Signed-off-by: Daniel P. Berrange > --- > > NB, just a demo - this should have

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

* Aaron Lindsay (alind...@codeaurora.org) wrote: > On Jul 14 14:33, Dr. David Alan Gilbert wrote: > > * Aaron Lindsay (alind...@codeaurora.org) wrote: > > > I'm configuring with: > > > # ./configure \ > > > --static \ > > > --disable-gtk \ > > > --target-list=aarch64-softmmu > > > > Does

Re: [Qemu-devel] [RFC v2 08/11] linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()

Sergey Fedorov writes: > From: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > --- > linux-user/main.c | 10 ++ > 1 file changed, 10 insertions(+)

Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement

On 14.07.2016 16:32, Eric Blake wrote: > On 07/14/2016 02:14 AM, Thomas Huth wrote: >> No need to include error-report.h twice here. >> >> Signed-off-by: Thomas Huth >> --- >> target-ppc/mmu-hash64.c | 1 - >> 1 file changed, 1 deletion(-) > > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout

On 07/14/2016 04:51 PM, Thomas Huth wrote: On 14.07.2016 15:43, Marcel Apfelbaum wrote: On a slower machine the test can take more than 30 seconds. Increase the timeout to 100 seconds. Signed-off-by: Marcel Apfelbaum --- tests/prom-env-test.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [Qemu-block] [PATCH v2] aio-posix: remove useless parameter

On Wed, Jul 13, 2016 at 10:26:13AM +0800, Cao jin wrote: > -void aio_context_setup(AioContext *ctx, Error **errp) > +void aio_context_setup(AioContext *ctx) > { > #ifdef CONFIG_EPOLL_CREATE1 > assert(!ctx->epollfd); > ctx->epollfd = epoll_create1(EPOLL_CLOEXEC); > if (ctx->epollfd

Re: [Qemu-devel] [virtio-dev][RFC v2 1/2] content: reserve virtio device ID

On Tue, Jun 28, 2016 at 01:03:43PM +0200, Christian Pinto wrote: > Signed-off-by: Christian Pinto > Signed-off-by: Baptiste Reynal > > --- > v1 -> v2: > - removed edit including virtio-sdm specs text > --- > content.tex | 2 ++ >

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On 14/07/2016 15:13, Aaron Lindsay wrote: > On Jun 10 12:16, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Use the avx2 primitives during the test, thus making sure that the >> compiler and assembler could actually use avx2. >> >> This also

[Qemu-devel] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap

All .bdrv_co_write_zeroes callbacks nowadays work perfectly even with backing store attached. If future new callbacks would be unable to do that - they have a chance to block this in bdrv_get_info(). Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount

Underlying HBitmap operates even with uint64_t. Thus this change is safe. This would be useful f.e. to mark entire bitmap dirty in one call. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[Qemu-devel] [PATCH 2/7] hw/alpha: fix PCI bus initialization

Delay the host-bridge 'realization' until the PCI root bus is attached. Signed-off-by: Marcel Apfelbaum --- hw/alpha/typhoon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 97721b5..883db13 100644 ---

[Qemu-devel] [PATCH v3 7/8] mirror: efficiently zero out target

With a bdrv_co_write_zeroes method on a target BDS and when this method is working as indicated by the bdrv_can_write_zeroes_with_unmap(), zeroes will not be placed into the wire. Thus the target could be very efficiently zeroed out. This should be done with the largest chunk possible.

[Qemu-devel] [PATCH v8 3/7] qapi: add a QmpInputVisitor that does string conversion

Currently the QmpInputVisitor assumes that all scalar values are directly represented as their final types. ie it assumes an 'int' is using QInt, and a 'bool' is using QBool. This adds an alternative constructor for QmpInputVisitor that will set it up such that it expects a QString for all scalar

[Qemu-devel] [PATCH 7/7] hw/versatile: realize the PCI root bus as part of the versatile init

'Realize' the PCI root bus manually since the 'realize' mechanism does not propagate to child devices yet. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/versatile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index

[Qemu-devel] [PATCH v8 2/7] option: make parse_option_bool/number non-static

The opts-visitor.c opts_type_bool() method has code for parsing a string to set a bool value, as does the qemu-option.c parse_option_bool() method, except it handles fewer cases. To enable consistency across the codebase, extend parse_option_bool() to handle "yes", "no", "y" and "n", and make it

[Qemu-devel] [PATCH v8 4/7] qom: support arbitrary non-scalar properties with -object

The current -object command line syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way

Re: [Qemu-devel] [PATCH 00/17] byte-based block discard

On 06/22/2016 09:50 AM, Eric Blake wrote: > Another step towards making NBD pass a byte-aligned discard > request over the wire. Actually, until both raw_bsd.c and > nbd-client.c support .bdrv_co_preadv(), the block layer still > sets up a required_alignment of 512, so with this series alone, >

Re: [Qemu-devel] [PATCH v3 07/11] tcg: Prepare TB invalidation for lockless TB lookup

Sergey Fedorov writes: > From: Sergey Fedorov > > When invalidating a translation block, set an invalid CPU state into the > TranslationBlock structure first. All subsequent changes are ordered > after it with smp_wmb(). This pairs with implied

[Qemu-devel] [PATCH v4 00/11] block: Accept node-name in all node level QMP commands

As stated in the RFC I sent two weeks ago: * Node level commands: We need to complete the conversion that makes commands accept node names instead of BlockBackend names. In some places we intentionally allow only BlockBackends because we don't know if the command works in other

[Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf ---

Re: [Qemu-devel] [PATCH] virtio: Tell the user what went wrong when event_notifier_init failed

On 28.06.2016 00:12, Thomas Huth wrote: > event_notifier_init() can fail in real life, for example when there > are not enough open file handles available (EMFILE) when using a lot > of devices. So instead of leaving the average user with a cryptic > error number only, print out a proper error

[Qemu-devel] [PATCH v3 0/8] drive-mirror improvements

This patchset contains patches dealing with known-to-be-zero areas in drive mirror from [PATCH 0/9] major rework of drive-mirror patchset. Changes from v2: - added mirror_throttle helper (patch 3) to address Eric' comment about last_time_ns - comment tweaks (thank you, Eric) - marked

[Qemu-devel] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the

[Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

This allows to create an empty ide-cd device without manually creating a BlockBackend. Signed-off-by: Kevin Wolf --- hw/ide/qdev.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 67c76bf..2eb055a

[Qemu-devel] [PATCH 2/2] scsi: scsi-cd without drive property for empty drive

This allows to create an empty scsi-cd device without manually creating a BlockBackend. Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 8dbfc10..b4e71ff 100644 ---

[Qemu-devel] [PATCH v8 1/7] qdict: implement a qdict_crumple method for un-flattening a dict

The qdict_flatten() method will take a dict whose elements are further nested dicts/lists and flatten them by concatenating keys. The qdict_crumple() method aims to do the reverse, taking a flat qdict, and turning it into a set of nested dicts/lists. It will apply nesting based on the key name,

[Qemu-devel] [PATCH v8 7/7] acl: delete existing ACL implementation

The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ and QAuthZSimple QOM classes provide a superset of

Re: [Qemu-devel] [PATCH v9 16/17] qapi: Tweak QmpInputVisitor to optionally do string conversion

On Thu, Jul 14, 2016 at 08:04:29AM -0600, Eric Blake wrote: > On 07/14/2016 07:03 AM, Daniel P. Berrange wrote: > > >>> I'm not really a huge fan of the approach there. IMHO the > >>> input visitor should strictly operate in "all native types" > >>> or "all string types" mode. The way you've done

[Qemu-devel] [PATCH 5/7] hw/grackle: fix PCI bus initialization

Delay the host-bridge 'realization' until the PCI root bus is attached. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/grackle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 8f91216..2c8acda 100644

[Qemu-devel] [PULL 1/1] Add optionrom compatible with fw_cfg DMA version

From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones Message-Id: <1464027093-24073-2-git-send-email-rjo...@redhat.com> [Add -fno-toplevel-reorder, support clang without -m16.

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-commit to accept a node-name without lifting the restriction that > we're operating at a root node. > > As

Re: [Qemu-devel] [RFC v2 09/11] linux-user: Support CPU work queue

Sergey Fedorov writes: > From: Sergey Fedorov > > Make CPU work core functions common between system and user-mode > emulation. User-mode does not have BQL, so process_queued_cpu_work() is > protected by 'exclusive_lock'. > > Signed-off-by:

Re: [Qemu-devel] [PULL for-2.7] target-xtensa fix

/rth/tags/pull-rth-20160712' into > staging (2016-07-14 10:36:27 +0100) > > are available in the git repository at: > > git://github.com/OSLL/qemu-xtensa.git tags/20160714-xtensa > > for you to fetch changes up to f9a555e4991b9ddc257ea8ce2e4acde672275097: > > target-xtensa: xtfpga

Re: [Qemu-devel] [PATCH] util: Fix MIN_NON_ZERO

On Tue, Jul 12, 2016 at 02:48:33PM +0800, Fam Zheng wrote: > MIN_NON_ZERO(0, 1) is evaluated to 0. Rewrite the macro to fix it. This is incorrect. The actual results are: MIN_NON_ZERO(0, 1) = 1 MIN_NON_ZERO(1, 0) = 0 The second case is the buggy one. > > Reported-by: Miroslav Rezanina

[Qemu-devel] [PATCH v3] aio-posix: remove useless parameter

Parameter **errp of aio_context_setup() is useless, remove it and clean up the related code. Cc: Stefan Hajnoczi Cc: Fam Zheng Cc: Eric Blake Signed-off-by: Cao jin --- aio-posix.c | 3 ++- aio-win32.c

Re: [Qemu-devel] [PATCH v3 05/11] target-i386: Remove redundant HF_SOFTMMU_MASK

Sergey Fedorov writes: > From: Sergey Fedorov > > 'HF_SOFTMMU_MASK' is only set when 'CONFIG_SOFTMMU' is defined. So > there's no need in this flag: test 'CONFIG_SOFTMMU' instead. > > Suggested-by: Paolo Bonzini >

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

On 14/07/2016 15:00, Sergey Fedorov wrote: > > > +} > > > + > > > +static inline bool tb_is_invalid(TranslationBlock *tb) > > > +{ > > > +return cpu_tb_cpu_state_is_invalidated(tb->pc, tb->cs_base, > > > tb->flags); > > > +} > > Also why are we passing three pointers to parts of

[Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-commit to accept a node-name without lifting the restriction that we're operating at a root node. As libvirt makes use of the DeviceNotFound error class, we

[Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run

The code inside the helper will be extended in the next patch. mirror_run itself is overbloated at the moment. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

On 13/07/2016 19:50, Sergey Fedorov wrote: > On 13/07/16 10:36, Paolo Bonzini wrote: >> >> On 13/07/2016 01:19, Emilio G. Cota wrote: >>> I wouldn't put those comments in the source--seqlock callers should >>> know what they're doing, and what barriers seqlocks imply. >> In general I'd agree

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

On Jul 14 14:33, Dr. David Alan Gilbert wrote: > * Aaron Lindsay (alind...@codeaurora.org) wrote: > > I'm configuring with: > > # ./configure \ > > --static \ > > --disable-gtk \ > > --target-list=aarch64-softmmu > > Does it work if you configure without the --static? Yes, it works

Re: [Qemu-devel] [PATCH v9 16/17] qapi: Tweak QmpInputVisitor to optionally do string conversion

On 07/14/2016 07:03 AM, Daniel P. Berrange wrote: >>> I'm not really a huge fan of the approach there. IMHO the >>> input visitor should strictly operate in "all native types" >>> or "all string types" mode. The way you've done it here >>> means that users can actually mix & match strings vs

[Qemu-devel] [PATCH 0/2] block: Create empty drives without explicit BB

This series allows creating empty IDE and SCSI CD-ROM drives by leaving out the drive=... option. At the moment, such drives are still relatively useless because you can't insert a medium at runtime yet, but we'll change the QMP commands soon to accept qdev device names instead of BlockBackend

[Qemu-devel] [PATCH v8 0/7] Provide a QOM-based authorization API

This is a followup of previously posted work in 2.6 cycle: v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html v4:

Re: [Qemu-devel] [RFC v2 07/11] linux-user: Rework exclusive operation mechanism

Sergey Fedorov writes: > From: Sergey Fedorov > > A single variable 'pending_cpus' was used for both counting currently > running CPUs and for signalling the pending exclusive operation request. > > To prepare for supporting operations which

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

On Thu, Jul 14, 2016 at 08:23:18AM -0600, Eric Blake wrote: > On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: > > Add a qmp_mixed_input_visitor_new() method which returns > > a QMP input visitor that accepts either strings or the > > native data types. > > > > Signed-off-by: Daniel P. Berrange

  1   2   3   4   5   >