[Qemu-devel] [Patch v4 04/30] s390x/cpumodel: introduce CPU features

2016-09-05 Thread David Hildenbrand
From: Michael Mueller The patch introduces s390x CPU features (most of them refered to as facilities) along with their discription and some functions that will be helpful when working with the features later on. Please note that we don't introduce all known CPU

[Qemu-devel] [Patch v4 03/30] s390x/cpumodel: expose CPU class properties

2016-09-05 Thread David Hildenbrand
Let's expose the description and migration safety and whether a definition is static, as class properties, this can be helpful in the future. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu.c| 1 +

[Qemu-devel] [Patch v4 29/30] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison"

2016-09-05 Thread David Hildenbrand
Let's implement that interface by reusing our convertion code implemented for expansion. We use CPU generations and CPU features to calculate the result. This means, that a zEC12 cannot simply be converted into a z13 by stripping of features. This is required, as other magic values (e.g. maximum

[Qemu-devel] [Patch v4 20/30] s390x/kvm: allow runtime-instrumentation for "none" machine

2016-09-05 Thread David Hildenbrand
To be able to query the correct host model for the "none" machine, let's allow runtime-instrumentation for that machine. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 5 + 1 file changed, 5

[Qemu-devel] [Patch v4 30/30] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline"

2016-09-05 Thread David Hildenbrand
Let's implement that interface by reusing our conversion code and lookup code for CPU definitions. In order to find a compatible CPU model, we first detect the maximum possible CPU generation and then try to find a maximum model, satisfying all base features (not exceeding the maximum

[Qemu-devel] [Patch v4 22/30] s390x/kvm: disable host model for problematic compat machines

2016-09-05 Thread David Hildenbrand
Compatibility machines that touch runtime-instrumentation should not be used with the CPU model. Otherwise the host model will look different, depending on the QEMU machine QEMU has been started with. So let's simply disable the host model for existing compatibility machines that all disable ri.

[Qemu-devel] [Patch v4 11/30] s390x/cpumodel: let the CPU model handle feature checks

2016-09-05 Thread David Hildenbrand
If we have certain features enabled, we have to migrate additional state (e.g. vector registers or runtime-instrumentation registers). Let the CPU model control that unless we have no "host" CPU model in the KVM case. This will later on be the case for compatibility machines, so migration from

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > > > > With the new chip class per cpu class, does this chip_type field > > serve > > any purpose any more? > > > > > +    k->chip_f000f = 0x120d30498000ull; > >

Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-05 Thread Marc-André Lureau
Hi On Sat, Sep 3, 2016 at 5:36 PM Wang, Wei W wrote: > Marc-André and I just got different thoughts about a design direction. I > prefer to have all the frontend virtio devices (net, scsi, console etc.) > from the same VM to be supported by one backend vhost-pci device

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 09:41 AM, David Gibson wrote: > On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: >>> >>> With the new chip class per cpu class, does this chip_type field >>> serve >>> any purpose any more? >>> +

Re: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores

2016-09-05 Thread Michael Rolnik
ping On Thu, Aug 18, 2016 at 3:07 PM, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested yet. > However I was able to execute simple code with functions. e.g fibonacci >

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-05 Thread Peter Maydell
On 1 September 2016 at 12:18, Peter Maydell wrote: > I know 2.7 isn't quite out the door yet, but I figured we should > kick off the discussion of 2.8's schedule. At the QEMU Summit there > was some discussion on how we're doing with releases, and I think > the consensus

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 13:37, Ashijeet Acharya wrote: > Include migrate_set_speed and migrate_set_downtime inside > migrate_set_parameters for setting maximum migration speed and expected > downtime parameters respectively. Also update the query part for both in qmp > and hmp qemu control interfaces.

Re: [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

2016-09-05 Thread Markus Armbruster
Thomas Huth writes: > On 05.09.2016 13:05, Markus Armbruster wrote: [...] >> Let's fix all this. You or I? > > I don't mind. I'm currently busy hunting some bugs ... So feel free to > send the patches for these issues. (and in case you also don't have time > for that now, I've

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-05 Thread Maxime Coquelin
On 09/02/2016 07:29 PM, Michael S. Tsirkin wrote: On Fri, Sep 02, 2016 at 10:57:17AM +0200, Maxime Coquelin wrote: On 09/01/2016 03:46 PM, Michael S. Tsirkin wrote: On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: On 08/14/2016 11:42 AM, Prerna Saxena wrote: On 14/08/16

Re: [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

2016-09-05 Thread Thomas Huth
On 05.09.2016 10:22, Markus Armbruster wrote: > Thomas Huth writes: > >> The folder does not exist anymore, thus should be removed from the >> MAINTAINERS file, too. >> >> Signed-off-by: Thomas Huth >> --- >> MAINTAINERS | 1 - >> 1 file changed, 1

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Peter Xu
On Mon, Sep 05, 2016 at 10:04:42AM +0200, Paolo Bonzini wrote: > > > On 05/09/2016 09:21, Peter Xu wrote: > > void memory_region_notify_iommu(MemoryRegion *mr, > > -IOMMUTLBEntry entry) > > +IOMMUTLBEntry entry, IOMMUAccessFlags

[Qemu-devel] [Patch v4 21/30] s390x/kvm: implement CPU model support

2016-09-05 Thread David Hildenbrand
Let's implement our two hooks so we can support CPU models. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu_models.c | 75 +++- target-s390x/cpu_models.h | 50 target-s390x/kvm.c| 295

[Qemu-devel] [Patch v4 19/30] linux-headers: update against kvm/next

2016-09-05 Thread David Hildenbrand
Update against 29b4817d4018 ("Linux 4.8-rc1") Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- include/standard-headers/linux/input-event-codes.h | 32 + include/standard-headers/linux/input.h | 1 +

[Qemu-devel] [Patch v4 07/30] s390x/cpumodel: introduce CPU feature group definitions

2016-09-05 Thread David Hildenbrand
Let's use the generated groups to create feature group representations for the user. These groups can later be used to enable/disable multiple features in one shot and will be used to reduce the amount of reported features to the user if all subfeatures are in place. We want to work on features

[Qemu-devel] [PATCH V13 12/12] MAINTAINERS: add maintainer for COLO-proxy

2016-09-05 Thread Zhang Chen
add Zhang Chen and Li zhijian as co-maintainers of COLO-proxy. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff

Re: [Qemu-devel] [PATCH v2 1/2] crypto: fix building complaint

2016-09-05 Thread Daniel P. Berrange
On Mon, Sep 05, 2016 at 10:50:54AM +, Gonglei (Arei) wrote: > > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, September 05, 2016 6:15 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org; dmi...@daynix.com > > Subject: Re:

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 13:13, P J P wrote: > +-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ > | No, that's not what happens. chunk_size is set to sg.resid, after which: > | > | sg.dataAddr += chunk_size; > | data_length -= chunk_size; > | sg.resid -= chunk_size; > | > | The

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini wrote: > > > On 05/09/2016 13:37, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters for setting maximum migration speed and expected >> downtime parameters

[Qemu-devel] [Patch v4 05/30] s390x/cpumodel: generate CPU feature lists for CPU models

2016-09-05 Thread David Hildenbrand
From: Michael Mueller This patch introduces the helper "gen-features" which allows to generate feature list definitions at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper

[Qemu-devel] [Patch v4 01/30] qmp: details about CPU definitions in query-cpu-definitions

2016-09-05 Thread David Hildenbrand
It might be of interest for tooling whether a CPU definition can be safely used when migrating, or if e.g. CPU features might get lost during migration when migrationg from/to a different QEMU version or host, even if the same compatibility machine is used. Also, we want to know if a CPU

[Qemu-devel] [Patch v4 16/30] s390x/sclp: propagate the ibc val(lowest and unblocked ibc)

2016-09-05 Thread David Hildenbrand
If we have a lowest ibc, we can indicate the ibc to the guest. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 2 ++ include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 21

[Qemu-devel] [Patch v4 13/30] s390x/sclp: factor out preparation of cpu entries

2016-09-05 Thread David Hildenbrand
Let's factor out the common code of "read cpu info" and "read scp info". This will make the introduction of new cpu entry fields easier. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 22 --

[Qemu-devel] [Patch v4 15/30] s390x/sclp: indicate sclp features

2016-09-05 Thread David Hildenbrand
We have three different blocks in the SCLP read-SCP information response that indicate sclp features. Let's prepare propagation. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 9 +

Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread Cornelia Huck
On Mon, 5 Sep 2016 10:52:14 +0200 David Hildenbrand wrote: > Hi, > > no logical changes this time. > > In this version, cross-compilation and compilation with mingw32 are fixed. > Our feature generation script gen-features has to be compiled for the > host

[Qemu-devel] [Patch v4 24/30] s390x/kvm: don't enable key wrapping if msa3 is disabled

2016-09-05 Thread David Hildenbrand
As the CPU model now controls msa3, trying to set wrapping keys without msa3 being around/enable in the kernel will produce misleading errors. So let's simply not configure key wrapping if msa3 is not enabled and make compat machines with disabled CPU model work correctly. Signed-off-by: David

[Qemu-devel] [PATCH V13 11/12] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-09-05 Thread Zhang Chen
We will rewrite tcp packet secondary received and sent. When colo guest is a tcp server. Firstly, client start a tcp handshake. the packet's seq=client_seq, ack=0,flag=SYN. COLO primary guest get this pkt and mirror(filter-mirror) to secondary guest, secondary get it use filter-redirector.

[Qemu-devel] [PATCH V13 03/12] colo-compare: introduce colo compare initialization

2016-09-05 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ |

[Qemu-devel] [PATCH V13 05/12] Jhash: add linux kernel jhashtable in qemu

2016-09-05 Thread Zhang Chen
Jhash will be used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 59

[Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-05 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+

Re: [Qemu-devel] [PATCH 06/12] cpus-common: move CPU list management to common code

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 12:05, Alex Bennée wrote: > What tree are you based off? git-am is having trouble applying this > patch and the -3way fall back gets very confused: > > Applying: cpus-common: move CPU list management to common code > fatal: sha1 information is lacking or useless (exec.c).

Re: [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

2016-09-05 Thread Markus Armbruster
Thomas Huth writes: > On 05.09.2016 10:22, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> The folder does not exist anymore, thus should be removed from the >>> MAINTAINERS file, too. >>> >>> Signed-off-by: Thomas Huth >>> --- >>>

Re: [Qemu-devel] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 05:42 AM, David Gibson wrote: > On Wed, Aug 31, 2016 at 06:34:12PM +0200, Cédric Le Goater wrote: >> This will be used to build real HW ids for the cores and enforce some >> limits on the available cores per chip. >> >> Signed-off-by: Cédric Le Goater >> --- >>

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread P J P
+-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ | No, that's not what happens. chunk_size is set to sg.resid, after which: | | sg.dataAddr += chunk_size; | data_length -= chunk_size; | sg.resid -= chunk_size; | | The loop is reentered with sg.resid == 0, it calls into |

Re: [Qemu-devel] aio: reg. smp_read_barrier_depends() in aio_bh_poll()

2016-09-05 Thread Paolo Bonzini
On 02/09/2016 20:23, Pranith Kumar wrote: > If I understand you correctly, this is what might happen without the > barrier(): > > P0P1 > > // bh = ctx->first_bh; optimized > if (ctx->first_bh)

[Qemu-devel] [PATCH 7/9] target-cris: ignore prefix insns in singlestep

2016-09-05 Thread Rabin Vincent
From: Hans-Peter Nilsson Don't count prefix instructions as separate when singlestepping. For example, for this following instruction 1ad8: a011 e00b move.d r0,[r1-96] before this patch, we get two register dumps: PC=1ad8 CCS=0 btaken=1 btarget=1ac6

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-05 Thread Markus Armbruster
Peter Maydell writes: > On 1 September 2016 at 12:18, Peter Maydell wrote: >> I know 2.7 isn't quite out the door yet, but I figured we should >> kick off the discussion of 2.8's schedule. At the QEMU Summit there >> was some discussion on how

Re: [Qemu-devel] [PATCH v2 1/2] crypto: fix building complaint

2016-09-05 Thread Daniel P. Berrange
On Mon, Sep 05, 2016 at 12:02:42PM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, September 05, 2016 7:04 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org > > Subject: Re: [PATCH v2 1/2] crypto: fix

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix up F: entry bit rot

2016-09-05 Thread Thomas Huth
On 05.09.2016 14:28, Markus Armbruster wrote: > include/hw/xilinx.h is gone since commit d5001cf, drop. > > include/hw/*/xlnx*.c is a typo, change .c to .h. > > include/hw/acpi/piix.h is a typo, change piix.h to piix4.h. > > hw/i386/*dsl and scripts/acpi*py are gone since since commit 9fc6502,

[Qemu-devel] [Patch v4 12/30] s390x/cpumodel: check and apply the CPU model

2016-09-05 Thread David Hildenbrand
We have to test if a configured CPU model is runnable in the current configuration, and if not report why that is the case. This is done by comparing it to the maximum supported model (host for KVM or z900 for TCG). Also, we want to do some base sanity checking for a configured CPU model. We'll

[Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread David Hildenbrand
Hi, no logical changes this time. In this version, cross-compilation and compilation with mingw32 are fixed. Our feature generation script gen-features has to be compiled for the host architecture, where we do the compilation and bitmaps cannot be directly initialized from the generated data,

[Qemu-devel] [Patch v4 23/30] s390x/kvm: let the CPU model control CMM(A)

2016-09-05 Thread David Hildenbrand
Starting with recent kernels, if the cmma attributes are available, we actually have hardware support. Enabling CMMA then means providing the guest VCPU with CMM, therefore enabling its CMM facility. Let's not blindly enable CMM anymore but let's control it using CPU models. For disabled CPU

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-05 Thread Kevin Wolf
Am 01.09.2016 um 16:08 hat Stefan Hajnoczi geschrieben: > On Thu, Sep 01, 2016 at 12:18:10PM +0100, Peter Maydell wrote: > > I know 2.7 isn't quite out the door yet, but I figured we should > > kick off the discussion of 2.8's schedule. At the QEMU Summit there > > was some discussion on how we're

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 11:50, P J P wrote: > Hello Paolo, all > > +-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ > | > -uint64_t data_length = r->req.dataLen; > | > +uint32_t data_length = r->req.dataLen; > | > | Why is this needed if you remove the cast in MIN, below? > > The outer while

Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini wrote: > > > > > > On 05/09/2016 10:11, Ashijeet Acharya wrote: > >> > > Include migrate_set_speed and migrate_set_downtime inside > >> > > migrate_set_parameters

Re: [Qemu-devel] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 13:13 +0200, Cédric Le Goater wrote: > > Is it worth having this cores_max field, since AFAICT you can > > calculate it as hweight(~cores_mask)? > > Sure. I looked for it and missed it.  > > Here is a slightly improved version from Brian Kernighan : > > unsigned

[Qemu-devel] [PATCH 4/9] tests: cris: remove check_time1

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent This test, borrowed from the GDB simulator test suite, checks that every syscall increments the time returned by gettimeofday() by exactly 1 ms. This is not guaranteed or even desirable on QEMU so remove this test. Signed-off-by: Rabin Vincent

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 13:59, Ashijeet Acharya wrote: >>> >> +if (has_migrate_set_speed) { >>> >> +qmp_migrate_set_speed(migrate_set_speed, NULL); >>> >> +} >>> >> +if (has_migrate_set_downtime) { >>> >> +qmp_migrate_set_downtime(migrate_set_downtime, NULL); >>> >> +} >> >

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 14:58, P J P wrote: > +-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+ > | Without a public spec it's hard, but I guess 2048 is more than enough. > > === > diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c > index 4245c15..4823b9d 100644 > --- a/hw/scsi/vmw_pvscsi.c > +++

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 15:09, Ashijeet Acharya wrote: >>> >> + >>> >> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?", >> > >> > Same here about the names. Also use "i" for QMP

[Qemu-devel] [PATCH V13 04/12] net/colo.c: add colo.c to define and handle packet

2016-09-05 Thread Zhang Chen
The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit

2016-09-05 Thread Paolo Bonzini
On 03/09/2016 08:33, P J P wrote: > From: Prasad J Pandit > > In PVSCSI paravirtual SCSI bus, the request descriptor data > length is defined to be 64 bit. While building SG list from > a request descriptor, it gets truncated to 32bit in routine >

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Ola Liljedahl
On 05/09/2016, 09:40, "Alexander Graf" wrote: >On 09/04/2016 05:47 PM, Ola Liljedahl wrote: >> >> On 02/09/2016, 16:05, "Alexander Graf" wrote: >> > There is a big problem that the control handle logic is >synchronization, > but the data queue >

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 10:38, Peter Xu wrote: > However in this patch I was not meant to do that. I made it an > exclusive flag to identify two different use cases. I don't know > whether this is good, but at least for Intel IOMMU's current use case, > these two types should be totally isolated from each

[Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
Include migrate_set_speed and migrate_set_downtime inside migrate_set_parameters for setting maximum migration speed and expected downtime parameters respectively. Also update the query part for both in qmp and hmp qemu control interfaces. Signed-off-by: Ashijeet Acharya

Re: [Qemu-devel] [PATCH] vl: Delay initialization of memory backends

2016-09-05 Thread Paolo Bonzini
On 02/09/2016 20:10, Eduardo Habkost wrote: > On Fri, Sep 02, 2016 at 04:56:49PM +0200, Paolo Bonzini wrote: >> On 02/09/2016 16:04, Eduardo Habkost wrote: > [...] >>> Now, why exactly vhost-user-test needs accel=tcg and can't use >>> accel=qtest? >> >> Because it uses iPXE to exercise the NIC.

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 5:31 PM, Paolo Bonzini wrote: > > > On 05/09/2016 13:59, Ashijeet Acharya wrote: >> +if (has_migrate_set_speed) { >> +qmp_migrate_set_speed(migrate_set_speed, NULL); >> +} >> +if (has_migrate_set_downtime) {

[Qemu-devel] [PATCH] MAINTAINERS: Fix up F: entry bit rot

2016-09-05 Thread Markus Armbruster
include/hw/xilinx.h is gone since commit d5001cf, drop. include/hw/*/xlnx*.c is a typo, change .c to .h. include/hw/acpi/piix.h is a typo, change piix.h to piix4.h. hw/i386/*dsl and scripts/acpi*py are gone since since commit 9fc6502, drop. hw/virtio/dataplane/* are gone since commit fee089e,

Re: [Qemu-devel] [Qemu-discuss] Throttle in virtio-net

2016-09-05 Thread Pradeep Kiruvale
Hi Alberto, Thanks for your reply. > > > I am planning to implement throttling functionality for virtio-net > > driver using the throttling APIs that exist inside qemu. > > Hi Pradeep, > > the problem with implementing throttling for the network is that > it's useless if you use the vhost_net

Re: [Qemu-devel] [PATCH 06/12] cpus-common: move CPU list management to common code

2016-09-05 Thread Alex Bennée
Paolo Bonzini writes: > Add a mutex for the CPU list to system emulation, as it will be used to > manage safe work. Abstract manipulation of the CPU list in new functions > cpu_list_add and cpu_list_remove. > > Signed-off-by: Paolo Bonzini > index

Re: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-05 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy Type: series Message-id:

[Qemu-devel] [Patch v4 27/30] qmp: add QMP interface "query-cpu-model-baseline"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to baseline two CPU models, to create a third, compatible one. This is especially helpful when two CPU models are not identical, but a CPU model is required that is guaranteed to run under both configurations, where the original models run.

[Qemu-devel] [Patch v4 17/30] s390x/sclp: propagate the mha via sclp

2016-09-05 Thread David Hildenbrand
The mha is provided in the CPU model, so get any CPU and extract the value. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 1 + include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 14

[Qemu-devel] [Patch v4 02/30] s390x/cpumodel: "host" and "qemu" as CPU subclasses

2016-09-05 Thread David Hildenbrand
This patch introduces two CPU models, "host" and "qemu". "qemu" is used as default when running under TCG. "host" is used as default when running under KVM. "host" cannot be used without KVM. "host" is not migration-safe. They both inherit from the base s390x CPU, which is turned into an abstract

[Qemu-devel] [Patch v4 26/30] qmp: add QMP interface "query-cpu-model-comparison"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to compare two CPU models. "query-cpu-model-compare" takes two models and returns how they compare in a specific configuration. The result will give guarantees about runnability. E.g. if a CPU model A is a subset of CPU model B, model A is guaranteed to run

[Qemu-devel] [Patch v4 18/30] s390x/sclp: propagate hmfai

2016-09-05 Thread David Hildenbrand
hmfai is provided on CPU models >= z196. Let's propagate it properly. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 1 + include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 14

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-05 Thread Markus Armbruster
John Snow writes: > On 09/02/2016 01:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> If a device still has an attached BDS because the medium has not yet >>> been removed, we will be unable to migrate to a new host because >>> blk_flush will

[Qemu-devel] [PATCH V13 07/12] colo-compare: introduce packet comparison thread

2016-09-05 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes but secondary packet does not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a

Re: [Qemu-devel] question with usb stick host pass-through do ejection in guest

2016-09-05 Thread Gonglei (Arei)
Hi Gerd, Thank you very much for your reply, it's very useful! Regards, -Gonglei > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, September 05, 2016 4:58 PM > To: wangxin (U) > Cc: qemu-devel@nongnu.org; fuweiwei (C); Gonglei (Arei) > Subject: Re:

[Qemu-devel] [PATCH 3/9] tests: cris: remove openpf4 test

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent This test, borrowed from the GDB simulator test suite, is meant to test the GDB simulator's --sysroot feature and always fails in QEMU. Remove it. openpf3 tests the same sequence of system calls (without assuming the precence of --sysroot). Signed-off-by:

[Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent The CRIS tests expect that functions marked inline are always inline. With newer versions of GCC, building them results warnings like the following and spurious failures when they are run. In file included from tests/tcg/cris/check_moveq.c:5:0:

[Qemu-devel] [PATCH 8/9] target-cris: add v17 CPU

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent In the CRIS v17 CPU an ADDC (add with carry) instruction has been added compared to the v10 instruction set. Assembler syntax: ADDC [Rs],Rd ADDC [Rs+],Rd Size: Dword Description: The source data is added together with the carry flag to the

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-05 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini wrote: > > > On 05/09/2016 13:37, Ashijeet Acharya wrote: >> Include migrate_set_speed and migrate_set_downtime inside >> migrate_set_parameters for setting maximum migration speed and expected >> downtime parameters

Re: [Qemu-devel] [PATCH v2 1/2] crypto: fix building complaint

2016-09-05 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 05, 2016 7:04 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH v2 1/2] crypto: fix building complaint > > On Mon, Sep 05, 2016 at 10:50:54AM +, Gonglei

Re: [Qemu-devel] [PATCH v2 0/2] Delay initialization of memory backends

2016-09-05 Thread Paolo Bonzini
On 02/09/2016 20:59, Eduardo Habkost wrote: > While trying to fix the original bug in v1, another bug was fixed > by accident: TCG initialization of dirty_log_mask was broken when > using memory backends. > > The fix, on the other hand, broke vhost-user-test because it > relied on TCG, even

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-05 Thread Daniel P. Berrange
On Thu, Sep 01, 2016 at 12:18:10PM +0100, Peter Maydell wrote: > I know 2.7 isn't quite out the door yet, but I figured we should > kick off the discussion of 2.8's schedule. At the QEMU Summit there > was some discussion on how we're doing with releases, and I think > the consensus view was that

[Qemu-devel] [Patch v4 08/30] s390x/cpumodel: register defined CPU models as subclasses

2016-09-05 Thread David Hildenbrand
This patch adds the CPU model definitions that are known on s390x - like z900, zBC12 or z13. For each definition, introduce two CPU models: 1. Base model (e.g. z13-base): Minimum feature set we expect to be around on all z13 systems. These models are migration-safe and will never change. 2.

[Qemu-devel] [Patch v4 25/30] qmp: add QMP interface "query-cpu-model-expansion"

2016-09-05 Thread David Hildenbrand
Let's provide a standardized interface to expand CPU models. This interface can be used by tooling to get details about a specific CPU model in a certain configuration, e.g. about the "host" model. To take care of all architectures, two detail levels for an expansion are introduced. Certain

[Qemu-devel] [Patch v4 10/30] s390x/cpumodel: expose features and feature groups as properties

2016-09-05 Thread David Hildenbrand
Let's add all features and feature groups as properties to all CPU models. If the "host" CPU model is unknown, we can neither query nor change features. KVM will just continue to work like it did until now. We will not allow to enable features that were not part of the original CPU model, because

[Qemu-devel] TPM Passthrough

2016-09-05 Thread Kelvin Middleton
Hi all, sorry for the repeat emails...I sent in a question during the days running up to the 2.7 release and I understand you were all busy working to get that complete. My question is about whether my expectations are correct or not with TPM passthrough. I have a known good device but when

Re: [Qemu-devel] [libvirt] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 11:23, Markus Armbruster wrote: >> > >> > On the other hand, it is clearly documented that the DEVICE_DELETED >> > event is sent as soon as guest acknowledges completion of device >> > removal. So libvirt's buggy if we'd follow documentation strictly. But >> > then again, I don't

Re: [Qemu-devel] [PATCH v2 0/2] Delay initialization of memory backends

2016-09-05 Thread Markus Armbruster
Eduardo Habkost writes: > While trying to fix the original bug in v1, another bug was fixed > by accident: TCG initialization of dirty_log_mask was broken when > using memory backends. > > The fix, on the other hand, broke vhost-user-test because it > relied on TCG, even

[Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-05 Thread Zhang Chen
COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO-proxy's help, COLO greatly improves the performance. The filter-redirector,

[Qemu-devel] [PATCH V13 09/12] filter-rewriter: introduce filter-rewriter initialization

2016-09-05 Thread Zhang Chen
Filter-rewriter is a part of COLO project. It will rewrite some of secondary packet to make secondary guest's tcp connection established successfully. In this module we will rewrite tcp packet's ack to the secondary from primary,and rewrite tcp packet's seq to the primary from secondary. usage:

Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features

2016-09-05 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features Type: series Message-id: 20160905085244.99980-1-d...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH V13 02/12] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-05 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian

Re: [Qemu-devel] [PATCH v2] tests: fix qvirtqueue_kick

2016-09-05 Thread Laurent Vivier
for 2.8, ping. Thanks, Laurent On 27/08/2016 22:34, Laurent Vivier wrote: > vq->avail.idx and vq->avail->ring[] are a 16bit values, > so read and write them with readw()/writew() instead of > readl()/writel(). > > To read/write a 16bit value with a 32bit accessor works fine > on little-endian

[Qemu-devel] [PATCH 9/9] tests: cris: add v17 ADDC test

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent Add a test for the newly implemented ADDC instruction in the v17 CRIS CPU. Signed-off-by: Rabin Vincent --- tests/tcg/cris/Makefile| 19 ++-- tests/tcg/cris/check_addcv17.s | 65 ++ 2

[Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps

2016-09-05 Thread Rabin Vincent
From: Hans-Peter Nilsson Use the correct register names for v10 and don't dump support function registers for pre-v32. Signed-off-by: Hans-Peter Nilsson Signed-off-by: Rabin Vincent --- target-cris/translate.c | 36

[Qemu-devel] [PATCH 2/9] tests: cris: fix syscall inline asm

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent Add the clobbered registeres to the inline asm for the write and exit system calls. Without the correct clobbers for the write() function, correct failure messages are not printed succesfully on newer version of GCC. Signed-off-by: Rabin Vincent

[Qemu-devel] [PATCH v3] crypto: fix building complaint

2016-09-05 Thread Gonglei
gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to GNUTLS_VERSION_NUMBER. If using gnutls before that verion, we'll get the below warning: crypto/tlscredsx509.c:618:5: warning: "GNUTLS_VERSION_NUMBER" is not defined Because gnutls 3.x still defines LIBGNUTLS_VERSION_NUMBER for back

Re: [Qemu-devel] [Qemu-discuss] Throttle in virtio-net

2016-09-05 Thread Alberto Garcia
On Fri, Sep 02, 2016 at 05:13:40PM +0200, Pradeep Kiruvale wrote: > I am planning to implement throttling functionality for virtio-net > driver using the throttling APIs that exist inside qemu. Hi Pradeep, the problem with implementing throttling for the network is that it's useless if you use

[Qemu-devel] [Patch v4 28/30] s390x/cpumodel: implement QMP interface "query-cpu-model-expansion"

2016-09-05 Thread David Hildenbrand
In order to expand CPU models, we create temporary cpus that handle the feature/group parsing. Only CPU feature properties are expanded. When converting the data structure back, we always fall back to the static base CPU model, which is by definition migration-safe. Acked-by: Cornelia Huck

[Qemu-devel] [Patch v4 06/30] s390x/cpumodel: generate CPU feature group lists

2016-09-05 Thread David Hildenbrand
Feature groups will be very helpful to reduce the amount of features typically available in sane configurations. E.g. the MSA facilities introduced loads of subfunctions, which could - in theory - go away in the future, but we want to avoid reporting hundrets of features to the user if usually all

[Qemu-devel] [Patch v4 09/30] s390x/cpumodel: store the CPU model in the CPU instance

2016-09-05 Thread David Hildenbrand
A CPU model consists of a CPU definition, to which delta changes are applied - features added or removed (e.g. z13-base,vx=on). In addition, certain properties (e.g. cpu id) can later on change during migration but belong into the CPU model. This data will later be filled from the host model in

  1   2   3   4   5   >