Re: [Qemu-devel] [PATCH 04/12] slirp: add in6_multicast() and use it instead of IN6_IS_ADDR_MULTICAST()

On 09.01.2018 17:33, Richard Henderson wrote: > On 01/08/2018 09:28 AM, Philippe Mathieu-Daudé wrote: >> Host: Mac OS 10.12.5 >> Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) >> >> slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' >> of class or >>

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

On 09/01/2018 17:02, Michael Roth wrote: >> so you can see it's already diverged because it prints out >> a different value for the name of the pci node and the >> SCSI line has 8200 vs . > FYI I actually see this with a raspberry pi 3 too Is this an arm32 or aarch64 install?

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > > +\drivernormative{\subsubsection}{Device configuration layout}{Device Types > > / Crypto Device / Device configuration layout} > > + > > +\begin{itemize*} > > +\item The driver MUST read the \field{status} from the bottom bit of >

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

On 08/01/2018 04:09, Fam Zheng wrote: > After the out label there is a check on iTask.task but it is not > initialized yet. > > Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 > Signed-off-by: Fam Zheng > --- > block/iscsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [Qemu-devel] [PATCH v6 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

On Tue, Jan 9, 2018 at 9:45 AM, Cornelia Huck wrote: > On Wed, 20 Dec 2017 09:24:41 -0800 > Alistair Francis wrote: > >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

Hi Michael, > Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: >> >> Create the SDCard in the realize() function. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/milkymist-memcard.c | 24 +++- >> 1 file changed, 15 insertions(+), 9

[Qemu-devel] [PULL v3] target/xtensa updates

Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20180109-xtensa for you to fetch changes up to 5a6539e627faf9251e1db78238b9f9b870610518: target/xtensa: implement disassembler (2018-01-09 09:55:39

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

>> Creating the device (milkymist_memcard_create()) fails with an assertion: >> sysbus_mmio_map_common: Assertion `n >= 0 && n < dev->num_mmio' failed. > > Thanks for trying this. > > Odd 'make check-qtest-lm32' didn't catch this... Oh it actually does... My bad! GTESTER check-qtest-lm32

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict >> *qdict) >> bool writable = qdict_get_try_bool(qdict, "writable", false); >> Error *local_err = NULL; >> >> -qmp_nbd_server_add(device, true,

Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

On 01/09/2018 01:37 PM, Marcelo Tosatti wrote: > > Improve hugepage allocation failure message, indicating > whats happening to the user. s/whats/what's/ > > Signed-off-by: Marcelo Tosatti > > diff --git a/exec.c b/exec.c > index 4722e521d4..439abedb98 100644 > ---

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Mon, Dec 25, 2017 at 07:54:00AM +, He, Junyan wrote: > > I am now focusing on snapshot optimization for Intel NVDimm kind memory. > > Different from the normal memory, the NVDimm may be 128G, 256G or even more > > for just one guest, and its

Re: [Qemu-devel] [PATCH] scripts: Remove fixed entries from the device-crash-test

On Mon, Dec 18, 2017 at 05:10:38PM +0100, Thomas Huth wrote: > These are crashes / errors which have been fixed already in the past > months. We can remove these from the device-crash-test script now. > > Signed-off-by: Thomas Huth Queued on machine-next. Sorry for the long

Re: [Qemu-devel] [PATCH for-2.12 v4 0/3] nvdimm: fixes for (non-)dax backends

Queued on machine-next. Thanks, and sorry for the long delay. On Mon, Dec 11, 2017 at 03:28:03PM +0800, Haozhong Zhang wrote: > Previous versions can be found at > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04785.html > v2:

Re: [Qemu-devel] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: The subject says what, but there is no commit body that says why. Presumably this makes writing the test in the next patch easier, but some details in the commit message would make this obvious. > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove

On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/201 | 130 > + > tests/qemu-iotests/201.out | 5 ++ > tests/qemu-iotests/group | 1

Re: [Qemu-devel] [PATCH 03/12] slirp: avoid IN6_IS_ADDR_UNSPECIFIED(), rather use in6_zero()

Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:55 -0300, wrote: > Host: Mac OS 10.12.5 > Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) > > slirp/ip6_icmp.c:80:38: warning: taking address of packed member 'ip_src' > of class or > structure 'ip6' may result in an unaligned

[Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

Improve hugepage allocation failure message, indicating whats happening to the user. Signed-off-by: Marcelo Tosatti diff --git a/exec.c b/exec.c index 4722e521d4..439abedb98 100644 --- a/exec.c +++ b/exec.c @@ -1643,7 +1643,8 @@ static void *file_ram_alloc(RAMBlock *block,

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Tue, Jan 9, 2018 at 11:58 AM, Kevin Wolf wrote: > Am 09.01.2018 um 07:24 hat Fam Zheng geschrieben: > > On Mon, 01/08 18:57, Kevin Wolf wrote: > > > I'm not sure if going back to the old behaviour for a while now would > be > > > helpful, you'd just end up with an even more

Re: [Qemu-devel] [PATCH v2 0/6] Replace has_dynamic_sysbus with list of allowed device types

Queued on machine-next. -- Eduardo

Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

On 01/09/18 17:37 -0200, Marcelo Tosatti wrote: > > Improve hugepage allocation failure message, indicating > whats happening to the user. > > Signed-off-by: Marcelo Tosatti > > diff --git a/exec.c b/exec.c > index 4722e521d4..439abedb98 100644 > --- a/exec.c > +++

Re: [Qemu-devel] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add

On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/147 | 68 > +- > tests/qemu-iotests/147.out | 4 +-- > 2 files changed, 57

Re: [Qemu-devel] [PATCH v2 0/7] macro do/while (0) cleanup

ping On 12/01/2017 05:24 PM, Eric Blake wrote: > Noticed this by chance in the tests/ directory, so I broadened > it to a grep of the entire code base. I suspect^wKNOW many of > the bad macros were the victims of copy-and-paste from some > other bad location (particularly given how many

[Qemu-devel] [PATCH v2 2.5/6] hmp: Add name parameter to nbd_server_add

Extend the flexibility of the previous QMP patch to also work in HMP. Signed-off-by: Eric Blake --- In response to Dave's request. I could also squash this into Vladimir's 2/6 if desired. hmp.c | 3 ++- hmp-commands.hx | 9 + 2 files changed, 7

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should

Re: [Qemu-devel] [PATCH for-2.11 v3 0/2] Check for the availability of a hotplug controller before adding a device

On Mon, Dec 18, 2017 at 12:59:50PM +0100, Thomas Huth wrote: > On 02.11.2017 11:10, Thomas Huth wrote: > > First patch is a small clean up to the error handling code in > > qdev_device_add(), and the second patch adds a proper check for > > the availability of a hotplug controller to prevent the

Re: [Qemu-devel] [PATCH v6 0/9] Add memfd memory backend

On Fri, Dec 22, 2017 at 07:48:43PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Oct 23, 2017 at 4:18 PM, Marc-André Lureau > wrote: > > Add a new Linux-specific memory backend, similar to hostmem-file, > > except that it doesn't need file path. It also try to

[Qemu-devel] [PATCHv2] linux-user: Fix sched_get/setaffinity conversion

sched_get/setaffinity linux-user syscalls were missing conversions for little/big endian, which is hairy since longs may not be the same size either. For simplicity, this just introduces loops to convert bit by bit like is done for select. Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

Hello, Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:53 -0300, wrote: > struct mbuf_ptr { > struct mbuf *mptr; > uint32_t dummy; > -} QEMU_PACKED; > +}; > #else > struct mbuf_ptr { > struct mbuf *mptr; > -} QEMU_PACKED; > +}; > @@ -199,7 +199,7 @@ struct ipovly { >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On 01/09/2018 01:58 PM, Ala Hino wrote: >>> I know this is debatable but I think the #1 purpose of image locking is >> to >>> prevent data corruption; >> >> Isn't potentially wrong output of 'qemu-img info' a form of data >> corruption? Not data as in disk content, but metadata is data, too. >>

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Tue, Jan 9, 2018 at 10:11 PM, Eric Blake wrote: > On 01/09/2018 01:58 PM, Ala Hino wrote: > > >>> I know this is debatable but I think the #1 purpose of image locking is > >> to > >>> prevent data corruption; > >> > >> Isn't potentially wrong output of 'qemu-img info' a

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

Thanks. How is your hand? Frediano - Original Message - > > On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote: > > ping > > > > > > > > ping > > > > > > > > > > > ping the series > > > > > > Was on sick leave for a few weeks, back now, will process asap but will >

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

On 01/09/2018 01:28 PM, Peter Maydell wrote: > On 9 January 2018 at 16:25, Philippe Mathieu-Daudé wrote: >> Hi Peter, >> >> On 01/09/2018 11:01 AM, Peter Maydell wrote: >>> Since ssi-sd is still using the legacy SD card API, the SD >>> card created by sd_init() is not plugged

[Qemu-devel] [PATCH v5 1/4] vhost: remove assertion to prevent crash

Start QEMU with more DIMM devices than limit but without any vhost backends and then hotplug a vhost user backend, the VM will be crashed. Instead of asserting in vhost_user_set_mem_table(), error number is used to gracefully prevent device to start. This fixes the crash issue. Cc:

Re: [Qemu-devel] [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

From: Jason Baron Date: Fri, 5 Jan 2018 17:44:54 -0500 > The ability to set speed and duplex for virtio_net is useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able

Re: [Qemu-devel] [PATCH v14 2/9] ACPI: Add APEI GHES table generation and CPER record support

On 3 January 2018 at 02:21, gengdongjiu wrote: > On 2017/12/28 22:18, Igor Mammedov wrote: >> On Thu, 28 Dec 2017 13:54:11 +0800 >> Dongjiu Geng wrote: >>> In order to simulation, we hard code the error >>> type to Multi-bit ECC. >> Not sure what

[Qemu-devel] [PATCH] lm32: take BQL before writing IP/IM register

Writing to these registers may raise an interrupt request. Actually, this prevents the milkymist board from starting. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael Walle --- target/lm32/op_helper.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v14 4/9] ACPI: enable APEI GHES in the configure file

On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak > and add build choice in the Makefile.objs. > > Signed-off-by: Dongjiu Geng > --- > default-configs/arm-softmmu.mak | 1 + >

Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

On 8 January 2018 at 17:49, Max Filippov wrote: > Hi Peter, > > please pull the following batch of updates for the target/xtensa. > Changes v1->v2: > - Drop no longer used function option_bits_enabled. > > The following changes since commit

Re: [Qemu-devel] [PATCH] irq: fix memory leak

On 25/12/2017 03:47, linzhecheng wrote: > entry is moved from list but is not freed. > > Signed-off-by: linzhecheng > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 351b64f77c..3c920db79a 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@

[Qemu-devel] [PATCH v4] target/xtensa: use libisa for instruction decoding

Replace manual opcode analysis with libisa-based code. This makes it possible to support variable-encoding instructions of the core ISA, like const16, and will allow to support advanced Xtensa features, like FLIX and TIE. Signed-off-by: Max Filippov --- Changes v3->v4: -

Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

On Tue, Jan 9, 2018 at 9:44 AM, Peter Maydell wrote: > /Users/pm215/src/qemu-for-merges/target/xtensa/helper.c:63:26: error: > implicit declaration of function 'g_malloc_n' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > config->opcode_ops =

Re: [Qemu-devel] [PULL] qemu-sparc updates

On 8 January 2018 at 19:31, Mark Cave-Ayland wrote: > Hi Peter, > > Here is the first set of SPARC updates for 2.12. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9: > > Merge remote-tracking

Re: [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check

* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 14 Dec 2017 15:20:10 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 13 Dec 2017 18:08:02 + > > > "Dr. David Alan Gilbert (git)" wrote: >

Re: [Qemu-devel] New documentation for the LatticeMicro32 target

Am 2018-01-09 12:58, schrieb Peter Maydell: I just fell over this, it looks like this fix never made it into master. Michael, could you submit this as a full patch with a commit message and signed-off-by, please? cc: qemu-sta...@nongnu.org as well, since it fixes a "breaks the board

Re: [Qemu-devel] [PATCH v2 16/20] fpu/softfloat: re-factor float to int/uint

On 01/09/2018 04:22 AM, Alex Bennée wrote: > We share the common int64/uint64_pack_decomposed function across all > the helpers and simply limit the final result depending on the final > size. > > Signed-off-by: Alex Bennée > > -- > v2 > - apply float_flg_invalid fixes

Re: [Qemu-devel] [PATCH v2 20/20] fpu/softfloat: re-factor compare

On 01/09/2018 04:22 AM, Alex Bennée wrote: > The compare function was already expanded from a macro. I keep the > macro expansion but move most of the logic into a compare_decomposed. > > Signed-off-by: Alex Bennée > > --- > v2 > - minor re-factor for better inf

[Qemu-devel] [PATCH v3] usb: Remove legacy -usbdevice options (host, serial, disk and net)

The option have been marked as deprecated since QEMU 2.10, and so far nobody complained that the host, serial, disk and net options are urgently required anymore. So let's now get rid at least of this legacy pile, to simplify the usb code quite a bit. This patch removes the usbdevices host,

Re: [Qemu-devel] [PATCH v1 for-2-12 13/15] s390x/tcg: STSI overhaul

On Mon, 11 Dec 2017 14:47:38 +0100 David Hildenbrand wrote: > Current STSI implementation is a mess, so let's rewrite it. > > Problems fixed by this patch: > 1) The order of exceptions/when recognized is wrong. > 2) We have to store to virtual address space, not absolute. > 3)

[Qemu-devel] [Bug 1727250] Re: qemu-io-test 147 segfaults when configured with gcov

The fix was committed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c4365735a7d38f4355c6f77e6670d3972315f7c2 commit c4365735a7d38f4355c6f77e6670d3972315f7c2 Author: Murilo Opsfelder Araujo Date: Fri Jan 5 11:32:41 2018 -0200 block/nbd: fix segmentation

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2-12 12/15] s390x/tcg: fix size + content of STSI blocks

On 11.12.2017 14:47, David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in /proc/sysinfo under TCG. (for > now,

[Qemu-devel] [PATCH v5 4/4] vhost: used_memslots refactoring

Used_memslots is shared by vhost kernel and user, it is equal to dev->mem->nregions, which is correct for vhost kernel, but not for vhost user, the latter one uses memory regions that have file descriptor. E.g. a VM has a vhost-user NIC and 8(vhost user memslot upper limit) memory slots, it will

Re: [Qemu-devel] [PATCH v5 5/7] vhost: Regenerate region list from changed sections list

* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 27 Dec 2017 14:19:03 +0100 > Igor Mammedov wrote: > > > On Mon, 18 Dec 2017 20:13:38 + > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" >

[Qemu-devel] [PATCH v5 3/4] vhost: fix memslot limit check

Since used_memslots will be updated to the actual value after registering memory listener for the first time, move the memslots limit checking to the right place. Signed-off-by: Jay Zhou --- hw/virtio/vhost.c | 19 --- 1 file changed, 12 insertions(+), 7

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

Re: [Qemu-devel] [PATCH v1 for-2-12 00/15] s390x: flic rework, tcg flic support and tcg

On Mon, 11 Dec 2017 14:47:25 +0100 David Hildenbrand wrote: > This patch series implements floating interrupt support for TCG and fixes > STSI so we can remove warnings related to s390x SMP and MTTCG. > > KVM code has to be touched in order to factor out the injection routines

[Qemu-devel] [Bug 1727259] Re: qemu-io-test 58 segfaults when configured with gcov

The fix was committed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c4365735a7d38f4355c6f77e6670d3972315f7c2 commit c4365735a7d38f4355c6f77e6670d3972315f7c2 Author: Murilo Opsfelder Araujo Date: Fri Jan 5 11:32:41 2018 -0200 block/nbd: fix segmentation

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

Quoting Paolo Bonzini (2018-01-09 11:34:48) > On 09/01/2018 17:02, Michael Roth wrote: > >> so you can see it's already diverged because it prints out > >> a different value for the name of the pci node and the > >> SCSI line has 8200 vs . > > FYI I actually see this with a

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

On 01/09/2018 12:05 PM, Paolo Bonzini wrote: > On 08/01/2018 04:09, Fam Zheng wrote: >> After the out label there is a check on iTask.task but it is not >> initialized yet. >> >> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 >> Signed-off-by: Fam Zheng >> --- >> block/iscsi.c

Re: [Qemu-devel] [PULL 00/14] Migration pull request

On 5 January 2018 at 09:59, Juan Quintela wrote: > Eric Blake wrote: >> On 01/03/2018 03:38 AM, Juan Quintela wrote: >>> Hi >>> >>> This are the changes for migration that are already reviewed. >>> >>> Please, apply. >>> >> >>> Alexey Perevalov (6): >>>

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

On Tue, Jan 09, 2018 at 04:35:30PM +, Peter Maydell wrote: > On 9 January 2018 at 16:29, Laszlo Ersek wrote: > > On 01/09/18 17:12, Peter Maydell wrote: > >> On 9 January 2018 at 15:58, Laszlo Ersek wrote: > >>> Sorry, no clue about any of this -- where

[Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the RTC device

Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 14 ++ include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 325642058b..deef583c2a 100644 ---

[Qemu-devel] [PATCH v1 1/3] xlnx-zynqmp-rtc: Initial commit

Initial commit of the ZynqMP RTC device. Signed-off-by: Alistair Francis --- hw/timer/Makefile.objs | 1 + hw/timer/xlnx-zynqmp-rtc.c | 232 + include/hw/timer/xlnx-zynqmp-rtc.h | 84 ++ 3 files

[Qemu-devel] [PATCH v1 2/3] xlnx-zynqmp-rtc: Add basic time support

Allow the guest to determine the time set from the QEMU command line. Signed-off-by: Alistair Francis --- hw/timer/xlnx-zynqmp-rtc.c | 24 include/hw/timer/xlnx-zynqmp-rtc.h | 2 ++ 2 files changed, 26 insertions(+) diff --git

[Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

v4 -> v5: Making the followed up device_add to fall back to userspace virtio when netdev_add fails if vhost force flag does not set. Jay Zhou (4): vhost: remove assertion to prevent crash tap: do not close fd if only vhost failed to initialize vhost: fix memslot limit check vhost:

[Qemu-devel] [PATCH v5 2/4][RFC] tap: do not close fd if only vhost failed to initialize

Making the followed up device_add to fall back to userspace virtio when netdev_add fails if vhost force flag does not set. Suggested-by: Michael S. Tsirkin Suggested-by: Igor Mammedov Signed-off-by: Jay Zhou --- net/tap.c | 25

Re: [Qemu-devel] [PATCH v2 10/20] fpu/softfloat: define decompose structures

On 01/09/2018 04:22 AM, Alex Bennée wrote: > +float_class_qnan, > +float_class_snan, > +float_class_dnan, /* default nan */ here wouldn't go amiss. > +float_class_msnan, /* maybe silenced */ r~

Re: [Qemu-devel] [PATCH v14 9/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA which is delivered by host to guest PA, then fill > this PA to CPER and fill the CPER to guest APEI GHES memory, finally >

Re: [Qemu-devel] [PATCH v6 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

On Wed, 20 Dec 2017 09:24:41 -0800 Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

On 01/09/18 17:35, Peter Maydell wrote: > On 9 January 2018 at 16:29, Laszlo Ersek wrote: >> On 01/09/18 17:12, Peter Maydell wrote: >>> On 9 January 2018 at 15:58, Laszlo Ersek wrote: Sorry, no clue about any of this -- where should I read up? >>> >>>

Re: [Qemu-devel] [PATCH v2 19/20] fpu/softfloat: re-factor minmax

On 01/09/2018 04:22 AM, Alex Bennée wrote: > Let's do the same re-factor treatment for minmax functions. I still > use the MACRO trick to expand but now all the checking code is common. > > Signed-off-by: Alex Bennée > > --- > v2 > - minor indentation fix > --- >

Re: [Qemu-devel] [PATCH v14 5/9] target-arm: kvm64: inject synchronous External Abort

On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add synchronous external abort injection logic, setup > exception type and syndrome value. When switch to guest, > guest will jump to the synchronous external abort vector > table entry. > > The ESR_ELx.DFSC is set to

[Qemu-devel] [PATCH] fixup! i386: Change X86CPUDefinition::model_id to const char*

On Tue, Jan 09, 2018 at 01:45:13PM -0200, Eduardo Habkost wrote: > It is valid to have a 48-character model ID on CPUID, however the > definition of X86CPUDefinition::model_id is char[48], which can > make the compiler drop the null terminator from the string. > > If a CPU model happens to have

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Allow user to specify name for new export, to not reuse internal > node name and to not show it to clients. > > This also allows creating several exports per device. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v1 for-2-12 08/15] s390x/flic: make floating interrupts on TCG actually floating

On Mon, 11 Dec 2017 14:47:33 +0100 David Hildenbrand wrote: > Move floating interrupt handling into the flic. Floating interrupts > will now be considered by all CPUs, not just CPU #0. While at it, convert > I/O interrupts to use a list and make sure we properly consider I/O >

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

On 01/09/2018 06:43 AM, Peter Maydell wrote: > On 9 January 2018 at 14:20, Laurent Vivier wrote: >> Le 09/01/2018 à 15:14, Peter Maydell a écrit : >>> Is gcc's codegen still bad enough that we have to default to not >>> using the type-checking versions? If so, maybe we could at

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

Hey Philippe, Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: Create the SDCard in the realize() function. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Peter Maydell wrote: > On 5 January 2018 at 09:59, Juan Quintela wrote: >> Eric Blake wrote: >>> On 01/03/2018 03:38 AM, Juan Quintela wrote: Hi This are the changes for migration that are already reviewed.

[Qemu-devel] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

Since ssi-sd is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

[Qemu-devel] [PATCH 4/4] hw/sd/omap_mmc: Reset SD card on controller reset

Since omap_mmc is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

On Tue, Dec 19, 2017 at 04:45:51PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index b571866659..505db439d8 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1090,6 +1090,44 @@ static void qmp_caps_apply(Monitor *mon, > QMPCapabilityList *list) > } > } > > +/* > + *

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

On 2018-01-09 13:27, Laurent Vivier wrote: > Le 09/01/2018 à 13:22, Alex Bennée a écrit : > > It's not actively built and when enabled things fail to compile. I'm > > not sure the type-checking is really helping here. Seeing as we "own" > > our softfloat now lets remove the cruft. > > I think it

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

On 9 January 2018 at 14:12, Aurelien Jarno wrote: > On 2018-01-09 13:27, Laurent Vivier wrote: >> Le 09/01/2018 à 13:22, Alex Bennée a écrit : >> > It's not actively built and when enabled things fail to compile. I'm >> > not sure the type-checking is really helping here.

Re: [Qemu-devel] [PATCH] linux-user/arm/nwfpe: Check coprocessor number for FPA emulation

On 29 November 2017 at 09:30, Richard Henderson wrote: > On 11/28/2017 05:34 PM, Peter Maydell wrote: >> Our copy of the nwfpe code for emulating of the old FPA11 floating >> point unit doesn't check the coprocessor number in the instruction >> when it emulates it.

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

Le 09/01/2018 à 15:14, Peter Maydell a écrit : > On 9 January 2018 at 14:12, Aurelien Jarno wrote: >> On 2018-01-09 13:27, Laurent Vivier wrote: >>> Le 09/01/2018 à 13:22, Alex Bennée a écrit : It's not actively built and when enabled things fail to compile. I'm

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/intc/armv7m: Support byte and halfword accesses to CFSR

Ping for code review? thanks -- PMM On 8 December 2017 at 14:12, Peter Maydell wrote: > The Configurable Fault Status Register for ARMv7M and v8M is > supposed to be byte and halfword accessible, but we were only > implementing word accesses. Add support for the other

Re: [Qemu-devel] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions

On 12 December 2017 at 17:39, Richard Henderson wrote: > On 12/12/2017 04:08 AM, Peter Maydell wrote: >> Refactor disas_thumb2_insn() so that it generates the code for raising >> an UNDEF exception for invalid insns, rather than returning a flag >> which the caller

Re: [Qemu-devel] [PATCH] get_phys_addr_pmsav7: Support AP=0b111 for v7M

Ping for code review? thanks -- PMM On 8 December 2017 at 14:13, Peter Maydell wrote: > For PMSAv7, the v7A/R Arm ARM defines that setting AP to 0b111 > is an UNPREDICTABLE reserved combination. However, for v7M > this value is documented as having the same behaviour

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

Ping for code review? thanks -- PMM On 13 December 2017 at 16:52, Peter Maydell wrote: > The GICv2 and GICv3 specifications say that reserved register > addresses should RAZ/WI. This means we need to return MEMTX_OK, not > MEMTX_ERROR, because now that we support

[Qemu-devel] [PATCH 1/4] hw/sd/pl181: Reset SD card on controller reset

Since pl181 is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

Re: [Qemu-devel] [RFC v6 22/27] qmp: isolate responses into io thread

On Tue, Dec 19, 2017 at 04:45:52PM +0800, Peter Xu wrote: > +static void monitor_qmp_bh_responder(void *opaque) > +{ > +QMPResponse response; > + > +while (true) { > +response = monitor_qmp_response_pop_one(); > +if (!response.data) { > +break; > +} > +

[Qemu-devel] [PATCH 0/4] Reset SD cards attached to legacy-API controllers

It turns out that we don't reset the SD card model if it's attached to a legacy-API controller. For new-style controllers where the SD card object is attached to an SD_BUS, the generic qbus infrastructure takes care of ensuring that the card's DeviceState::reset method gets called. But for the

[Qemu-devel] [PATCH 2/4] hw/sd/milkymist-memcard: Reset SD card on controller reset

Since pl181 is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

Re: [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed

On Tue, Dec 19, 2017 at 04:45:53PM +0800, Peter Xu wrote: > Start to use dedicate IO thread for QMP monitors that are not using > MUXed chardev. > > Signed-off-by: Peter Xu > --- > monitor.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Stefan

Re: [Qemu-devel] [PATCH v1 01/21] RISC-V Maintainers

On Tue, Jan 2, 2018 at 4:44 PM, Michael Clark wrote: > Add Michael Clark, Sagar Karandikar and Bastian Koppelmann as > RISC-V Maintainers. > > Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Alistair > --- >

Re: [Qemu-devel] [PATCH 2/2] hw/intc/arm_gic: reserved register addresses are RAZ/WI

On Wed, Dec 13, 2017 at 8:52 AM, Peter Maydell wrote: > The GICv2 specification says that reserved register addresses > must RAZ/WI; now that we implement external abort handling > for Arm CPUs this means we must return MEMTX_OK rather than > MEMTX_ERROR, to avoid

Re: [Qemu-devel] [PATCH v5 05/31] sdhci: add DMA and 64-bit capabilities (Spec v2)

On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci-internal.h | 14 +++--- > include/hw/sd/sdhci.h | 4 > hw/sd/sdhci.c | 40 ++--

Re: [Qemu-devel] [PATCH v5 26/31] sdhci: remove the deprecated 'capareg' property

On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > All SDHCI consumers have been upgraded to set correct properties. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [Qemu-devel] [PATCH] maint: Mention web site maintenance in README

On 11/29/2017 09:25 AM, Eric Blake wrote: > Now that we have a website that accepts patches on the list, the > main project should make it easier to find information about that > process. > > Signed-off-by: Eric Blake > --- > > Doc only, so it could go in -rc3 if we have a

Re: [Qemu-devel] [RFC v6 02/27] qobject: introduce qstring_get_try_str()

On 12/19/2017 02:45 AM, Peter Xu wrote: > The only difference from qstring_get_str() is that it allows the qstring > to be NULL. If so, NULL is returned. > > CC: Eric Blake > CC: Markus Armbruster > Reviewed-by: Fam Zheng > Reviewed-by:

Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init

On 12/19/2017 02:45 AM, Peter Xu wrote: > There are many places for monitor init its globals, at least: Reads awkwardly; maybe: ...many places where the monitor initializes its globals,... > > - monitor_init_qmp_commands() at the very beginning > - single function to init monitor_lock > - in

  1   2   3   >