Re: [PATCH 3/7] block/nvme: don't access CQE after moving cq.head

On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: > Do not access a CQE after incrementing q->cq.head and releasing q->lock. > It is unlikely that this causes problems in practice but it's a latent > bug. > > The reason why it should be safe at the moment is that completion > processing is not

Re: [PATCH 5/7] block/nvme: clarify that free_req_queue is protected by q->lock

On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: > Existing users access free_req_queue under q->lock. Document this. > > Signed-off-by: Stefan Hajnoczi > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/nvme.c > index

Re: [PATCH 2/7] block/nvme: drop tautologous assertion

On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: > nvme_process_completion() explicitly checks cid so the assertion that > follows is always true: > > if (cid == 0 || cid > NVME_QUEUE_SIZE) { > ... > continue; > } > assert(cid <= NVME_QUEUE_SIZE); > > Signed-off-by: Stefan Hajnoczi

Re: [PATCH v2 1/2] qapi: Fix comment format for @CpuInstanceProperties

On Tue, 26 May 2020 10:25:34 +0200 Michal Privoznik wrote: > In 176d2cda0de, the @die-id attribute was introduced to > CpuInstanceProperties type. However, it mangled the comment. > > Signed-off-by: Michal Privoznik Reviewed-by: Igor Mammedov > --- > qapi/machine.json | 3 ++- > 1 file

[PULL 06/14] hw/pci-host/bonito: Map the different PCI ranges more detailed

Better describe the Bonito64 MEM HI/LO and I/O PCI ranges, add more PCI regions as unimplemented. Reviewed-by: Aleksandar Markovic Message-id: <20200526104726.11273-7-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 32 1 file

[PULL 14/14] MAINTAINERS: Change Aleksandar Rikalo's email address

From: Aleksandar Markovic Aleksandar Rikalo wants to use a different email address from now on. Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-id:

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: > On 26.05.20 15:28, Vivek Goyal wrote: > > On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > >> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > >> results in > >> "virtio-pmem-pci not

[PATCH] iotests: Dump QCOW2 dirty bitmaps metadata

Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script. The sample output: Header extension (Bitmaps): magic 0x23852875 length24 nb_bitmaps2 reserved320 bitmap_directory_size 0x40 bitmap_directory_offset

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

On 5/19/20 12:54 PM, Vladimir Sementsov-Ogievskiy wrote: > 19.05.2020 03:27, John Snow wrote: >> >> >> On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 18.05.2020 21:23, John Snow wrote: On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.05.2020 08:53, John

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

On 5/14/20 4:26 PM, John Snow wrote: > > > On 5/14/20 9:55 AM, Eric Blake wrote: >> On 5/14/20 12:53 AM, John Snow wrote: >>> Catch only the timeout error; if there are other problems, allow the >>> stack trace to be visible. >>> >> >> A lot of patches in this series start with "python//" - is

Re: [PATCH 13/19] accel/tcg: Fixed tsan warnings.

On Sat, 23 May 2020 at 16:06, Emilio G. Cota wrote: > > On Fri, May 22, 2020 at 12:07:49 -0400, Robert Foley wrote: > > For example: > > WARNING: ThreadSanitizer: data race (pid=35425) > > Write of size 4 at 0x7bbc00ac by main thread (mutexes: write M875): > > #0 cpu_reset_interrupt

Re: [PATCH 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name

On Tue, May 26, 2020 at 14:37:41 +0200, Aleksandar Markovic wrote: > > > > > > +mips ``fulong2e`` machine (since 5.1) > > > +' > > > + > > > +This machine has been renamed ``fuloong2e``. > > > + > > > > Libvirt doesn't have any special handling for this machine

Re: [RFC v3 0/4] QEMU cpus.c refactoring

Some comments on patchew output: On 5/26/20 12:58 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200525145440.29728-1-cfont...@suse.de/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id:

Re: [PATCH v7 00/32] Add subcluster allocation to qcow2

Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id

On Tue, 26 May 2020 10:25:35 +0200 Michal Privoznik wrote: > If a management application (like Libvirt) want's to preserve > migration ability and switch to '-machine memory-backend' it > needs to set exactly the same RAM id as QEMU would. Since the id > is machine type dependant, expose it

Re: [PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id

On Tue, 26 May 2020 10:25:35 +0200 Michal Privoznik wrote: > If a management application (like Libvirt) want's to preserve > migration ability and switch to '-machine memory-backend' it > needs to set exactly the same RAM id as QEMU would. Since the id > is machine type dependant, expose it

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > results in > "virtio-pmem-pci not supported on this bus" > > Reasons is, that the bus does not support hotplug and, therefore, does > not have a hotplug

[PULL 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name

We always miswrote the Fuloong machine... Fix its name. Add an machine alias to the previous name for backward compatibility. Suggested-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-id: <20200526104726.11273-11-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 02/19] cpu: convert queued work to a QSIMPLEQ

On Sun, 24 May 2020 at 06:21, Philippe Mathieu-Daudé wrote: > > On 5/22/20 6:07 PM, Robert Foley wrote: > > From: "Emilio G. Cota" > > > > Instead of open-coding it. > > Please use a full sentence (repeating the patch subject): > > "Convert queued work to a QSIMPLEQ instead of open-coding it." >

Re: [PATCH v2 2/8] qapi/misc: Restrict LostTickPolicy enum to machine code

On Mon, 16 Mar 2020 01:03:42 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > qapi/machine.json| 32 > qapi/misc.json | 32 >

[Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

I haven't worked on this topic in years. ** Changed in: qemu Status: In Progress => Confirmed ** Changed in: qemu Assignee: Greg Kurz (gkurz) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name

уто, 26. мај 2020. у 14:50 Peter Krempa је написао/ла: > > On Tue, May 26, 2020 at 14:37:41 +0200, Aleksandar Markovic wrote: > > > > > > > > +mips ``fulong2e`` machine (since 5.1) > > > > +' > > > > + > > > > +This machine has been renamed ``fuloong2e``. > > >

Re: [PATCH 00/14] hw/mips: patch queue for 2020-05-26

уто, 26. мај 2020. у 13:06 Aleksandar Markovic је написао/ла: > > уто, 26. мај 2020. у 12:47 Philippe Mathieu-Daudé је > написао/ла: > > > > Hi, > > > > This is the current state of my hw/mips/next tree. > > > > - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, > > and update

[PULL 05/14] hw/pci-host/bonito: Map all the Bonito64 I/O range

To ease following guest accesses to the Bonito64 chipset, map its I/O range as UnimplementedDevice. We can now see the accesses to unimplemented peripheral using the '-d unimp' command line option. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-9-f4...@amsat.org>

[PULL 02/14] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge

From: Philippe Mathieu-Daudé Ease the kconfig selection by introducing CONFIG_PCI_BONITO to select the Bonito North Bridge. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé Message-id: <20200510210128.18343-6-f4...@amsat.org> Reviewed-by: Huacai Chen Signed-off-by:

[PULL 03/14] hw/pci-host/bonito: Fix DPRINTF() format strings

Reviewed-by: Huacai Chen Message-id: <20200510210128.18343-7-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index f212796044..b874468ea6 100644

[PULL 04/14] hw/pci-host/bonito: Map peripheral using physical address

Peripherals are mapped at physical address on busses. Only CPU/IOMMU can use virtual addresses. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-8-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PULL 08/14] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32

Describe some bits of the Config registers fields with the registerfields API. Use the FIELD_DP32() macro to set the BONGENCFG register bits at reset. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-12-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

On 26.05.20 15:28, Vivek Goyal wrote: > On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: >> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices >> results in >> "virtio-pmem-pci not supported on this bus" >> >> Reasons is, that the bus does not support

Re: [PATCH 18/19] target/arm: Fix tsan warning in cpu.c

On Sat, 23 May 2020 at 13:18, Emilio G. Cota wrote: > > On Fri, May 22, 2020 at 23:36:18 +0100, Peter Maydell wrote: > > So is this: > > (a) a TSan false positive, because we've analysed the use > > of this struct field and know it's not a race because > > [details], but which we're

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

On 26.05.20 16:22, Vivek Goyal wrote: > On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: >> On 26.05.20 15:28, Vivek Goyal wrote: >>> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices

Re: [PATCH 0/2] tests/qtest/fuzz: Avoid QTest serialization

On 200526 1725, Philippe Mathieu-Daudé wrote: > On 5/26/20 4:56 PM, Alexander Bulekov wrote: > > On 200526 1105, Philippe Mathieu-Daudé wrote: > >> On 5/26/20 10:56 AM, Stefan Hajnoczi wrote: > >>> On Tue, May 26, 2020 at 07:58:18AM +0200, Philippe Mathieu-Daudé wrote: > Hi Alexander, >

Re: [PATCH 00/19] Add Thread Sanitizer support to QEMU

On Sat, 23 May 2020 at 17:36, Emilio G. Cota wrote: > > On Fri, May 22, 2020 at 12:07:36 -0400, Robert Foley wrote: > > This patch series continues the work done by Emilio Cota and others to add > > Thread Sanitizer (TSan) support to QEMU. > > > > The starting point for this work was Emilio's

Re: [PATCH 14/19] util/async: Fixed tsan warnings

On Sat, 23 May 2020 at 16:12, Emilio G. Cota wrote: > > On Fri, May 22, 2020 at 12:07:50 -0400, Robert Foley wrote: > > > QSIMPLEQ_INSERT_TAIL(>bh_slice_list, , next); > > > > while ((s = QSIMPLEQ_FIRST(>bh_slice_list))) { > > @@ -280,14 +285,16 @@ aio_ctx_check(GSource *source) > >

Re: [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair

On 5/26/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: >> Passing around both BDRVNVMeState and NVMeQueuePair is unwiedly. Reduce Oh, and typo "unwieldy". >> the number of function arguments by keeping the BDRVNVMeState pointer in >> NVMeQueuePair. This

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

On Mon, May 18, 2020 at 08:27:54PM -0400, John Snow wrote: > > > On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: > > 18.05.2020 21:23, John Snow wrote: > >> > >> > >> On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: > >>> 14.05.2020 08:53, John Snow wrote: > move

Re: [PATCH 14/19] util/async: Fixed tsan warnings

Hi Stefan, On Tue, 26 May 2020 at 06:32, Stefan Hajnoczi wrote: > > On Fri, May 22, 2020 at 12:07:50PM -0400, Robert Foley wrote: > > For example: > > Atomic write of size 8 at 0x7b4800113c28 by main thread (mutexes: write > > M30): > > #0 __tsan_atomic64_exchange

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

On 5/26/20 5:22 PM, Daniel P. Berrangé wrote: > On Mon, May 18, 2020 at 08:27:54PM -0400, John Snow wrote: >> >> >> On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 18.05.2020 21:23, John Snow wrote: On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.05.2020

Re: [PATCH 0/2] tests/qtest/fuzz: Avoid QTest serialization

On 5/26/20 4:56 PM, Alexander Bulekov wrote: > On 200526 1105, Philippe Mathieu-Daudé wrote: >> On 5/26/20 10:56 AM, Stefan Hajnoczi wrote: >>> On Tue, May 26, 2020 at 07:58:18AM +0200, Philippe Mathieu-Daudé wrote: Hi Alexander, I forgot to share these 2 patches wrote before

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

Just to clarify my last comment, and in absence of updates, if I launch the VM as: qemu-system-x86_64 \ -drive if=virtio,file=/home/oc/VM/img/openbsd.image,index=0,media=disk \ -drive if=virtio,file=/home/oc/VM/img/openbsd.image.old,index=1,media=disk \ -M q35,accel=kvm,graphics=on -m 250M -cpu

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

On Tue, May 26, 2020 at 05:23:42PM +0200, Philippe Mathieu-Daudé wrote: > On 5/26/20 5:22 PM, Daniel P. Berrangé wrote: > > On Mon, May 18, 2020 at 08:27:54PM -0400, John Snow wrote: > >> > >> > >> On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: > >>> 18.05.2020 21:23, John Snow wrote: >

Re: [PATCH 2/2] tests/qtest/fuzz: Avoid QTest mmio serialization

On 200526 0758, Philippe Mathieu-Daudé wrote: > We don't need to serialize over QTest chardev when we can > directly access the MMIO address space via the first > registered CPU view. > > virtio-net-socket gets ~50% performance improvement. One option might be to write alternate (direct)

Re: [PATCH v2 5/7] sm501: Replace hand written implementation with pixman where possible

On Tue, 26 May 2020, Gerd Hoffmann wrote: On Thu, May 21, 2020 at 09:39:44PM +0200, BALATON Zoltan wrote: Besides being faster this should also prevent malicious guests to abuse 2D engine to overwrite data or cause a crash. uint32_t src_base = s->twoD_source_base & 0x03FF; -

[PULL 07/14] hw/pci-host/bonito: Better describe the I/O CS regions

Better describe the I/O CS regions, add the ROMCS region. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-11-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[PULL 09/14] hw/mips/fuloong2e: Move code and update a comment

Move the RAM-related call closer to the RAM creation block, rename the ROM comment. Reviewed-by: Huacai Chen Message-id: <20200510210128.18343-4-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_fulong2e.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

> If nobody objects, I will instruct Ahmed to file a bug in QEMU Bugzilla. > Ahmed, please follow the instructions on this page: How to report a QEMU bug and file the bug related to the discussion, to the best of your abilities, if possible, today.

Re: [PATCH 1/1] util/oslib: Returns real thread identifier on FreeBSD and NetBSD

Reviewed-by: Kamil Rytarowski On 26.05.2020 09:29, David CARLIER wrote: > From 792fbcd9114f43bd80fd1ef5b25cd9935a536f9f Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Tue, 26 May 2020 08:25:26 +0100 > Subject: [PATCH] util/oslib: Returns the real thread identifier on FreeBSD and >

Re: [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair

On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: > Passing around both BDRVNVMeState and NVMeQueuePair is unwiedly. Reduce > the number of function arguments by keeping the BDRVNVMeState pointer in > NVMeQueuePair. This will come in handly when a BH is introduced in a > later patch and only one argument

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

On Sat, 23 May 2020 at 12:55, Philippe Mathieu-Daudé wrote: > > Hi Robert, > > On 5/22/20 6:07 PM, Robert Foley wrote: > > From: Lingfeng Yang > > > > We tried running QEMU under tsan in 2016, but tsan's lack of support for > > longjmp-based fibers was a blocker: > > @@ -6277,6 +6304,14 @@ if

Re: [PATCH 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name

> > > > +mips ``fulong2e`` machine (since 5.1) > > +' > > + > > +This machine has been renamed ``fuloong2e``. > > + > > Libvirt doesn't have any special handling for this machine so this > shouldn't impact us. > Well, Peter, I was also wondering libvirt listed

Re: [PATCH 00/14] hw/mips: patch queue for 2020-05-26

уто, 26. мај 2020. у 15:14 Aleksandar Markovic је написао/ла: > > уто, 26. мај 2020. у 13:06 Aleksandar Markovic > је написао/ла: > > > > уто, 26. мај 2020. у 12:47 Philippe Mathieu-Daudé је > > написао/ла: > > > > > > Hi, > > > > > > This is the current state of my hw/mips/next tree. > > > > >

Re: [PATCH 00/14] hw/mips: patch queue for 2020-05-26

On 5/26/20 3:14 PM, Aleksandar Markovic wrote: > уто, 26. мај 2020. у 13:06 Aleksandar Markovic > је написао/ла: >> >> уто, 26. мај 2020. у 12:47 Philippe Mathieu-Daudé је >> написао/ла: >>> >>> Hi, >>> >>> This is the current state of my hw/mips/next tree. >>> >>> - MAINTAINERS updated to

Re: [PATCH 00/14] hw/mips: patch queue for 2020-05-26

уто, 26. мај 2020. у 15:20 Philippe Mathieu-Daudé је написао/ла: > > On 5/26/20 3:14 PM, Aleksandar Markovic wrote: > > уто, 26. мај 2020. у 13:06 Aleksandar Markovic > > је написао/ла: > >> > >> уто, 26. мај 2020. у 12:47 Philippe Mathieu-Daudé је > >> написао/ла: > >>> > >>> Hi, > >>> > >>>

Re: [PATCH 00/14] hw/mips: patch queue for 2020-05-26

On 5/26/20 3:29 PM, Aleksandar Markovic wrote: > уто, 26. мај 2020. у 15:20 Philippe Mathieu-Daudé је > написао/ла: >> >> On 5/26/20 3:14 PM, Aleksandar Markovic wrote: >>> уто, 26. мај 2020. у 13:06 Aleksandar Markovic >>> је написао/ла: уто, 26. мај 2020. у 12:47 Philippe

[PULL 13/14] hw/mips/mips_int: De-duplicate KVM interrupt delivery

Refactor duplicated code in a single place. Reviewed-by: Thomas Huth Message-Id: <20200429082916.10669-2-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_int.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/mips/mips_int.c

Re: [PATCH 12/19] configure: added tsan support for blacklist.

On Sat, 23 May 2020 at 13:27, Emilio G. Cota wrote: > > On Fri, May 22, 2020 at 12:07:48 -0400, Robert Foley wrote: > > Initially put several files into blacklist that were > > causing the most problems, namely bitops.c and bitmap.c. > > > > Signed-off-by: Robert Foley > > --- > > configure

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

On Tue, May 26, 2020 at 04:43:35PM +0200, David Hildenbrand wrote: > On 26.05.20 16:22, Vivek Goyal wrote: > > On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: > >> On 26.05.20 15:28, Vivek Goyal wrote: > >>> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: >

Re: [PATCH 0/2] tests/qtest/fuzz: Avoid QTest serialization

On 200526 1105, Philippe Mathieu-Daudé wrote: > On 5/26/20 10:56 AM, Stefan Hajnoczi wrote: > > On Tue, May 26, 2020 at 07:58:18AM +0200, Philippe Mathieu-Daudé wrote: > >> Hi Alexander, > >> > >> I forgot to share these 2 patches wrote before > >> the direct MemoryRegion fuzzer sent yesterday. >

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

On 5/14/20 7:53 AM, John Snow wrote: > Catch only the timeout error; if there are other problems, allow the > stack trace to be visible. > > Signed-off-by: John Snow > --- > python/qemu/lib/machine.py | 33 + > 1 file changed, 21 insertions(+), 12 deletions(-) >

Re: [PATCH 0/4] fuzz: misc changes for oss-fuzz compatability

On Mon, May 11, 2020 at 11:01:29PM -0400, Alexander Bulekov wrote: > Hello, > With these patches, the fuzzer passes the oss-fuzz build checks. > There are also some miscelanous improvement to the fuzzer, in general: > * If building for oss-fuzz, check executable_dir/pc-bios for >the bios

Re: [PATCH 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name

On 5/26/20 2:37 PM, Aleksandar Markovic wrote: >>> >>> +mips ``fulong2e`` machine (since 5.1) >>> +' >>> + >>> +This machine has been renamed ``fuloong2e``. >>> + >> >> Libvirt doesn't have any special handling for this machine so this >> shouldn't impact us. >>

Re: [PULL 0/8] Audio 20200526 patches

are available in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20200526-pull-request > > for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02: > > hw/mips/mips_fulong2e: Remove unused 'audio/audi

[PULL 00/14] mips-hw-next patches for 2020-05-26

The following changes since commit 8f72c75cfc9b3c84a9b5e7a58ee5e471cb2f19c8: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20200526-pull-reque= st' into staging (2020-05-26 10:59:01 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-hw-next

[PULL 01/14] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer

From: Huacai Chen I submitted the MIPS/fuloong2e support about ten years ago, and after that I became a MIPS kernel developer. Last year, Philippe Mathieu- Daudé asked me that whether I can be a reviewer of MIPS/fuloong2e, and I promised that I will do some QEMU work in the next year (i.e., 2020

[PULL 11/14] hw/mips: Rename malta/mipssim/r4k/jazz files

From: Aleksandar Markovic Machine file names should not have prefix "mips_". Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-id: <20200518200920.17344-22-aleksandar.qemu.de...@gmail.com> [PMD: Fixed Fuloong line conflict due to rebase] Signed-off-by: Philippe

[PULL 12/14] hw/mips/malta: Add some logging for bad register offset cases

From: Aleksandar Markovic Log the cases where a guest attempts read or write using bad register offset. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-id: <20200518200920.17344-21-aleksandar.qemu.de...@gmail.com> [PMD:

Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part)

On Sat, May 23, 2020 at 07:20:24PM -0400, Peter Xu wrote: > I gave it a shot with a 24G guest, 8 vcpus, using 10g NIC as migration > channel. When idle or dirty workload small, I don't observe major > difference on total migration time. When with higher random dirty > workload (800MB/s dirty

Re: [PATCH v2 6/8] s390/sclp: add extended-length sccb support for kvm guest

On 5/25/20 6:50 AM, Janosch Frank wrote: > On 5/18/20 4:31 PM, Collin Walling wrote: >> On 5/18/20 4:55 AM, Janosch Frank wrote: >>> On 5/16/20 12:20 AM, Collin Walling wrote: As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store

Re: [PATCH v6 07/20] hw/block/nvme: fix pin-based interrupt behavior

On Thu, May 14, 2020 at 06:45:58AM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > First, since the device only supports MSI-X or pin-based interrupt, if > MSI-X is not enabled, it should not accept interrupt vectors different > from 0 when creating completion queues. > > Secondly, the

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote: > +Laurent > > On 5/26/20 11:04 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 5/26/20 9:38 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé A

Re: [PATCH] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

ping? On 5/15/20 10:42 AM, Philippe Mathieu-Daudé wrote: > The Fuloong machine never had to use "audio/audio.h", remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_fulong2e.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_fulong2e.c

[PATCH 03/14] hw/display/cirrus_vga: Convert debug printf() to trace event

Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 4 +--- hw/display/trace-events | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 1f29731ffe..33ccdde000 100644 --- a/hw/display/cirrus_vga.c +++

[PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf

Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP), and add a new one in cirrus_linear_bitblt_read(). Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/display/cirrus_vga.c

[PATCH 06/14] hw/display/cirrus_vga: Convert debug printf() to trace event

Convert the final bit of DEBUG_BITBLT to a tracepoint. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 24 ++-- hw/display/trace-events | 1 + 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/display/cirrus_vga.c

[PATCH 12/14] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR)

Replace DPRINT_ERROR() by qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daudé --- hw/display/exynos4210_fimd.c | 46 +++- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c

[PATCH 13/14] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)

Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is disabled by default. This avoid flooding the terminal when fuzzing the device. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/omap_dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/omap_dss.c

Re: [PATCH] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

ping? On 5/15/20 10:42 AM, Philippe Mathieu-Daudé wrote: > The Fuloong machine never had to use "audio/audio.h", remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_fulong2e.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_fulong2e.c

Re: [PATCH v7 00/32] Add subcluster allocation to qcow2

Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH 08/14] hw/display/dpcd: Convert debug printf()s to trace events

Convert DPRINTF() to trace events and remove ifdef'ry. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/dpcd.c | 16 +++- hw/display/trace-events | 4 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/hw/display/dpcd.c b/hw/display/dpcd.c index

[PATCH 00/14] hw/display: Omnibus cleanups

Hi Gerd, for your convenience I joined all the hw/display/ patches I sent recently altogether in a series. Regards, Phil. Philippe Mathieu-Daudé (14): hw/display/edid: Add missing 'qdev-properties.h' header hw/display/cg3: Convert debug printf()s to trace events hw/display/cirrus_vga:

[PATCH 02/14] hw/display/cg3: Convert debug printf()s to trace events

Convert DPRINTF() to trace events and remove ifdef'ry. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cg3.c| 14 -- hw/display/trace-events | 4 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index

[PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' header

When trying to consume the DEFINE_EDID_PROPERTIES() macro by including "hw/display/edid.h", we get this build failure: include/hw/display/edid.h:24:5: error: implicit declaration of function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration] 24 | DEFINE_PROP_UINT32("xres",

[PATCH 09/14] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report()

DPRINTF() calls are disabled by default, so when unexpected data is used, the whole process abort without information. Display a bit of information with error_report() before crashing. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/xlnx_dp.c | 14 -- 1 file changed, 8

[PATCH 11/14] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion

To avoid the orphan I/O memory region being added in the /unattached QOM container, register the PCI device as its owner. Signed-off-by: Philippe Mathieu-Daudé --- RFC: This might break migration --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

Philippe Mathieu-Daudé writes: > Move out x86-specific structures from generic machine code. > > Acked-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/machine-target.json | 45 ++ > qapi/machine.json | 42

[PATCH 2/2] tests/qtest/fuzz: Avoid QTest mmio serialization

We don't need to serialize over QTest chardev when we can directly access the MMIO address space via the first registered CPU view. virtio-net-socket gets ~50% performance improvement. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz/virtio_net_fuzz.c | 6 --

Re: [PATCH] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

Reviewed-by: Huacai Chen On Tue, May 26, 2020 at 2:04 PM Philippe Mathieu-Daudé wrote: > > ping? > > On 5/15/20 10:42 AM, Philippe Mathieu-Daudé wrote: > > The Fuloong machine never had to use "audio/audio.h", remove it. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > >

[PATCH 10/14] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR)

Avoid flooding stdio by converting printf() calls to qemu_log_mask(GUEST_ERROR), which are disabled by default. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vmware_vga.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/display/vmware_vga.c

Re: [PATCH v5 4/7] dwc-hsotg (dwc2) USB host controller emulation

On 5/20/20 11:24 PM, Paul Zimmerman wrote: > On Wed, May 20, 2020 at 6:18 AM Peter Maydell > wrote: > > On Wed, 20 May 2020 at 06:49, Paul Zimmerman > wrote: > > Is there a tree somewhere that has a working example of a

Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference

Hello, +-- On Thu, 21 May 2020, Paolo Bonzini wrote --+ | I think the code here was expecting frame_size_p to be 0 if cmd->frame is | NULL. Can you check why this is not the case, or whether it ever was the | case? static MegasasCmd *megasas_enqueue_frame(MegasasState *s, hwaddr frame,

Re: [PATCH 0/7] audio: Spring cleaning

On 5/5/20 3:25 PM, Philippe Mathieu-Daudé wrote: > Cleaning old branches, salvaging what seems worthwhile... > This series is from the time I wanted cleaner buffer handling > to avoid abuses, started with chardev/ but got lost with reviews. > audio/ is smaller, so easier. > > - Convert various

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

ping... On 5/5/20 12:07 PM, Philippe Mathieu-Daudé wrote: > Use the generic AUDIO_HOST_ENDIANNESS definition instead > of a custom one. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Who/what machine is using this device anyway? > --- > hw/audio/gus.c | 8 +--- > 1 file changed, 1

[PATCH 05/14] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf

Replace some debug printf() calls by qemu_log_mask(LOG_GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 77 ++--- 1 file changed, 33 insertions(+), 44 deletions(-) diff --git a/hw/display/cirrus_vga.c

[PATCH 07/14] hw/display/dpcd: Fix memory region size

The memory region size is 512K. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/dpcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/dpcd.c b/hw/display/dpcd.c index 170545c605..0c1b7b35fb 100644 --- a/hw/display/dpcd.c +++ b/hw/display/dpcd.c @@ -1,5

Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices

Paolo Bonzini writes: > On 25/05/20 09:01, Markus Armbruster wrote: >>> Just remembered that we fail creating the machine and therefore abort. So >>> not necessary :) >> True. >> >> But let's review briefly what happens when a realize method fails. >> >> In theory, realize fails cleanly, i.e.

[PATCH 14/14] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask()

Replace printf() calls by qemu_log_mask(UNIMP), which is disabled by default. This avoid flooding the terminal when fuzzing the device. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/pxa2xx_lcd.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff

[PATCH v2] arm/aspeed: Rework NIC attachment

The number of MACs supported by an Aspeed SoC is defined by "macs_num" under the SoC model, that is two for the AST2400 and AST2500 and four the AST2600. The model initializes the maximum number of supported MACs but the number of realized devices is caped by the number of network device back-ends

Re: [PATCH] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)

On 24/05/2020 12.38, Philippe Mathieu-Daudé wrote: > Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is > disabled by default. This avoid flooding the terminal when > fuzzing the device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/omap_dss.c | 2 +- > 1 file changed,

Re: [PATCH v3 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

On 5/26/20 8:45 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Move out x86-specific structures from generic machine code. >> >> Acked-by: Richard Henderson >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> qapi/machine-target.json | 45

About the PVH in Seabios

Hello all, The current PVH has been implemented in Qemu and Qboot/uefi, i am not familiar with the PVH implementation history, and found there is no PVH support in Seabios, my question is do we have plan to support PVH in Seabios? thanks. Regards, Yang

  1   2   3   4   >