Re: What is the intended behaviour of usb_host_get_port for root hubs?

2021-03-08 Thread Ben Leslie
On Tue, 9 Mar 2021 at 18:24, Gerd Hoffmann wrote: > On Tue, Mar 09, 2021 at 10:54:15AM +1100, Ben Leslie wrote: > > When usb_host_get_port is called for a root-hub device what string should > > be output in the port parameter? > > Just the port number, as string. > > (and in case this isn't a

Re: USB port claiming / set configuration problems

2021-03-08 Thread Ben Leslie
On Fri, 5 Mar 2021 at 11:50, Ben Leslie wrote: > On Fri, 5 Mar 2021 at 01:31, Gerd Hoffmann wrote: > >> Hi, >> >> > Would adding support to host-libusb to use these >> > ioctl to claim the port be beneficial? >> >> I don't feel like side-stepping libusb. That is asking for trouble >> because

Re: [PATCH] hw/char: disable ibex uart receive if the buffer is full

2021-03-08 Thread Alexander Wagner
ping https://patchew.org/QEMU/20210215231528.2718086-1-alexander.wag...@ulal.de/ On 16.02.21 00:15, Alexander Wagner wrote: Not disabling the UART leads to QEMU overwriting the UART receive buffer with the newest received byte. The rx_level variable is added to allow the use of the existing

Re: [PATCH v2 0/2] Update libslirp & make it a subproject

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 1/25/21 8:34 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Here is a few patches to update libslirp to git upstream. > Since it now supports meson subproject(), adapt the build > system to use it, and related fixes. > > v2: > - fix unused

Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO

2021-03-08 Thread Peter Maydell
On Sat, 6 Mar 2021 at 16:54, Keith Packard wrote: > > Peter Maydell writes: > > Part of why I asked is that the current RISCV implementation > > is just looking at sizeof(target_ulong); but the qemu-system-riscv64 > > executable AIUI now supports emulating both "this is a 64 bit > > guest CPU"

[qemu-web PATCH] pages: update deprecation policy links to "official" manual

2021-03-08 Thread Alex Bennée
The links are broken now so lets point them at the right place. Signed-off-by: Alex Bennée --- _posts/2017-08-10-deprecation.md | 2 +- download.html| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/_posts/2017-08-10-deprecation.md

[PATCH v4 2/2] hw/pflash_cfi01: Correct the type of PFlashCFI01.ro

2021-03-08 Thread David Edmondson
PFlashCFI01.ro is a bool, declare it as such. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson --- hw/block/pflash_cfi01.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 9e1f3b42c6..6b21b4af52

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Peter Maydell
On Mon, 8 Mar 2021 at 11:16, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > +Markus/Paolo/Laurent/Richard > > On 3/8/21 11:24 AM, Peter Maydell wrote: > > On Mon, 8 Mar 2021 at 10:09, Thomas Huth wrote: > >> > >> On 07/03/2021 16.56, Warner Losh wrote: > >>> The FreeBSD project has a number of

Re: [PATCH 2/2] target/m68k: add M68K_FEATURE_NO_DALIGN feature

2021-03-08 Thread Mark Cave-Ayland
On 08/03/2021 01:03, Richard Henderson wrote: On 3/7/21 12:26 PM, Mark Cave-Ayland wrote: According to the M68040UM Appendix D the requirement for data accesses to be word aligned is only for the 68000, 68008 and 68010 CPUs. Later CPUs from the 68020 onwards will allow unaligned data accesses

Re: [PATCH] virtio-net: calculating proper msix vectors on init

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Jason, On 3/8/21 6:30 AM, Jason Wang wrote: > Currently, the default msix vectors for virtio-net-pci is 3 which is > obvious not suitable for multiqueue guest, so we depends on the user > or management tools to pass a correct vectors parameter. In fact, we > can simplifying this by calculating

[PATCH v4 1/2] hw/pflash_cfi*: Replace DPRINTF with trace events

2021-03-08 Thread David Edmondson
Rather than having a device specific debug implementation in pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson --- hw/block/pflash_cfi01.c | 78 +

Re: [PATCH v3 1/3] migration/ram: Modify the code comment of ram_save_host_page()

2021-03-08 Thread Kunkun Jiang
Hi, Peter On 2021/3/5 21:59, Peter Xu wrote: On Fri, Mar 05, 2021 at 03:50:33PM +0800, Kunkun Jiang wrote: The ram_save_host_page() has been modified several times since its birth. But the comment hasn't been modified as it should be. It'd better to modify the comment to explain

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Peter, +Markus/Paolo/Laurent/Richard On 3/8/21 11:24 AM, Peter Maydell wrote: > On Mon, 8 Mar 2021 at 10:09, Thomas Huth wrote: >> >> On 07/03/2021 16.56, Warner Losh wrote: >>> The FreeBSD project has a number of enhancements to bsd-user. Add myself >>> as maintainer and Kyle Evans as a

[qemu-web RFC PATCH] _download/source.html: show the GPG fingerprint for releases

2021-03-08 Thread Alex Bennée
At the moment we mention the signature but don't actually say what it is or how to check it. Lets surface the fingerprint on the information along with a guide of how to verify the download. Signed-off-by: Alex Bennée Cc: Michael Roth Cc: Stefan Hajnoczi --- _download/source.html | 13

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-08 Thread Thomas Huth
On 22/02/2021 08.28, Brad Smith wrote: OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. Remove a time_t cast that is no longer necessary. Signed-off-by: Brad Smith diff --git a/migration/savevm.c b/migration/savevm.c index 52e2d72e4b..9557f85ba9 100644 ---

[PULL v3 00/49] target-arm queue

2021-03-08 Thread Peter Maydell
) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210308 for you to fetch changes up to 50b52b18cdb9294ce83dd49bb60b8e55a6526ea0: hw/arm/mps2: Update old infocenter.arm.com URLs (2021-03-08 11:54:16 +

Re: [PATCH v2 0/2] Clarify error messages pertaining to 'node-name'

2021-03-08 Thread Kevin Wolf
Am 05.03.2021 um 16:19 hat Connor Kuehl geschrieben: > v2: > - Moved summary into patch #1 > - Updated test cases that were missed in v1 from running 'make check'. > This time I used 'make check-block SPEED=thorough' and some more > grepping to make sure I didn't miss any. > -

Re: [PATCH 3/4] hw/xtensa/xtfpga: Get pflash MemoryRegion with sysbus_mmio_get_region()

2021-03-08 Thread Max Filippov
On Sun, Mar 7, 2021 at 2:26 PM Philippe Mathieu-Daudé wrote: > > TYPE_PFLASH_CFI01 is a TYPE_SYS_BUS_DEVICE which registers its romd > MemoryRegion with sysbus_init_mmio(), so we can use the generic > sysbus_mmio_get_region() to get the region, no need for a specific > pflash_cfi01_get_memory()

Re: [PATCH v2 8/9] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

2021-03-08 Thread Marcel Apfelbaum
Hi David, On Mon, Mar 8, 2021 at 10:45 AM David Hildenbrand wrote: > On 07.03.21 15:11, Marcel Apfelbaum wrote: > > Hi David, > > > > On Sun, Mar 7, 2021 at 3:18 PM David Hildenbrand > > wrote: > > > > On 05.03.21 16:51, Peter Xu wrote: > > > On Fri, Mar 05,

Re: [PATCH v2 0/2] Update libslirp & make it a subproject

2021-03-08 Thread Marc-André Lureau
Hi On Mon, Mar 8, 2021 at 2:03 PM Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 1/25/21 8:34 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > Here is a few patches to update libslirp to git upstream. > > Since it now supports meson subproject(),

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Christian Schoenebeck
On Montag, 8. März 2021 04:45:24 CET Akihiko Odaki wrote: > 2021年3月8日(月) 4:57 Christian Schoenebeck : > > DisplaySurface pointer passed to gd_switch() can be NULL, so check this > > before trying to dereference it. > > > > Fixes: c821a58ee7 ("ui/console: Pass placeholder surface to display") > >

Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-03-08 Thread Philippe Mathieu-Daudé
On 2/15/21 5:26 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> +if (a->rt == 0) { >> +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); >> +tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); >> +return true; >> +} > > Is there a good reason not to use

Re: [RFC PATCH 06/27] virtio: Add virtio_queue_get_used_notify_split

2021-03-08 Thread Stefan Hajnoczi
On Tue, Mar 02, 2021 at 07:34:20PM +0100, Eugenio Perez Martin wrote: > On Tue, Mar 2, 2021 at 12:22 PM Stefan Hajnoczi wrote: > > > > On Tue, Jan 12, 2021 at 07:21:27PM +0100, Eugenio Perez Martin wrote: > > > On Mon, Dec 7, 2020 at 5:58 PM Stefan Hajnoczi wrote: > > > > > > > > On Fri, Nov 20,

Re: [PATCH v2] linux-user: Fix executable page of /proc/self/maps

2021-03-08 Thread Laurent Vivier
Le 08/03/2021 à 10:19, Nicolas Surbayrole a écrit : > The guest binary and libraries are not always map with the > executable bit in the host process. The guest may read a > /proc/self/maps with no executable address range. The > perm fields should be based on the guest permission inside > Qemu. >

Re: [PATCH] meson: Stop if cfi is enabled with system slirp

2021-03-08 Thread Daniel P . Berrangé
On Fri, Mar 05, 2021 at 11:53:07AM -0500, Daniele Buono wrote: > On 3/4/2021 5:37 AM, Daniel P. Berrangé wrote: > > Is there work being done, or at least an active plan, for fixing this ? > > > > Distros generally won't want to static link slirp to QEMU when there is > > a shared slirp available.

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Akihiko Odaki
2021年3月8日(月) 19:39 Christian Schoenebeck : > > This was just about silencing the mentioned automated Coverity defects report. > If you have a better solution, then just ignore this patch. > > Best regards, > Christian Schoenebeck > > I do not have an access to Coverity defects report. I'd

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Thomas Huth
On 08/03/2021 12.16, Philippe Mathieu-Daudé wrote: Hi Peter, +Markus/Paolo/Laurent/Richard On 3/8/21 11:24 AM, Peter Maydell wrote: On Mon, 8 Mar 2021 at 10:09, Thomas Huth wrote: On 07/03/2021 16.56, Warner Losh wrote: The FreeBSD project has a number of enhancements to bsd-user. Add

Re: [PATCH] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Alex Bennée
Thomas Huth writes: > The status of the gitlab-CI files is currently somewhat confusing, and > it is often not quite clear whether a patch should go via my tree or > via the testing tree of Alex. That situation has grown historically... > Initially, I was the only one using the gitlab-CI, just

Re: [PATCH v2] hw/nvme: move nvme emulation out of hw/block

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Klaus, On 3/1/21 12:35 PM, Klaus Jensen wrote: > From: Klaus Jensen > > With the introduction of the nvme-subsystem device we are really > cluttering up the hw/block directory. > > As suggested by Philippe previously, move the nvme emulation to > hw/nvme. Maybe type "NVMe" when talking

Re: [PATCH v2 0/3] hw/lm32: Kconfig cleanups

2021-03-08 Thread Philippe Mathieu-Daudé
ping? On 2/21/21 11:56 PM, Philippe Mathieu-Daudé wrote: > Hi Laurent, > > This series is fully reviewed. Since LM32 is not very > active, can this go via qemu-trivial@? > > Thanks, > > Phil. > > v2: Rebased > > Supersedes: <20210208135048.2601693-1-f4...@amsat.org> > > Philippe

Re: [PULL 00/31] Block layer patches

2021-03-08 Thread Kevin Wolf
Am 06.03.2021 um 12:22 hat Peter Maydell geschrieben: > On Fri, 5 Mar 2021 at 16:55, Kevin Wolf wrote: > > > > The following changes since commit 9a7beaad3dbba982f7a461d676b55a5c3851d312: > > > > Merge remote-tracking branch > > 'remotes/alistair/tags/pull-riscv-to-apply-20210304' into staging

Re: [qemu-web PATCH] pages: update deprecation policy links to "official" manual

2021-03-08 Thread Thomas Huth
On 08/03/2021 11.30, Alex Bennée wrote: The links are broken now so lets point them at the right place. Signed-off-by: Alex Bennée --- _posts/2017-08-10-deprecation.md | 2 +- download.html| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 11:48 AM, Philippe Mathieu-Daudé wrote: > On 2/15/21 5:26 PM, Richard Henderson wrote: >> On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >>> +if (a->rt == 0) { >>> +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); >>> +tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); >>> +

Re: [PATCH v2] hw/nvme: move nvme emulation out of hw/block

2021-03-08 Thread Klaus Jensen
On Mar 8 10:44, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 3/1/21 12:35 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > With the introduction of the nvme-subsystem device we are really > > cluttering up the hw/block directory. > > > > As suggested by Philippe previously, move the

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Thomas Huth
On 07/03/2021 16.56, Warner Losh wrote: The FreeBSD project has a number of enhancements to bsd-user. Add myself as maintainer and Kyle Evans as a reviewer. Also add our github repo. Signed-off-by: Warner Losh Signed-off-by: Kyle Evans Reviewed-by: Thomas Huth --- MAINTAINERS | 5 - 1

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

2021-03-08 Thread Peter Maydell
On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: > Do we need to care about other type of networking backends? E.g socket. > > Or at least we should keep the padding logic if we can't audit all of > the backends. I think the key thing we need to do here is make a decision and be clear about what

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Daniel P . Berrangé
On Sun, Mar 07, 2021 at 05:31:24PM -0800, Doug Evans wrote: > Not sure how this "Author email address is mangled" happened. > > $ git format-patch -o patches/error-parsing-ipv6 -1 > $ git send-email --to='qemu-devel@nongnu.org,Samuel Thibault < > samuel.thiba...@ens-lyon.org>,"Daniel P. Berrangé"

Re: [PATCH v4 6/6] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-08 Thread BALATON Zoltan
On Thu, 4 Mar 2021, BALATON Zoltan wrote: On Wed, 3 Mar 2021, David Gibson wrote: On Tue, Mar 02, 2021 at 10:13:19AM +0100, BALATON Zoltan wrote: On Tue, 2 Mar 2021, Philippe Mathieu-Daudé wrote: On 2/25/21 8:47 PM, BALATON Zoltan wrote: Add new machine called pegasos2 emulating the

Re: [PATCH] target/i386/sev: Ensure sev_fw_errlist is sync with update-linux-headers

2021-03-08 Thread Philippe Mathieu-Daudé
ping? On 2/19/21 7:01 PM, Philippe Mathieu-Daudé wrote: > Ensure sev_fw_errlist[] is updated after running > the update-linux-headers.sh script. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20210218151633.215374-1-cku...@redhat.com> > --- > target/i386/sev.c | 5 - > 1 file

[PATCH v4 0/2] replace pflash DPRINTF with trace events, fix type

2021-03-08 Thread David Edmondson
Given that the "sub-region" approach to shrinking the flash mapping size on ARM isn't progressing (I'm looking at Philippe's mmap based approach instead), this pair of changes are the already reviewed changes from the original changeset. David Edmondson (2): hw/pflash_cfi*: Replace DPRINTF with

Re: [PULL v2 00/49] target-arm queue

2021-03-08 Thread Peter Maydell
On Sat, 6 Mar 2021 at 13:51, Peter Maydell wrote: > > v2: don't delete is_surface_bgr() definition, the ppc patches > that drop use of it from sm501 haven't hit master yet. I forgot about the "32 bit hosts don't allow guests to have 2GB of RAM" thing; this minor fixup needs squashing into the

Re: [PATCH v2 8/9] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

2021-03-08 Thread David Hildenbrand
On 07.03.21 15:11, Marcel Apfelbaum wrote: Hi David, On Sun, Mar 7, 2021 at 3:18 PM David Hildenbrand > wrote: On 05.03.21 16:51, Peter Xu wrote: > On Fri, Mar 05, 2021 at 04:44:36PM +0100, David Hildenbrand wrote: >> On 05.03.21 16:42, Peter Xu wrote:

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Peter Maydell
On Mon, 8 Mar 2021 at 10:09, Thomas Huth wrote: > > On 07/03/2021 16.56, Warner Losh wrote: > > The FreeBSD project has a number of enhancements to bsd-user. Add myself > > as maintainer and Kyle Evans as a reviewer. Also add our github repo. > > > > Signed-off-by: Warner Losh > > Signed-off-by:

Re: [qemu-web PATCH] pages: update deprecation policy links to "official" manual

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 11:30 AM, Alex Bennée wrote: > The links are broken now so lets point them at the right place. > > Signed-off-by: Alex Bennée > --- > _posts/2017-08-10-deprecation.md | 2 +- > download.html| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by:

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-08 Thread Daniel P . Berrangé
On Fri, Mar 05, 2021 at 09:06:45AM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > > > Daniel P. Berrangé writes: > > > >> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: > >>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate > >>> configuring

Re: [PATCH V4 0/8] hw/block/nvme: support namespace attachment

2021-03-08 Thread Klaus Jensen
On Mar 2 22:26, Minwoo Im wrote: > Hello, > > This series supports namespace attachment: attach and detach. This is > the fourth version of series with replacing changed namespace list to > bitmap to indicate changed namespace IDs. > > Please review. > > Thanks, > > Since V3: > - Replace

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Daniel P . Berrangé
On Sun, Mar 07, 2021 at 04:29:28PM -0800, Doug Evans via wrote: > Wrapping an IP address in square brackets does not necessarily > mean the address is an IPv6 address. The wrapping is just an aid > to parsing since IPv6 addresses have colons, but does not provide > semantic information. > E.g.,

Re: [PATCH v4 00/12] hw/block/nvme: metadata and end-to-end data protection support

2021-03-08 Thread Klaus Jensen
On Mar 1 15:00, Klaus Jensen wrote: > From: Klaus Jensen > > This is v4 (RFC removed) of a series that adds support for metadata and > end-to-end data protection. > > First, on the subject of metadata, in v1, support was restricted to > extended logical blocks, which was pretty trivial to

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Peter Maydell
On Mon, 8 Mar 2021 at 11:55, Thomas Huth wrote: > https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01399.html > > So this is not about declaring that bsd-user is maintained in a different > repository, but about giving Warner et al. a chance to finally upstream > their work. Thanks; I'd

Re: [PATCH v3 2/2] coroutine: take exactly one batch from global pool at a time

2021-03-08 Thread Stefan Hajnoczi
On Fri, Oct 16, 2020 at 07:26:40PM +0800, wanghonghao wrote: > This patch replace the global coroutine queue with a lock-free stack of which > the elements are coroutine queues. Threads can put coroutine queues into the > stack or take queues from it and each coroutine queue has exactly >

Re: [PATCH v3 2/3] migration/ram: Reduce unnecessary rate limiting

2021-03-08 Thread Kunkun Jiang
Hi, On 2021/3/5 22:22, Peter Xu wrote: Kunkun, On Fri, Mar 05, 2021 at 03:50:34PM +0800, Kunkun Jiang wrote: When the host page is a huge page and something is sent in the current iteration, the migration_rate_limit() should be executed. If not, this function can be omitted to save time.

Re: [PATCH] qom: Check for wellformed id in user_creatable_add_type()

2021-03-08 Thread Kevin Wolf
Am 06.03.2021 um 11:50 hat Paolo Bonzini geschrieben: > On 02/03/21 18:16, Kevin Wolf wrote: > > Most code paths for creating a user creatable object go through > > QemuOpts, which ensures that the provided 'id' option is actually a > > valid identifier. > > > > However, there are some code paths

Re: [PATCH] meson: Stop if cfi is enabled with system slirp

2021-03-08 Thread Paolo Bonzini
On 08/03/21 12:19, Daniel P. Berrangé wrote: My concern is that libslirp is just showing us one known example of the problem. QEMU links to many more external libraries, which might exhibit similar issues. We know exactly the issue: QEMU uses a pointer to a library function as a function

Re: [PATCH v2 0/2] Update libslirp & make it a subproject

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 11:23 AM, Marc-André Lureau wrote: > Hi > > On Mon, Mar 8, 2021 at 2:03 PM Philippe Mathieu-Daudé > wrote: > > Hi Marc-André, > > On 1/25/21 8:34 AM, marcandre.lur...@redhat.com > wrote: > > From:

Re: [RFC PATCH v2 6/8] cpu: Declare cpu_has_work() in 'sysemu/tcg.h'

2021-03-08 Thread Claudio Fontana
On 3/4/21 11:23 PM, Philippe Mathieu-Daudé wrote: > We can only check if a vCPU has work with TCG. > Move the cpu_has_work() prototype to "sysemu/tcg.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC: could another accelerator do that? > can we rename this tcg_vcpu_has_work()? > ---

[PULL 01/38] hw/block/nvme: introduce nvme-subsys device

2021-03-08 Thread Klaus Jensen
From: Minwoo Im To support multi-path in QEMU NVMe device model, We need to have NVMe subsystem hierarchy to map controllers and namespaces to a NVMe subsystem. This patch introduced a simple nvme-subsys device model. The subsystem will be prepared with subsystem NQN with provided in

[PULL 00/38] emulated nvme device updates

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen The following changes since commit 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1: Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210305' into staging (2021-03-05 19:04:47 +) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git

[PULL 07/38] hw/block/nvme: remove unused parameter in check zone write

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen Remove the unused NvmeCtrl parameter in nvme_check_zone_write. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

[PULL 14/38] hw/block/nvme: improve invalid zasl value reporting

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen The Zone Append Size Limit (ZASL) must be at least 4096 bytes, so improve the user experience by adding an early parameter check in nvme_check_constraints. When ZASL is still too small due to the host configuring the device for an even larger page size, convert the trace

[PULL 26/38] hw/block/nvme: remove block accounting for write zeroes

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen A Write Zeroes commands should not be counted in either the 'Data Units Written' or in 'Host Write Commands' SMART/Health Information Log page. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Reviewed-by: Keith Busch --- hw/block/nvme.c | 1 - 1 file changed, 1

[PULL 21/38] hw/block/nvme: add identify trace event

2021-03-08 Thread Klaus Jensen
From: Gollu Appalanaidu Add a trace event for the Identify command. Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im --- hw/block/nvme.c | 3 +++ hw/block/trace-events | 1 + 2 files changed, 4 insertions(+) diff --git a/hw/block/nvme.c

[PULL 37/38] hw/block/nvme: support changed namespace asynchronous event

2021-03-08 Thread Klaus Jensen
From: Minwoo Im If namespace inventory is changed due to some reasons (e.g., namespace attachment/detachment), controller can send out event notifier to the host to manage namespaces. This patch sends out the AEN to the host after either attach or detach namespaces from controllers. To support

[PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-08 Thread Greg Kurz
The slave channel is implemented with socketpair() : QEMU creates the pair, passes one of the socket to virtiofsd and monitors the other one with the main event loop using qemu_set_fd_handler(). In order to fix a potential deadlock between QEMU and a vhost-user external process (e.g. virtiofsd

[PATCH 4/4] virtiofsd: Release vu_dispatch_lock when stopping queue

2021-03-08 Thread Greg Kurz
QEMU can stop a virtqueue by sending a VHOST_USER_GET_VRING_BASE request to virtiofsd. As with all other vhost-user protocol messages, the thread that runs the main event loop in virtiofsd takes the vu_dispatch lock in write mode. This ensures that no other thread can access virtqueues or memory

Re: [PULL v3 00/49] target-arm queue

2021-03-08 Thread Peter Maydell
es/alistair/tags/pull-riscv-to-apply-20210304' into staging (2021-03-05 > 10:47:46 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20210308 > > for you to fetch changes up to 50b52b18cdb9294c

[PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Adrian Catangiu
- Background and problem The System Generation ID feature is required in virtualized or containerized environments by applications that work with local copies or caches of world-unique data such as random values, uuids, monotonically increasing counters, cryptographic nonces, etc. Such

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Akihiko Odaki
2021年3月8日(月) 23:03 Christian Schoenebeck : > > BTW, there is __nonnull supported by clang, e.g.: > > static void foo(void *__nonnull p) { > ... > } > > Maybe as an optionally defined macro (if supported by compiler) this could be > a useful tool for such intended nonnull designs, as it

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 3:17 PM, Akihiko Odaki wrote: > 2021年3月8日(月) 23:03 Christian Schoenebeck : >> >> BTW, there is __nonnull supported by clang, e.g.: >> >> static void foo(void *__nonnull p) { >> ... >> } >> >> Maybe as an optionally defined macro (if supported by compiler) this could be >> a

[PATCH] xen-block: Fix removal of backend instance via xenstore

2021-03-08 Thread Anthony PERARD via
From: Anthony PERARD Whenever a Xen block device is detach via xenstore, the image associated with it remained open by the backend QEMU and an error is logged: qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use This happened since object_unparent() doesn't immediately

[PULL 18/18] semihosting: Move hw/semihosting/ -> semihosting/

2021-03-08 Thread Alex Bennée
From: Philippe Mathieu-Daudé With the exception of hw/core/, the hw/ directory only contains device models used in system emulation. Semihosting is also used by user emulation. As a generic feature, move it out of hw/ directory. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée

Re: [PATCH] meson: Stop if cfi is enabled with system slirp

2021-03-08 Thread Daniele Buono
On 3/8/2021 6:19 AM, Daniel P. Berrangé wrote: My concern is that libslirp is just showing us one known example of the problem. QEMU links to many more external libraries, which might exhibit similar issues. If we need to rebuild all the dependancies with CFI too, to be confident that the

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Christian Schoenebeck
On Montag, 8. März 2021 15:30:23 CET Philippe Mathieu-Daudé wrote: > On 3/8/21 3:17 PM, Akihiko Odaki wrote: > > 2021年3月8日(月) 23:03 Christian Schoenebeck : > >> BTW, there is __nonnull supported by clang, e.g.: > >> > >> static void foo(void *__nonnull p) { > >> > >> ... > >> > >> } >

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-03-08 Thread Daniel P . Berrangé
On Mon, Mar 08, 2021 at 03:57:29PM +0100, Philippe Mathieu-Daudé wrote: > On 3/8/21 2:52 PM, Claudio Fontana wrote: > > On 3/8/21 2:27 PM, Philippe Mathieu-Daudé wrote: > >> Hi Claudio, > >> > >> On 3/8/21 1:57 PM, Claudio Fontana wrote: > >>> Hi, > >>> > >>> anything else for me to do here? > >>>

[PATCH v3 02/12] softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory

2021-03-08 Thread David Hildenbrand
We can create shared anonymous memory via "-object memory-backend-ram,share=on,..." which is, for example, required by PVRDMA for mremap() to work. Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we have to use MADV_REMOVE. MADV_DONTNEED fails silently and does nothing.

[PATCH v3 10/12] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()

2021-03-08 Thread David Hildenbrand
Let's introduce RAM_NORESERVE, allowing mmap'ing with MAP_NORESERVE. The new flag has the following semantics: RAM is mmap-ed with MAP_NORESERVE. When set, reserving swap space (or huge pages on Linux) is skipped: will bail out if not supported. When not set, the OS might reserve swap space

[PATCH v3 11/12] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

2021-03-08 Thread David Hildenbrand
Let's support RAM_NORESERVE via MAP_NORESERVE. At least on Linux, the flag has no effect on most shared mappings - except for hugetlbfs and anonymous memory. Linux man page: "MAP_NORESERVE: Do not reserve swap space for this mapping. When swap space is reserved, one has the guarantee that it

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Daniel P . Berrangé
On Mon, Mar 08, 2021 at 08:21:34AM -0700, Warner Losh wrote: > On Mon, Mar 8, 2021 at 6:14 AM Philippe Mathieu-Daudé > wrote: > > > On 3/8/21 1:14 PM, Daniel P. Berrangé wrote: > > > On Mon, Mar 08, 2021 at 12:55:10PM +0100, Thomas Huth wrote: > > >> On 08/03/2021 12.16, Philippe Mathieu-Daudé

Re: [RFC PATCH v2 6/8] cpu: Declare cpu_has_work() in 'sysemu/tcg.h'

2021-03-08 Thread Claudio Fontana
On 3/4/21 11:23 PM, Philippe Mathieu-Daudé wrote: > We can only check if a vCPU has work with TCG. > Move the cpu_has_work() prototype to "sysemu/tcg.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC: could another accelerator do that? > can we rename this tcg_vcpu_has_work()? > ---

[PULL 08/38] hw/block/nvme: refactor zone resource management

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen Zone transition handling and resource management is open coded (and semi-duplicated in the case of open, close and finish). In preparation for Simple Copy command support (which also needs to open zones for writing), consolidate into a set of 'nvme_zrm' functions and in the

[PULL 13/38] hw/block/nvme: add missing mor/mar constraint checks

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen Firstly, if zoned.max_active is non-zero, zoned.max_open must be less than or equal to zoned.max_active. Secondly, if only zones.max_active is set, we have to explicitly set zones.max_open or we end up with an invalid MAR/MOR configuration. This is an artifact of the

[PULL 20/38] hw/block/nvme: remove unnecessary endian conversion

2021-03-08 Thread Klaus Jensen
From: Gollu Appalanaidu Remove an unnecessary le_to_cpu conversion in Identify. Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

[PULL 15/38] hw/block/nvme: use locally assigned QEMU IEEE OUI

2021-03-08 Thread Klaus Jensen
From: Gollu Appalanaidu Commit 6eb7a071292a ("hw/block/nvme: change controller pci id") changed the controller to use a Red Hat assigned PCI Device and Vendor ID, but did not change the IEEE OUI away from the Intel IEEE OUI. Fix that and use the locally assigned QEMU IEEE OUI instead if the

[PULL 28/38] hw/block/nvme: try to deal with the iov/qsg duality

2021-03-08 Thread Klaus Jensen
From: Klaus Jensen Introduce NvmeSg and try to deal with that pesky qsg/iov duality that haunts all the memory-related functions. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.h | 17 - hw/block/nvme.c | 191 ++-- 2

[PULL 33/38] hw/block/nvme: fix allocated namespace list to 256

2021-03-08 Thread Klaus Jensen
From: Minwoo Im Expand allocated namespace list (subsys->namespaces) to have 256 entries which is a value lager than at least NVME_MAX_NAMESPACES which is for attached namespace list in a controller. Allocated namespace list should at least larger than attached namespace list.

Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO

2021-03-08 Thread Alistair Francis
On Mon, Mar 8, 2021 at 5:10 AM Peter Maydell wrote: > > On Sat, 6 Mar 2021 at 16:54, Keith Packard wrote: > > > > Peter Maydell writes: > > > Part of why I asked is that the current RISCV implementation > > > is just looking at sizeof(target_ulong); but the qemu-system-riscv64 > > > executable

Re: [PATCH] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Alex, On 3/8/21 12:57 PM, Alex Bennée wrote: > > Thomas Huth writes: > >> The status of the gitlab-CI files is currently somewhat confusing, and >> it is often not quite clear whether a patch should go via my tree or >> via the testing tree of Alex. That situation has grown historically...

[PULL 07/18] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-08 Thread Alex Bennée
From: Daniele Buono QEMU has had options to enable control-flow integrity features for a few months now. Add two sets of build/check/acceptance jobs to ensure the binary produced is working fine. The three sets allow testing of x86_64 binaries for x86_64, s390x, ppc64 and aarch64 targets [AJB:

[PULL 13/18] hw/core: implement a guest-loader to support static hypervisor guests

2021-03-08 Thread Alex Bennée
Hypervisors, especially type-1 ones, need the firmware/bootcode to put their initial guest somewhere in memory and pass the information to it via platform data. The guest-loader is modelled after the generic loader for exactly this sort of purpose: $QEMU $ARGS -kernel ~/xen.git/xen/xen \

[PULL 12/18] device_tree: add qemu_fdt_setprop_string_array helper

2021-03-08 Thread Alex Bennée
A string array in device tree is simply a series of \0 terminated strings next to each other. As libfdt doesn't support that directly we need to build it ourselves. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20210303173642.3805-4-alex.ben...@linaro.org> diff --git

[PULL 03/18] docker: Add Hexagon image

2021-03-08 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Base on qemu/debian10, add missing EXTRA_FILES, remove X86] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Message-Id: <20210228222314.304787-2-f4...@amsat.org> [AJB: add build-dep for QEMU, include in

[PULL 10/18] hw/board: promote fdt from ARM VirtMachineState to MachineState

2021-03-08 Thread Alex Bennée
The use of FDT's is quite common across our various platforms. To allow the guest loader to tweak it we need to make it available in the generic state. This creates the field and migrates the initial user to use the generic field. Other boards will be updated in later patches. Signed-off-by: Alex

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-03-08 Thread Claudio Fontana
On 3/8/21 2:27 PM, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 3/8/21 1:57 PM, Claudio Fontana wrote: >> Hi, >> >> anything else for me to do here? >> >> The latest rebased state of this series should be always available here: >> >> https://gitlab.com/hw-claudio/qemu/-/tree/i386_cleanup_8

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > +static struct miscdevice sysgenid_misc = { > + .minor = MISC_DYNAMIC_MINOR, > + .name = "sysgenid", > + .fops = , > +}; Much cleaner, but: > +static int __init sysgenid_init(void) > +{ > + int ret; > + > +

[Bug 1918149] [NEW] qemu-user reports wrong fault_addr in signal handler

2021-03-08 Thread Leonardo
Public bug reported: When a SEGV signal occurs and si_addr of the info struct is nil, qemu still tries to translate the address from host to guest (handle_cpu_signal in accel/tcg/user-exec.c). This means, that the actual signal handler, will receive a fault_addr that is something like

Re: [PATCH] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Thomas Huth
On 08/03/2021 14.34, Philippe Mathieu-Daudé wrote: Hi Alex, On 3/8/21 12:57 PM, Alex Bennée wrote: Thomas Huth writes: The status of the gitlab-CI files is currently somewhat confusing, and it is often not quite clear whether a patch should go via my tree or via the testing tree of Alex.

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Warner Losh
On Mon, Mar 8, 2021 at 6:14 AM Philippe Mathieu-Daudé wrote: > On 3/8/21 1:14 PM, Daniel P. Berrangé wrote: > > On Mon, Mar 08, 2021 at 12:55:10PM +0100, Thomas Huth wrote: > >> On 08/03/2021 12.16, Philippe Mathieu-Daudé wrote: > >>> Hi Peter, > >>> > >>> +Markus/Paolo/Laurent/Richard > >>> >

[PATCH v3 12/12] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-03-08 Thread David Hildenbrand
Let's provide a way to control the use of RAM_NORESERVE via memory backends using the "reserve" property which defaults to true (old behavior). Only POSIX supports setting the flag (and Linux support is checked at runtime, depending on the setting of "/proc/sys/vm/overcommit_memory"). Windows

[PATCH v2 2/3] target/m68k: reformat m68k_features enum

2021-03-08 Thread Mark Cave-Ayland
Move the feature comment from after the feature name to the preceding line to allow for longer feature names and descriptions without hitting the 80 character line limit. Signed-off-by: Mark Cave-Ayland --- target/m68k/cpu.h | 66 +++ 1 file changed,

[PATCH v2 3/3] target/m68k: add M68K_FEATURE_UNALIGNED_DATA feature

2021-03-08 Thread Mark Cave-Ayland
According to the M68040UM Appendix D the requirement for data accesses to be word aligned is only for the 68000, 68008 and 68010 CPUs. Later CPUs from the 68020 onwards will allow unaligned data accesses but at the cost of being less efficient. Add a new M68K_FEATURE_UNALIGNED_DATA feature to

[PULL 03/38] hw/block/nvme: add CMIC enum value for Identify Controller

2021-03-08 Thread Klaus Jensen
From: Minwoo Im Added Controller Multi-path I/O and Namespace Sharing Capabilities (CMIC) field to support multi-controller in the following patches. This field is in Identify Controller data structure in [76]. Signed-off-by: Minwoo Im Tested-by: Klaus Jensen Reviewed-by: Klaus Jensen

  1   2   3   4   5   >