[quagga-dev 16549] Re: [PATCH v3] nhrpd: implement next hop resolution protocol

2017-01-20 Thread Jafar Al-Gharaibeh
On 1/12/2017 9:58 AM, Vincent JARDIN wrote: Le 12/01/2017 à 15:31, Timo Teräs a écrit : This provides DMVPN support and integrates to strongSwan. Please read README.nhrpd and README.kernel for more details. I do like the value that NHRP brings for DMVPN support. Sorry, I did not review the

[quagga-dev 16460] Re: [PATCH] vtysh: make warnings about node installs a non-default compile-time option

2016-12-06 Thread Jafar Al-Gharaibeh
I tested this patch with the latest sources and got a weird situation where vtysh shell doesn't exit. "end", "exit", "quit" failed to make it do so. I moved the #ifdef DEV_BUILD inside the if statement to cover only the fprintf statement and that fixed it. The reason I think is that the ifdef

[quagga-dev 16091] Re: Building new Daemon question for add route

2016-09-10 Thread Jafar Al-Gharaibeh
Kerem, Have you tried adding the same static route from the command line? Your static route looks like this using ip route command: ip route add 100.100.100.1/24 dev eth0 via 200.200.200.1 Right? My guess is that 200.200.200.1 is unreachable and the ip route command would fail

[quagga-dev 15973] Re: [PATCH] config: Give the option of disabling run as user/group

2016-07-28 Thread Jafar Al-Gharaibeh
Martin, Please let me know how it goes this time if you get a chance to test this. I made sure to test all possible configurations this time. :) Thanks, Jafar On 7/28/2016 2:41 PM, Jafar Al-Gharaibeh wrote: Leave "user/group" unset when explicitly configuring with "

[quagga-dev 15972] [PATCH] config: Give the option of disabling run as user/group

2016-07-28 Thread Jafar Al-Gharaibeh
Leave "user/group" unset when explicitly configuring with "--disable-user" / "--enable-user=no" and "--disable-group" / "--enable-group=no" This allows quagga to skip unsupported system calls such as setuid() on certain platfroms. S

[quagga-dev 15971] Re: [PATCH] config: Give the option of disabling run as user/group

2016-07-28 Thread Jafar Al-Gharaibeh
Quagga was already started under the correct user, then we just skip the user (and group) changes. Just an alternative thought. Happy to send the change to the list (or you) if the community prefers this choice. - Martin On 27 Jul 2016, at 15:02, Jafar Al-Gharaibeh wrote: Leave "user/group&q

[quagga-dev 15963] [PATCH] config: Give the option of disabling run as user/group

2016-07-27 Thread Jafar Al-Gharaibeh
Leave "user/group" unset when explicitly configuring with "--disable-user" and "--disable-group". This allows quagga to skip unsupported system calls such as setuid() on certain platfroms. Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- configur

[quagga-dev 15956] Re: Quagga on Android

2016-07-27 Thread Jafar Al-Gharaibeh
will try and get that to work as well. Regards, Jafar On 7/27/2016 7:36 AM, Paul Jakma wrote: On Fri, 22 Jul 2016, Jafar Al-Gharaibeh wrote: If do create a patch to drop this as a config/compile for corner cases like the situation I have, would it be useful to upstream? Sure. I was going

[quagga-dev 15932] Re: Quagga on Android

2016-07-22 Thread Jafar Al-Gharaibeh
On 7/22/2016 5:03 AM, Marco Pratesi wrote: Most of the documents I produced are available here: https://github.com/marco-pratesi/android/tree/master/quagga Some other informations are available on an IEEE conference paper. Thanks Marco! I actually came across this and read through your steps

[quagga-dev 15926] Quagga on Android

2016-07-21 Thread Jafar Al-Gharaibeh
Hi, Is there anyone on the list who has tried/succeeded running Quagga on Android? I managed to cross-compile Quagga for ARMv7 targeting an android phone I have and producing binaries that I can "run" in an android shell emulator. I'm using an Android app called Terminal IDE to provide

[quagga-dev 15775] Re: Quagga project governance

2016-06-29 Thread Jafar Al-Gharaibeh
On 6/28/2016 5:25 PM, Vincent JARDIN wrote: Le 29 juin 2016 00:24, "Vincent JARDIN" > a écrit : > > > > Let us move forward and not continue to be distracted by finger pointing. We all like to see progress. > > > > Right now, the

[quagga-dev 15772] Re: Quagga project governance

2016-06-28 Thread Jafar Al-Gharaibeh
On 6/28/2016 7:49 AM, Paul Jakma wrote: On Tue, 28 Jun 2016, Paul Jakma wrote: What is unclear - for a contributor - at the moment? Oh, and that wasn't meant to be a rhetorical question. One of Lou's emails summarized a few points : 1. no ability to predict when the next release

[quagga-dev 15739] Re: Quagga project governance

2016-06-27 Thread Jafar Al-Gharaibeh
On 6/27/2016 11:07 AM, Paul Jakma wrote: On Mon, 27 Jun 2016, Lou Berger wrote: Thanks -- glad to see you're not singling me out ;-) Grumpy old gits like me are happy to direct their ire widely, don't worry. ;) I was hoping you were singled out Lou! so that the wider community feels

[quagga-dev 15703] Re: Quagga Monthly Meeting Notes

2016-06-22 Thread Jafar Al-Gharaibeh
On 6/22/2016 6:04 PM, Lou Berger wrote: why not just use personal github for this? that said,there might be value in having an easy way to see the features in development... I do use github for this, as many of us probably do. At some point we want this to go into the Quagga. Even if everyone

[quagga-dev 15697] Re: Quagga Monthly Meeting Notes

2016-06-22 Thread Jafar Al-Gharaibeh
On 6/22/2016 5:45 AM, Paul Jakma wrote: On Wed, 22 Jun 2016, Lou Berger wrote: While the conclusion to work on ce may (or may not, I wasn't on the call for this) be premature, why can't a branch just be added under the existing repo if/when that's the consensus among the community? What is

[quagga-dev 15666] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Jafar Al-Gharaibeh
On 6/20/2016 5:05 PM, Sergey Popov wrote: Well, silly me. I look on quagga's cgit and found commit bb01bdd740339b0c07d8ed0786811801b2a79192, which, i hope, fixes my problem. Yep, that is the one I had in mind :) At least 1 hour run for test router with flapping ppp interfaces does not crash

[quagga-dev 15664] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Jafar Al-Gharaibeh
t's strange) when i remove one of the interfaces, that is responsible for generating summarized route(for example by killing pppd process). Maybe some race condition with null pointer dereference happens? 21.04.2016 18:57, Jafar Al-Gharaibeh пишет: Hi Sergey, Do you have the log file for os

[quagga-dev 15661] Re: [PATCH] zebra: Change bitwise operations to purpose-built macros

2016-06-20 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 6/20/2016 12:58 PM, Quentin Young wrote: Some bitfields for zebra_debug_* flags were being modified with bitwise operators instead of the purpose-built macros in lib/zebra.h. Changed such instances to use the macros. Signed-off-by: Q

[quagga-dev 15659] Re: [PATCH ] bgpd: use default index table for vpnv4 when called from vty

2016-06-20 Thread Jafar Al-Gharaibeh
Submitted by Christian Franke a few days ago. See patch 1988. What is the action taken for duplicate/identical patches. Nack, so that they can be easily identified and dropped? --Jafar On 6/20/2016 3:35 AM, Philippe Guibert wrote: For vpnv4, RIB is reachable through safi index set to

[quagga-dev 15651] [PATCH] zserv: get rid of code duplication in nexthop_lookup[_mrib] functions

2016-06-17 Thread Jafar Al-Gharaibeh
with a few lines of code are enough to handle the differences with a lot less and cleaner code. Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- zebra/zserv.c | 121 +- 1 file changed, 27 insertions(+), 94 deletions(-) diff

[quagga-dev 15574] Re: Bug Fixes Fast Lane

2016-06-14 Thread Jafar Al-Gharaibeh
Thanks for pointing that out. --Jafar On 6/14/2016 2:26 PM, Donald Sharp wrote: Jafar - I would point out that the new process as outlined, is that once a bug get's Acked is immediately placed in master by a maintainer. donald On Tue, Jun 14, 2016 at 3:03 PM, Jafar Al-Gharaibeh <

[quagga-dev 15568] Re: [PATCH 01/16] zebra: fix null pointer dereference in zsend_ipv4_nexthop_lookup_mrib

2016-06-14 Thread Jafar Al-Gharaibeh
This is already addressed and included in round 8 branch. --Jafar On 6/14/2016 1:06 PM, Christian Franke wrote: From: Christian Franke zsend_ipv4_nexthop_lookup_mrib is called with rib == NULL if the lookup does not yield any result. Therefore, rib->vrf_id cannot be used

[quagga-dev 15497] Re: Round 8

2016-06-08 Thread Jafar Al-Gharaibeh
On 6/8/2016 4:39 PM, Martin Winter wrote: On 8 Jun 2016, at 8:10, Jafar Al-Gharaibeh wrote: On 6/8/2016 9:13 AM, Paul Jakma wrote: On Wed, 8 Jun 2016, Martin Winter wrote: So even in a set of 4 patches, I would test patch 1, patch 1+2, patch 1+2+3 and finally patch 1+2+3+4 ? Or test each

[quagga-dev 15479] Re: [PATCH] pimd: Add ability to safely ignore route-maps

2016-06-07 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 6/2/2016 1:37 AM, Donald Sharp wrote: pim was not parsing route-map code and causing issues using vtysh because of this. Add code to safely ignore the route-map code and set us up for future expansion into route-maps if neeeded. Sign

[quagga-dev 15477] Re: [PATCH 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter

2016-06-07 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 6/2/2016 1:20 AM, Donald Sharp wrote: The interface name is already passed in as part of the 'struct igrmp *group' pointer. No need to do it twice. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/pim_i

[quagga-dev 15475] Re: [PATCH 1/3] pimd: Remove dead code.

2016-06-07 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 6/2/2016 1:20 AM, Donald Sharp wrote: No need to keep '#if 0' code. If we need it in the future, just go back into the history and grab it. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/pim_

[quagga-dev 15434] Re: Quagga Release Process Meeting Notes

2016-06-06 Thread Jafar Al-Gharaibeh
On 6/5/2016 9:30 AM, Michael Richardson wrote: Jafar Al-Gharaibeh <ja...@atcorp.com> wrote: Identical releases: Quagga-CE-1.0-0.0 Quagga-YE-1.0 How would a Quagga-YE-1.0 that has had a security patch applied to it be numbered? I thought about this (and yes, we are overthinking it :) )

[quagga-dev 15433] Re: Round 8

2016-06-06 Thread Jafar Al-Gharaibeh
Remove unused #ifdef HAVE_STRUCT_SOCKADDR_DL bgpd: Fix code path that leads to uninitialized variables lib: Remove unnecessary paranthesis bgpd, lib: Remove RESTRICTED_NODE from code base Igor Ryzhov <iryz...@nfware.com> (2): zebra: add missing vty commands bgpd

[quagga-dev 15427] Re: Quagga Release Process Meeting Notes

2016-06-03 Thread Jafar Al-Gharaibeh
2016 5:16 PM, Jafar Al-Gharaibeh wrote: On 6/2/2016 11:43 AM, Donald Sharp wrote: How do the releases relate to each other? Not sure if it is a problem. Keep numbering disconnected since we don't currently have CE and YE connected? This boils down to the question of how much differen

[quagga-dev 15418] Re: Quagga Release Process Meeting Notes

2016-06-02 Thread Jafar Al-Gharaibeh
he numbers told me everything I need to know. --Jafar On 6/2/2016 4:16 PM, Jafar Al-Gharaibeh wrote: On 6/2/2016 11:43 AM, Donald Sharp wrote: How do the releases relate to each other? Not sure if it is a problem. Keep numbering disconnected since we don't currently have CE and YE

[quagga-dev 15354] Re: Straw man (wacko?) idea on releases, process, and repo structure

2016-05-23 Thread Jafar Al-Gharaibeh
+1 On 5/23/2016 12:45 PM, Donald Sharp wrote: +1 donald On Sat, May 21, 2016 at 3:31 PM, Lou Berger > wrote: So in thinking about the problems we are discussing this and a little bit more, considering the comments made on the list as well

[quagga-dev 15272] Re: Unable to clone quagga repo

2016-05-16 Thread Jafar Al-Gharaibeh
On 5/15/2016 7:40 AM, Lou Berger wrote: That would work for me. Should be pretty simple to regularly mirror. We could even go crazy and make it a bidirectional mirror to start Why not bring this up in the meeting tomorrow :) ... I like the idea of a github repo as well. --Jafar

[quagga-dev 15243] [PATCH] pimd: [fix] send pim prune via correct interface when rpf upstream interface for a source changes

2016-05-09 Thread Jafar Al-Gharaibeh
-by: Jafar Al-Gharaibeh <ja...@atcorp.com> Signed-off-by: Taylor Bouvin <tbou...@atcorp.com> --- pimd/pim_rpf.c | 12 ++-- pimd/pim_rpf.h | 2 +- pimd/pim_zebra.c | 8 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/pimd/pim_rpf.c b/pimd/pim_rpf.c i

[quagga-dev 15176] Re: proposed 7

2016-04-26 Thread Jafar Al-Gharaibeh
On 4/26/2016 7:05 AM, Donald Sharp wrote: Jafar - That seems reasonable. The route-map crash does as well. Any other votes? Maybe 1913, missing vty commands? donald On Mon, Apr 25, 2016 at 11:15 AM, Jafar Al-Gharaibeh <ja...@atcorp.com <mailto:ja...@atcorp.com>> wrote:

[quagga-dev 15149] Re: [PATCH] ospfd: fix - correct neighbor index on changing/p2p/virtual links

2016-04-22 Thread Jafar Al-Gharaibeh
On 4/22/2016 12:24 AM, Joakim Tjernlund wrote: On Thu, 2016-04-21 at 16:22 -0500, Jafar Al-Gharaibeh wrote: ospfd keeps a list of neighbor routers for each configured interface. This list is indexed using the neighbor router id in case of point-to-point and virtual link types, otherwise

[quagga-dev 15130] [PATCH] zserv: [pimd] fix - avoid dereferencing a NULL pointer

2016-04-21 Thread Jafar Al-Gharaibeh
Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- zebra/zserv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zebra/zserv.c b/zebra/zserv.c index 7a75ed4..6fd5ee7 100644 --- a/zebra/zserv.c +++ b/zebra/zserv.c @@ -630,7 +630,8 @@ zsend_ipv4_nexthop_looku

[quagga-dev 15128] Re: [PATCH] ospfd: fix - correct neighbor index on changing/p2p/virtual links

2016-04-21 Thread Jafar Al-Gharaibeh
This patch supersedes patches 1897 and 1898 and provides a better more general solution to the problem. --Jafar On 4/21/2016 4:22 PM, Jafar Al-Gharaibeh wrote: ospfd keeps a list of neighbor routers for each configured interface. This list is indexed using the neighbor router id in case

[quagga-dev 15127] [PATCH] ospfd: fix - correct neighbor index on changing/p2p/virtual links

2016-04-21 Thread Jafar Al-Gharaibeh
to stumble over this dangling pointer causing ospfd to crash. Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- ospfd/ospf_interface.c | 8 +--- ospfd/ospf_neighbor.c | 33 - ospfd/ospfd.c | 6 +++--- 3 files changed, 40 insertions

[quagga-dev 15123] Re: [PATCH] pimd: Fix hang when doing nexthop lookup from zebra

2016-04-21 Thread Jafar Al-Gharaibeh
-by: Jafar Al-Gharaibeh On 4/20/2016 12:13 AM, jonomh...@gmail.com wrote: From: Jonathan Hart <j...@onlab.us> I was running in to a bug when pimd would hang in some cases when it had to do a nexthop lookup from zebra, such as when a PIM JOIN was received. This issue could be easily repr

[quagga-dev 15120] Re: ospfd crashes after updating to 1.0.20160315

2016-04-21 Thread Jafar Al-Gharaibeh
Hi Sergey, Do you have the log file for ospfd with various debugging options enabled? debug ospfd [packet|ism|nsm|zebra|lsa] Thanks, Jafar On 4/21/2016 10:30 AM, Sergey Popov wrote: Hi, guys. After updating Quagga from 0.99.24.1 to 1.0.20160315 i am expirience constant crashing of

[quagga-dev 15078] Re: [PATCH] ospfd: fix - use the correct index for pseudo neighbors on p2p/virtual links

2016-04-19 Thread Jafar Al-Gharaibeh
bout to free +*/ + if (nbr == rn->info);{ + rn->info = NULL; + route_unlock_node (rn); + } + } + route_unlock_node (rn); Thanks, Jafar On 4/18/2016 11:15 AM, Jafar Al-Gharaibeh wrote: ospfd keeps a list of neighbor routers for each configured interface. This lis

[quagga-dev 15062] [PATCH] ospfd: fix - use the correct index for pseudo neighbors on p2p/virtual links

2016-04-18 Thread Jafar Al-Gharaibeh
t is bound to stumble over this dangling pointer causing ospfd to crash. Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- ospfd/ospf_interface.c | 8 +--- ospfd/ospf_neighbor.c | 29 - ospfd/ospfd.c | 6 +++--- 3 files changed, 36 insertions

[quagga-dev 15056] [PATCH] Fix ospfd: use the correct index for pseudo neighbors on p2p/v links

2016-04-15 Thread Jafar Al-Gharaibeh
t is bound to stumble over this dangling pointer causing ospfd to crash. Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com> --- diff --git a/ospfd/ospf_interface.c b/ospfd/ospf_interface.c index f4242b0..d54bc47 100644 --- a/ospfd/ospf_interface.c +++ b/ospfd/ospf_interface.c @@ -232,8 +232,

[quagga-dev 15055] Re: ospfd Random Crash During "Warm Up"

2016-04-14 Thread Jafar Al-Gharaibeh
I found the bug! It is in ospfd's code for handling router id change and point-to-point links, will send a patch in the next couple of days. Regards, Jafar On 4/14/2016 2:02 PM, Jafar Al-Gharaibeh wrote: On 4/14/2016 11:27 AM, Jafar Al-Gharaibeh wrote: I'm running the latest Quagga

[quagga-dev 15052] ospfd Random Crash During "Warm Up"

2016-04-14 Thread Jafar Al-Gharaibeh
I'm running the latest Quagga release on a few routers and I get random crashes every now and then when I restart Quagga followed by another program that pushes a lot of configuration through vtysh. All of the links I have are GRE tunnels (point-to-point) sharing the IP address of the

[quagga-dev 15024] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

2016-04-08 Thread Jafar Al-Gharaibeh
we present it in the output then? While I'm in favor of keeping it the way it is, I also don't have a strong opinion against starting with the initial state. --Jafar On Fri, Apr 8, 2016 at 11:11 AM, Jafar Al-Gharaibeh <ja...@atcorp.com <mailto:ja...@atcorp.com>> wrote:

[quagga-dev 15019] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

2016-04-08 Thread Jafar Al-Gharaibeh
ly up or now (there are already ways to know that). So, the reported output in your case is correct; the interface never went up/down since Quagga started. --Jafar doanld On Thu, Apr 7, 2016 at 5:00 PM, Jafar Al-Gharaibeh <ja...@atcorp.com <mailto:ja...@atcorp.com>> wrote: Acke

[quagga-dev 15015] Re: [PATCH 1/2] lib: use constant to replace magic value for length of quagga_timestamp

2016-04-07 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 4/7/2016 2:43 PM, Christian Franke wrote: From: Christian Franke <nob...@nowhere.ws> Signed-off-by: Christian Franke <ch...@opensourcerouting.org> --- lib/log.h | 3 ++- lib/vty.c | 2 +- 2 files changed, 3 insertio

[quagga-dev 15016] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

2016-04-07 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 4/7/2016 2:43 PM, Christian Franke wrote: From: Christian Franke <nob...@nowhere.ws> It is quite useful to be able to assert whether specific interfaces have flapped or also to verify that specific interfaces have not flapped

[quagga-dev 15014] Re: Multipath doesn't work in 1.0

2016-04-07 Thread Jafar Al-Gharaibeh
On 4/7/2016 2:12 PM, Christian Franke wrote: On 04/07/2016 12:26 PM, Igor Ryzhov wrote: I studied zebra_rib.c history and found one strange change in commit 0abf6796 (http://git.savannah.gnu.org/cgit/quagga.git/commit/?id=0abf6796c3d8ae8f5ea8624668424bc1554de25e). Before this patch there

[quagga-dev 14937] Update on Multi Topology Routing: OSPF

2016-03-15 Thread Jafar Al-Gharaibeh
Hi, I started with the MTR code from 2010 at https://github.com/tomhenderson/quagga-mtr/tree/mtr (mtr branch) which was based off Quagga 0.99.17.0 and ported it to Quagga 0.99.24.1+ as of May 2015 to the last commit before introducing the big VRF changes. I created a github repo for this

[quagga-dev 14692] Re: Proposed Versioning

2016-02-17 Thread Jafar Al-Gharaibeh
I like the idea. This should work as long as users do not read too much into MMDD thinking of it as a build date rather than a sub minor version with actual fixes/changes in the sources, but probably that is unlikely. --Jafar On 2/16/2016 7:28 PM, Donald Sharp wrote: In today's Monthly

[quagga-dev 14320] Re: Multi-Topology Routing in OSPF

2015-12-21 Thread Jafar Al-Gharaibeh
On 12/21/2015 12:06 PM, Daniel Walton wrote: On Mon, Dec 21, 2015 at 12:38 PM, Jafar Al-Gharaibeh <ja...@atcorp.com <mailto:ja...@atcorp.com>> wrote: On 12/20/2015 11:51 PM, Andrew Qu wrote: In order to support MTR, we worked hard as well to design our ASIC in c

[quagga-dev 14321] Re: Multi-Topology Routing in OSPF

2015-12-21 Thread Jafar Al-Gharaibeh
. This should happen on all routers in the network. This depends on the ability of OSPF to build different spf trees based on different metrics for each link. --Jafar *From:*Jafar Al-Gharaibeh [mailto:ja...@atcorp.com] *Sent:* Monday, December 21, 2015 9:39 AM *To:* Andrew Qu; Donald Sharp; Daniel

[quagga-dev 14315] Re: Multi-Topology Routing in OSPF

2015-12-21 Thread Jafar Al-Gharaibeh
( such as segment routing), MTR may be easier to be supported in the network end-to-end that way. Thanks, Andrew *From:*Donald Sharp [mailto:sha...@cumulusnetworks.com] *Sent:* Sunday, December 20, 2015 6:34 AM *To:* Daniel Walton *Cc:* Jafar Al-Gharaibeh; Quagga Devel *Subject:* [quagga-dev 14302] Re: Multi

[quagga-dev 14299] Multi-Topology Routing in OSPF

2015-12-18 Thread Jafar Al-Gharaibeh
Hi Everyone, I have been looking into the ability to support multiple cost metrics per link for ospf, which is something that I brought up in our first Quagga monthly meeting. The "official" term for that is Multi-Topology (MT) Routing in OSPF which is described in RFC 4915

[quagga-dev 13905] Re: [PATCH 22/58] Zebra: Dissallow outside programs to delete Quagga routes

2015-11-17 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh <ja...@atcorp.com> On 11/13/2015 1:18 PM, Donald Sharp wrote: From: James Li <j...@cumulusnetworks.com> Do not allow a program outside Quagga to delete a Quagga route from the kernel. To delete a Quagga route, do it inside Quagga. Signed-off-by:

[quagga-dev 13752] Re: Quagga community development processes

2015-11-12 Thread Jafar Al-Gharaibeh
On 11/12/2015 11:21 AM, Paul Jakma wrote: On Thu, 12 Nov 2015, Jafar Al-Gharaibeh wrote: Technically, I don't think there is a way around this - write access will not be turned loose. The privileged group will be made bigger, maybe covering everyone on the dev list if that what you mean

[quagga-dev 13743] Re: Quagga community development processes

2015-11-12 Thread Jafar Al-Gharaibeh
Paul, Thank you for having a very liberal standing on how to handle this. Regarding your comment "privileged group": First, like politicians you can always say this is responsibility not privilege ;) Technically, I don't think there is a way around this - write access will not be

[quagga-dev 13642] Re: [PATCH 20/31] OSPF: Fix no ip ospf hello-interval

2015-11-10 Thread Jafar Al-Gharaibeh
The comment should read: OSPF silently ignores 'no ip ospf dead-interval X' and 'no ip ospf hello-interval X' --Jafar On 11/10/2015 8:33 AM, Donald Sharp wrote: From: Daniel Walton OSPF silently ignores 'no ip ospf hello-interval X' and 'no ip ospf

[quagga-dev 13524] Re: Quagga community development processes

2015-11-06 Thread Jafar Al-Gharaibeh
On 11/6/2015 5:44 PM, Martin Winter wrote: To push this even further, is there a reason why you (Daniel) or your colleague Donald or a person like Timos don’t want to be a maintainer? Or just nobody ever asked or considered it? Thank you Martin for pushing this. I think this is very

[quagga-dev 13473] Re: the VRF/namespace/multi-instance story

2015-10-30 Thread Jafar Al-Gharaibeh
On 10/19/2015 4:49 AM, Nicolas Dichtel wrote: Le 16/10/2015 14:24, Paul Jakma a écrit : That was one thing blocking. The other is the current patch, being only a part of the story, is somewhat confusing. It is still not clear to me how we will make this "support both in-daemon VRFs and

[quagga-dev 12902] Re: Fast OSPF convergence

2015-07-30 Thread Jafar Al-Gharaibeh
On 7/27/2015 2:14 PM, Michael Rossberg wrote: Hi, This is a great idea, thanks for the implementation! I am happy if someone finds it useful. struct timeval +msec2tv (int a) +{ + struct timeval ret; + + ret.tv_sec = 0; + ret.tv_usec = a * 1000; + + return tv_adjust (ret); +} I'm

[quagga-dev 12750] Re: VRF - TBD/XXX

2015-06-16 Thread Jafar Al-Gharaibeh
200.0.0.0/24 1.2.3.4 ltid 1 Code level: s/vrfid/ltid (standing for logical table index) Best regards Alain On 06/16/2015 04:16 PM, Jafar Al-Gharaibeh wrote: Andrew, According to the figure, you built your point view on the assumption that LR is a network namespace, or at least associated

[quagga-dev 12724] Re: [PATCH v3 00/22] VRF support in quagga

2015-06-15 Thread Jafar Al-Gharaibeh
I don't have a strong opinion on this, but each of the suggested terms has its own shortcoming. Domain is overused logical-table is a little too long vrf is a little ambiguous The best thing I could came up with was LRF, since we are still talking about a VRF related feature, but ewe don't

[quagga-dev 12736] Re: VRF - TBD/XXX

2015-06-15 Thread Jafar Al-Gharaibeh
I think of LR: logical router as something more than a table. i.e, a collection of logical tables might serve the same logical router, just like a physical router might have multiple routing tables. So I suggest LR to mean Logical Routing table, if LRF: Logical Routing and Forwarding table is

[quagga-dev 12709] Re: pimd fatal asserts

2015-06-12 Thread Jafar Al-Gharaibeh
12, 2015 at 12:51 AM, Jafar Al-Gharaibeh ja...@atcorp.com mailto:ja...@atcorp.com wrote: Donald, We have been using pimd for a couple of years and we had submitted several bug fixes that seem to have made it to the official sources which is great, especially with the addition

[quagga-dev 12708] Re: pimd fatal asserts

2015-06-12 Thread Jafar Al-Gharaibeh
to send a packet to A but since it doesn't have a route yet (even a default one), it doesn't find an interface to use which triggers the assertion below. --Jafar On 6/11/2015 11:51 PM, Jafar Al-Gharaibeh wrote: Donald, We have been using pimd for a couple of years and we had submitted

[quagga-dev 12703] [PATCH] pimd: add support for configuring multicast static routes

2015-06-11 Thread Jafar Al-Gharaibeh
Hi, This patch adds the ability to configure multicast static routes directly into pimd. Two source files are introduced to implement the new feature in addition to changes to existing files. Here is how it can be used the CLI: interface incoming interface ip mroute outgoing interface group

[quagga-dev 12705] pimd fatal asserts

2015-06-11 Thread Jafar Al-Gharaibeh
Donald, We have been using pimd for a couple of years and we had submitted several bug fixes that seem to have made it to the official sources which is great, especially with the addition of pimd to the official Quagga. There are several places in the code where asserts appear to be an

[quagga-dev 12678] Re: [PATCH v3 00/22] VRF support in quagga

2015-06-09 Thread Jafar Al-Gharaibeh
, Jafar Al-Gharaibeh wrote: But you are doing this for every daemon for every VRF, things add up really quick. In a small experiment that I'm running now Quagga (zebra, ospfd, pimd) uses 9MB of RAM. if I start adding VRFs I'm going to hit a wall really quick. Just on this. This is a freshly

[quagga-dev 12679] Re: [PATCH v3 00/22] VRF support in quagga

2015-06-09 Thread Jafar Al-Gharaibeh
On 6/9/2015 3:38 PM, Paul Jakma wrote: On Tue, 9 Jun 2015, Jafar Al-Gharaibeh wrote: The current table command seems to be more of a global state controlling what is the current kernel table Quagga is communicating with by default. Yeah, that's what I thought. It's never really been

[quagga-dev 12652] Re: [PATCH v5 3/3] lib, vtysh: support multiple VRFs by using linux netns

2015-06-05 Thread Jafar Al-Gharaibeh
On 6/5/2015 7:53 AM, Vincent JARDIN wrote: On 05/06/2015 13:54, Alain Ritoux wrote: Code level: s/vrfid/ltid (standing for logical table index) +1 , it makes sense since it is indexing tables. Except that it doesn't index a table really, it does index a domain (for lack of a better

[quagga-dev 12656] Re: [PATCH v5 3/3] lib, vtysh: support multiple VRFs by using linux netns

2015-06-05 Thread Jafar Al-Gharaibeh
On 6/5/2015 9:51 AM, Alain Ritoux wrote: On 06/05/2015 04:28 PM, Jafar Al-Gharaibeh wrote: Except that it doesn't index a table really, it does index a domain (for lack of a better term) where multiple tables can live. No, it really indexes a logical-table (ex-domain); the way the logical

[quagga-dev 12564] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-29 Thread Jafar Al-Gharaibeh
On 5/29/2015 2:55 AM, Paul Jakma wrote: One of the key questions for me is whether the two approaches can live together. I have scripts semi-hacked together to run Quagga daemons in different VRFs^Wnamespaces - I use a number as the namespace name, so it's like a VRF id. The script

[quagga-dev 12545] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Jafar Al-Gharaibeh
On 5/28/2015 11:35 AM, Paul Jakma wrote: On Thu, 28 May 2015, Lennart Sorensen wrote: As someone working on small embedded level boxes without lots of cpu cores, the separate process per VRF is not desirable at all. One process with one config interface running in multiple namespaces is

[quagga-dev 12544] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Jafar Al-Gharaibeh
On 5/28/2015 11:29 AM, Jafar Al-Gharaibeh wrote: Lennart, I agree. I Kinda made the same statements in earlier emails. I also don't have a strong opinion against moving VRF creation/management to a new daemon. Unlike other protocol daemons that need to be replicated across different VRFs

[quagga-dev 12511] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-27 Thread Jafar Al-Gharaibeh
On 5/27/2015 3:49 AM, Nicolas Dichtel wrote: Le 27/05/2015 03:26, Xiaorong (Andrew) Qu a écrit : Hi Jafar, Either way of merging should work. As for terminology, using your example VRF 3 table 2 is not ideal to me. I would like netns 3|blue table 2 as netns is the keyword for namespace

[quagga-dev 12496] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-26 Thread Jafar Al-Gharaibeh
Andrew, I will leave direct answers to your questions to Nicolas, but here is my take in the matter. Given how substantial 6WIND's patches already, I'd probably wait for the patches to be merged in (if ever) and rebase afterward. Just a thought, in the bigger picture, I think your

[quagga-dev 12320] Re: VRF and Multiple-Instance OSPF

2015-05-15 Thread Jafar Al-Gharaibeh
, do you see any problem going that route? Thanks, Jafar On 5/15/2015 1:01 PM, Vipin Kumar wrote: On Thu, May 14, 2015 at 4:28 PM, Jafar Al-Gharaibeh ja...@atcorp.com mailto:ja...@atcorp.com wrote: Hi Nicolas, Thank you for the email. I looked at the comments/details

[quagga-dev 12312] Re: VRF and Multiple-Instance OSPF

2015-05-14 Thread Jafar Al-Gharaibeh
code to let them know which VRF they are talking about at the daemon level - from ospfd at least. Regards, Jafar On 5/14/2015 2:25 AM, Nicolas Dichtel wrote: Hi, Le 07/05/2015 17:57, Jafar Al-Gharaibeh a écrit : Hi, I have been trying the VRF features for the last few weeks, and I

[quagga-dev 12259] Re: VRF and Multiple-Instance OSPF

2015-05-07 Thread Jafar Al-Gharaibeh
/implementation. Thanks, Jafar On 2/2/2015 11:12 AM, Jafar Al-Gharaibeh wrote: Hi Feng, Thank you very much for the info. I'm not underestimating the amount of work needed to merge these big patches. I understand the need to go slow with any major update. kudos to Quagga's maintainers for all

[quagga-dev 11999] VRF and Multiple-Instance OSPF

2015-01-30 Thread Jafar Al-Gharaibeh
Hi, I have seen a lot of discussion recently about VRF and Multiple-Instance OSPF to be added to Quagga. These are really great features! When are these features going to be added (if ever) to the main/master branch and be available for everybody, is there a time frame? Is there a branch