Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Bruce Cran
Thanks - the patch fixed the problem. -- Bruce -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send ema

Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Colin Caughie
This is issue 2791 - https://code.google.com/p/reviewboard/issues/detail?id=2971. I have a fix pending (http://reviews.reviewboard.org/r/4121/) but I haven't yet had time to address Christian's feedback on the patch. It's unlikely I'll be able to spend any time on this this until about 2 weeks

Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Bruce Cran
I've tried restarting memcached, but it didn't help. reviewboard.log just shows that it's getting a 404 from Hg web server when trying to fetch the parent revision - which makes sense since it hasn't been committed - e.g. the patches are: parent: diff -r 1 -r 2 file1.txt --- a/file1.txtFri Ju

Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Christian Hammond
Hi Bruce, There's only two change to Mercurial since 1.7.6. One has to do with fixes to the Mercurial version checking. That fix, though, has to do with handling the different ways of checking the Mercurial version and working around a breakage we had in some setups, and I wouldn't expect it to h

Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Bruce Cran
Hi Christian, I upgraded from 1.7.6, and this breaks both when using RBTools and when uploading patches via the Web interface. I've not upgraded RBTools, but someone else tried using the newer version and found it was still broken. -- Bruce Cran On 10 June 2013 09:19, Christian Hammond wrote:

Re: 1.7.9 regression with hg parent diffs

2013-06-10 Thread Christian Hammond
Hi Bruce, Can you tell me what version of Review Board you were using before? Also, did you upgrade RBTools before this broke? I don't see any changes to our Mercurial support in the past two releases of Review Board, aside from one to do verification when adding a new repository. It's possible

1.7.9 regression with hg parent diffs

2013-06-07 Thread Bruce Cran
There seems to be a regression in 1.7.9 with mercurial parent diffs: if a file is modified in the review diff that wasn't changed in the parent diff, then Review Board generates the error "*Error:* The file 'file2.txt' (r12345678) could not be found in the repository". -- Bruce Cran -- Wan