Re: Active Directory - Can't Assign New User to Review

2014-07-18 Thread fireworm
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backends.py Line 698: def get_or_create_user(self, username, request, ad_user_data): username = re.sub(INVALID_USERNAME_CHAR_REGEX, '', username).lower()

Re: Active Directory - Can't Assign New User to Review

2014-07-17 Thread Jason Batchkoff
*bump bump* Anyone? Still haven't figured out how to get a local change to the py scripts to reflect correctly in the running copy. On Wed, Jul 2, 2014 at 9:58 AM, fireworm firewor...@gmail.com wrote: *bump* Anyone have any ideas? On Thursday, June 26, 2014 11:53:46 AM UTC-7, fireworm

Re: Active Directory - Can't Assign New User to Review

2014-07-17 Thread Bruce Cran
Do you also need to restart memcached? -- Bruce On Thu, Jul 17, 2014 at 9:51 AM, Jason Batchkoff firewor...@gmail.com wrote: *bump bump* Anyone? Still haven't figured out how to get a local change to the py scripts to reflect correctly in the running copy. -- Get the Review Board

Re: Active Directory - Can't Assign New User to Review

2014-07-17 Thread David Trowbridge
You probably need to delete the .pyc file and reload the web server. -David On Thu, Jul 17, 2014 at 11:32 AM, Bruce Cran bruce.c...@gmail.com wrote: Do you also need to restart memcached? -- Bruce On Thu, Jul 17, 2014 at 9:51 AM, Jason Batchkoff firewor...@gmail.com wrote: *bump

Re: Active Directory - Can't Assign New User to Review

2014-07-17 Thread David Trowbridge
That's pretty mysterious. Are you sure that the logging you added is in the correct places? -David On Thu, Jul 17, 2014 at 2:01 PM, fireworm firewor...@gmail.com wrote: Yep, that's what I did. But it refuses to acknowledge I changed the actual execution logic... Or it's just super smart?

Re: Active Directory - Can't Assign New User to Review

2014-07-02 Thread fireworm
*bump* Anyone have any ideas? On Thursday, June 26, 2014 11:53:46 AM UTC-7, fireworm wrote: Removed the pyc file (review_request.pyc). Set myself as the owner (not www-data or admin or whatever). Restarted apache. Refreshed the review webpage. Page loaded just fine, no pyc next to

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread Christian Hammond
Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian --  Christian Hammond - 

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread fireworm
Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread fireworm
...I get the feeling my changes to the python are somehow not being actually run. Is there a place I can put a logging.debug() call that absolutely gets hit 100% of the time to make sure i can see it? On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote: Local Site: Not that I'm

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread fireworm
Ok, adding garbage text to the python is not causing the server to go down, I'm thinking my updates aren't taking effect. More sanity checking: I don't have any of the developer code installed and am modifying the install itself, right? I don't need to update an executable somewhere forcibly?

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread Christian Hammond
Yeah, it does sound like it’s not executing. Try removing the .pyc file, just to check. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 10:12:41 AM, fireworm (firewor...@gmail.com)

Re: Active Directory - Can't Assign New User to Review

2014-06-26 Thread fireworm
Removed the pyc file (review_request.pyc). Set myself as the owner (not www-data or admin or whatever). Restarted apache. Refreshed the review webpage. Page loaded just fine, no pyc next to review_request.py. Seems super suspicious. On Thursday, June 26, 2014 11:47:41 AM UTC-7, Christian Hammond

Re: Active Directory - Can't Assign New User to Review

2014-06-25 Thread Christian Hammond
Just to sanity-check, can you tell me the exact steps you’re using for adding a user, and exactly what you see on the screen? Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 24, 2014 at

Re: Active Directory - Can't Assign New User to Review

2014-06-25 Thread Bruce Cran
Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firewor...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted

Re: Active Directory - Can't Assign New User to Review

2014-06-25 Thread fireworm
Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter.

Re: Active Directory - Can't Assign New User to Review

2014-06-24 Thread Christian Hammond
Sorry, busy few days. You would need to edit reviewboard/accounts/backends.py and look for ActiveDirectoryBackend. In it, you will find a ‘get_or_create_user’ function. I’d start by adding a logging statement just below where username is assigned:    

Re: Active Directory - Can't Assign New User to Review

2014-06-24 Thread fireworm
I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see

Re: Active Directory - Can't Assign New User to Review

2014-06-23 Thread fireworm
*bump* Any ideas on what I can do? On Thursday, June 19, 2014 9:08:00 AM UTC-7, fireworm wrote: I'd be ok with adding some logging. Just be super explicit on what to do and what commands to run after. :) On Thursday, June 19, 2014 12:54:49 AM UTC-7, Christian Hammond wrote: Hi, Would

Re: Active Directory - Can't Assign New User to Review

2014-06-19 Thread Christian Hammond
Hi, Would you feel comfortable adding some logging statements to the ActiveDirectory code to help track this down? It’s supposed to look up the appropriate user and add it, even if Review Board doesn’t yet know about it. I can give you instructions on where to add them. Christian -- 

Re: Active Directory - Can't Assign New User to Review

2014-06-19 Thread fireworm
I'd be ok with adding some logging. Just be super explicit on what to do and what commands to run after. :) On Thursday, June 19, 2014 12:54:49 AM UTC-7, Christian Hammond wrote: Hi, Would you feel comfortable adding some logging statements to the ActiveDirectory code to help track this

Active Directory - Can't Assign New User to Review

2014-06-18 Thread fireworm
New install of RB 2.0.2 on Ubuntu, with Active Directory login working. Users can login once and create their account correctly. But I can't seem to add a user to a review who has not logged in at least once. I enabled logging, but don't see anything in the log after failing to add a user.