Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-15 Thread Thilo-Alexander Ginkel
On Mon, Dec 14, 2009 at 23:11, Christian Hammond chip...@chipx86.com wrote: It should just be the field constraints from those FileFields. We don't do any custom validation checks in those forms that I can see. It could potentially fail if the diff itself is empty, even though the name is

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-15 Thread Thilo-Alexander Ginkel
On Tue, Dec 15, 2009 at 15:28, Thilo-Alexander Ginkel th...@ginkel.com wrote: The question is, how can I calculate the length of this string in bytes, not characters, taking the wire encoding into account? A patch is available at: http://reviews.reviewboard.org/r/1298/ Regards, Thilo -- Want

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-15 Thread Ryan Oblak
Regarding this issue on the 1.1 alpha nightlies, I believe it is caused by the patch I submitted in this review: http://reviews.reviewboard.org/r/1295/ It seems as though my fix for the New Review Request web UI broke the diff upload mechanism. This affects both the web UI for uploading new

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-14 Thread Christian Hammond
Which version of Review Board is this running right now? I've seen this recently on the 1.1 alpha nightlies. Also, what repository type is this? It could indicate a missing dependency. The error checking/reporting for that on 1.0.x is pretty bad, but improved in 1.1. Is this only happening to

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-14 Thread Christian Hammond
It should just be the field constraints from those FileFields. We don't do any custom validation checks in those forms that I can see. It could potentially fail if the diff itself is empty, even though the name is populated. Are they uploading using post-review? Might be worth seeing what