It should just be the field constraints from those FileFields. We don't do any custom validation checks in those forms that I can see.
It could potentially fail if the diff itself is empty, even though the name is populated. Are they uploading using post-review? Might be worth seeing what post-review --output-diff shows. Or otherwise, just making sure the diff is non-empty. Short of that, I wouldn't be able to see off-hand without seeing the code and doing my own debugging. Though it's probably not the cause, it also might be worth checking if there are any proxy settings getting in the way. We used to run into some issues with users who were going through the proxy for the Review Board server (despite it being within the network), and some stuff broke along the way. Though I don't believe we hit file upload issues. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Dec 14, 2009 at 1:52 PM, Thilo-Alexander Ginkel <th...@ginkel.com>wrote: > On Monday 14 December 2009 22:28:35 Christian Hammond wrote: > > Which version of Review Board is this running right now? I've seen this > > recently on the 1.1 alpha nightlies. > > It's a slightly patched 1.0.5.1. > > > Also, what repository type is this? It could indicate a missing > dependency. > > The error checking/reporting for that on 1.0.x is pretty bad, but > improved > > in 1.1. > > It's a custom SCM, so I cannot rule out that the bug is in my code. > Dependencies should not be an issue, though, as the SCM client code is > mostly > self-contained and does all of its communication with the SCM via HTTP. > > Do you have an idea what may be causing form.is_valid() to return false? Is > it > just the mandatory field constraints, which are being checked? The weird > thing > is, that according to my client-side dump the 'path' attribute is populated > correctly. > > > Is this only happening to some people and not everyone? > > Yes. > > Regards, > Thilo > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
