Re: Testing Done field frequently breaks reviews

2013-01-17 Thread Steve
Repairing this would require going into the database viewer in the administration UI, locating the Change Description table for the change (we don't give you the easiest ways to do that, so you'll have to try narrowing it down by date), and fixing the content to be valid JSON. YMMV. When I go

Re: Testing Done field frequently breaks reviews

2013-01-16 Thread Christian Hammond
Hi Steve, This breaks on the review request page because the Testing Done text is being stored in a JSON structure along with other data for the Review request updated sections. These sections do not show on the diff viewer. Repairing this would require going into the database viewer in the

Re: Testing Done field frequently breaks reviews

2013-01-16 Thread Steve
I have a 1.6 server staged for testing that I'm planning to roll out soon. I'll import the latest database and see if the problem shows up there as well. As for Tell developers not to paste so much :) I thought it was the size of the text also, but I'm beginning to think it's not. I've

Re: Testing Done field frequently breaks reviews

2013-01-16 Thread Christian Hammond
It won't fix existing review requests. The data is truncated at write, so you have to fix it manually, by hand. It will only prevent the problem for new review requests. It's certainly not the content. This is an old, very well known and tested bug. The problem is that there's only so much

Re: Testing Done field frequently breaks reviews

2013-01-16 Thread Steve
I just read this again more carefully: Actually, the reason you're having this problem is that your release is so old. If you upgrade, this shouldn't happen on newer review requests. That sounds like even on the new server this particular review will be broken, but new reviews should not end

Re: Testing Done field frequently breaks reviews

2013-01-16 Thread Steve
Excellent - thanks Chris! On Wednesday, January 16, 2013 2:39:20 PM UTC-8, Christian Hammond wrote: It won't fix existing review requests. The data is truncated at write, so you have to fix it manually, by hand. It will only prevent the problem for new review requests. It's certainly not