Hi Steve,
I really don't know then. It must either be some weird bug in that install, or
something funky and custom going on. Certainly, the behavior of not showing
Close/Update is correct.
I'm curious if Close/Update even works on the old install.
Christian
--
Christian Hammond -
I'd like to back up and break this down into smaller, simpler questions.
When I go to my 1.6.9 RB server and browse to another user's review, I see
these buttons along the top, right portion of the page:
Download DiffReviewShip It!View Diff
When I go to both of my 1.7.6
Hi Steve,
Are you set up as an admin on both servers? Or do you have the Can Close
privilege set?
If so, 1.7.x should behave the same as it did in 1.6.x (and certainly does in
our installs).
Christian
On Jun 14, 2013, at 14:04, Steve seide.al...@gmail.com wrote:
I'd like to back up and
I do not have staff or superuser set for this account, nor any special mod
permissions. And everyone here also sees the same 'Close' button on other
people's reviews. So, something is configured. I wonder if there's an old
database setting that we've been pulling along since the 1.0.x, 1.5
Hi Steve,
There's no special flag for this. We implemented this functionality pre-1.0 and
it has never changed. The only way you ever see Close or Update is when you
have superuser privileges or the Can Edit/Can Close privileges. I'm not aware
of this ever regressing or changing throughout the
I just went to a friend's desk and verified he sees the 'Close' button on
other people's reviews. Here are his user settings in the DB:
id: 7
username: xx
first_name: xx
last_name: xx
email: x
password: x
is_staff: 0
is_active: 1
It's auth_user_user_permissions, which will map user IDs to IDs in
auth_permissions.
Alternatively, you can do:
$ rb-site manage /path/to/site shell
from django.contrib.auth.models import User
u = User.objects.get(username='youruser')
u.is_superuser
u.is_staff
Thanks for the example - I keep forgetting about rb-site shell. It's
nifty. Here's what I get:
# rb-site manage /var/www/reviewboard shell
Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
Type help, copyright, credits or license for more
We have a custom authentication backend we use to authenticate via ldap.
Other than that, it's out-of-the-box. The server is brand new, so RB 1.7
was newly installed. However, our database schema has migrated from 1.0 to
1.5 to 1.7.6. Any chance of an old configuration setting in the
We're running RB 1.7.6. I've had several users report their reviews have
been marked as submitted, and I've seen it as well. As an experiment, I
asked a user without admin or superuser rights to mark one of my reviews as
submitted and they were able to do so. This raises these questions:
1.
Normal users should not have the ability to close others' review requests.
You say these users are not admin or superuser. Do they have the can
change status permission enabled?
-David
On Tue, Jun 11, 2013 at 10:23 AM, Steve seide.al...@gmail.com wrote:
We're running RB 1.7.6. I've had
11 matches
Mail list logo
