git and diffs against branches

2009-10-23 Thread Chris Clark
Whilst I use other distributed SCM's I've only just started with git (as ReviewBoard uses it) and I think I'm having some trouble understanding git (and reviewboard). What I'd like to do is post for review changes/diffs against a branch (not master/bleeding edge). E.g. git clone

Diff issue on new install

2009-10-23 Thread Mike Gunderloy
Setting up a new Review Board install (1.0.5.1) to experiment with. Install seems to have worked and I've set up a single git repo and used post-review to toss a review request in. But on trying to view the diff I get: [Errno 32] Broken pipe Traceback (most recent call last): File

Apache hangs upon post-review

2009-10-23 Thread James
Per an earlier thread I'm trying to get Review Board working on a Windows machine with ClearCase integration. I've gotten earlier road blocks and now post-review runs but it only gets so far and then the Apache server goes to 99% CPU utilization and post-review process hangs until I restart

Re: git and diffs against branches

2009-10-23 Thread Dan Savilonis
Lobby for http://reviews.reviewboard.org/r/1144/ to get committed and you should be all set. :) For now, the only options are to use the web form or specify a revision range manually. Can you explain more about the error with the web form? You mentioned git diff, and if you meant that literally,

Re: Apache hangs upon post-review

2009-10-23 Thread Dan Savilonis
There was a problem like this with git support a long time ago. Can you add use the diff only option and make sure the diff it generates looks somewhat reasonable? Dan On Oct 23, 11:22 am, James jimspe...@gmail.com wrote: Per an earlier thread I'm trying to get Review Board working on a

Re: git and diffs against branches

2009-10-23 Thread Christian Hammond
Make sure you also use --full-index on git diff. I've been really busy the last couple weeks. In and out of town, busy work work, etc. I want that change in as much as anyone, just haven't been able to give it the attention it needs. Soon :) Christian -- Christian Hammond - chip...@chipx86.com

Re: Diff issue on new install

2009-10-23 Thread Mike Gunderloy
Debian 5.0. /usr/bin/patch exists. Mike On Oct 23, 2009, at 5:44 PM, Christian Hammond wrote: Hmm, this is a new one. /usr/bin/patch exists, right? What distro is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. -

Re: Diff issue on new install

2009-10-23 Thread Christian Hammond
Okay. Well, it sounds like for whatever reason, the STDIN or STDOUT pipe to patch is failing. What would be interesting is to take the source and dest file and manually run: cat difffile | patch -o somenewfilename oldfile There should be a /tmp/reviewboard.* directory containing a .diff

Issue 1366 in reviewboard: Group netster is not recognized by review board

2009-10-23 Thread codesite-noreply
Updates: Status: Invalid Comment #1 on issue 1366 by chipx86: Group netster is not recognized by review board http://code.google.com/p/reviewboard/issues/detail?id=1366 This is the issue tracker for bugs in Review Board, which is an open source project used by many companies. You

Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update

2009-10-23 Thread codesite-noreply
Comment #10 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Unfortunately, I can't confirm the fix. The issue is still present in version 1.0.5 in our installation (tested with Chromium 4.0.222.4,

Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update

2009-10-23 Thread codesite-noreply
Comment #12 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Yes, I restarted both apache and memcached (and tried also disabling memcached), reloaded the page multiple times, cleared the browser