Re: Role of scmtool.py

2010-06-22 Thread Albert
Hi Christian

Thank you for your reply.

I'm trying to implement the SCMTools for one of the repositories that
I work with.
I'm trying to figure out what exactly it is that reviewboard wants
with this class.

How should my implementation be for reviewboard to talk to it?

Thanks
Albert

On Jun 20, 10:20 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Albert,

 The SCMTool class is the communication layer between Review Board and
 the repositories. Every supported source code management system (Git,
 Subversion, etc.) have a corresponding SCMTool class.

 Primarily, the class has a few main purposes: downloading files (based
 on path and revision) from a repository, and parsing the diff (using a
 custom DiffParser subclass) for revision information (and any special
 metadata that's useful). There are some other things it does as well,
 though, particularly in 1.5. For example, checking if a repository
 path points to a valid repository, converting a SCM-specific revision
 string into a normalized Review Board revision indicator, checking if
 a file at all exists in a repository, and a few other small things.

 Without knowing your needs, I can't say much. However, if you look at
 the other SCMTool classes, you should have some good examples to work
 from.

 In Review Board, any bundled SCMTool must live in the scmtools
 directory, and the module path must be included in setup.py. To get a
 development environment to recognize it, you'd run
 './reviewboard/manage.py registerscmtools'. If you're using a
 production environment with this tool, you can either build your own
 package from your development tree, or package your SCMTool as a
 third-party Python egg, add lines in your setup.py file based on the
 SCMTool lines in Review Board's setup.py, install your package, and do
 an rb-site upgrade on your site.

 Christian

 On Thursday, June 17, 2010, Albert albert.geo...@gmail.com wrote:
  I need to understand the role of SCMTool class and how a class
  inheriting from this should be implmented. Any information will be
  greatly appreciated.

  Thanks,
  Albert

  --
  Want to help the Review Board project? Donate today 
  athttp://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to 
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group 
  athttp://groups.google.com/group/reviewboard?hl=en

 --
 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Loops when trying to add a svn repository

2010-06-22 Thread Martelo
Thanks Christian!

I' ve missed the apache user credentials on .subversion folder!!
Issue resolved!!!




On 21 jun, 15:55, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 It's possible that it wasn't able to store the certificate. This is
 stored in $HOME/.subversion, and this would be your web server's home
 directory. Starting in Review Board 1.5, we generate Apache +
 mod_python config files (assuming that's what you're using) that point
 HOME to $sitedir/data. Make sure your config file does this. You can
 add it with a:

     SetEnv HOME /var/www/mysite/data

 Near the other SetEnv lines.

 Also make sure your data directory is owned by the Apache user.

 Christian





 On Monday, June 21, 2010, Martelo martel...@gmail.com wrote:
  I'm trying to add an https SVN repository.
  After click on save, the folowing message is shown...

  A verified HTTPS certificate is required to connect to this
  repository.
  There were errors validating this certificate:
  The certificate is not issued by a trusted authority. Use the
  fingerprint to validate the certificate manually. ...

  ... with the following options: I trust this host and Re edit
  repository.
  So far so good, but when I click on I trust this host, RB enters an
  infinite loop.

  The error message is:

  ERROR - SVN: Failed to get repository information forhttps://myserver/repo:
  OPTIONS of 'https://myserver/repo':Server certificate verification
  failed: issuer is not trusted (https://myserver)

  I'm using RB1.5 beta 2+ Apache 2.2 + Ubuntu...
  I'm able to perform a SVB checkout with both root and www-data
  users... I'm not sure why the certificate is not issued by a trusted
  authority message is still been shown.

  Does anyone have this problem?

  --
  Want to help the Review Board project? Donate today 
  athttp://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to 
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group 
  athttp://groups.google.com/group/reviewboard?hl=en

 --
 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com- Ocultar texto das mensagens anteriores -

 - Mostrar texto das mensagens anteriores -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


installing on ubuntu 10.04

2010-06-22 Thread kgoedert
Hi,

I was trying to install reviewboard on a ubuntu 10.04 using memcached
as suggested. Everything went right until the point of creating the
database. I chose mysql. I get the following output

File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/core/cache/backends/memcached.py, line 19, in module
raise InvalidCacheBackendError(Memcached cache backend requires
either the 'memcache' or 'cmemcache' library)
django.core.cache.backends.base.InvalidCacheBackendError: Memcached
cache backend requires either the 'memcache' or 'cmemcache' library

I'm pretty sure I installed memcached and that it is running.

What should I do to fix this?

Thank you

Kelly

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Unable to submit reviews via post-review after svn switch --relocate

2010-06-22 Thread Edwin Vane
Hi,

We recently moved our svn server (or at least the DNS alias was
changed). Every developer did an svn switch --relocate old_location
new_location. The reviewboard server was updated too so that the new
paths were associated with recognized repositories.

Reviews submitted via the web interface have no problems. However, if
I use post-review I get the following error:

Error creating review request: The repository path specified is not in
the list of known repositories (code 206)

The debug output from post-review is as follows:

 svn info
 repository info: Path: http://new.server.com/path/to/repo, Base path: 
 /trunk, Supports changesets: False
 svn propget reviewboard:url /home/revane/work
 svn diff --diff-cmd=diff
 Looking for 'local.reviewboard.server.com /' cookie in 
 /home/revane/.post-review-cookies.txt
 Loaded valid cookie -- no login required
 Attempting to create review request for None
 HTTP GETting /api/json/repositories/
 HTTP GETting /api/json/repositories/3/info/
 HTTP GETting /api/json/repositories/4/info/
 HTTP GETting /api/json/repositories/5/info/
 HTTP GETting /api/json/repositories/1/info/
 repository info: Path: http://new.server.com/path/to/repo, Base path: 
 /trunk, Supports changesets: False
 HTTP POSTing to 
 http://local.reviewboard.server.com/api/json/reviewrequests/new/: 
 {'repository_path': u'http://new.server.com/path/to/repo'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)

So it appears that the correct repository path is being sent. For some
reason the server is refusing it. Is there a cache in the server
configuration that needs to be wiped? Is JSON stuff cached somewhere
(perhaps even on the client) and this needs to be wiped? Is there more
debug options I can try to help identify the problem? Any help would
be appreciated. I'd love to be using post-review again.

Edwin V

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: installing on ubuntu 10.04

2010-06-22 Thread Stephen Gallagher

On 06/22/2010 08:52 AM, kgoedert wrote:

Hi,

I was trying to install reviewboard on a ubuntu 10.04 using memcached
as suggested. Everything went right until the point of creating the
database. I chose mysql. I get the following output

File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/core/cache/backends/memcached.py, line 19, inmodule
 raise InvalidCacheBackendError(Memcached cache backend requires
either the 'memcache' or 'cmemcache' library)
django.core.cache.backends.base.InvalidCacheBackendError: Memcached
cache backend requires either the 'memcache' or 'cmemcache' library

I'm pretty sure I installed memcached and that it is running.

What should I do to fix this?

Thank you

Kelly

   


In addition to the memcache daemon, you also need the python memcache 
client library.
I'm not sure what they call it on Ubuntu, but on Fedora it would be 
'python-memcache'


--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Issue 1696 in reviewboard: Disallow closing review as submitted without getting Ship it

2010-06-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1696 by hadru...@gmail.com: Disallow closing review as submitted  
without getting Ship it

http://code.google.com/p/reviewboard/issues/detail?id=1696

If closing as submitted was blocked before the review gets any ship it!,  
it would be easier not to overlook unresolved issues.


possible issues:
- review may need a ship it from more than one person
- review may get ship it only for the part of the code

Anyway, I feel, that not closing review as submitted should not take place  
before the changes get at least one ship it.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1697 in reviewboard: tok tori

2010-06-22 Thread reviewboard

Updates:
Status: Invalid

Comment #1 on issue 1697 by chipx86: tok tori
http://code.google.com/p/reviewboard/issues/detail?id=1697

You're on the wrong issue tracker. This is for the Review Board project.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1698 in reviewboard: REview BORAD SCIUKs

2010-06-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1698 by allang: REview BORAD SCIUKs
http://code.google.com/p/reviewboard/issues/detail?id=1698

*NOTE: Do not post confidential information in this bug report.*

What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1698 in reviewboard: REview BORAD SCIUKs

2010-06-22 Thread reviewboard


Comment #3 on issue 1698 by chipx86: REview BORAD SCIUKs
http://code.google.com/p/reviewboard/issues/detail?id=1698

Now we're all http://i.imgur.com/uGTKb.jpg

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1698 in reviewboard: REview BORAD SCIUKs

2010-06-22 Thread reviewboard


Comment #5 on issue 1698 by carmiendo: REview BORAD SCIUKs
http://code.google.com/p/reviewboard/issues/detail?id=1698

Who's your employer?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1698 in reviewboard: REview BORAD SCIUKs

2010-06-22 Thread reviewboard


Comment #7 on issue 1698 by russell.bryant: REview BORAD SCIUKs
http://code.google.com/p/reviewboard/issues/detail?id=1698

I could really use someone on my team with this kind of spelling ability  
and clue about how the internet works.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1698 in reviewboard: REview BORAD SCIUKs

2010-06-22 Thread reviewboard


Comment #9 on issue 1698 by russell.bryant: REview BORAD SCIUKs
http://code.google.com/p/reviewboard/issues/detail?id=1698

resu...@foxnews.com

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.