GUI tests on reviewboard

2013-06-14 Thread Varun Jain
Hi All, If I take xpath via firebug compares the xpath of same element taken via chrome both are different. Which one should be preferred?? Also, In GUI automation I am facing time.sleep errors too much. Is there any way to get rid of it??? Is it required to install selenium web driver

Extending the Review Workflow

2013-06-14 Thread winston . mike
I have just setup my first instance of ReviewBoard and use JIRA to track my bugs/work. ReviewBoard gives me a basic way to link my review back to the JIRA ticket through the Custom Bug Tracker feature. But I also want to link my JIRA ticket to my set of Reviews for that ticket. JIRA gives me

Re: GUI tests on reviewboard

2013-06-14 Thread David Trowbridge
What exactly are you trying to do? -David On Fri, Jun 14, 2013 at 3:30 AM, Varun Jain varun.iam.j...@gmail.comwrote: Hi All, If I take xpath via firebug compares the xpath of same element taken via chrome both are different. Which one should be preferred?? Also, In GUI automation I am

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Steve
I'd like to back up and break this down into smaller, simpler questions. When I go to my 1.6.9 RB server and browse to another user's review, I see these buttons along the top, right portion of the page: Download DiffReviewShip It!View Diff When I go to both of my 1.7.6

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Christian Hammond
Hi Steve, Are you set up as an admin on both servers? Or do you have the Can Close privilege set? If so, 1.7.x should behave the same as it did in 1.6.x (and certainly does in our installs). Christian On Jun 14, 2013, at 14:04, Steve seide.al...@gmail.com wrote: I'd like to back up and

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Steve
I do not have staff or superuser set for this account, nor any special mod permissions. And everyone here also sees the same 'Close' button on other people's reviews. So, something is configured. I wonder if there's an old database setting that we've been pulling along since the 1.0.x, 1.5

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Christian Hammond
Hi Steve, There's no special flag for this. We implemented this functionality pre-1.0 and it has never changed. The only way you ever see Close or Update is when you have superuser privileges or the Can Edit/Can Close privileges. I'm not aware of this ever regressing or changing throughout the

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Steve
I just went to a friend's desk and verified he sees the 'Close' button on other people's reviews. Here are his user settings in the DB: id: 7 username: xx first_name: xx last_name: xx email: x password: x is_staff: 0 is_active: 1

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Christian Hammond
It's auth_user_user_permissions, which will map user IDs to IDs in auth_permissions. Alternatively, you can do: $ rb-site manage /path/to/site shell from django.contrib.auth.models import User u = User.objects.get(username='youruser') u.is_superuser u.is_staff

Re: Reviews are being mysteriously marked as submitted

2013-06-14 Thread Steve
Thanks for the example - I keep forgetting about rb-site shell. It's nifty. Here's what I get: # rb-site manage /var/www/reviewboard shell Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23) [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2 Type help, copyright, credits or license for more

Re: Extending the Review Workflow

2013-06-14 Thread David Trowbridge
Winston, Doing this as an extension is definitely the way to go. There are django signals that your extension code can listen to. Take a look at reviewboard/reviews/signals.py for the things you'd want to listen to, and then your code can attach to those and do whatever you need. -David On

Re: Issue 2988 in reviewboard: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please repor

2013-06-14 Thread reviewboard
Comment #1 on issue 2988 by asa...@gmail.com: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator

Re: Issue 3006 in reviewboard: When creating new site entered password isn't checked for match

2013-06-14 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 3006 by chip...@gmail.com: When creating new site entered password isn't checked for match http://code.google.com/p/reviewboard/issues/detail?id=3006 Sorry, to clarify, are we talking database passwords? -- You received this message

Re: Issue 3001 in reviewboard: Session cookies are stored imporperly

2013-06-14 Thread reviewboard
Updates: Status: ThirdParty Comment #3 on issue 3001 by chip...@gmail.com: Session cookies are stored imporperly http://code.google.com/p/reviewboard/issues/detail?id=3001 All session management is handled by Django. Short of duplicating all their work and rewriting it, there's not

Issue 3007 in reviewboard: Mechanism to customize email messages

2013-06-14 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3007 by vlov...@gmail.com: Mechanism to customize email messages http://code.google.com/p/reviewboard/issues/detail?id=3007 It would be nice to have a mechanism to customize the e-mail format with templates that get filled

Issue 3008 in reviewboard: Customize e-mail behaviour via RBTools

2013-06-14 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3008 by vlov...@gmail.com: Customize e-mail behaviour via RBTools http://code.google.com/p/reviewboard/issues/detail?id=3008 What version are you running? 1.7.9 Describe the enhancement and the motivation for it. It