Re: Loading Diffs takes a lot of time, and sometimes proxyerror

2014-05-27 Thread Nicolas Comet
Yes, the svn server is local.

Another test I made is even more strange : by changing the user to access 
the SVN server to my user, for the same file, and same request, it takes 
2,5s (still a bit slow, but definitely faster than the other user).

I can't understand why it happens. Why on Earth would changing the SVN user 
to fetch files change the time so drastically? I tried to ask the 
sysadmins, but they could not come with a satisfying answer... I thought 
about user rights, repository access.


Le vendredi 23 mai 2014 21:39:29 UTC+2, Christian Hammond a écrit :

 Is the server local to your network?

 This is definitely a lot longer than I would expect. 63 seconds is a bit 
 crazy... svn+ssh is not inherently that slow.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Fri, May 23, 2014 at 2:26 AM, Nicolas Comet 
 nicola...@gmail.comjavascript:
  wrote:

 Hello again,

 We have a problem of timeouts when trying to visualize the diff via the 
 View Diff button. Sometimes it loads, after a lot of times, sometimes it 
 displays a proxyerror.

 Anyway in the logs we find for every user trying to display diffs this 
 critical error in reviewboard.log :

 # 2014-05-23 09:00:46,434 - CRITICAL - None - n.comet - 
 /r/1/fragments/diff-comments/2/ - Fetching file 
 'TemplateEngine/trunk/template-api/src/main/java/com/*/common/template/api/TemplateContext.java'
  
 r173756 from PLMPlatform took 63.261421 seconds

 Does it come from svn+ssh access slowness? I suppose so.

 Thank you !

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default Reviewers not working

2014-05-27 Thread Nicolas Comet
I hope it will help people having the same problem :

The only way I got default reviewers (groups or people) working was by 
removing the first / character at the beginning of the regexp field.

If your repository is svn://urltorepo/Repository/ModuleOrProject

You want to type in the field : *trunk/.**, *branch/.** or *tag/.**

*Do not add a leading / !*



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


css/js ... static files cannot find (404) after upgraded 1.7.20 to 2.01

2014-05-27 Thread Sam Ku
Hi everyone,

I used $easy_install -U ReviewBoard command to upgrade reviewboard and 
then $ rb-site upgrade /path/to/site to upgrade the site. Everything was 
fine.
Then I restarted lighttpd and tried to browse the the website.

It only shows the plain text in main page and doesn't get any css/js files. 
I found all response codes are 404.

And I tried to use the URL : http://XXX/static/; and I got this error.

Page not found (404)  Request Method: GET  Request URL: http://XXX/static/  
 
Using the URLconf defined in djblets.urls.root, Django tried these URL 
patterns, in this order: 

   1. ^ ^admin/extensions/ 
   2. ^ ^admin/ 
   3. ^ ^jsi18n/ [name='js-catalog'] 
   4. ^ ^account/ 
   5. ^ ^s/(?Plocal_site_name[A-Za-z0-9\-_.]+)/ 
   6. ^ ^$ [name='root'] 
   7. ^ ^api/ 
   8. ^ ^r/ 
   9. ^ ^support/$ [name='support'] 
   10. ^ ^users/(?Pusername[A-Za-z0-9@_\-\.'\+]+)/infobox/$ 
   [name='user-infobox'] 
   11. ^ ^r/$ [name='all-review-requests'] 
   12. ^ ^dashboard/$ [name='dashboard'] 
   13. ^ ^users/$ [name='all-users'] 
   14. ^ ^users/(?Pusername[A-Za-z0-9@_\-\.'\+]+)/$ [name='user'] 
   15. ^ ^groups/$ [name='all-groups'] 
   16. ^ ^groups/(?Pname[A-Za-z0-9_-]+)/$ [name='group'] 
   17. ^ ^groups/(?Pname[A-Za-z0-9_-]+)/members/$ [name='group-members'] 
   18. ^ ^repos/(?Prepo_id\d+)/ 

The current URL, static/, didn't match any of these.

My OS is CentOS 6.0. 

web server: lighttpd/1.4.28

python 2.6.5

Does anyone know how I could fix it? 

Many thanks.

Best,

Sam Ku


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: css/js ... static files cannot find (404) after upgraded 1.7.20 to 2.01

2014-05-27 Thread Christian Hammond
You need to turn DEBUG off in settings_local.py. That's only intended for
developer installs, and will cause problems with loading static media on a
production install.

DEBUG Is False by default, but it sounds like it was enabled by hand at
some point in your install.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Tue, May 27, 2014 at 7:19 AM, Sam Ku yenchi...@gmail.com wrote:

 Hi everyone,

 I used $easy_install -U ReviewBoard command to upgrade reviewboard and
 then $ rb-site upgrade /path/to/site to upgrade the site. Everything was
 fine.
 Then I restarted lighttpd and tried to browse the the website.

 It only shows the plain text in main page and doesn't get any css/js
 files. I found all response codes are 404.

 And I tried to use the URL : http://XXX/static/; and I got this error.

 Page not found (404)  Request Method: GET  Request URL: http://XXX/static/

 Using the URLconf defined in djblets.urls.root, Django tried these URL
 patterns, in this order:

1. ^ ^admin/extensions/
2. ^ ^admin/
3. ^ ^jsi18n/ [name='js-catalog']
4. ^ ^account/
5. ^ ^s/(?Plocal_site_name[A-Za-z0-9\-_.]+)/
6. ^ ^$ [name='root']
7. ^ ^api/
8. ^ ^r/
9. ^ ^support/$ [name='support']
10. ^ ^users/(?Pusername[A-Za-z0-9@_\-\.'\+]+)/infobox/$
[name='user-infobox']
11. ^ ^r/$ [name='all-review-requests']
12. ^ ^dashboard/$ [name='dashboard']
13. ^ ^users/$ [name='all-users']
14. ^ ^users/(?Pusername[A-Za-z0-9@_\-\.'\+]+)/$ [name='user']
15. ^ ^groups/$ [name='all-groups']
16. ^ ^groups/(?Pname[A-Za-z0-9_-]+)/$ [name='group']
17. ^ ^groups/(?Pname[A-Za-z0-9_-]+)/members/$
[name='group-members']
18. ^ ^repos/(?Prepo_id\d+)/

 The current URL, static/, didn't match any of these.

 My OS is CentOS 6.0.

 web server: lighttpd/1.4.28

 python 2.6.5

 Does anyone know how I could fix it?

 Many thanks.

 Best,

 Sam Ku


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


How to configure the search properly

2014-05-27 Thread Christian Wuerdig
Hi,

We always had trouble with the search largely due to this bug: 
https://code.google.com/p/reviewboard/issues/detail?id=2544

Now with 2.0 I tried the search again and it worked a little bit better - 
instead of coming up with an error 500 I always got No results

So I figured maybe I need to rebuild the index which I did with sudo 
rb-site manage /var/www/codereview/ rebuild_index

It warned me that it will delete all indices and then claimed Indexing 1 
review request - hm, we have about 11,000+ review requests in the system 
so that is a bit weird
Also the search is now broken - I'm getting a server error 500 again and 
the stack trace points to:

IOError: The path to your Whoosh index '/var/www/codereview/index' is not 
 writable for the current user/group.

Typing something into the search box will yield perfectly good results 
after a little while in the drop down (as long as what I'm looking for is 
part of the Summary) just hitting enter on the search box won't work 
properly.

So my questions are:

1. How do I properly configure the search - mainly which user should own 
the index? Apparently not root because that's what it is now and that's not 
working.

2. How can I track down the indexing problem (in the sense that it claims 
it can only index 1 request)?


Cheers
Christian

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Multiple Warnings and strange behaviour on RB2.0

2014-05-27 Thread MoonWalker
I renable Debug mode, because we are experiencing some strange behavior on 
some reviews, when we try to update some reviews. Seems like when the 
developers submit publish the nothing happens and the new review does not 
get published. 

I have the following warring and this may or may not explain such behavior 
or any other potential issue.

23:00:49WARNING

 - Cache data for key 
codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
 (length 1706544) may be too big for the cache.

01:45:59WARNING

 - 
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
 RuntimeWarning: DateTimeField User.last_login received a naive datetime 
(2014-05-21 00:00:00) while time zone support is active.
  RuntimeWarning)

1:46:00WARNING

 - 
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
 DeprecationWarning: Using mimetype keyword argument is deprecated, use 
content_type instead
  super(HttpResponse, self).__init__(*args, **kwargs)


Is there any way to increase the level of verbosity, so far the only change 
that I made is enable DEBUG = True on settings_local.py

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-05-27 Thread MoonWalker
My mistake the version that we are using is 2.0.1

On Wednesday, May 28, 2014 12:19:57 PM UTC+10, MoonWalker wrote:

 I renable Debug mode, because we are experiencing some strange behavior on 
 some reviews, when we try to update some reviews. Seems like when the 
 developers submit publish the nothing happens and the new review does not 
 get published. 

 I have the following warring and this may or may not explain such behavior 
 or any other potential issue.

 23:00:49WARNING

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

 01:45:59WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

 1:46:00WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only 
 change that I made is enable DEBUG = True on settings_local.py



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-05-27 Thread Christian Hammond
Hi,

Those are completely harmless and unrelated.

Are you using any extensions? ReviewBot perhaps?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.cabrera...@gmail.comwrote:

 I renable Debug mode, because we are experiencing some strange behavior on
 some reviews, when we try to update some reviews. Seems like when the
 developers submit publish the nothing happens and the new review does not
 get published.

 I have the following warring and this may or may not explain such behavior
 or any other potential issue.

  23:00:49WARNING

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only
 change that I made is enable DEBUG = True on settings_local.py

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-05-27 Thread MoonWalker
No, we are using tortoisesvn to generate an unified diffs. We are using SVN 
only

On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker 
 daniel.c...@gmail.comjavascript:
  wrote:

 I renable Debug mode, because we are experiencing some strange behavior 
 on some reviews, when we try to update some reviews. Seems like when the 
 developers submit publish the nothing happens and the new review does not 
 get published. 

 I have the following warring and this may or may not explain such 
 behavior or any other potential issue.

  23:00:49WARNING 

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only 
 change that I made is enable DEBUG = True on settings_local.py

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to apply review code on local machine

2014-05-27 Thread shankar KC
Thanks David. It was really a quick fix. reviewboard team ROCKS.

On Saturday, May 24, 2014 1:06:28 AM UTC+5:30, David Trowbridge wrote:

 It should be fixed as of commit 09ee08e in rbtools git.

 -David


 On Thu, May 22, 2014 at 9:58 PM, shankar KC shank...@gmail.comjavascript:
  wrote:

 I raised a bug and its resoled as fixed. Fixed version is  0.6.x. Is this 
 version available for download. I downloaded the latest version from GIT 
 repo but it doesnt contain fix for this issue.
 https://code.google.com/p/reviewboard/issues/detail?id=3365 


 On Thursday, May 22, 2014 9:49:40 AM UTC+5:30, shankar KC wrote:

 These are the args that are passed to the method. I got them using print 
 statement.
 diff_file_path:- c:\users\shanka~1\appdata\local\temp\tmpzusqly, 
 repository_info.base_path :- None, 
 base_dir :- ,
 self.options.px :- None.

 It looked like its failing bcz base_dir empty and 
 repository_info.base_path :- None
 On Thursday, May 22, 2014 8:40:49 AM UTC+5:30, shankar KC wrote:

 Sure I will open a bug
 thx
 shankar

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3368 in reviewboard: Security Checker failing?

2014-05-27 Thread reviewboard


Comment #4 on issue 3368 by dangerpe...@gmail.com: Security Checker failing?
http://code.google.com/p/reviewboard/issues/detail?id=3368

(No comment was entered for this change.)

Attachments:
screenshot.png  104 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3385 in reviewboard: Error 500 while trying to login when two url point to the same site

2014-05-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3385 by pvals...@gmail.com: Error 500 while trying to login when  
two url point to the same site

http://code.google.com/p/reviewboard/issues/detail?id=3385

What version are you running?
2.0.1

What's the URL of the page containing the problem?
/account/login/

What steps will reproduce the problem?
1. Have an apache configuration that have two NamedVirtualHost pointing to  
exactly the same review board install
2. Configure, in general, one of the two hostname in the server field  
(for example: https://ipsla.cisco.com)

3. Test a logout/login with the two hostnames.

What is the expected output? What do you see instead?
I expect a normal login for both, but, instead, one of them gives me an  
error 500.



What operating system are you using? What browser?
Ubuntu 14.04, Chrome.

Please provide any additional information below.
I'm attaching my apache config.

Apache error log:
  Traceback (most recent call last):
  File /usr/lib/python2.7/logging/__init__.py, line 851, in emit
  msg = self.format(record)
  File /usr/lib/python2.7/logging/__init__.py, line 724, in format
  return fmt.format(record)
  File /usr/lib/python2.7/logging/__init__.py, line 467, in format
  s = self._fmt % record.__dict__
  KeyError: u'request_info'
  Logged from file response.py, line 111

The email I received from buildbot:
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/handlers/base.py,  
line 118, in get_response

response = middleware_method(request, e)
   
File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/log/middleware.py,  
line 245, in process_exception

exception, exc_info=1)
  File /usr/lib/python2.7/logging/__init__.py, line 1586, in error
root.error(msg, *args, **kwargs)
  File /usr/lib/python2.7/logging/__init__.py, line 1176, in error
self._log(ERROR, msg, args, **kwargs)
   
File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/log/__init__.py,  
line 116, in _log_with_request

old_log(self, *args, **kwargs)
  File /usr/lib/python2.7/logging/__init__.py, line 1269, in _log
self.handle(record)
  File /usr/lib/python2.7/logging/__init__.py, line 1279, in handle
self.callHandlers(record)
  File /usr/lib/python2.7/logging/__init__.py, line 1319, in callHandlers
hdlr.handle(record)
  File /usr/lib/python2.7/logging/__init__.py, line 749, in handle
self.emit(record)
  File /usr/lib/python2.7/logging/handlers.py, line 424, in emit
self.stream.flush()
  ValueError: I/O operation on closed file

The temporary fix I did:
Edit  
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/log/middleware.py  
and comment out the implementation of LoggingMiddleware.process_exception



Attachments:
apache.conf  999 bytes
reviewboard.inc  1.6 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3385 in reviewboard: Error 500 while trying to login when two url point to the same site

2014-05-27 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3385 by chip...@gmail.com: Error 500 while trying to  
login when two url point to the same site

http://code.google.com/p/reviewboard/issues/detail?id=3385

Why are there two virtualhosts pointing to the same install?

I'm afraid it's really not a supported use case. Can you simply have one  
redirect to the other?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3165 in reviewboard: Configurable subject of notification mails sent from Review Board

2014-05-27 Thread reviewboard


Comment #2 on issue 3165 by campbe...@gmail.com: Configurable subject of  
notification mails sent from Review Board

http://code.google.com/p/reviewboard/issues/detail?id=3165

I'm also looking for something like this, but for a slightly different  
reason (I already use the X-ReviewRequest headers for filtering in email).


Where I work we use a web forum as our 'mailing list', and the subject is  
used to determine which sub-forum/topic the email should go to.


So in my case it would be nice to be able to have a custom subject  
(or 'tag') for each 'review group'.


I'm willing to work on this if it's something that would be accepted.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3385 in reviewboard: Error 500 while trying to login when two url point to the same site

2014-05-27 Thread reviewboard


Comment #2 on issue 3385 by chip...@gmail.com: Error 500 while trying to  
login when two url point to the same site

http://code.google.com/p/reviewboard/issues/detail?id=3385

Going into this more...

When you have two VirtualHosts using mod_wsgi and the same wsgi script,  
you're going to have issues. You need to section them both off to make use  
of directives like WSGIProcessGroup, WSGIApplicationGroup, etc. That's a  
bigger topic though.


On top of that, Review Board expects to have one single domain that it can  
identify itself as, for use in e-mails, the API, etc.


You'll need to have one of these domains redirect to the other, or have two  
separate installs/databases.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3368 in reviewboard: Security Checker failing?

2014-05-27 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com
Labels: Component-Admin

Comment #5 on issue 3368 by trowb...@gmail.com: Security Checker failing?
http://code.google.com/p/reviewboard/issues/detail?id=3368

Thanks! I have enough info now to see what's going wrong. We'll get a fix  
in for 2.0.2.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3368 in reviewboard: Security Checker failing?

2014-05-27 Thread reviewboard

Updates:
Status: Fixed

Comment #6 on issue 3368 by trowb...@gmail.com: Security Checker failing?
http://code.google.com/p/reviewboard/issues/detail?id=3368

Fixed in release-2.0.x (c458ae9). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3385 in reviewboard: Error 500 while trying to login when two url point to the same site

2014-05-27 Thread reviewboard


Comment #3 on issue 3385 by pvals...@gmail.com: Error 500 while trying to  
login when two url point to the same site

http://code.google.com/p/reviewboard/issues/detail?id=3385

I didn't know WSGI doesn't like this kind of setup. Mea culpa.

OK, I'll change my config and put a redirect from one hostname to the  
other. Not as clean, but let's avoid trouble.

You can close the defect.

Thanks for the help.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3386 in reviewboard: Comments on PNG images don't show the image.

2014-05-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3386 by pvals...@gmail.com: Comments on PNG images don't show the  
image.

http://code.google.com/p/reviewboard/issues/detail?id=3386

What version are you running?
2.0.1

What's the URL of the page containing the problem?
/r/323/

What steps will reproduce the problem?
1. Create a review with a PNG screenshot attached
2. Click on the review tag for that PNG
3. Select an area and type a comment
4. Submit your review
5. look at the reviews

What is the expected output? What do you see instead?
I guess that I should see the selected portion of the image in the review,  
but I just see an empty box that has the same size as my selected area with  
the ALT message.

The HTML shows that:
img class=modified-image src= width=880 height=207 alt=Don't you  
want to hide them if they are skipped?


See the empty src?

I've put the screenshot in attachment.

By the way, is it not supposed to show the image thumbnail in the top area  
of my screenshot? This HTML area looks weird as well:
a href=/r/323/file/4/ class=file-thumbnail-overlay alt=Click to  
review title=Click to review /a
img src= data-at2x= class=file-thumbnail alt=Screen Shot 2014-05-27  
at 20.28.55.png



What operating system are you using? What browser?
Ubuntu 14.04 with Chrome 35.0.1916.114

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3386 in reviewboard: Comments on PNG images don't show the image.

2014-05-27 Thread reviewboard


Comment #1 on issue 3386 by pvals...@gmail.com: Comments on PNG images  
don't show the image.

http://code.google.com/p/reviewboard/issues/detail?id=3386

Argh, forgot the attachment.

Attachments:
bugCommentOnImage.png  115 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.