Git style mercurial diffs with file renames don't work
Hi, We have a problem where the diff viewer for diffs with rename operations. We use mercurial, and output the diff in git style. Here's a trivial example diff file: diff --git a/include/CCvideo/configUI.H b/include/CCvideo/configUITest.H rename from include/CCvideo/configUI.H rename to include/CCvideo/configUITest.H In the Diff summary section is: include/CCvideo/configUITest.H http://reviewboard.cctechnol.com/r/4112/diff/#0 Was include/CCvideo/configUI.H So I guess the rename works up to a point, but this is the error in the view diff page: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://reviewboard.cctechnol.com/support/. With traceback as follows: Traceback (most recent call last): File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/reviews/views.py, line 1088, in create_renderer *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 328, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 369, in _get_requested_diff_file request=self.request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 383, in populate_diff_chunks chunks = generator.get_chunks() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 153, in get_chunks large_data=True) File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 152, in lambda lambda: list(self._get_chunks_uncached()), File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 159, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 169, in get_original_file request=request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 291, in get_file large_data=True)[0] File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 290, in lambda request)], File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 456, in _get_file_uncached data = self.get_scmtool().get_file(path, revision) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 43, in get_file return self.client.cat_file(path, six.text_type(revision)) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 264, in cat_file raise FileNotFoundError(path, rev) FileNotFoundError: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OS Error 2
We have included line SetEnv PATH /usr/atria/bin:$PATH in httpd.conf file (path where cleartool resides). But we are still not able to get it working. Any other place we can look at? We are still unable to root cause the issue. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Is ReviewBot working with ReviewBoard 2.0?
We're currently using ReviewBoard 1.7.14 with the ReviewBot 0.1 (cppunit and python extensions) and we're considering moving to ReviewBoard 2.0. Anybody have experience, good or bad, with ReviewBoard 2.0 working with ReviewBot? Thanks -- -- Steve -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.7 is released!
On 09/15/2014 01:00 PM, Christian Hammond wrote: Hey everyone, Review Board 2.0.7 is out, with over 30 bug fixes, better support for per-repository incoming webhooks, improved usability, and more. This is a big release that should solve a lot of the issues that have been reported here since 2.0.6. It also introduces big changes to the incoming webhook support for repositories that we introduced in 2.0, which are used to auto-close review requests when their corresponding commits have been pushed to the repository. If you use this, make sure you read the news post and release notes for upgrade instructions. See https://www.reviewboard.org/news/2014/09/15/review-board-2-0-7-released/ for more information. Fedora 21+ and EPEL 7 packages have been submitted and will be in the updates-testing mirrors within 48 hours. Please try them out and let me know if there are any issues. https://admin.fedoraproject.org/updates/search/ReviewBoard -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
New Review Request shows no commits for Git repository
I have set up Review Board as suggested, created an SSH-key, added the public key to Gitolite and finally added my repository to Review Board. However, when I want to create a new review request and select my repository, there is no selection for a previous commit. I have pushed a few new commits, but these are not displayed as well. I've tried it for different repositories and even granted Review Board full access in Gitolite. https://lh3.googleusercontent.com/-M_-TQ9kOpHg/VBhXMl3AIII/AqU/Fa5oTBgNLF4/s1600/reviewboard.png -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: New Review Request shows no commits for Git repository
Hi, The post-commit UI is currently only available for GitHub and SVN repositories. Support for additional repositories will be coming in future releases. -David On Sep 16, 2014, at 8:29 AM, Wolfgang Magerl wolfgang.mag...@gmail.com wrote: I have set up Review Board as suggested, created an SSH-key, added the public key to Gitolite and finally added my repository to Review Board. However, when I want to create a new review request and select my repository, there is no selection for a previous commit. I have pushed a few new commits, but these are not displayed as well. I've tried it for different repositories and even granted Review Board full access in Gitolite. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OS Error 2
Depending on the version of apache that you're running, SetEnv may not be able to set PATH (note that even if you are running 2.4, it doesn't support using $PATH in the value--you'd have to list all of the path entries explicitly). Some linux distribution contain a file such as /etc/apache/envvars which can be used to set the PATH. Alternatively, you could create a symbolic link to cleartool in /usr/bin or another accessible location. -David On Tue, Sep 16, 2014 at 6:51 AM, shravanthi s shrav...@gmail.com wrote: We have included line SetEnv PATH /usr/atria/bin:$PATH in httpd.conf file (path where cleartool resides). But we are still not able to get it working. Any other place we can look at? We are still unable to root cause the issue. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Is ReviewBot working with ReviewBoard 2.0?
Steve, ReviewBot does work well with Review Board 2.0. I'd suggest moving to at least the release-0.2.x branch. -David On Tue, Sep 16, 2014 at 8:34 AM, Steve seide.al...@gmail.com wrote: We're currently using ReviewBoard 1.7.14 with the ReviewBot 0.1 (cppunit and python extensions) and we're considering moving to ReviewBoard 2.0. Anybody have experience, good or bad, with ReviewBoard 2.0 working with ReviewBot? Thanks -- -- Steve -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3571 in reviewboard: some rbtools error in windows 7 64 chinese system.
Updates: Status: NeedInfo Comment #1 on issue 3571 by trowb...@gmail.com: some rbtools error in windows 7 64 chinese system. https://code.google.com/p/reviewboard/issues/detail?id=3571 Can you look in the review board server log (or have your administrator do so) and find the traceback there? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3571 in reviewboard: some rbtools error in windows 7 64 chinese system.
Comment #2 on issue 3571 by feixin...@gmail.com: some rbtools error in windows 7 64 chinese system. https://code.google.com/p/reviewboard/issues/detail?id=3571 thanks for reply. The server log is the same as client log. When i check Review Board, i found that gb2312 is in ADVANCED SETTINGS's Encoding. and i delete it in Encoding, the error is not appear again. I guess that is the reson. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3571 in reviewboard: some rbtools error in windows 7 64 chinese system.
Comment #3 on issue 3571 by trowb...@gmail.com: some rbtools error in windows 7 64 chinese system. https://code.google.com/p/reviewboard/issues/detail?id=3571 The server log may have the same invalid multibyte sequence error but the traceback will be different. We'd like to have that traceback so we can make it not fail. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3572 in reviewboard: review board escape % to %25, and server said file is not found.
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3572 by feixin...@gmail.com: review board escape % to %25, and
server said file is not found.
https://code.google.com/p/reviewboard/issues/detail?id=3572
What version are you running?
ReviewBoard 2.0.7 / RBTools 0.6.2
Server:Centos
Client:windows 7 64 chinese system
What's the URL of the page containing the problem?
Not applicable as it's a RBTools issue.
client command:
rbt post -d --diff-filename E:\我的svn\我的地址\我的diff文件.txt.patch
some chinese character in diff file path.
What steps will reproduce the problem?
1. post a new diff file to reviweboard,and get some errors
2. See RBTools log
client log is :
RBTools 0.6.2
Python 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit
(Intel)]
Running on Windows-7-6.1.7601-SP1
Current directory = E:\xx
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
Making HTTP GET request to http://192.168.100.8/api/
Making HTTP GET request to http://192.168.100.8/api/review-requests/
Making HTTP POST request to http://192.168.100.80/api/review-requests/
Making HTTP GET request to
http://192.168.100.8/api/review-requests/28/diffs
/
Making HTTP POST request to
http://192.168.100.8/api/review-requests/28/diff
s/
Got API Error 207 (HTTP code 400): The file was not found in the
repository.
Error data: {u'stat': u'fail', u'file': u'/PUBLIC/%xx%xx%xx%xx%xx',
u'err': {u'msg': u'The file was n
ot found in the repository.', u'code': 207}, u'revision': u'702'}
Traceback (most recent call last):
File C:\Python26\Scripts\rbt-script.py, line 9, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
File C:\Python26\lib\site-packages\rbtools-0.6.2-py2.6.egg\rbtools\commands\m
ain.py, line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File C:\Python26\lib\site-packages\rbtools-0.6.2-py2.6.egg\rbtools\commands\_
_init__.py, line 416, in run_from_argv
exit_code = self.main(*args) or 0
File C:\Python26\lib\site-packages\rbtools-0.6.2-py2.6.egg\rbtools\commands\p
ost.py, line 783, in main
submit_as=self.options.submit_as)
File C:\Python26\lib\site-packages\rbtools-0.6.2-py2.6.egg\rbtools\commands\p
ost.py, line 550, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
The file was not found in the repository. (HTTP 400, API Error 207)
Your review request still exists, but the diff is not attached.
Svn Server http log is:
192.168.100.8 - username [16/Sep/2014:15:49:40 +0800] PROPFIND
/svn/mysvn/!svn/bc/702/PUBLIC/%25xx%25xx%25xx%25xx%25xx%25xx HTTP/1.1 404
369 - SVN/1.6.11 (r934486) neon/0.29.3
Operating system: Windows 7-64 chinese system
Browsers: Internet Explorer 8 / Google Chrome
python version: python2.6.6 utf-8
Hello,
My repo conf in reviewboard admin is
http://username:passw...@www.mysite.com/svn/mysvn/
When i rbt post diff file, the client log is
/PUBLIC/%xx%xx%xx%xx%xx%xx%xx%xx%xx%xx%xx%xx/mysql\u\u\uf\u.txt
Svn server's http log is
PUBLIC/%25xx%25xx%25xx%25xx%25xx%25xx%25xx%25xx%25xx%25xx%25xx%25xx/mysql%EF%BF%BDxxx.txt
I guess reviewboard escape % to %25, so the server said can't find file.
Thanks and Best regards.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3571 in reviewboard: some rbtools error in windows 7 64 chinese system.
Comment #4 on issue 3571 by feixin...@gmail.com: some rbtools error in windows 7 64 chinese system. https://code.google.com/p/reviewboard/issues/detail?id=3571 Yes, i want to give some help, but i can't reproduce the problem... -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
