FYI, in SVN revision r1573, I've committed the patch from
http://reviews.review-board.org/r/634/
This generalizes the LDAP authentication scheme to work better with
OpenLDAP. If you're using LDAP authentication, you'll have to update
your settings:
Your "User Mask" currently looks something like
Are you uploading one diff for each separate change to a review request, or
are you uploading diffs containing just the new changes requested for each
iteration?
The idea is that one review request maps to one diff. Each diff you upload
is just another iteration on that diff, but one that consists
Hi Maximillian.
This is, of course, the whole point of code review and the point of the
project.
Your change is a welcome one and we want it in, but there are things about
it that I'm not comfortable with yet. I proposed another potential solution
based on other work we've done that should both s
Sorry if the word "baseline" is confusing--now it seems like it's the
wrong word to use.
What I mean is that I'd like to see the cumulative effect of all
diffs, because as I mentioned in the example workflow, it's necessary
and important at the end of the iterations to ignore the intermediate
dif
Dear Christian,
first of: I'm thankful for you to publish and maintain rewiewboard.
I'm also aware that I might have chosen the wrong channel to submit my
bug report. Finally I also see that you want to spread the practice of
code reviews.
Still my experience with the bug reporting process in qu
