Re: Djblets in source tree
On Mon, Apr 20, 2009 at 2:43 PM, Eric Huss wrote: > > r1917 made a change to setup.py to require Djblets 0.5beta2.dev_20090420. > The downloads URL only seems to have an egg for 2.4. If you run "setup.py > install", it will complain since it can't find (in my case) a 2.5 egg. Looks like the build broke for 2.5 only last night, hence the lack of eggs. I'll get this fixed for tonight's build. > > 1. Are you planning to publish eggs for 2.4 and 2.5 in the future? Yep, definitely. We'll be continuing to distribute 2.4 and 2.5 eggs for the forseeable future (and 2.6 eventually, once I get another buildbot instance going somewhere). > 2. Is there some way to tell setup.py to use the version that gets checked > out by the svn externals link? If you're using setup.py in one, you should use it in the other, and not rely on svn:externals. To build your own nightly, you can run: sudo python setup.py install nightly This will tag the version with the date stamp. 3. I'm curious, in the course of development, do you use "setup.py > develop" to get reviewboard into your path? How do you get djblets into > your python path? Or do you set PYTHONPATH manually? I actually use Git-SVN for development and use a symlink to a checked out Djblets, rather than svn:externals. But the prinicipal is the same. I don't rely on installing eggs unless there's something I explicitly need to test. > I guess what I'm asking is why djblets and django_evolution are svn > externals, but the setuptools method of installation doesn't jive with > that. Djblets won't be an svn:external much longer, nor will django_evolution. Now that people aren't running directly out of an SVN checkout anymore (or shouldn't be) there's little reason to continue with this route. I would say for developers, either just develop out of the tree, use devserver.sh for testing, and use symlinks/svn:externals for the dependencies, -or- use eggs and install with the "install nightly" alias or "develop" (not sure if you need to do "develop nightly" -- I honestly don't use develop for this). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Djblets in source tree
r1917 made a change to setup.py to require Djblets 0.5beta2.dev_20090420. The downloads URL only seems to have an egg for 2.4. If you run "setup.py install", it will complain since it can't find (in my case) a 2.5 egg. 1. Are you planning to publish eggs for 2.4 and 2.5 in the future? 2. Is there some way to tell setup.py to use the version that gets checked out by the svn externals link? 3. I'm curious, in the course of development, do you use "setup.py develop" to get reviewboard into your path? How do you get djblets into your python path? Or do you set PYTHONPATH manually? I guess what I'm asking is why djblets and django_evolution are svn externals, but the setuptools method of installation doesn't jive with that. -Eric --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review : Review a single existing file in repository
Hi Nicholas, post-review is indeed the right tool to use for most things. You can review existing files by passing the filenames to post-review, OR you can specify a revision range. It doesn't support both (though we'd accept patches for this, which probably would be easy -- just modify SVNClient.diff_between_revisions to append the value of args to the do_diff argument list). If your goal to start with is to put whole existing files up for review, you'd want to use a revision range of 0 to the latest version. Short of modifying post-review for this, you could use svn diff for the purpose and then upload through the web UI. If you're comfortable with Python, though, I'd recommend modifying post-review and giving that a try. If it works, we'll commit it upstream. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Sun, Apr 19, 2009 at 8:53 PM, Nicholas wrote: > > Hi, > > I am attempting to introduce ReviewBoard to a group of junior > developers who have been committing code to their existing SVN server > for over one year. > > As this is their initial code review, there are files for which I'd > like to review as a whole, not just the recent few diffs/commits > > Is post-review the tool to use? > > For example, there is a header file called utility.h which have been > worked on for about 1 year with hundreds of revisions. > > I'd like to code review the whole header file. > > What flags should I use? > > The plan is that over time, we can start diffing specific section of > the file for review but it's the initial review that I need to plan > for. > > Regards > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cleartool missing + Svn access issue ?
Filled http://code.google.com/p/reviewboard/issues/detail?id=1062 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
