Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Thilo-Alexander Ginkel
Hello everybody, while attempting to add some basic support for a proprietary SCM to Review Board / post-review I stumbled over one issue that I'm currently uncertain how to solve: The SCM I'm integrating uses change identifiers, which are not numeric. Instead arbitrary strings are used, which

Re: Install Issue on Windows

2009-05-11 Thread Chris
Christian, I moved the discussion of how i wanted to use review board to a new topic, seems more appropriate. As for the windows install after a load of effort (and some swearing at the computer) i've got it all working, having SVN on https didn't help but i've sorted that out as well. The

Using Review Board

2009-05-11 Thread Chris
This discussion was moved from another one that was about windows installs. I was hoping to use review board as such: The main development trunk is stable. We want to add something new, so a developer takes a branch to work in leaving trunk alone. Once the developer is happy with their work

Re: Using Review Board

2009-05-11 Thread H M
Chris wrote: Also unless code has been given the OK i dont want it to get into trunk, is this possible? i.e. can we stop people committing to trunk, or is that more something we need to deal with at a people level not an automation level I don't think this is done out of the box. At least not

Re: Using Review Board

2009-05-11 Thread Christian Hammond
Hi Chris, Review Board doesn't have any way of preventing code from being checked in. As H M said, you'll need a pre-commit hook for this. I think there's one on http://reviews.review-boardorg/ somewhere. At some point we may bundle and document one, but not until we have a solid concept of

Re: Install Issue on Windows

2009-05-11 Thread Christian Hammond
We definitely want to improve the install process. Since Review Board depends on a bunch of other components, each with their own quirks and platform biases, it's not easy to get a dead simple install going. In time, a native Windows installer will be provided for this, but probably not for a

Re: Problems with Apache configuration

2009-05-11 Thread Christian Hammond
The general use case is installing in a new virtual host. We may be able to get rb-site to generate different kinds of configurations someday, but usually anything custom should be handled by the administrators. We're only providing sample configurations. Still, if you wouldn't mind filing a bug

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Thilo-Alexander Ginkel
On May 11, 9:55 pm, Christian Hammond chip...@chipx86.com wrote: With this SCM, is the change identifier a server-stored ID that contains the description and other information for Review Board to parse? Or is it more like an atomic ID representing that change that gets pushed to the server

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Christian Hammond
On Mon, May 11, 2009 at 2:32 PM, Thilo-Alexander Ginkel thilo.gin...@gmail.com wrote: On May 11, 9:55 pm, Christian Hammond chip...@chipx86.com wrote: With this SCM, is the change identifier a server-stored ID that contains the description and other information for Review Board to parse?

Issue 1107 in reviewboard: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do

2009-05-11 Thread codesite-noreply
Comment #2 on issue 1107 by ivazqueznet: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do http://code.google.com/p/reviewboard/issues/detail?id=1107 If you look at the descriptions, you'll see that the description in the second change doesn't

Issue 1117 in reviewboard: Error 500 Please help

2009-05-11 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1117 by cmburboa: Error 500 Please help http://code.google.com/p/reviewboard/issues/detail?id=1117 *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page

Issue 1117 in reviewboard: Error 500 Please help

2009-05-11 Thread codesite-noreply
Updates: Status: NeedInfo Comment #1 on issue 1117 by chipx86: Error 500 Please help http://code.google.com/p/reviewboard/issues/detail?id=1117 In sitedir/conf/settings_local.py, add: DEBUG = True You should then get a backtrace instead of that error page, which we can use to

Issue 1107 in reviewboard: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do

2009-05-11 Thread codesite-noreply
Comment #3 on issue 1107 by chipx86: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do http://code.google.com/p/reviewboard/issues/detail?id=1107 Oh, okay. So would I be correct in assuming that you posted the review request, then changed the

Issue 1116 in reviewboard: Error after 'bugs fixed' field edit

2009-05-11 Thread codesite-noreply
Comment #2 on issue 1116 by delight.tm: Error after 'bugs fixed' field edit http://code.google.com/p/reviewboard/issues/detail?id=1116 Nothing. It is ok for me to get just comma-separated bug ids. -- You received this message because you are listed in the owner or CC fields of this issue, or

Issue 1117 in reviewboard: Error 500 Please help

2009-05-11 Thread codesite-noreply
Comment #2 on issue 1117 by cmburboa: Error 500 Please help http://code.google.com/p/reviewboard/issues/detail?id=1117 I tried that one time before but after the change of falase to true, anything else works, I had to run the rb-site script again -- You received this message because you are

Issue 1107 in reviewboard: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do

2009-05-11 Thread codesite-noreply
Comment #5 on issue 1107 by chipx86: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do http://code.google.com/p/reviewboard/issues/detail?id=1107 I don't know, it seems like it's working fine. I really just think you don't have the correct

Issue 1117 in reviewboard: Error 500 Please help

2009-05-11 Thread codesite-noreply
Comment #3 on issue 1117 by chipx86: Error 500 Please help http://code.google.com/p/reviewboard/issues/detail?id=1117 it could be that you typoed something. It must be exactly as I listed, no spaces before it, on its own line. Capital T on True. Without this information, there's nothing I