non-ASCII in comments

2009-09-15 Thread Dmitry Konyshev
Hi guys, First of all, many thanks to the developers of this wonderful piece of software! Please help me with the following issue: When I use non-ASCII characters in comments (specifically, cyrillic characters), they are turned into question marks once comments are published. I looked at the

Re: non-ASCII in comments

2009-09-15 Thread Christian Hammond
Hi Dmitry, Review Board is designed to work entirely with UTF-8, but it's up to the database to use the correct encoding. It's possible that yours isn't set for UTF-8. When did you create your database, and what version of MySQL are you using? You should be able to see the character set of the

Re: non-ASCII in comments

2009-09-15 Thread Dmitry Konyshev
Hi, David and Christian, Thank you for the prompt responses and the tip! I'm running MySQL 5.0.84. This command did the trick: ALTER TABLE reviews_comment MODIFY text longtext CHARACTER SET utf8; I guess, now I need to find other longtext columns in the database and convert they too? I

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Flavio Castelli
On Wednesday 09 September 2009 20:25:45 Dan Savilonis wrote: The currently released version of post-review is limited to very basic git functionality. You can't specify an arbitrary revision range. You can try my updated version here and see how it works:

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Flavio Castelli
On Tuesday 15 September 2009 12:11:00 Christian Hammond wrote: Please submit code changes up on http://reviews.review-board.org/. I have selected RBTools as repository but I get this error message when I try to upload the diff: The file 'rbtools/postreview.py' (r2e2518f) could not be found in

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Christian Hammond
You'll need the nightly of RBTools (instructions below), or generate a diff manually with `git diff --full-index`. To get the nightly: easy_install -f http://downloads.review-board.org/nightlies -U RBTools Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: ReviewBoard + GIT Integration

2009-09-15 Thread Matthew Woehlke
On 2009-09-15 18:07, Kunjal wrote: We already have RB integrated with Perforce and it is working cool. Now, we have some developers working in GIT and we want to review that code as well. What are the steps developer should perform to get the diff and post the review? Save yourself a whole

Issue 1232 in reviewboard: Installing a site in a subdirectory does not display pages formatted with CSS

2009-09-15 Thread codesite-noreply
Updates: Status: Fixed Owner: chipx86 Comment #6 on issue 1232 by chipx86: Installing a site in a subdirectory does not display pages formatted with CSS http://code.google.com/p/reviewboard/issues/detail?id=1232 Thanks. Committed in rf3ecbd5. -- You received this message

Issue 1309 in reviewboard: DashBoard: Using spaces for reviewers break review records

2009-09-15 Thread codesite-noreply
Updates: Status: NeedInfo Labels: -Component-Reviews Component-Accounts Comment #2 on issue 1309 by chipx86: DashBoard: Using spaces for reviewers break review records http://code.google.com/p/reviewboard/issues/detail?id=1309 What authentication mechanism are you using? The

Issue 751 in reviewboard: Long file path results in error: Data truncated for column 'source_file' at row 1

2009-09-15 Thread codesite-noreply
Updates: Status: Fixed Labels: -Component-Docs Component-DiffViewer Comment #7 on issue 751 by chipx86: Long file path results in error: Data truncated for column 'source_file' at row 1 http://code.google.com/p/reviewboard/issues/detail?id=751 Bumped the limit up to 1024.

Issue 1312 in reviewboard: Settings sometimes ignored

2009-09-15 Thread codesite-noreply
Comment #1 on issue 1312 by dbunduki: Settings sometimes ignored http://code.google.com/p/reviewboard/issues/detail?id=1312 I'm using apache-2.2.11, memcached-1.3.3, mysql-5.0.70, mod_python-3.3.1, python-memcached-1.44, libmemcache-1.2.4, mysql-python-1.2.2 -- You received this message

Issue 1313 in reviewboard: Rendering problem in Safari

2009-09-15 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1313 by ehinter: Rendering problem in Safari http://code.google.com/p/reviewboard/issues/detail?id=1313 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.1 What's the URL of

Issue 1312 in reviewboard: Settings sometimes ignored

2009-09-15 Thread codesite-noreply
Comment #2 on issue 1312 by dbunduki: Settings sometimes ignored http://code.google.com/p/reviewboard/issues/detail?id=1312 Restarting the webserver right after changing the settings seems to fix this. I wonder what triggers it ... -- You received this message because you are listed in the

Issue 1179 in reviewboard: Unable to view/submit Review Requests

2009-09-15 Thread codesite-noreply
Updates: Status: Incomplete Comment #2 on issue 1179 by trowbrds: Unable to view/submit Review Requests http://code.google.com/p/reviewboard/issues/detail?id=1179 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of

Issue 1313 in reviewboard: Rendering problem in Safari

2009-09-15 Thread codesite-noreply
Updates: Status: Confirmed Labels: OpSys-OSX Comment #1 on issue 1313 by eduardofelipe87: Rendering problem in Safari http://code.google.com/p/reviewboard/issues/detail?id=1313 I've had the same issue for sometime. There is no easy fix that worked without browser-specific

Issue 1314 in reviewboard: ambiguity in git repository paths is not handled

2009-09-15 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1314 by dmitry.konyshev: ambiguity in git repository paths is not handled http://code.google.com/p/reviewboard/issues/detail?id=1314 *NOTE: Do not post confidential information in this bug report.* What version are you