git and diffs against branches
Whilst I use other distributed SCM's I've only just started with git (as ReviewBoard uses it) and I think I'm having some trouble understanding git (and reviewboard). What I'd like to do is post for review changes/diffs against a branch (not master/bleeding edge). E.g. git clone git://github.com/reviewboard/reviewboard.git git checkout release-1.0.5.1 ## hack on stuff, e.g. git add myfile postreview.py --server=http://reviews.reviewboard.org/ --debug Here is my output (note headrevs of rbtools and this is actually posted explictly with -r1177): svn info git rev-parse --git-dir git svn info git svn --version git config --get svn-remote.svn.url git remote show origin repository info: Path: git://github.com/reviewboard/reviewboard.git, Base path: , Supports changesets: False git diff --no-color --full-index master Looking for 'reviews.reviewboard.org /' cookie in /home/ingres/.post-review-cookies.txt Loaded valid cookie -- no login required HTTP GETting api/json/reviewrequests/1177/ Uploading diff, size: 467617 HTTP POSTing to http://reviews.reviewboard.org/api/json/reviewrequests/1177/diff/new/: {} Error uploading diff: One or more fields had errors (105) {u'fields': {u'path': [u'int argument required']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Your review request still exists, but the diff is not attached. From the instructions near the end of http://www.reviewboard.org/docs/codebase/dev/getting-started/#gettingstarted (Posting Changes for Review) I get the impression this is not allowed? The checkout is based on master but it is a different branch, I guess this maybe a bug report too as it fails to post but does create an empty review without printing out the review number. I ended up browsing http://reviews.reviewboard.org/r/ and looking at the top to work out it had created one. Similar behavior if I just do a git diff and try and use the web interface (i.e. get int arg required error). Help! Chris --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Diff issue on new install
Setting up a new Review Board install (1.0.5.1) to experiment with. Install seems to have worked and I've set up a single git repo and used post-review to toss a review request in. But on trying to view the diff I get: [Errno 32] Broken pipe Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/views.py, line 153, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.5.5-py2.5.egg/ djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 110, in patch p.stdin.write(diff) IOError: [Errno 32] Broken pipe Any ideas? Mike --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Apache hangs upon post-review
Per an earlier thread I'm trying to get Review Board working on a Windows machine with ClearCase integration. I've gotten earlier road blocks and now post-review runs but it only gets so far and then the Apache server goes to 99% CPU utilization and post-review process hangs until I restart Apache server. Here is output from a debug post-review run. Any ideas? snip HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/draft/set/: {'de scription': 'sperry_releaseboard\nVIEWTYPE: dynamic\n'} HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/draft/save/: {} Review request draft saved Uploading diff, size: 4635 HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/diff/new/: {'bas edir': 's:\\'} ^C S:\softdbTraceback (most recent call last): File C:\Python25\Scripts\post-review-script.py, line 8, in module load_entry_point('rbtools==0.2beta2', 'console_scripts', 'post- review')() File build\bdist.win32\egg\rbtools\postreview.py, line 2522, in main File build\bdist.win32\egg\rbtools\postreview.py, line 2254, in tempt_fate File build\bdist.win32\egg\rbtools\postreview.py, line 463, in upload_diff File build\bdist.win32\egg\rbtools\postreview.py, line 575, in api_post File build\bdist.win32\egg\rbtools\postreview.py, line 556, in http_post File C:\Python25\lib\urllib2.py, line 124, in urlopen return _opener.open(url, data) File C:\Python25\lib\urllib2.py, line 381, in open response = self._open(req, data) File C:\Python25\lib\urllib2.py, line 399, in _open '_open', req) File C:\Python25\lib\urllib2.py, line 360, in _call_chain result = func(*args) File C:\Python25\lib\urllib2.py, line 1107, in http_open return self.do_open(httplib.HTTPConnection, req) File C:\Python25\lib\urllib2.py, line 1080, in do_open r = h.getresponse() --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: git and diffs against branches
Lobby for http://reviews.reviewboard.org/r/1144/ to get committed and you should be all set. :) For now, the only options are to use the web form or specify a revision range manually. Can you explain more about the error with the web form? You mentioned git diff, and if you meant that literally, that would end up diffing your working copy changes against whatever is your HEAD. If your HEAD is not a revision in the remote repository, RB won't understand what you are diffing against. Dan On Oct 23, 2:10 pm, Chris Clark chris.cl...@ingres.com wrote: Whilst I use other distributed SCM's I've only just started with git (as ReviewBoard uses it) and I think I'm having some trouble understanding git (and reviewboard). What I'd like to do is post for review changes/diffs against a branch (not master/bleeding edge). E.g. git clone git://github.com/reviewboard/reviewboard.git git checkout release-1.0.5.1 ## hack on stuff, e.g. git add myfile postreview.py --server=http://reviews.reviewboard.org/ --debug Here is my output (note headrevs of rbtools and this is actually posted explictly with -r1177): svn info git rev-parse --git-dir git svn info git svn --version git config --get svn-remote.svn.url git remote show origin repository info: Path: git://github.com/reviewboard/reviewboard.git, Base path: , Supports changesets: False git diff --no-color --full-index master Looking for 'reviews.reviewboard.org /' cookie in /home/ingres/.post-review-cookies.txt Loaded valid cookie -- no login required HTTP GETting api/json/reviewrequests/1177/ Uploading diff, size: 467617 HTTP POSTing tohttp://reviews.reviewboard.org/api/json/reviewrequests/1177/diff/new/:{} Error uploading diff: One or more fields had errors (105) {u'fields': {u'path': [u'int argument required']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Your review request still exists, but the diff is not attached. From the instructions near the end ofhttp://www.reviewboard.org/docs/codebase/dev/getting-started/#getting... (Posting Changes for Review) I get the impression this is not allowed? The checkout is based on master but it is a different branch, I guess this maybe a bug report too as it fails to post but does create an empty review without printing out the review number. I ended up browsinghttp://reviews.reviewboard.org/r/and looking at the top to work out it had created one. Similar behavior if I just do a git diff and try and use the web interface (i.e. get int arg required error). Help! Chris --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Apache hangs upon post-review
There was a problem like this with git support a long time ago. Can you add use the diff only option and make sure the diff it generates looks somewhat reasonable? Dan On Oct 23, 11:22 am, James jimspe...@gmail.com wrote: Per an earlier thread I'm trying to get Review Board working on a Windows machine with ClearCase integration. I've gotten earlier road blocks and now post-review runs but it only gets so far and then the Apache server goes to 99% CPU utilization and post-review process hangs until I restart Apache server. Here is output from a debug post-review run. Any ideas? snip HTTP POSTing tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/set/:{'de scription': 'sperry_releaseboard\nVIEWTYPE: dynamic\n'} HTTP POSTing tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/save/:{} Review request draft saved Uploading diff, size: 4635 HTTP POSTing tohttp://ndm-xp-vm1/api/json/reviewrequests/4/diff/new/:{'bas edir': 's:\\'} ^C S:\softdbTraceback (most recent call last): File C:\Python25\Scripts\post-review-script.py, line 8, in module load_entry_point('rbtools==0.2beta2', 'console_scripts', 'post- review')() File build\bdist.win32\egg\rbtools\postreview.py, line 2522, in main File build\bdist.win32\egg\rbtools\postreview.py, line 2254, in tempt_fate File build\bdist.win32\egg\rbtools\postreview.py, line 463, in upload_diff File build\bdist.win32\egg\rbtools\postreview.py, line 575, in api_post File build\bdist.win32\egg\rbtools\postreview.py, line 556, in http_post File C:\Python25\lib\urllib2.py, line 124, in urlopen return _opener.open(url, data) File C:\Python25\lib\urllib2.py, line 381, in open response = self._open(req, data) File C:\Python25\lib\urllib2.py, line 399, in _open '_open', req) File C:\Python25\lib\urllib2.py, line 360, in _call_chain result = func(*args) File C:\Python25\lib\urllib2.py, line 1107, in http_open return self.do_open(httplib.HTTPConnection, req) File C:\Python25\lib\urllib2.py, line 1080, in do_open r = h.getresponse() --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: git and diffs against branches
Make sure you also use --full-index on git diff. I've been really busy the last couple weeks. In and out of town, busy work work, etc. I want that change in as much as anyone, just haven't been able to give it the attention it needs. Soon :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Oct 23, 2009 at 2:08 PM, Chris Clark chris.cl...@ingres.com wrote: Dan Savilonis wrote: Lobby for http://reviews.reviewboard.org/r/1144/ to get committed and you should be all set. :) For now, the only options are to use the web form or specify a revision range manually. Consider this me +1 for this ;-) Can you explain more about the error with the web form? You mentioned git diff, and if you meant that literally, that would end up diffing your working copy changes against whatever is your HEAD. If your HEAD is not a revision in the remote repository, RB won't understand what you are diffing against. Thanks to your hint I (think I) have this working now (I have a review ready to go). So this was user error/trouble learning git. I was assuming a diff was all I needed (and the branch would be assumed), what I needed to do was: git diff HEAD file1 file2. i.e. add the HEAD. Thanks again! Chris To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff issue on new install
Debian 5.0. /usr/bin/patch exists. Mike On Oct 23, 2009, at 5:44 PM, Christian Hammond wrote: Hmm, this is a new one. /usr/bin/patch exists, right? What distro is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Oct 23, 2009 at 4:52 AM, Mike Gunderloy larkw...@gmail.com wrote: Setting up a new Review Board install (1.0.5.1) to experiment with. Install seems to have worked and I've set up a single git repo and used post-review to toss a review request in. But on trying to view the diff I get: [Errno 32] Broken pipe Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/views.py, line 153, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.5.5-py2.5.egg/ djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 110, in patch p.stdin.write(diff) IOError: [Errno 32] Broken pipe Any ideas? Mike To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Diff issue on new install
Okay. Well, it sounds like for whatever reason, the STDIN or STDOUT pipe to patch is failing. What would be interesting is to take the source and dest file and manually run: cat difffile | patch -o somenewfilename oldfile There should be a /tmp/reviewboard.* directory containing a .diff file and a file without -new that you'd put in the above command line. If there are several /tmp/reviewboard.* directories, try deleting them all and then reproduce this. Also, you might want to look at the diff file and see if it looks sane. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Oct 23, 2009 at 4:17 PM, Mike Gunderloy larkw...@gmail.com wrote: Debian 5.0. /usr/bin/patch exists. Mike On Oct 23, 2009, at 5:44 PM, Christian Hammond wrote: Hmm, this is a new one. /usr/bin/patch exists, right? What distro is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Oct 23, 2009 at 4:52 AM, Mike Gunderloy larkw...@gmail.comwrote: Setting up a new Review Board install (1.0.5.1) to experiment with. Install seems to have worked and I've set up a single git repo and used post-review to toss a review request in. But on trying to view the diff I get: [Errno 32] Broken pipe Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/views.py, line 153, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 110, in patch p.stdin.write(diff) IOError: [Errno 32] Broken pipe Any ideas? Mike To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1366 in reviewboard: Group netster is not recognized by review board
Updates: Status: Invalid Comment #1 on issue 1366 by chipx86: Group netster is not recognized by review board http://code.google.com/p/reviewboard/issues/detail?id=1366 This is the issue tracker for bugs in Review Board, which is an open source project used by many companies. You should contact your system administrator. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #10 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Unfortunately, I can't confirm the fix. The issue is still present in version 1.0.5 in our installation (tested with Chromium 4.0.222.4, Firefox 3 and 3.5; all in Linux). The link Expand behaves still the same way as in 1.0.4. It is sending wrong requests as described in comments #2 and #5 above. I don't see our configuration obscure in any way; it is the following: Response Headers DateFri, 23 Oct 2009 22:31:23 GMT Server Apache/2.2.9 (Debian) DAV/2 SVN/1.5.1 mod_jk/1.2.26 PHP/5.2.6-1+lenny3 with Suhosin-Patch mod_python/3.3.1 Python/2.5.2 mod_ssl/2.2.9 OpenSSL/0.9.8g mod_perl/2.0.4 Perl/v5.10.0 Content-Length 232 Content-Languageen-us Content-Encodinggzip VaryCookie,Accept-Language,Accept-Encoding Content-Typetext/html; charset=utf-8 Keep-Alive timeout=15, max=100 Connection Keep-Alive Request Headers Host... User-Agent Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 Accept text/html, */* Accept-Language en,en-us;q=0.8,fr;q=0.5,fr-fr;q=0.3 Accept-Encoding gzip,deflate Accept-Charset UTF-8,* Keep-Alive 300 Connection keep-alive X-Requested-WithXMLHttpRequest Referer https://.../rb/r/171/diff/ Cookie rbsessionid=ae1bc5f72f8e0af9e9f8de5d857676be; ... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #12 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Yes, I restarted both apache and memcached (and tried also disabling memcached), reloaded the page multiple times, cleared the browser cache and tested it also in Chromium's incognito mode.. ..just to be sure. And I think there is not a problem with any cache, because it works immediately after downgrading to 1.0.1. What about checking changes in the diff viewer between 1.0.1 and 1.0.3? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---