Show tabulators in review
Hi! Today I made first step in patch which show !TAB! instead tabulator in diffviewer. Yellow background, red, bold text and border. Is my patch will be usefull in ReviewBoard? Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
No new line at end of file crash diffviewer
Hi! When I make review for file where some changes was made near last line and it have not new line at end of file diffviewer crush :/ I'm thinking about adding one more fake new line sign at the end everytime. Is this patch will be submitted if I create one? Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
AD Settings in RB
We have RB 1.0.5.1 installed. We have configured AD settings so all the users can login easily. Now, the issue is that we want to restrict users to only few departments in our company. So, we have created new windows security groups which has nested multiple department names in it. After doing this, the users of this departments can not access RB. If we put one department group then it works. But nesting of departments does not work. Does the RB 1.0.5.1 has ability to put multiple windows security groups for access/authentication? Is nesting possible? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Something broke! (Error 500)
Hi, I put the patch.exe into Paython/Scripts folder because of RB can not found patch.exe before. Now, I got this page: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. What can I do now? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HTTPS support
Do you mean the Apache installation? That should work fine. Review Board doesn't really care whether it's being used with https or http. It's a matter of configuring your Apache installation and updating your .reviewboardrc files (or whatever mechanism you're using for post-review support) to point to the https URL instead of the http URL. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Apr 27, 2010 at 5:38 PM, Kunjal kunjal.par...@gmail.com wrote: We have RB 1.0.5.1 in production and it is http now. We want to move it to https. So, we did apache server settings and move RB to https. But now I can post the review but I can not post the diff. It gives me error. Is HTTTPS supported in 1.0.5.1? Because I see that in the roadmap of RB 1.5, it says ... SSH and HTTPS support -- commited. Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HTTPS support
Chris, Changes to Apache installation is done and we have moved our RB website to HTTPS. However, now when I post the review now, I can not post the diff. Does the HTTPS interact the way diff is done ? Do I need to update post-review.py script to update the url field to point to https? Thanks a lot. Kunjal On Apr 27, 10:45 pm, Christian Hammond chip...@chipx86.com wrote: Do you mean the Apache installation? That should work fine. Review Board doesn't really care whether it's being used with https or http. It's a matter of configuring your Apache installation and updating your .reviewboardrc files (or whatever mechanism you're using for post-review support) to point to the https URL instead of the http URL. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Apr 27, 2010 at 5:38 PM, Kunjal kunjal.par...@gmail.com wrote: We have RB 1.0.5.1 in production and it is http now. We want to move it to https. So, we did apache server settings and move RB to https. But now I can post the review but I can not post the diff. It gives me error. Is HTTTPS supported in 1.0.5.1? Because I see that in the roadmap of RB 1.5, it says ... SSH and HTTPS support -- commited. Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Comment on Summer_of_Code_Ideas in reviewboard
Comment by evgeny.zislis: Some more ideas: - A feature for merging two review requests into one, good for post-commit reviews especially. - IM notifications, in addition/parallel to e-mail - A more fine grained system of notifications, where each user can select which notifications he can receive. For more information: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1623 in reviewboard: patch for perforce
Comment #5 on issue 1623 by seagle0128: patch for perforce http://code.google.com/p/reviewboard/issues/detail?id=1623 I've post a new request. Please refer to http://reviews.reviewboard.org/r/1537/. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1629 in reviewboard: post-review doesn't work with uploading diffs between two revisions of the same file.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1629 by adityarathi: post-review doesn't work with uploading diffs between two revisions of the same file. http://code.google.com/p/reviewboard/issues/detail?id=1629 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.6 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/users/tools/post-review/#posting-paths What steps will reproduce the problem? 1. Use the following command as pointed out by the documentation: Uploading a diff of a file between two revisions: //path/to/fi...@#]rev,[...@#]rev 2. This one even doesn't work. Uploading a file from a revision as a “new” file (not as common): //path/to/file/[...@#]rev Both the above command fail. The syntax isn't clear either. I have tried a) /path/to/file/#nrev -- errors with nrev invalid rev number b) /path/to/file/[#n]rev -- errors with 2]rev invalid rev number c) /path/to/file/@nrev -- errors with nrev invalid changelist d) /path/to/file/[...@n]rev -- errors with 2]rev invalid changelist What is the expected output? What do you see instead? Expect it to post a diff to the server. Instead, I see the error messages as above What operating system are you using? What browser? Windows 7 with Firefox Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 100 in reviewboard: Allow for reviews based on an existing committed revision in the web UI
Comment #20 on issue 100 by eric.twilegar: Allow for reviews based on an existing committed revision in the web UI http://code.google.com/p/reviewboard/issues/detail?id=100 I think this is huge for adoption. Making it easier to generate review requests. Check out Kiln from Fog Creek ( same guys that make FogBugz ). It is kind of annoying how it implement Mercurial integration, but the review and integration with FogBugz is great. It's post commit...but generally you commit to a develop branch, review, and then push/merge to trunk...and all from the web which is nice. Just seeing a history log from your repository is nice. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
