How apply patches in pre-review process?
Hi! I'm thinking a lot about how and who should apply patches in pre- review process? I see one problem. When review is done and submitted developer can change everything he want in working tree and commit everything he want. I'm thinking how be sure that reviewed changes is commited changes. For now I see one option. Reviewer download raw diff from ReviewBoard, apply patches to master/trunk resolving all conflicts themselves. Is there another way which could automate this process with avoiding conflicts? Another way is allow allow commit changes after review but in commit hook check is diff from commiting code is identical with ReviewBoard diffs. But this looks a little bit too tricky. Can You share You experience? Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Finally a PyLucene Package
For anyone interested I just installed an Ubuntu 10.04 LTS server and the PyLucene package is finally built with Python 2.6 which means it is finally usable via modpython. No more painful building of PyLucene, just an easy to install package. I just got the system installed and restored a backup so I have not done much testing but so far everything seems to be working fine. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Finally a PyLucene Package
On 04/30/2010 01:32 PM, grimbeaver wrote: For anyone interested I just installed an Ubuntu 10.04 LTS server and the PyLucene package is finally built with Python 2.6 which means it is finally usable via modpython. No more painful building of PyLucene, just an easy to install package. I just got the system installed and restored a backup so I have not done much testing but so far everything seems to be working fine. A link to the package would be helpful :) Also, is it 3.0 (which if I remember correctly is not compatible with ReviewBoard), or is it an older version? (I'm very interested, because I want to put together a Fedora package for it) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Finally a PyLucene Package
I just got the package through apt-get. Looks like it's 2.3.1 so it's actually a bit dated. But it seems to work. http://packages.ubuntu.com/lucid/pylucene On Apr 30, 12:35 pm, Stephen Gallagher step...@gallagherhome.com wrote: On 04/30/2010 01:32 PM, grimbeaver wrote: For anyone interested I just installed an Ubuntu 10.04 LTS server and the PyLucene package is finally built with Python 2.6 which means it is finally usable via modpython. No more painful building of PyLucene, just an easy to install package. I just got the system installed and restored a backup so I have not done much testing but so far everything seems to be working fine. A link to the package would be helpful :) Also, is it 3.0 (which if I remember correctly is not compatible with ReviewBoard), or is it an older version? (I'm very interested, because I want to put together a Fedora package for it) -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How apply patches in pre-review process?
Jan Koprowski wrote: . When review is done and submitted developer can change everything he want in working tree and commit everything he want. I'm thinking how be sure that reviewed changes is commited changes. For us, we are just using the honour/honor system, i.e. no checks :-) This mostly works BUT occasionally people do make mistakes (e.g. submit an extra file that was not in the review) so a check would be nice, for me personally I'm not sure it is worth spending the time on it. For a central based SCM (like svn) you could add a commit hook that pulls the diff from reviewboard and compare the diff with what the SCM has been given, as you suggested. I suspect this is the easiest thing to setup and would help catch accidents rather than deliberate deceptive developers ;-) The other idea similar to your manual reviewer idea would be for a script to pull the diff from RB (that is marked with Ship It!) and submit the change (assuming the patch applies cleanly). If patches don't apply cleanly the review could be marked with patch didn't apply cleanly to [rev in SCM] and the developer an resubmit. If you already have a buildbot system this is probably your best option (especially if you have tests as part of the build bot, you could add additional rejection checks). I've deliberately minimized the procedures/policies we have for RB at our site so this isn't something I plan on implementing myself but I can see the value. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RB 1.5b - Configuring SVN over HTTPS
Is there any step-by-step guide to configure a svn https repository in RB? I've configured my certificate path within svn servers file.. (tested and working) Even though, it seems that RB cannot find my certificate.. If I try to add a repository, I get the following error: A repository was not found at the specified path. (the repository url is correct).. In the RB logs, the error is: ERROR - SVN: Failed to get repository information for URL: callback_ssl_client_certificate_prompt required Thank you in advance... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RB 1.5b - Configuring SVN over HTTPS
Greetings, Is there a cook-book to configure a https svn repository in RB? I get this error in the dashboard: A repository was not found at the specified path. In the logs the error is: ERROR - SVN: Failed to get repository information for https://myproj.csd200a.com/svn/myproj: callback_ssl_client_cert_prompt required My certificate path and pwd are configured in svn servers file. So, it is working locally. Any thoughts? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.5b - Configuring SVN over HTTPS
Hi, Support for this is being added to Review Board 1.5. The 1.5 beta 1 supports it, though you may hit some regressions. Beta 2 will be out soon. Christian On Thursday, April 29, 2010, Martelo martel...@gmail.com wrote: Greetings, Is there a cook-book to configure a https svn repository in RB? I get this error in the dashboard: A repository was not found at the specified path. In the logs the error is: ERROR - SVN: Failed to get repository information for https://myproj.csd200a.com/svn/myproj: callback_ssl_client_cert_prompt required My certificate path and pwd are configured in svn servers file. So, it is working locally. Any thoughts? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewing merges
You're using the term two parents very liberally. I don't know of a version control system that sees merges in this way. Every node in a repository has, in my experience across a wide variety of systems, one parent. It might have merge history that involves other sources (in any system that tracks merge history like git, Perforce, Clearcase, etc.) but that's not a parent, per se. Parenting typically comes from one of two mechanics: branching or versioning. When you branch, you create a new entity whose immediate parent is on another branch. When you version you create a new entity whose immediate parent is on the same branch. A good 3-way diff would actually account for this, showing changes from the parent, and then perhaps highlighting to indicate what parts of those changes might have come from any given merge source. And no, I don't know of anything in RB that does that because RB is version control system agnostic, so it doesn't even assume you HAVE merge tracking. On Fri, Apr 30, 2010 at 4:52 PM, Andrew aschwa...@gmail.com wrote: Hi all. Is there any support for reviewing merges (changesets with two parents)? I imagine that ideally, it would be a review request that has two diffs -- one against the first parent and the other against the second parent. -- Aaron Sherman Email or GTalk: a...@ajs.com http://www.ajs.com/~ajs -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.5b - Configuring SVN over HTTPS
Hi, Support for this is being added to Review Board 1.5. The 1.5 beta 1 supports it, though you may hit some regressions. Beta 2 will be out soon. Christian On Thursday, April 29, 2010, Martelo martel...@gmail.com wrote: Greetings, Is there a cook-book to configure a https svn repository in RB? I get this error in the dashboard: A repository was not found at the specified path. In the logs the error is: ERROR - SVN: Failed to get repository information for https://myproj.csd200a.com/svn/myproj: callback_ssl_client_cert_prompt required My certificate path and pwd are configured in svn servers file. So, it is working locally. Any thoughts? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 1635 in reviewboard: New review request: width of entry fields
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1635 by gorf4673: New review request: width of entry fields http://code.google.com/p/reviewboard/issues/detail?id=1635 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0.7 What's the URL of the page this enhancement relates to, if any? /r/new/ Describe the enhancement and the motivation for it. Enhancement: Allow the user a greater use of the width of the web browser to show more of the detail in regards to the Base Directory and Diff. ie. Remove size=35 on input fields for base directory and diff file name. Motivation: It's painful to have to hover over drop down list options to see the full text in a tool tip one at a time when you have many long texts starting with similar values. It's annoying to have to enter the edit field and scroll to the right to see the file name of the chosen file to ensure correct file was chosen. What operating system are you using? What browser? Windows, FireFox and Internet Exploder Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1426 in reviewboard: The reply button is not working
Comment #3 on issue 1426 by lonico: The reply button is not working http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue is still present in 1.5 Beta 1 too. I was wondering what is the expectation: 1) go back to the reviews view and open the add comment dialog (which is really add reply)? 2) or stay in the diff view and open a reply dialog box (or replace the behavior of the current one)? Most of our users would prefer to stay in the diff view when replying to a comment. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
